mirrors/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

surface: Only rebuild paint node regions when necessary

Browse Source 
Rebuilding regions can be an expensive operation, and we're adding more
of them. This means we need to be clever about when we actually do them.

Only dirty the paint nodes when the transform or buffer size has
actually changed, not on every commit.

Signed-off-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Daniel Stone 2023-06-20 00:25:54 +01:00
parent 8532c28761
commit ead8bd5fdb
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
libweston/compositor.c
View File

@ -4067,22 +4067,17 @@ weston_surface_commit_state(struct weston_surface *surface,
assert(state->acquire_fence_fd == -1);
assert(state->buffer_release_ref.buffer_release == NULL);
weston_surface_build_buffer_matrix(surface,
&surface->surface_to_buffer_matrix);
weston_matrix_invert(&surface->buffer_to_surface_matrix,
&surface->surface_to_buffer_matrix);
if (status & WESTON_SURFACE_DIRTY_SIZE) {
weston_surface_build_buffer_matrix(surface,
&surface->surface_to_buffer_matrix);
weston_matrix_invert(&surface->buffer_to_surface_matrix,
&surface->surface_to_buffer_matrix);
weston_surface_dirty_paint_nodes(surface);
weston_surface_update_size(surface);
}
/* It's possible that this surface's buffer and transform changed
* at the same time in such a way that its size remains the same.
*
* That means we can't depend on view_geometry_dirty() from a
* size update to invalidate the paint node data in all relevant
* cases, so just smash it here.
*/
weston_surface_dirty_paint_nodes(surface);
if (state->newly_attached || state->buffer_viewport.changed ||
state->sx != 0 || state->sy != 0) {
weston_surface_update_size(surface);
if (surface->committed) {
struct weston_coord_surface new_origin;