mirrors
/
weston
mirror of https://gitlab.freedesktop.org/wayland/weston.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

view: Add weston_view_geometry_dirty_internal() 

weston_view_geometry_dirty_internal() can be used by internal callers to
mark a view's internal geometry as dirty, without signaling the need for
a full rebuild of the view list.

This is a transitional step towards eliminating
weston_view_geometry_dirty() from public API. Up until recently, the
view-manipulation API has been that users should manually manipulate
lists of transforms, layers, and other internal members, then call
weston_view_geometry_dirty() as well as manually provoking damage.

Now that we have helper functions to handle view manipulation, they
still need to mark the view geometry as being dirty. However, most of
them do not need to invoke a full rebuild of the view_list, which is
only required when views are added or removed from the scene graph, or
restacked.

weston_view_geometry_dirty() will assume that everything has changed
before eventually being ushered out of existence.

Signed-off-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Daniel Stone 2023-06-27 14:06:37 +01:00
parent c859dd1b9e
commit c699253da8
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
libweston/compositor.c
View File

@ -109,6 +109,9 @@ static void
subsurface_committed(struct weston_surface *surface,
struct weston_coord_surface new_origin);
static void
weston_view_geometry_dirty_internal(struct weston_view *view);
static void
weston_view_dirty_paint_nodes(struct weston_view *view)
{
@ -1547,8 +1550,8 @@ weston_view_update_transform(struct weston_view *view)
}
}
WL_EXPORT void
weston_view_geometry_dirty(struct weston_view *view)
static void
weston_view_geometry_dirty_internal(struct weston_view *view)
{
struct weston_view *child;
@ -1566,11 +1569,17 @@ weston_view_geometry_dirty(struct weston_view *view)
wl_list_for_each(child, &view->geometry.child_list,
geometry.parent_link)
weston_view_geometry_dirty(child);
weston_view_geometry_dirty_internal(child);
weston_view_dirty_paint_nodes(view);
}
WL_EXPORT void
weston_view_geometry_dirty(struct weston_view *view)
{
weston_view_geometry_dirty_internal(view);
}
/**
* \param surface The surface to be repainted
*
@ -3568,7 +3577,7 @@ weston_view_move_to_layer(struct weston_view *view,
/* Damage the view's old region, and remove it from the layer. */
if (weston_view_is_mapped(view)) {
weston_view_damage_below(view);
weston_view_geometry_dirty(view);
weston_view_geometry_dirty_internal(view);
}
weston_layer_entry_remove(&view->layer_link);
@ -3581,7 +3590,7 @@ weston_view_move_to_layer(struct weston_view *view,
/* Add the view to the new layer and damage its new region. */
weston_layer_entry_insert(layer, &view->layer_link);
view->is_mapped = true;
weston_view_geometry_dirty(view);
weston_view_geometry_dirty_internal(view);
weston_view_update_transform(view);
weston_surface_damage(view->surface);
@ -3682,7 +3691,7 @@ weston_layer_set_mask(struct weston_layer *layer,
layer->mask.y2 = y + height;
wl_list_for_each(view, &layer->view_list.link, layer_link.link) {
weston_view_geometry_dirty(view);
weston_view_geometry_dirty_internal(view);
}
}
@ -3697,7 +3706,7 @@ weston_layer_set_mask_infinite(struct weston_layer *layer)
layer->mask.y2 = INT32_MAX;
wl_list_for_each(view, &layer->view_list.link, layer_link.link) {
weston_view_geometry_dirty(view);
weston_view_geometry_dirty_internal(view);
}
}
@ -6755,7 +6764,7 @@ weston_compositor_add_output(struct weston_compositor *compositor,
* output yet. Any existing view might touch this new output.
*/
wl_list_for_each_safe(view, next, &compositor->view_list, link)
weston_view_geometry_dirty(view);
weston_view_geometry_dirty_internal(view);
}
/** Create a weston_coord_global from a point and a weston_output