mirrors/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: Remove single case for device destroy test

Browse Source 
Currently we have some device tests which run in a single iteration
once, then in lots of iterations after that.

The single-iteration case is useless, so remove it, which has the happy
side effect of not breaking when we change the test signature.

Signed-off-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Daniel Stone 2023-06-28 10:44:18 +01:00
parent b510f4a9cb
commit ae2c47045f
2 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/devices-test.c
View File

@ -152,7 +152,8 @@ TEST(multiple_device_add_and_remove)
client_destroy(cl); client_destroy(cl);
} }
TEST(device_release_before_destroy) static void
device_release_before_destroy(void)
{ {
struct client *cl = create_client_and_test_surface(100, 100, 100, 100); struct client *cl = create_client_and_test_surface(100, 100, 100, 100);
@ -195,15 +196,12 @@ TEST(device_release_before_destroy_multiple)
{ {
int i; int i;
/* if weston crashed during this test, then there is for (i = 0; i < 30; ++i)
* some inconsistency */
for (i = 0; i < 30; ++i) {
device_release_before_destroy(); device_release_before_destroy();
}
} }
/* normal work-flow test */ static void
TEST(device_release_after_destroy) device_release_after_destroy(void)
{ {
struct client *cl = create_client_and_test_surface(100, 100, 100, 100); struct client *cl = create_client_and_test_surface(100, 100, 100, 100);
@ -247,17 +245,15 @@ TEST(device_release_after_destroy_multiple)
{ {
int i; int i;
/* if weston crashed during this test, then there is for (i = 0; i < 30; ++i)
* some inconsistency */
for (i = 0; i < 30; ++i) {
device_release_after_destroy(); device_release_after_destroy();
}
} }
/* see https://bugzilla.gnome.org/show_bug.cgi?id=745008 /* see https://bugzilla.gnome.org/show_bug.cgi?id=745008
* It is a mutter bug, but highly relevant. Weston does not * It is a mutter bug, but highly relevant. Weston does not
* suffer from this bug atm, but it is worth of testing. */ * suffer from this bug atm, but it is worth of testing. */
TEST(get_device_after_destroy) static void
get_device_after_destroy(void)
{ {
struct client *cl = create_client_and_test_surface(100, 100, 100, 100); struct client *cl = create_client_and_test_surface(100, 100, 100, 100);
struct wl_pointer *wl_pointer; struct wl_pointer *wl_pointer;

2
tests/weston-test-runner.h
View File

@ -128,7 +128,7 @@ struct weston_test_entry {
* *
* \ingroup testharness * \ingroup testharness
*/ */
#define PLUGIN_TEST(name) \ #define PLUGIN_TEST(name) \
TEST_COMMON(wrap##name, name, NULL, 0, 1) \ TEST_COMMON(wrap##name, name, NULL, 0, 1) \
static void name(struct weston_compositor *); \ static void name(struct weston_compositor *); \
static void wrap##name(void *compositor) \ static void wrap##name(void *compositor) \