mirrors/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

desktop-shell: Be more precise with rotation damage

Browse Source 
When we're rotating a surface, only mark the geometry as dirty after
we've actually updated the transformations. Then we can restrict our
repaint to just the view itself, not the full compositor.

Signed-off-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Daniel Stone 2023-06-20 11:46:34 +01:00
parent 1da1d860fe
commit 785af26007
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
desktop-shell/shell.c
View File

@ -3499,7 +3499,6 @@ rotate_grab_motion(struct weston_pointer_grab *grab,
r = sqrtf(dx * dx + dy * dy);
wl_list_remove(&shsurf->rotation.transform.link);
weston_view_geometry_dirty(shsurf->view);
if (r > 20.0f) {
struct weston_matrix *matrix =
@ -3523,6 +3522,8 @@ rotate_grab_motion(struct weston_pointer_grab *grab,
weston_matrix_init(&rotate->rotation);
}
weston_view_geometry_dirty(shsurf->view);
/* We need to adjust the position of the surface
* in case it was resized in a rotated state before */
cposx = shsurf->view->geometry.pos_offset.x + cx;
@ -3538,10 +3539,8 @@ rotate_grab_motion(struct weston_pointer_grab *grab,
weston_view_set_position(shsurf->view, pos);
}
/* Repaint implies weston_view_update_transform(), which
* lazily applies the damage due to rotation update.
*/
weston_compositor_schedule_repaint(surface->compositor);
weston_view_update_transform(shsurf->view);
weston_surface_damage(shsurf->view->surface);
}
static void