mirrors/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libweston: Defer animation destruction to idle loop

Browse Source 
If the first tick of an animation finishes the animation, then the
animation is destroyed before its creation function even returns.

Let's just defer that destruction to the idle loop so that can't happen.

Signed-off-by: Derek Foreman <derek.foreman@collabora.com>
This commit is contained in:
Derek Foreman 2024-07-03 06:58:44 -05:00
parent b3df77a627
commit 661a7142ca
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libweston/animation.c
View File

@ -180,6 +180,9 @@ static void defer_animation_destroy(struct weston_view_animation *animation)
struct weston_compositor *ec = animation->view->surface->compositor;
struct wl_event_loop *loop = wl_display_get_event_loop(ec->wl_display);
if (animation->idle_destroy_source)
return;
animation->idle_destroy_source =
wl_event_loop_add_idle(loop, idle_animation_destroy,
animation);
@ -202,10 +205,7 @@ weston_view_animation_frame(struct weston_animation *base,
weston_spring_update(&animation->spring, time);
if (weston_spring_done(&animation->spring)) {
if (animation->idle_destroy_source)
wl_event_source_remove(animation->idle_destroy_source);
weston_view_animation_destroy(animation);
defer_animation_destroy(animation);
return;
}