mirrors
/
weston
mirror of https://gitlab.freedesktop.org/wayland/weston.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Document WESTON_VERSION_AT_LEAST() macro behavior 

Adding this comment to explain the behavior:

  This macro may not do what you expect.  Weston doesn't guarantee any
  stable API between 1.X and 1.Y, and thus this macro will return
  FALSE on any WESTON_VERSION_AT_LEAST(1,X,0) if the actualy version
  is 1.Y.0 and X !=Y).  In particular, it fail if X < Y, that is,
  1.3.0 is considered to not be "at least" 1.4.0.

  If you want to test for the version number being 1.3.0 or above or
  maybe in a range (eg 1.2.0 to 1.4.0), just use the WESTON_VERSION_*
  defines above directly.

Version number testing is the one thing we can't break in the weston API,
so we'll have to settle for documenting the behavior and recommending
using the version number macros directly.

https://bugs.freedesktop.org/show_bug.cgi?id=74023
This commit is contained in:
Kristian Høgsberg 2014-01-27 12:07:19 -08:00
parent 1811312537
commit 5f1ea4eb6f
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/version.h.in
View File

@ -28,7 +28,17 @@
#define WESTON_VERSION_MICRO @WESTON_VERSION_MICRO@
#define WESTON_VERSION "@WESTON_VERSION@"
/* Can be used like #if WESTON_VERSION_AT_LEAST(1, 2, 0) */
/* This macro may not do what you expect. Weston doesn't guarantee
* any stable API between 1.X and 1.Y, and thus this macro will return
* FALSE on any WESTON_VERSION_AT_LEAST(1,X,0) if the actualy version
* is 1.Y.0 and X !=Y). In particular, it fail if X < Y, that is,
* 1.3.0 is considered to not be "at least" 1.4.0.
*
* If you want to test for the version number being 1.3.0 or above or
* maybe in a range (eg 1.2.0 to 1.4.0), just use the WESTON_VERSION_*
* defines above directly.
*/
#define WESTON_VERSION_AT_LEAST(major, minor, micro) \
(WESTON_VERSION_MAJOR == (major) && \
WESTON_VERSION_MINOR == (minor) && \