mirrors
/
weston
mirror of https://gitlab.freedesktop.org/wayland/weston.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

backend-drm/state-propose: Amend an older comment 

Since b38b735e20, 'backend-drm: Remove Pixman conditional
for keep_buffer' the Pixman renderer keeps its own reference to buffers
when attached to surfaces, rather than flipping keep_buffer variable for
the surface. Problem is that when switching from the Pixman render to
the GL would not work and could result in a crash upon first repaint.

Signed-off-by: Marius Vlad <marius.vlad@collabora.com>
This commit is contained in:
Marius Vlad 2022-07-11 14:19:32 +03:00
parent 764c2aff8f
commit 50f98b1006
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libweston/backend-drm/state-propose.c
View File

@ -981,10 +981,11 @@ drm_assign_planes(struct weston_output *output_base)
/* Test whether this buffer can ever go into a plane:
* non-shm, or small enough to be a cursor.
*
* Also, keep a reference when using the pixman renderer.
* That makes it possible to do a seamless switch to the GL
* renderer and since the pixman renderer keeps a reference
* to the buffer anyway, there is no side effects.
* FIXME: Also, we should keep a reference when using the
* pixman renderer. That makes it possible to do a seamless
* switch to the GL renderer and since the pixman renderer
* keeps a reference to the buffer anyway, there is no side
* effects.
*/
ev->surface->keep_buffer = false;
if (weston_view_has_valid_buffer(ev)) {