mirrors
/
weston
mirror of https://gitlab.freedesktop.org/wayland/weston.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

repaint: Requeue presentation feedback on failed repaint 

Whenever an output repaint fails, we leave the presentation-feedback
requests hanging. Requeue them back to the surface so the next repaint
attempt can collect them.

Signed-off-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Daniel Stone 2023-12-06 16:39:40 +00:00 committed by Marius Vlad
parent f5074f261a
commit 3b7ef70d3a
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
libweston/compositor.c
View File

@ -734,6 +734,8 @@ weston_view_create(struct weston_surface *surface)
struct weston_presentation_feedback {
struct wl_resource *resource;
struct weston_surface *surface;
/* XXX: could use just wl_resource_get_link() instead */
struct wl_list link;
@ -3601,6 +3603,23 @@ weston_output_take_feedback_list(struct weston_output *output,
wl_list_init(&surface->feedback_list);
}
static void
weston_output_put_back_feedback_list(struct weston_output *output)
{
struct weston_presentation_feedback *feedback, *tmp;
if (wl_list_empty(&output->feedback_list))
return;
wl_list_for_each_safe(feedback, tmp, &output->feedback_list, link) {
wl_list_remove(&feedback->link);
wl_list_insert(&feedback->surface->feedback_list,
&feedback->link);
}
wl_list_init(&output->feedback_list);
}
WL_EXPORT bool
weston_output_flush_damage_for_plane(struct weston_output *output,
struct weston_plane *plane,
@ -3650,6 +3669,7 @@ weston_output_flush_damage_for_primary_plane(struct weston_output *output,
WL_EXPORT void
weston_output_schedule_repaint_reset(struct weston_output *output)
{
weston_output_put_back_feedback_list(output);
output->repaint_status = REPAINT_NOT_SCHEDULED;
TL_POINT(output->compositor, "core_repaint_exit_loop",
TLP_OUTPUT(output), TLP_END);
@ -8916,6 +8936,8 @@ presentation_feedback(struct wl_client *client,
if (feedback == NULL)
goto err_calloc;
feedback->surface = surface;
feedback->resource = wl_resource_create(client,
&wp_presentation_feedback_interface,
1, callback);