From 3995ffaf3d18acef6296861645ac2b22f72f9b88 Mon Sep 17 00:00:00 2001 From: Philipp Kerling Date: Fri, 9 Feb 2018 21:59:17 +0100 Subject: [PATCH] gl-renderer: Fix crash in dmabuf format query for fallback formats Since formats is an out parameter, we need to copy to the alloc'ed memory and not over the pointer address. Signed-off-by: Philipp Kerling Reviewed-by: Daniel Stone --- libweston/gl-renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index 371e06b3..d091d165 100644 --- a/libweston/gl-renderer.c +++ b/libweston/gl-renderer.c @@ -2122,7 +2122,7 @@ gl_renderer_query_dmabuf_formats(struct weston_compositor *wc, } if (fallback) { - memcpy(formats, fallback_formats, num * sizeof(int)); + memcpy(*formats, fallback_formats, num * sizeof(int)); *num_formats = num; return; }