mirrors/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shared/cairo-util: Hold onto our pattern reference until we're done

Browse Source 
This doesn't actually fix a bug - cairo refcounts this. But I
really don't like the look of code that drops a reference then
continues to use it.

While we're here, set a different pattern when we're done so the
one we allocated loses its last reference.

Signed-off-by: Derek Foreman <derek.foreman@collabora.com>
This commit is contained in:
Derek Foreman 2022-06-06 14:19:07 -05:00
parent 8b654c47eb
commit 2afb812d1e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
shared/cairo-util.c
View File

@ -275,7 +275,6 @@ tile_source(cairo_t *cr, cairo_surface_t *surface,
pattern = cairo_pattern_create_for_surface (surface); pattern = cairo_pattern_create_for_surface (surface);
cairo_pattern_set_filter(pattern, CAIRO_FILTER_NEAREST); cairo_pattern_set_filter(pattern, CAIRO_FILTER_NEAREST);
cairo_set_source(cr, pattern); cairo_set_source(cr, pattern);
cairo_pattern_destroy(pattern);
for (i = 0; i < 4; i++) { for (i = 0; i < 4; i++) {
fx = i & 1; fx = i & 1;
@ -328,6 +327,9 @@ tile_source(cairo_t *cr, cairo_surface_t *surface,
cairo_rectangle(cr, x + width - margin, y + top_margin, cairo_rectangle(cr, x + width - margin, y + top_margin,
margin, height - margin - top_margin); margin, height - margin - top_margin);
cairo_fill(cr); cairo_fill(cr);
cairo_pattern_destroy(pattern);
cairo_set_source_rgb(cr, 0.0, 0.0, 0.0);
} }
void void