mirrors/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compositor: Handle OOM in weston_buffer_from_resource()

Browse Source 
Handle NULL-return in call-sites as well.
This commit is contained in:
Kristian Høgsberg 2013-08-15 12:26:42 -07:00
parent 980b018825
commit 08b58c7c12
2 changed files with 20 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/compositor.c
View File

@ -1077,17 +1077,18 @@ weston_buffer_from_resource(struct wl_resource *resource)
listener = wl_resource_get_destroy_listener(resource,
weston_buffer_destroy_handler);
if (listener) {
buffer = container_of(listener, struct weston_buffer,
destroy_listener);
} else {
buffer = zalloc(sizeof *buffer);
buffer->resource = resource;
wl_signal_init(&buffer->destroy_signal);
buffer->destroy_listener.notify = weston_buffer_destroy_handler;
wl_resource_add_destroy_listener(resource,
&buffer->destroy_listener);
}
if (listener)
return container_of(listener, struct weston_buffer,
destroy_listener);
buffer = zalloc(sizeof *buffer);
if (buffer == NULL)
return NULL;
buffer->resource = resource;
wl_signal_init(&buffer->destroy_signal);
buffer->destroy_listener.notify = weston_buffer_destroy_handler;
wl_resource_add_destroy_listener(resource, &buffer->destroy_listener);
return buffer;
}
@ -1443,6 +1444,10 @@ surface_attach(struct wl_client *client,
if (buffer_resource)
buffer = weston_buffer_from_resource(buffer_resource);
if (buffer == NULL) {
wl_client_post_no_memory(client);
return;
}
/* Attach, attach, without commit in between does not send
* wl_buffer.release. */

4
src/screenshooter.c
View File

@ -180,6 +180,10 @@ screenshooter_shoot(struct wl_client *client,
struct weston_buffer *buffer =
weston_buffer_from_resource(buffer_resource);
if (buffer == NULL) {
wl_resource_post_no_memory(resource);
return;
}
if (!wl_shm_buffer_get(buffer->resource))
return;