From e54eea00ecd7d0ad5b0a21cadf98a1b8d19dbc91 Mon Sep 17 00:00:00 2001 From: kickass156 <14991217+Waterman178@users.noreply.github.com> Date: Sat, 15 Feb 2020 08:11:41 +0800 Subject: [PATCH] The expression(args[i] < 0) always returns false (#1207) * Update optimize.c typedef uint64_t tcg_target_ulong; typedef tcg_target_ulong TCGArg; TCGArg *args The expression(args[i] < 0) always returns false * Update tcg.c typedef uint64_t tcg_target_ulong; typedef tcg_target_ulong TCGArg; TCGArg *args The expression(args[i] < 0) always returns false --- qemu/tcg/optimize.c | 2 +- qemu/tcg/tcg.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu/tcg/optimize.c b/qemu/tcg/optimize.c index fcf7a90a..3316b76c 100644 --- a/qemu/tcg/optimize.c +++ b/qemu/tcg/optimize.c @@ -1370,7 +1370,7 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, } else { do_reset_output: for (i = 0; i < nb_oargs; i++) { - if (args[i] < 0 || args[i] >= TCG_MAX_TEMPS) { + if (args[i] >= TCG_MAX_TEMPS) { continue; } reset_temp(s, args[i]); diff --git a/qemu/tcg/tcg.c b/qemu/tcg/tcg.c index b438b7e2..fd0b2871 100644 --- a/qemu/tcg/tcg.c +++ b/qemu/tcg/tcg.c @@ -1719,7 +1719,7 @@ static void tcg_liveness_analysis(TCGContext *s) implies side effects */ if (!(def->flags & TCG_OPF_SIDE_EFFECTS) && nb_oargs != 0) { for(i = 0; i < nb_oargs; i++) { - if (args[i] < 0 || args[i] >= TCG_MAX_TEMPS) { + if (args[i] >= TCG_MAX_TEMPS) { continue; } arg = args[i];