mirrors/unicorn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix leak and style in map_write.c (#658)

Browse Source 
Fix potential leak, wrong text in log, and restyle
to a cleaner exit path
This commit is contained in:
Peter Harliman Liem 2016-10-25 23:47:55 +08:00 committed by Nguyen Anh Quynh
parent 44ab083d9b
commit 7660768942
1 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/regress/map_write.c
View File

@ -8,20 +8,20 @@
int main()
{
uc_engine *uc;
uint8_t *buf, *buf2;
uc_engine *uc = NULL;
uint8_t *buf = NULL, *buf2 = NULL;
int i;
uc_err err;
err = uc_open (UC_ARCH_X86, UC_MODE_64, &uc);
if (err) {
printf ("uc_open %d\n", err);
return 1;
goto exit;
}
err = uc_mem_map (uc, ADDR, SIZE, UC_PROT_ALL);
if (err) {
printf ("uc_mem_map %d\n", err);
return 1;
goto exit;
}
buf = calloc (SIZE*2, 1);
buf2 = calloc (SIZE, 1);
@ -31,20 +31,24 @@ int main()
/* crash here */
err = uc_mem_write (uc, ADDR, buf, SIZE+OVERFLOW);
if (err) {
printf ("uc_mem_map %d\n", err);
return 1;
printf ("uc_mem_write %d\n", err);
goto exit;
}
err = uc_mem_read (uc, ADDR+10, buf2, 4);
if (err) {
printf ("uc_mem_map %d\n", err);
return 1;
printf ("uc_mem_read %d\n", err);
goto exit;
}
if (buf2[0] != 0xa) {
printf ("mem contents are wrong\n");
return 1;
goto exit;
}
printf ("OK\n");
exit:
if (uc)
uc_close (uc);
free (buf);
free (buf2);
return 0;
return err ? 1 : 0;
}