From 46ae3a042e4298132fc6cc25b7855d768280ce38 Mon Sep 17 00:00:00 2001 From: fallenoak Date: Sun, 17 Sep 2017 10:44:30 -0500 Subject: [PATCH] Ruby: Support reading and writing x86 FPU stack registers (#892) In order to reduce rounding problems from calculations, FPU stack registers for x86 architectures contain values stored in an 80-bit extended precision format. As a result, reading and writing to these registers requires specific handling. This update brings the Ruby bindings in line with the Python bindings by supporting reading and writing the FPU stack registers using 2-element arrays: [mantissa, exponent] The mantissa array element contains the first 64 bits of the FPU stack register. The exponent array element contains the last 16 bits of the FPU stack register. --- bindings/ruby/unicorn_gem/ext/types.h | 25 ++++++++++++ bindings/ruby/unicorn_gem/ext/unicorn.c | 48 +++++++++++++++++++++++ bindings/ruby/unicorn_gem/unicorn.gemspec | 2 +- 3 files changed, 74 insertions(+), 1 deletion(-) create mode 100644 bindings/ruby/unicorn_gem/ext/types.h diff --git a/bindings/ruby/unicorn_gem/ext/types.h b/bindings/ruby/unicorn_gem/ext/types.h new file mode 100644 index 00000000..2a183ceb --- /dev/null +++ b/bindings/ruby/unicorn_gem/ext/types.h @@ -0,0 +1,25 @@ +/* + +Ruby bindings for the Unicorn Emulator Engine + +Copyright(c) 2016 Sascha Schirra + +This program is free software; you can redistribute it and/or +modify it under the terms of the GNU General Public License +version 2 as published by the Free Software Foundation. + +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. + +You should have received a copy of the GNU General Public License +along with this program; if not, write to the Free Software +Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + +*/ + +typedef struct uc_x86_float80 { + uint64_t mantissa; + uint16_t exponent; +} uc_x86_float80; diff --git a/bindings/ruby/unicorn_gem/ext/unicorn.c b/bindings/ruby/unicorn_gem/ext/unicorn.c index e743aaed..db1ae81e 100644 --- a/bindings/ruby/unicorn_gem/ext/unicorn.c +++ b/bindings/ruby/unicorn_gem/ext/unicorn.c @@ -22,6 +22,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. #include #include #include "unicorn.h" +#include "types.h" VALUE UnicornModule = Qnil; VALUE UcClass = Qnil; @@ -118,6 +119,7 @@ VALUE m_uc_reg_read(VALUE self, VALUE reg_id){ int64_t reg_value = 0; VALUE to_ret; uc_x86_mmr mmr; + uc_x86_float80 float80; uc_engine *_uc; Data_Get_Struct(rb_iv_get(self,"@uch"), uc_engine, _uc); @@ -147,6 +149,30 @@ VALUE m_uc_reg_read(VALUE self, VALUE reg_id){ rb_ary_store(mmr_ary, 2, UINT2NUM(mmr.limit)); rb_ary_store(mmr_ary, 3, UINT2NUM(mmr.flags)); return mmr_ary; + + case UC_X86_REG_FP0: + case UC_X86_REG_FP1: + case UC_X86_REG_FP2: + case UC_X86_REG_FP3: + case UC_X86_REG_FP4: + case UC_X86_REG_FP5: + case UC_X86_REG_FP6: + case UC_X86_REG_FP7: + float80.mantissa = 0; + float80.exponent = 0; + + err = uc_reg_read(_uc, tmp_reg, &float80); + + if (err != UC_ERR_OK) { + rb_raise(UcError, "%s", uc_strerror(err)); + } + + VALUE float80_ary = rb_ary_new(); + + rb_ary_store(float80_ary, 0, ULL2NUM(float80.mantissa)); + rb_ary_store(float80_ary, 1, UINT2NUM(float80.exponent)); + + return float80_ary; } } if(arch == UC_ARCH_ARM64) { @@ -177,6 +203,7 @@ VALUE m_uc_reg_write(VALUE self, VALUE reg_id, VALUE reg_value){ uc_err err; int32_t tmp_reg = NUM2INT(reg_id); uc_x86_mmr mmr; + uc_x86_float80 float80; int64_t tmp; uc_engine *_uc; Data_Get_Struct(rb_iv_get(self,"@uch"), uc_engine, _uc); @@ -201,6 +228,27 @@ VALUE m_uc_reg_write(VALUE self, VALUE reg_id, VALUE reg_value){ rb_raise(UcError, "%s", uc_strerror(err)); } return Qnil; + + case UC_X86_REG_FP0: + case UC_X86_REG_FP1: + case UC_X86_REG_FP2: + case UC_X86_REG_FP3: + case UC_X86_REG_FP4: + case UC_X86_REG_FP5: + case UC_X86_REG_FP6: + case UC_X86_REG_FP7: + Check_Type(reg_value, T_ARRAY); + + float80.mantissa = NUM2ULL(rb_ary_entry(reg_value,0)); + float80.exponent = NUM2USHORT(rb_ary_entry(reg_value,1)); + + err = uc_reg_write(_uc, tmp_reg, &float80); + + if (err != UC_ERR_OK) { + rb_raise(UcError, "%s", uc_strerror(err)); + } + + return Qnil; } } if(arch == UC_ARCH_ARM64) { diff --git a/bindings/ruby/unicorn_gem/unicorn.gemspec b/bindings/ruby/unicorn_gem/unicorn.gemspec index 67640837..e959ed6f 100644 --- a/bindings/ruby/unicorn_gem/unicorn.gemspec +++ b/bindings/ruby/unicorn_gem/unicorn.gemspec @@ -13,7 +13,7 @@ Gem::Specification.new do |spec| spec.description = %q{Ruby binding for Unicorn-Engine } spec.homepage = "https://unicorn-engine.org" - spec.files = Dir["lib/unicorn/*.rb"] + Dir["ext/unicorn.c"] + Dir["ext/unicorn.h"] + Dir["ext/extconf.rb"] + spec.files = Dir["lib/unicorn/*.rb"] + Dir["ext/unicorn.c"] + Dir["ext/unicorn.h"] + Dir["ext/types.h"] + Dir["ext/extconf.rb"] spec.require_paths = ["lib","ext"] spec.extensions = ["ext/extconf.rb"] spec.add_development_dependency "bundler", "~> 1.11"