mirrors/tinycc
1
0
Fork 0
mirror of https://github.com/frida/tinycc synced 2025-02-14 22:34:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Clear SHF_GROUP flag when linking

Browse Source 
SHF_GROUP flag set on a section indicates that it is part of a section
group and that if the section is removed, the other sections in the same
group should be removed as well [1]. Since section group are guide for
the linking process, they do not have any meaning after linking has
occured. TCC rightfully [2] discard such sections (by not recognizing the
section type) but keeps the SHF_GROUP flag set on sections that were
part of a section group which confuses binutils (objdump and gdb at
least). Clearing that bit makes objdump and gdb accept binaries created
by TCC.

[1] https://docs.oracle.com/cd/E19683-01/816-1386/chapter7-26/index.html
[2] GNU ld does the same
This commit is contained in:
root 2016-11-25 21:29:01 +00:00 committed by Thomas Preud'homme
parent ed99f3608d
commit ccf9ed7d54
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tccelf.c
View File

@ -3047,7 +3047,7 @@ ST_FUNC int tcc_load_object_file(TCCState *s1,
}
}
/* not found: create new section */
s = new_section(s1, sh_name, sh->sh_type, sh->sh_flags);
s = new_section(s1, sh_name, sh->sh_type, sh->sh_flags & ~SHF_GROUP);
/* take as much info as possible from the section. sh_link and
sh_info will be updated later */
s->sh_addralign = sh->sh_addralign;