mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
19,515 Commits 1,487 Branches 166 Tags 416 MiB
f62e8937ac
Commit Graph

7009 Commits

Author SHA1 Message Date
dan
f62e8937ac Fix a problem when renaming an IPK column that is also part of a child key. 
FossilOrigin-Name: ad15486022209205c65fb5ffdbe30a7b99379170451e6aff4bab6e90b549d6c7
 2018-08-14 21:03:38 +00:00
drh
1595abcda6 Improved error messages when an ALTER TABLE RENAME COLUMN fails due to a 
duplicate column name.

FossilOrigin-Name: 37d11b8e8224a8b241ff57b9c4b9499db39dde4ddcb56ff8b03a3d08091a4c11
 2018-08-14 19:27:51 +00:00
drh
5550b5eee7 Merge fixes and enhancements from trunk. 
FossilOrigin-Name: dff0314b7e7ef2d04375ff21fbf89039bf5f64a9cdca53d7bc7120faacd92c06
 2018-08-14 18:12:33 +00:00
dan
689b9d269c Fix ALTER TABLE RENAME COLUMN in cases where the column being renamed is an 
IPK declared with a separate PRIMARY KEY clause - "CREATE TABLE x(y INTEGER,
PRIMARY KEY(y))".

FossilOrigin-Name: 32ca8418df8735a6c53e53153f733579e514711f091e4e09ecce83db85fe4d85
 2018-08-14 16:18:19 +00:00
drh
8430450674 Fix UPSERT so that it checks the target-constraint first and fires the 
DO UPDATE if that constraint is violated regardless of whether or not
other constraints are in violation.  This aligns SQLite behavior with
what PostgreSQL does. Fix for ticket [908f001483982c43cdb476dfb590a1a].

FossilOrigin-Name: 529fb55e3d00472f13446117527b0896827b11e870b581af7fe7cbb7392ef3cd
 2018-08-14 15:12:52 +00:00
drh
3a9a76b70a Add the "atrc" test program. "Atrc" is short for "ALTER TABLE RENAME COLUMN". 
See the header comment on the program itself for further information.

FossilOrigin-Name: ed64a55a2242408ac0b889b330cf91d38a954399b75c6ebe71232613b864c70b
 2018-08-11 20:46:54 +00:00
dan
404c3ba0d6 If the new column name in an ALTER TABLE RENAME COLUMN statement is quoted, 
then also use quotes for the column name in the edited SQL statements.

FossilOrigin-Name: ca5184a25f9150540a3e401ef67df0606efa7a294d70e3fa5edad9854003eb36
 2018-08-11 20:38:33 +00:00
dan
b0c7920d86 Avoid an assert() sometimes triggered by ALTER TABLE RENAME COLUMN in non-debug builds. 
FossilOrigin-Name: 520c1c75dae5e3f4695fcdf0aad5fb9f492f0e528b5fbb49d5d3b5fc02762f47
 2018-08-11 18:34:25 +00:00
dan
a8762ae27c Fix a bug causing ALTER TABLE RENAME COLUMN to fail when renaming an IPK 
column that is used in a CHECK constraint.

FossilOrigin-Name: 6595c8811f13719d0aed8041abc7e1cade41c57427bcbf3503e2e42408eaa03b
 2018-08-11 17:49:23 +00:00
dan
872165f260 Fix a bug causing all ALTER TABLE RENAME COLUMN commands to fail if ANALYZE 
had been run on the database. Also prevent the user from renaming the columns
of system tables.

FossilOrigin-Name: ca644a2877c26561f8fb3b3feb74a070cd46621acb105577f04bc936c9b72a95
 2018-08-11 17:34:38 +00:00
dan
e325ffed04 Reload the entire schema after renaming a column in order to ensure that the 
schema for any tables for which parent key definitions were changed are
reloaded.

FossilOrigin-Name: f4497b0136e9fcb1121a834c86f84eeaf8f1e7d3157d409484e086bcef3487f1
 2018-08-11 13:40:20 +00:00
dan
5da06d3d7e Ensure the schema cookie is changed when a column is renamed. 
FossilOrigin-Name: 2dec9ea4ab1779d00bb22add0aa9a8536661d8abc9f4c2fb8628e04d4cd84326
 2018-08-10 20:19:34 +00:00
dan
6fe7f23fa9 When a column is renamed, update any references to it in REFERENCES clauses 
that belong to other tables.

FossilOrigin-Name: 191079bd4f774528a1e39b71b4a4ce7859dee0edf0ce72e4b6968ae889dc35c8
 2018-08-10 19:19:33 +00:00
dan
7364fb1d04 Merge latest trunk changes with this branch. 
FossilOrigin-Name: c355a8370782aa70f155ee956fa0faec7f45d7c483c442b169b63c5f0a988fd3
 2018-08-10 15:27:55 +00:00
dan
e9a2fa3182 Fix a problem with renaming columns on tables with REFERENCES clauses that 
specify a large number of columns.

FossilOrigin-Name: d48f7bbdf4a1686c25e634a8dec6ead88bf2866fee94ed8e5058f830363424a8
 2018-08-10 14:23:41 +00:00
drh
ad9f515f52 Fix the isLikeOrGlob() routine in the WHERE clause processing logic so that 
it avoids signed/unsigned character comparisons, as that can lead to an
incorrect answer if the ESCAPE clause is an invalid UTF8 string.  Problem
found by OSSFuzz.

FossilOrigin-Name: 4195a3f8b5d2c2ec63771890c5aa7b5e2de60b9fa2273652730239b8577ae418
 2018-08-09 21:45:45 +00:00
dan
cf8f289542 Experimental implementation of ALTER TABLE ... RENAME COLUMN. Still buggy. 
FossilOrigin-Name: fa0fc01eb48a864f0a3d43f9b805d5ed2e530846ee0c34fcbc2eabd9e5696277
 2018-08-09 20:47:01 +00:00
drh
d98f53249c When a column must be a constant due to WHERE clause and the value of that 
column is being coded as a constant, make sure the affinity is correct.

FossilOrigin-Name: 7404ea83168e6c739ebe8fc5d65bbf0265432ccb35b3418bb0381d74362f7527
 2018-08-09 18:36:54 +00:00
drh
5180d683a0 Add the --info option to the fuzzcheck test utility. 
FossilOrigin-Name: 1caaaaa70f21fe71fbe0af227eea8d1367870e2575eedf248cc2a0b515783390
 2018-08-06 01:39:31 +00:00
drh
24846bc0bf Fix an overzealous assert() statement discovered by OSSFuzz. 
FossilOrigin-Name: d9c9fe9f5ad3fc9123ad29ebafcb7f40dcecd448fb7a928bb31bea8181d81ec1
 2018-08-06 01:21:53 +00:00
drh
dda7e66d7d Remove the column-cache from the code generator. The column-cache has been 
a persistent source of bugs for years and with recent improvements
in the performance of OP_Column, it no longer provides a benefit.  After
the column cache is removed, the binary is almost 2KB smaller and the
speed-check.sh performance test is over 3 million cycles faster.

FossilOrigin-Name: cdff3af7bedc5ebea04bd9b5e2112d3db451a475c18c9a9ebd45f6f3a89a43cb
 2018-08-04 20:30:55 +00:00
drh
bb9c45b49a Add test cases for the constant expression fix of the previous check-in. 
FossilOrigin-Name: 95db5bd9fea86a10c9528dd24841e1370dfdc0bbb5c98b7cbd808a8bc59dd48f
 2018-08-04 15:28:12 +00:00
drh
02ceed058a Completely remove the column cache logic, which has been a persistent source 
of bugs for many years.  We recent enhancements to the performance of the
OP_Column opcode, the removing the column cache actually makes speed-check.sh
run faster.  It also saves about 1,800 bytes of code space.

FossilOrigin-Name: 3f5f60cd7529330209027fdae8129cca420cec1050eae50a7750d0b715b56972
 2018-08-03 23:04:16 +00:00
dan
a4b5fb55f3 Fix the handling of sub-queries with LIMIT clauses by the optimization 
activated by compile-time symbol SQLITE_COUNTOFVIEW_OPTIMIZATION.

FossilOrigin-Name: 21235d9a41567897418aa12f7bd6dd8d6ee363147527e1d8fbca14fc83e0f2c9
 2018-08-03 20:19:52 +00:00
drh
f559ed3400 Add a small cost penalty to sorting to bias the query planner in favor of 
plans that do not require a final sorting pass.

FossilOrigin-Name: 85b9beb4605eb0cfe2ed063c2a1925186c9e37031f78c875e60a347cce891638
 2018-07-28 21:01:55 +00:00
drh
07aded63f4 Do not allow a column reference that is converted into a constant by the 
WHERE-clause constant propagation optimization to be moved to the init-time
constant expression list, as the table reference will not work there.
This fixes a problem found by OSSFuzz.

FossilOrigin-Name: d30b2a947313b146f29e2b53f0fd471409fda7938151241d3fb5863614f88999
 2018-07-28 16:24:08 +00:00
drh
1fd4e7bb0c Fix an assert() statement that was made obsolete by the constant 
propagation enhancement.  Problem discovered by OSSFuzz.

FossilOrigin-Name: e4b4737e348235e196a45e1b71876b82e0cc836e1c5c16ea5f9333b7509b59b8
 2018-07-28 14:56:56 +00:00
drh
cf8e0861a2 When doing a DROP VIEW do not try to delete entries from the sqlite_stat1 
table as there are none.

FossilOrigin-Name: 7efdba2bbc8547ee9292a1bbd1e61d38b40d7aabc0860ceba188bdec539f5114
 2018-07-27 22:55:58 +00:00
drh
7de7602eb7 Add a test case demonstrating the collation problem with constant propagation. 
FossilOrigin-Name: 50add839fd95665bd67a6ae5de8346fd09e83904bbcbad26fad280dff86d9e93
 2018-07-26 23:54:19 +00:00
drh
24e1116e0f Generalize the constant propagation optimization so that it applies on every 
WHERE close, not just those that contain a subquery.  This then demonstrates
that the current implementation is inadequate since it does not take into
account collating sequences.

FossilOrigin-Name: 57eb2abd5b270d65be5e0f138f0d46899fa6091df3ba20b0ea7ef04244a15d48
 2018-07-26 23:47:11 +00:00
drh
660ee55663 Initial implementation of the WHERE-clause constant propagation optimization. 
FossilOrigin-Name: 2fb82ad8ebb6434438c0d235b1239444fb08c8711cea2c5a9ed955fedd0acdec
 2018-07-26 21:16:53 +00:00
drh
ba968dbfe7 Do not abort running queries due to a CREATE INDEX statement. Allow them 
to run to completion before being reprepared.  Fix for ticket
[c694113e50321afdf9].

FossilOrigin-Name: 2bd593332da0aade467e7a4ee89e966aa6302f37540a2c5e23671f98a6cb599c
 2018-07-24 22:02:12 +00:00
mistachkin
8417863fe1 Another minor revision to the 'fulltestonly' set of tests. 
FossilOrigin-Name: 61f8e2a4c6c146ffba498c8bb40f2b5627fdc14020057eab63b7e900bf88a9ed
 2018-07-22 21:08:35 +00:00
mistachkin
1e8487db29 In the Win32 VFS, when truncating a file, unmap it first. 
FossilOrigin-Name: 21510a66dce4d0843ccfe20f092a01f5a52563ef244a94f1d5d2563305cab925
 2018-07-22 06:25:35 +00:00
mistachkin
9676e611b6 In 'resetdb.test', close a database prior to trying to delete it. 
FossilOrigin-Name: 45137053a511b976f5447b0668e3f3a636785d242f44b110a1107898e847e95e
 2018-07-21 23:15:55 +00:00
mistachkin
0fc2da3f79 When dropping a view, skip trying to delete from 'sqlite_stat*'. 
FossilOrigin-Name: 2f5be3a2ddf469bd1b37b9e357545ce872b90c479a07094de2101d0a43ad70a4
 2018-07-20 20:56:22 +00:00
drh
91d5866eb6 Enhanced detection of problems on the freelist and on overflow list in 
PRAGMA integrity_check.

FossilOrigin-Name: 11e58f5b37d99848978007d834d187c262d904eb9d58924742e028d7cb324e64
 2018-07-20 13:39:28 +00:00
dan
ea933f07b0 Experimental fix for resetting databases that have been deemed read-only due 
to a corrupt "read-version" header field.

FossilOrigin-Name: e2394002d02754bb45d56e805df9bc5a2ef0d14e5d94262c1f8ab7643bc27c8f
 2018-07-19 11:44:02 +00:00
drh
ea99a31c59 Add the SQLITE_FCNTL_DATA_VERSION file control 
FossilOrigin-Name: a5087c5c87ad65f92e3bc96bbc84afb43faf10ab6b9ed3ba16304b5c60ad069f
 2018-07-18 19:09:07 +00:00
dan
140a59874b If an SQLITE_IOERR error is encountered as part of an atomic commit on an F2FS 
file-system, retry the commit in legacy journal mode.

FossilOrigin-Name: 1c41250f67ac5de423b0426ef2ab8fe3303278a270225920033933ca9609592a
 2018-07-14 20:25:13 +00:00
dan
e882551935 Add a test-control to disable the skip-scan optimization. 
FossilOrigin-Name: 650a3fe03d61068e06f3097878a777ca8ed713a769444cdb3f8be7d1e19a0b83
 2018-07-12 19:14:39 +00:00
dan
7490128240 Add a test case to check that SQLITE_DBCONFIG_RESET_DATABASE can be used with 
wal mode databases even if there are active readers.

FossilOrigin-Name: 6145f5b3bacdee8f377892ac8b885941336c4cc543052f6373e21c1f99e1eca8
 2018-07-12 11:28:42 +00:00
drh
222a384a06 On an UPSERT when the order of constraint checks is rearranged, make sure 
that the affinity transformations on the inserted content occur before
any of the constraint checks.  Fix for ticket [79cad5e4b2e219dd197242e9e5f4e].

FossilOrigin-Name: d120c45f3dc79f67afed0e44e5133569f784bc6792b15f5d79529deac2d13072
 2018-07-11 13:34:24 +00:00
drh
fef37760da Identify Select objects within a single statement using small sequential 
integers rather than "0x%p".  This is more readable and yields the same result
on successive runs.

FossilOrigin-Name: a7cdc5bc85e0edfcc38f920c2ce91599bcbfdb49522d88b08c64596546d13881
 2018-07-10 19:48:35 +00:00
dan
fd908888d3 Modify tests in window3.test to be tolerant of rounding errors when comparing 
floating point values.

FossilOrigin-Name: 7c26c443e7f6455ca7f11f640e42285b42d95c9ae5f2e19e9c066d6d9cdcceb2
 2018-07-10 18:50:01 +00:00
dan
b556f26145 Fix a problem with using scalar sub-selects in window function queries. 
FossilOrigin-Name: 687fe532c274265ca77451f97829743fcb8a714d0f6b1ceb9a147ab9babdc5b5
 2018-07-10 17:26:12 +00:00
dan
77f3f40292 Avoid leaving view-definitions with an incomplete set of column names/types in 
the in-memory schema if an OOM strikes while allocating the same.

FossilOrigin-Name: 1ddbb5372e7ea8407369b88698b3fb922b62dcac72be633a17bd0e41baa369f4
 2018-07-09 18:55:44 +00:00
dan
e6fcd1d5de Add a couple of OOM tests. 
FossilOrigin-Name: 50de2a0d2d96b6b5b8de7ac6277d60859a8d9a56f6a792950734386bb9f10b79
 2018-07-09 18:11:52 +00:00
dan
a1a7e112fe Throw an error if the second argument passed to nth_value() is not a positive 
integer.

FossilOrigin-Name: 1a06e57a0b4279fa580c7ff4f152645f005794aaf86eeabf694637b7da11f763
 2018-07-09 13:31:18 +00:00
dan
f5e8e31399 Fix a bad assert() in window.c. 
FossilOrigin-Name: fe8aaf0c806413965f50a03e34b5fdfaaa8b09dc0af73f41e830f7b664bd1ced
 2018-07-09 06:51:36 +00:00