mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
23,080 Commits 1,487 Branches 166 Tags 416 MiB
f5b70d06ea
Commit Graph

23080 Commits

Author SHA1 Message Date
drh
52d1407891 Fix a race condition that can lead to deadlock in the memdb VFS if one 
thread is trying to open an existing database at the same moment that
another thread that is the only prior user of that database is trying to
close it.

FossilOrigin-Name: b635375dbe22bd31c437ca574eb0c014c0b045de6cc0816c32d2ceceff9191fb
 2021-05-12 15:39:02 +00:00
drh
85ffcae177 Add the new threadtest5 test program for stressing multiple database 
connections in the same process hammering on a single database.
Primarily designed to test memdb, but works on any database.

FossilOrigin-Name: 8db1c06958b8e1691440d4fd392648b74a1940b721852dabd315005efad520fc
 2021-05-12 14:17:20 +00:00
drh
277ae64103 Enhance the memdb VFS so that it is able to share databases among multiple 
database connections in the same process, as long as the database filename
begins with "/".  This provides a way for threads to share an in-memory
database without the use of shared-cache mode.

FossilOrigin-Name: 533fffc4a39b01c3aba75bd3271fd6ccd9516d9681ed04adbe19bd7de03f4c16
 2021-05-12 11:55:59 +00:00
drh
2d344f944e Respond correctly to OOM during mutex allocation. 
FossilOrigin-Name: 98dae595d861941bb0bcd12126ee02492587c466e6da579a58b5dc4a4d655917
 2021-05-12 02:52:20 +00:00
drh
483051c9b6 Mark an unreachable branch as NEVER(). 
FossilOrigin-Name: 6c20d9d4b7c7986e8404142974a91dce7514ca574ee52ed5d036367aad396689
 2021-05-12 02:09:01 +00:00
drh
f71d6fa9db Fix a NEVER() that can sometimes be true. 
FossilOrigin-Name: 8f9f1cbc4468d07d693b418be4d89771fd240ee4af34395d7da5b7709fe88f37
 2021-05-11 11:40:22 +00:00
drh
ccb897c70a Fix a NEVER() that can sometimes be true. 
dbsqlfuzz 9a86fb3830977e216fde061bfbe1c1e5c2e9bfc4

FossilOrigin-Name: f39666e64d6d32420170c54f874d8314eb8c6f91df625f7b28f9ccffb9474dc0
 2021-05-11 10:47:41 +00:00
drh
2f4d0ec392 Enhance the memdb VFS to provide the ability to share a single database 
among multiple database connections.

FossilOrigin-Name: 0617c66ac213d406a9a21580227a57542d7f21c8750c854f549ab818d7a936bc
 2021-05-10 23:48:46 +00:00
drh
8d889afc0d Enable the sqlite3_serialize() and sqlite3_deserialize() interfaces by 
default.  Omit the SQLITE_ENABLE_DESERIALIZE option and replace it with
the SQLITE_OMIT_DESERIALIZE option.

FossilOrigin-Name: 6df3b03e00b1143be8fed3a39a58ce81063020275aa1ac13d87c84f1ceda6e27
 2021-05-08 17:18:23 +00:00
drh
d10c3ca3f7 Fix help-text typo in the CLI. 
FossilOrigin-Name: 560753148a16a0032477e379af6f62d9357f69847f351cc9db6021ce1b5594ea
 2021-05-08 11:57:35 +00:00
drh
4752bbd872 Detect misuse of aggregate functions in the ORDER BY clause of a query 
even if the query also contains window functions.

FossilOrigin-Name: 0d11d777c8d368f0b6e9faf3afccf7da1b041d303a68782e43aebd713aaecf51
 2021-05-07 15:46:36 +00:00
dan
01ec691979 Fixes for cksmvfs and rbu so that they work together. 
FossilOrigin-Name: f35f6972cdcf16915cc37908b65a3780742a1f75f65e974714b16e86f0c9e3f0
 2021-05-06 20:47:49 +00:00
drh
e31cba5675 Remove an assert() in FTS5 that can (rarely) be false in the event of an 
OOM while processing a corrupt database file.

FossilOrigin-Name: 5f12f89154843e83b1d69ea1652e881d583aa329df732af72dd59029cd7eb577
 2021-05-06 13:45:37 +00:00
drh
c3c23f346c Improved detection of oversized cells in balance_nonroot(), especially in 
index b-trees when a cell is being moved from a child page into the parent
page in order to become a new divider cell.

FossilOrigin-Name: 9080d3d5f5aaddbb3410158bcc446649651b7dce3940eb3491620ec9208914b4
 2021-05-06 11:02:55 +00:00
drh
59df3e92db Provide the sqlite3PrintMem() routine on SQLITE_DEBUG builds, which can be 
invoked from a debugger to get a summary of the status of an sqlite3_value
or Mem object.

FossilOrigin-Name: 5ac24179f5ef16dccc1b65248e33376c9748767b14c75c1056f3b0d08b7a89a7
 2021-05-05 19:46:50 +00:00
dan
4fd82a2a78 Fix an undefined-integer-overflow problem in fts3.c. 
FossilOrigin-Name: a0bf931bd712037e44e8d7cac3c00a6715c1b451f222bad3184d3ecab1a4c7f4
 2021-05-05 11:47:34 +00:00
drh
67656ac78a When applying the optimization that disables WHERE clause terms that drive 
indexes, make sure not to do so if the term being disabled is a transitive
constraint.  Fix for the problem identified by
[forum:forumpost/eb8613976a|forum post eb8613976a].

FossilOrigin-Name: f1f9b5de3c59489b94963685660b3ddc45eece5535b02fec399b6ece0e38563d
 2021-05-04 23:21:35 +00:00
drh
23634898c5 Also for the 0x20000 bit of ".wheretrace", show when WHERE clause terms are 
disabled.

FossilOrigin-Name: 625fb253eecd6c10fce5d0127d516361df0c1d1661502b396fc418dcdb4ae999
 2021-05-04 18:24:56 +00:00
drh
6068b6b451 Additional debugging output for whereScanNext() showing equivalence classes 
when the ".wheretrace" setting contains the 0x20000 bit.

FossilOrigin-Name: 9280e3d994656344d4feb346156df8a278da80181f6efe0ff8e0340b6f0f91cb
 2021-05-04 16:51:52 +00:00
drh
433a3e935d Back out the EXISTS-to-IN optimization. It slows things down rather than 
speeds them up depending on the query.  And (see
[forum:/forumpost/8692d94725|forum post 8692d94725]) it sometimes results in
an incorrect answer.  We may come back and revisit this optimization later,
but for now it seems best just to disable it.

FossilOrigin-Name: 16252d73fa73569fd7506676f6ffbbcd43addfb105384fb74449d30ca720904a
 2021-05-04 12:07:16 +00:00
drh
f83d501c6d Fix minor coverity warnings in the CLI. 
FossilOrigin-Name: 204086a94202fc631371b75c7a8286df2f66116399628ac27ef54533641b8f20
 2021-05-03 13:35:00 +00:00
drh
e103a8de2d Fix a potential memory leak following OOM in the decimal extension. 
FossilOrigin-Name: 5127f7376776e6220eb8f83a30aa6b823c23ae0ac76e7ae41b33ca4e03ce236a
 2021-05-03 13:24:30 +00:00
drh
736d11ed21 Back out the NEVER() inserted by [c7309ed3c7588c7e] because it is reachable 
after all.  dbsqlfuzz bc17a306a09329bba0ecc61547077f6178bcf321

FossilOrigin-Name: 20a4f3f12cdd8823d53d91025fa41e284c9f629b1d049eb486ff8dc4a1736e1f
 2021-05-01 12:09:36 +00:00
drh
76baad95f4 Guard against a NULL-pointer dereference following OOM in the JSON extension. 
FossilOrigin-Name: ea221f3c8e243a5dc4952e510cbe396614a24876bacdc04fb1ebd4127c7ef0d9
 2021-04-30 16:12:40 +00:00
drh
0449f6561f Fix a harmless "unused variable" warning when compiling with 
-DSQLITE_COVERAGE_TEST.

FossilOrigin-Name: 0bef3fb11fb95d7ede82b59aea26e99e2e23b3bce48009181e691ea17ae78a61
 2021-04-30 12:30:35 +00:00
larrybr
5f5719bd07 Reduce API lifetime requirement for objects passed to sqlite3_bind_...() with SQLITE_STATIC. 
Also fix broken session doc links (by zapping refs.)

FossilOrigin-Name: 327eb4792f9b98f6220fd35ba744002d36ed53f43a016924117b3cea32343947
 2021-04-29 19:30:35 +00:00
drh
5960724789 Fix the operation of the "-" argument to --load-dbsql in the fuzzcheck program. 
FossilOrigin-Name: 1f18b3cbee7e1342fdd66e45ef744fea3db2ba4513943c0582ff8ef98974865e
 2021-04-29 18:03:42 +00:00
drh
81f5ef05a9 Fix the IN-early-out optimization so that it works even for the corner case 
where the NULL bypass fires before the affinity of the LHS operator has been
set.  Fix for the problem described in
[forum:/forumpost/6a3ec138e9|forum post 6a3ec138e9].

FossilOrigin-Name: eb40248ce606b792a02e4e0b7dd826a82891c5f4c9793f3ca5d332e593109525
 2021-04-29 15:49:34 +00:00
drh
7bfccfe73c Enhanced "PRAGMA vdbe_trace=on" output associated with the seekHit flag. 
FossilOrigin-Name: 683950009300657b0321d7d3f77f2585a28696ff93cedef399d1cd4aa484b2d4
 2021-04-29 13:58:28 +00:00
drh
5f086ddee0 Fix harmless compiler warnings. 
See [forum:/forumpost/256140e470|forum post 256140e470].

FossilOrigin-Name: 1b8da7924cc78710ae4bbe12b57140fdaeae5efb0e6ac10073ae9c98b7f8d7a4
 2021-04-29 13:37:36 +00:00
drh
5e26d07d62 Update test/fuzzdata8.db with recent dbsqlfuzz finds. 
FossilOrigin-Name: bce2ea393a872b5b70ef3b9cedce3d406725dcc56d8800ee4f7ec29562cc3f9b
 2021-04-29 10:48:50 +00:00
drh
c645871123 Ignore the TEMP or TEMPORARY keyword on CREATE statements which parsing 
the schema out of an existing database file.  Those keywords should never be
there.  This change simply adds robustness in case a legacy or damaged database
is seen.

FossilOrigin-Name: 65ec39f0f092fe29e1d4e9e96cf07a73d2ef7ce2c41b6f1cd3ab23546ada0e67
 2021-04-28 17:37:26 +00:00
drh
79f313f13c Adjust a VDBE coverage macros due to the enhancement at [506333742103c1f4]. 
FossilOrigin-Name: daed59b4f96a6899d2404274ad985be3f22f407c1502b3f8ffd7977441a9fe9a
 2021-04-28 15:43:36 +00:00
drh
3765c03243 Further improvements to the handling of RETURNING clauses on changes 
to TEMP tables with triggers.
dbsqlfuzz 683913e98f54fe4f14e8dd11a48011f73bdca58d

FossilOrigin-Name: ff3538ae37a02f4f36a15cddd1245171e724aac9c84b2e576980fd3806302775
 2021-04-27 17:18:10 +00:00
drh
a476768340 RETURNING bug fix: Correctly deal with RETURNING statements on changes to 
TEMP tables that also have triggers.
dbsqlfuzz 78b9400770ef8cc7d9427dfba26f4fcf46ea7dc2

FossilOrigin-Name: d0b15eccbfe1e50c3daf7b2fd4769a52bba35d553b07e462ca3f5f22df6742fd
 2021-04-27 13:04:18 +00:00
dan
a4cd0bbcb3 Fix a segfault that could occur when querying a corrupt data structures with an fts5token table. 
FossilOrigin-Name: cbedfa05501f3eb9750fb21e2ab8516f8f14c479c847f454e52572af278aab71
 2021-04-27 11:28:57 +00:00
larrybr
3ec4861c00 merge latest trunk 
FossilOrigin-Name: 3ff228249adf2da345d3e19e9af3e23d1354f6b9a35ddbe9864e1a07716d871c
 2021-04-27 04:47:27 +00:00
drh
2f40dc9884 Better error messages on showdb. 
FossilOrigin-Name: 7e18e114b245d17aa259ea9ab42752ccc9ad5303bbac8d8e46928dd10319f545
 2021-04-27 00:05:03 +00:00
drh
19a7f72ce2 Improved robustness of the "showdb" debugging program when it is parsing 
corrupt database files.

FossilOrigin-Name: 3eabac2ee50fd70b22a927d3d2934718a15e1f666d8d271b854579156c8b01de
 2021-04-26 23:57:02 +00:00
drh
d8bc250b91 New dbsqlfuzz cases added to test/fuzzdata8.db. 
FossilOrigin-Name: 88d20500c516fe89ad1cd42f7366ca190c3790f911f11ab332b86b675f5f69ba
 2021-04-26 22:30:49 +00:00
drh
c7f5077e88 Fix the [/info/df1d6482f9e92daf|UNION ALL flattener optimization] so that it 
works better with recursive CTEs.
dbsqlfuzz 88ed5c66789fced139d148aed823cba7c0926dd7

FossilOrigin-Name: f80d7bb2c305c1dd4658767660b33259032c048a91f18c654a6bda7332c54a0c
 2021-04-26 21:23:01 +00:00
drh
feef447271 Add ALWAYS() to branches that are no longer reachable due to recent 
enhancements.

FossilOrigin-Name: 63c50fbdeed831ba450d1dce67e968a7daa2b69ac1270eb271fb1e1873d4a07e
 2021-04-26 21:00:51 +00:00
larrybr
ada2323d95 refix altertab.test 
FossilOrigin-Name: db032156932fb0dcae5ffb7cbdfb711079daa595713fcb254f09f8ef90c81d95
 2021-04-26 20:18:08 +00:00
dan
f0ac29090b Fix a problem that could cause a crash in sqlite3BtreeDelete() when operating on a corrupt database file. 
FossilOrigin-Name: 6c6334660dfe81cc33a14b87b25d748b1c98b0702b7bc6db2e3ced16dc992740
 2021-04-26 15:32:36 +00:00
drh
3c6edc8a11 More aggressive detection of OOM errors in resolveAlias(). 
dbsqlfuzz 7f96832c2ef7ee472022ed805b064e55e41094b2

FossilOrigin-Name: e99faf4f82746761c389e24db1b00ee94b9f849e7bcb29517fa0ca10290afc41
 2021-04-26 15:28:06 +00:00
drh
8ed8ddf759 When doing the optimization that attempts to avoid sorting on a 
GROUP BY, do not assume that the values in an index on an expression are
non-NULL.  Bug discovered by Wang Ke's fuzzer and reported at
[forum:/forumpost/74330094d8|forum post 74330094d8].

FossilOrigin-Name: 7178dc3a32c3a4a33e437fd5026f6f72e4809ceb7d2cd12a25a74b80d5c95d33
 2021-04-26 14:32:48 +00:00
dan
bb0eec438d Do not initialize eponymous virtual tables when parsing the schema. This can happen if the db is corrupt. 
FossilOrigin-Name: cb8c41aa20bb351c4c712ed7a3617187ceeb0905ede1e6f561bc1d89f31c95ea
 2021-04-26 14:09:48 +00:00
larrybr
3ff6a5edd9 Skip test when no JSON. 
FossilOrigin-Name: 6fcb2438f88a70ed67e19103bfa263a6c98b06962207f153559c9516d8c7b5d5
 2021-04-25 23:13:04 +00:00
drh
113a33c539 Make window range queries more robust against corrupt database files. 
dbsqlfuzz f22df3a7b2aab0937a415484514fc2f68a293c99.

FossilOrigin-Name: 506333742103c1f440db5da819a36f3b518f7b49e94a7b74419b02bbcadc5a78
 2021-04-24 23:40:05 +00:00
drh
ba9ebc2d12 Treat byte-order marks (BOMs) at the start of a token as whitespace. 
This enhancement is inspired by
[forum:/forumpost/ed8f696a20|forum post ed8f696a20].

FossilOrigin-Name: 3d55c21c167631f42d155aadec544e629bd078de9992aa5a74694d08bc52052b
 2021-04-24 12:24:08 +00:00
drh
971ae9f66a Fix testcase altertab-25.1 due to check-in [c7909e8e0d0577c6] disallowing 
ALTER TABLE on eponymous virtual tables.

FossilOrigin-Name: 32255e39cbde65492d88177464cee9e10cb20cf3105208416be131e2c89b63e1
 2021-04-24 12:20:10 +00:00
drh
1521270010 Fix harmless compiler warnings in fuzzcheck. 
FossilOrigin-Name: e7b4ffecc610c494ebd506977402ec48cc799780f96c6293c0ccf27697160aa1
 2021-04-23 13:57:53 +00:00
drh
ba6619d7be Enhance the --load-dbsql and related options of fuzzcheck so that if the 
argument is a single - then filenames are read from standard input.

FossilOrigin-Name: e1548802b6de7037baf388d27a7f3658abafe07b6f48d5ec97e5f644303592d8
 2021-04-23 12:58:16 +00:00
drh
292ed6decf Give a better final output line for the --spinner option on fuzzcheck. 
FossilOrigin-Name: 93729614e21ee674b83b0d2babb71bb758f1a2ec55bf9bda057fb7739f2e14e0
 2021-04-23 12:16:16 +00:00
drh
d84f10ed13 New dbsqlfuzz cases added to test/fuzzdata8.db. 
FossilOrigin-Name: 8da88508932e475c8c6af1553268ff02e3e013b78ccc94b14532ec928fc62537
 2021-04-23 11:50:23 +00:00
dan
f3d5a68461 Fix an assert() in fts5_index.c that may fail if the database records are corrupt. 
FossilOrigin-Name: dfadb96edfef1d49e48a659264b9eb8d7f98d95d159d95c92c30dd4ba6c6e739
 2021-04-23 11:37:01 +00:00
drh
7a04e296f3 Improved OOM detection in sqlite3ExprCheckIN(). 
dbsqlfuzz 46ae2d8f473ac672f3042cc14ab67aeab9ffa6c2

FossilOrigin-Name: fac12115a994a1b4347586e68faf38895ee9cb588eaa84c6f71cf9afd4c488b4
 2021-04-23 00:59:38 +00:00
drh
eca3c67b1c Change a memcpy() into a memmove() to prevent a warning about overlapping 
regions passed to memcpy() in case of some obscure and unlikely database
corruption.

FossilOrigin-Name: bab132cbd18a529389a0315e60f30ccf1b565823116e0ec9b4f7684db1914c80
 2021-04-22 20:01:02 +00:00
drh
214b50314a Fix harmless compiler warnings of unused function parameters in FTS5. 
FossilOrigin-Name: 14273915979f8fbf80111e795b5511a6ee24638896b9d434d6ccf4bf7f7a7f62
 2021-04-22 19:34:31 +00:00
dan
743b5fd589 Further tweaks for comments in sqlite3session.h. 
FossilOrigin-Name: 553ada28f356d773c145b502163d766285e73fd4f64dc05f98e3e43ade806331
 2021-04-22 18:52:36 +00:00
dan
9ad39a33ff Change to comments in sqlite3session.h. No changes to code. 
FossilOrigin-Name: 353ebb71c4113a35a92011c72f9c1d6c56f3bf681d94426a6a73e40f219ff2f4
 2021-04-22 18:39:02 +00:00
drh
3d8c92d041 Raise an error on an attempt to rename an eponymous virtual table. 
FossilOrigin-Name: c7909e8e0d0577c6109f13c0b14fb565239aae8af8963d659f363e124f3437fc
 2021-04-22 18:02:48 +00:00
dan
a5b51b8715 Add the experimental sqlite3session_changeset_size() API. 
FossilOrigin-Name: 3de544d495fee553d95fde3fb656745d633138115d25ed39760a1ea7c8c3fae6
 2021-04-22 17:55:42 +00:00
dan
6d29a4fe5b Add the sqlite3session_object_config() API. Current used to enable/disable collecting data for sqlite3session_changeset_size(). 
FossilOrigin-Name: 4d5fd2151e024d11289b6c4fbce2996d8d07b2b5a1c953ef895c237e79d3aa55
 2021-04-22 17:40:28 +00:00
drh
65b930553d Improved handling of errors in ALTER TABLE RENAME. 
dbsqlfuzz 3e3e2e076e53d02288f80af41a11143a6ddf8c88

FossilOrigin-Name: 9c7a449f52a391506ebf4a8efa4ff27e6e97bd8da4b300a5c0dd942a209fe474
 2021-04-22 16:54:34 +00:00
drh
68b63c0195 Fix the date/time translation logic in the zipfile extension so that it 
works with boundary cases. See
[forum:/forumpost/d82289d69f|forum post d82289d69f] for the trouble report.

FossilOrigin-Name: c8de5f061359c174e143e5e81ade8aa9b7d71ba57287459cf0f4f2c94459c345
 2021-04-22 14:43:16 +00:00
drh
1da9c97bc0 Ensure that the typedefs for specific-length integers in zipfile.c are 
correct.

FossilOrigin-Name: f1f2a49007e938ea7a00dda6f8898b1cd38525c0de1e1cac00a7aebcd7b625f5
 2021-04-22 13:59:54 +00:00
drh
824043150f In the whereLoopXfer() routine, ensure that the destination is fully 
initialized even if an OOM error occurs.

FossilOrigin-Name: c4258708c08c5b1956052f9febbf22c1e94c8352a25059063746921d2cc373b7
 2021-04-22 12:38:30 +00:00
drh
31536304a5 The new OP_Null opcode from check-in [8b54102a00852b72] was not coded 
correctly.  This check-in attempts to fix that.

FossilOrigin-Name: 02af30aab24878c4382a8863512b816889400104549b51df6a632767fee48d04
 2021-04-21 23:13:26 +00:00
dan
a23a873fbb Add the experimental sqlite3session_changeset_size() API. 
FossilOrigin-Name: b5564a6fd54875db1de884fdc0e5eeabcd6aa5595ad03a8a60843503e830a2d8
 2021-04-21 20:52:17 +00:00
drh
7437c25b63 Add recent dbsqlfuzz test cases to test/fuzzdata8.db. 
FossilOrigin-Name: 6fe50dcc239d2d1fc2a38aa705f4c75cbe26b3e48d098537306d96d6a4005659
 2021-04-21 12:03:36 +00:00
drh
f02b5ad69d Initialize the key registers in the skip-scan optimization to NULL, in case 
the query is run on a corrupt database that causes the initialization of the
key to be bypassed.
dbsqlfuzz 62fdf2bece00d24cac8a4edf2cf562e6eeac779d

FossilOrigin-Name: 8b54102a00852b72783b5b2f336c7a093adbdc8e1b94d46b7d315ae6e5d9476b
 2021-04-21 11:58:45 +00:00
dan
fe599b05f2 Fix a problem allowing SQL variables to be used expressions within the second and subsequent ON CONFLICT clauses of an UPSERT within a trigger. 
FossilOrigin-Name: 2a28910a17dc5b3ce43062fdf879f9622f6ec2db19ed780fa7fe5cae781be7b7
 2021-04-21 11:32:22 +00:00
drh
935ad98d60 Remove a testcase() that is no longer relevant due to the previous check-in. 
FossilOrigin-Name: ca70c8ac72c9fe3b92f8e63151229bebdccc769c5c4d603ad4f466dc4bcd11e0
 2021-04-20 22:48:25 +00:00
drh
8cae5a4a47 More aggressive detection of database corruption in the rebuildPage() routine. 
FossilOrigin-Name: a18c65068b16eae3c0725356d7f4775774b23e248c700cef8c15f23459fba68f
 2021-04-20 20:48:15 +00:00
dan
5b482a9832 Update an assert() in btree.c that may fail with a corrupt database. 
FossilOrigin-Name: d74bf88c5a027cf080a2892a3538fe5104952b5b3759a6eba1b1a98a75ddf5f4
 2021-04-20 13:31:51 +00:00
drh
9da977f1a5 In the sqlite3SelectDup() routine, do not do an incomplete duplication due 
to OOM.  This in turn requires several new NEVER() and ALWAYS() macros for
unreachable branches.

FossilOrigin-Name: a61c0e6b78bd39f55464fafd257e68effded64995a66e8fa2d686e8c507ebe43
 2021-04-20 12:14:12 +00:00
drh
8c6cb1bc6f Improvement to check-in [d564d8882ef18b55] to detect the OOM fault even 
if it occurs deep down inside the duplicated expression.

FossilOrigin-Name: 3e863cd09355abd80c1053d6d4dabb55841f806e3c418f923d67d36bf8313cb0
 2021-04-19 20:36:13 +00:00
drh
5e8e7464d0 An improvement to check-in [1a341378ab24a509] that omits the new 
Walker.bWalkWinDefn boolean (which is not always initialized) and uses
a special value for xSelectCallback2 instead.

FossilOrigin-Name: bef2238de9550de84d4cd1c970a542b43db288d73d09a3c3ced7f98bb3188fd3
 2021-04-19 19:59:16 +00:00
drh
1bb89e9cc8 Ensure that a WITHOUT ROWID table does not have the .iPKey field set, even if 
an OOM error occurs while parsing a schema in PRAGMA writable_schema=ON mode.
Add extra assert() statements to triple-check that this never happens.
dbsqlfuzz 803bb1f63d6f3bd6c14db568494d6e96be8f1ec9.

FossilOrigin-Name: 41228350a620a7de1ee748a4e19a96749c4d39418853fe8b68c43cf401dbd7cd
 2021-04-19 18:03:52 +00:00
dan
6a4f7f0225 Remove fts5 test functions fts5_expr(), fts5_expr_tcl(), fts5_isalnum() and fts5_fold() from release builds. 
FossilOrigin-Name: c68a6c6c898d2acd1f7032ff98f8f3f99eb0b37ffbc6ee88d0dd7badf55a0e0a
 2021-04-19 16:45:09 +00:00
drh
60b95335e2 In the query flattener, avoid invalidating an expression if an OOM occurs. 
This prevents problems in higher-level routines that might not check for
the OOM after processing a subquery.
dbsqlfuzz fb70fa8602421f87673e0670b0712ff2b5240ea0

FossilOrigin-Name: d564d8882ef18b55ebf93e838426b485281c7ebe3a9b321a2f984ed0f229cc25
 2021-04-19 15:05:27 +00:00
dan
0a746cc528 Ensure that all records are updated by setting the OPFLAG_SAVEPOSITION flag when updating records as part of ALTER TABLE DROP COLUMN. 
FossilOrigin-Name: 354a4db5cb769c6aed386f43ee26d7e42342e92f781eef100c09751dc5b51751
 2021-04-18 05:30:39 +00:00
dan
3c6fbd6dd9 Remove a couple of NEVER() macros from the code for walking window lists. 
FossilOrigin-Name: 4ec9ef4bcd12bd9ba5e1a2424f75479070d12c25f1272548c6cf3f89be826b8c
 2021-04-17 20:13:53 +00:00
larrybr
7d0a2f3fe3 Merge trunk bug/test fixes 
FossilOrigin-Name: 830b0b1c49aaca53a40e5a4ca9a11351d697a980c7bf80379e32f0646738d566
 2021-04-17 20:13:35 +00:00
larrybr
68d261d073 Bring in permutations mod. 
FossilOrigin-Name: 7a1316f32c857b5ec9e50c5d341f977f998dbf404f4758e3fe317fd8ef25f41e
 2021-04-17 20:04:40 +00:00
dan
55f36787ea Do not run external_reader.test as part of permutation "journaltest", as it requires wal mode. 
FossilOrigin-Name: 9f5f16cf093cd8b8c7649f664eaf2ad8128fd50e182720dbddf05a6d9227c037
 2021-04-17 19:59:14 +00:00
larrybr
f5576936f1 Allow more time for perf tests when instrumented. Condition another on feature it needs. 
FossilOrigin-Name: f0dd9cf2d7045d3634294bcf2722d3d7b0a6c4c3ef713b0f7f54fbe31432027f
 2021-04-17 18:43:29 +00:00
drh
48a6aede46 Add new dbsqlfuzz cases to test/fuzzdata8.db. 
FossilOrigin-Name: d18793e589a4ee7706e994a1f3d24ba7df190467d92fa6ac040258f4debc149d
 2021-04-17 18:39:39 +00:00
dan
44918c74cd Fix cases where code in expr.c was failing to handle OOM failures that occurred while processing sub-select expressions. 
FossilOrigin-Name: 62efe2eee34fdb147cc456290576d8fc3801487867c78aadd4485f85468d9ffc
 2021-04-17 14:42:37 +00:00
drh
7b0d34fe32 Ensure that variables are not used in the WINDOW clause of a query inside 
of a trigger.  dbsqlfuzz d9cf66100064952b66951845dfab41de1c124611

FossilOrigin-Name: 1a341378ab24a5091e6cf03b9e957d11b2bfe5c711835e8c583785f8fa0125d3
 2021-04-17 13:46:23 +00:00
larrybr
c7a409e78e Merge from trunk. 
FossilOrigin-Name: 43894f0b5b4f000a929052bc32822d704d25d139375362fad77f8824b5aad456
 2021-04-16 23:53:07 +00:00
larrybr
1929cc0d8a Add geopoly to $::sqlite_options() and use it to pass more tests. 
FossilOrigin-Name: 23da5016b66f3947cc902dbe2766ea9f5a00f85312a652b536ab51d657446ab7
 2021-04-16 23:43:22 +00:00
drh
de0e1b150c Performance optimizations in the code generator, especially in name 
resolution.

FossilOrigin-Name: ab83a99899ceae931b43e0c4b3f8f8b83bc832f1568de5692c0d038c968f8a87
 2021-04-16 22:53:57 +00:00
larrybr
453954b0de Make a test conditioned on feature used. 
FossilOrigin-Name: 31afda7ac3081d05fc9b6d080abeba1296327d0c480bbb4bc5f65c3168cd34ac
 2021-04-16 21:29:07 +00:00
drh
188ba3a979 Add new dbsqlfuzz-generated cases to test/fuzzdata8.db. 
FossilOrigin-Name: 1ac0a056a07895cc4ae62d01cbba5525402be3af3b8f97fd1dfaba2236ef912b
 2021-04-16 19:25:47 +00:00
dan
6c68e55689 Fix another undefined behaviour in fts3 that could follow an OOM error. 
FossilOrigin-Name: fac3ff857c4abdb44f59849af80d93a5bd4b64f088e5164fb5ad0be8d14748b7
 2021-04-16 17:09:58 +00:00
dan
7f2eb8fff2 Avoid signed integer overflow when finding snippets in fts3 by using 64-bit integer offsets. 
FossilOrigin-Name: 4cc09a872f627f4a2b94345bef07cd49c3ec3627f8d78c1eb091741cdb4ec0b3
 2021-04-16 16:55:28 +00:00
larrybr
89eab376da Merge from trunk. 
FossilOrigin-Name: d762784a46946c5a5d565d7ef8ae243703eb38eb71d6101a7f2ed6d22eff1c53
 2021-04-16 15:44:32 +00:00
drh
197561cd42 Remove an ALWAYS() from a branch in sqlite3ExprAddCollateToken() which can 
be false following an OOM.
dbsqlfuzz 9e8516bf1e786c84e520ae43141b75b7399f8618.

FossilOrigin-Name: 6af4e6d054efd8445e1010aabd584f36e70dfad0de13bd0e2f1761cad4d9a7d6
 2021-04-16 12:33:52 +00:00
drh
19c16c8771 Fix an assert() in whereLoopAddOr() that can be wrong if an OOM occurs in 
an OR constraint on a virtual table if one of the terms of the OR is an IN
operator.  dbsqlfuzz 5ee7350b40014f5a878c5d6e76913a2d619f5146

FossilOrigin-Name: 5cb40e53edcb1e54cde0e54c38a647144bc3158435df0161f95c89732de086e6
 2021-04-16 12:13:39 +00:00
dan
11a6e9d9f0 Fix an assert() in fts3 that might fail when handing corrupt records. 
FossilOrigin-Name: d0e2d6742f314f71562e404980aad20de6b17e0b04c08582c18bbc4fd0360751
 2021-04-16 11:25:37 +00:00
drh
81e5a9a6df Fix the comment on the implementation of the pi() SQL function. No changes 
to code.

FossilOrigin-Name: 5620bd466eb10fd4daf51af9b88d8221f981dc0ceabfa84a0e1d5c817f635429
 2021-04-16 11:05:19 +00:00
larrybr
5ae13144ef Dial back assumptions on compile option defaults to reflect actual conditionals. 
FossilOrigin-Name: cb3127725dbb9490f9bb3a95d7fd52acd78390981ee8b7c6da35bdfb84ad0359
 2021-04-16 10:25:54 +00:00
drh
34c11e2f4b Do not invoke sqlite3ExprAffinity() if there is a possibility that the Expr 
is incomplete due to a prior OOM.
dbsqlfuzz b8a824706914488bd236da51118eb9174ceb870f

FossilOrigin-Name: e8a1515b44380cc52aca1838814ca398012e4e9cf5728d40b404546e812a39b7
 2021-04-16 01:03:16 +00:00
larrybr
cf5ad4210e Merge from (forked) trunk. Handle compile options that differ from default by being 0. 
FossilOrigin-Name: 6eb83f83d280f82bd225972f52c52922257303740a968457ff0be08d43993d59
 2021-04-15 23:43:25 +00:00
dan
9988db8302 Fix a bad interaction between constant propagation and transitive term handling causing patterns like "WHERE unlikely(t1.x=t1.y) AND t1.y=?" to return non-matching rows. 
FossilOrigin-Name: 2363a14ca723c0343fbe350f6c19787a7a47c2289fd9af136c97a451b53b5226
 2021-04-15 19:09:19 +00:00
dan
37d4ec86bf Add extra test case for OOM handling in where.c. 
FossilOrigin-Name: 7163de3dea0445bf25dba47a54c50f35bb5c7edc7bdae9630b51c1ca970ec6cf
 2021-04-15 13:26:29 +00:00
drh
d784cc893c Make sure the WhereInfo.pExprMods list is properly cleared when existing 
sqlite3WhereBegin() early due to an OOM fault.
dbsqlfuzz 1247a51318047aba42e7f6991dfa62577cb7a151.

FossilOrigin-Name: 0e19af72d84f96245cb4a5cfc37232579b6f5fdebd525f8b6515a4f2cc84e273
 2021-04-15 12:56:44 +00:00
larrybr
f8fb27f4a9 Bring pragma compile_options up to date. And make mkctimec.tcl help do so. 
FossilOrigin-Name: 63ea3e298c575a408e5c5e12368292c966db6dcffcb6e1c770734f28b8757635
 2021-04-15 00:26:34 +00:00
dan
385b982865 Prevent an assert() from failing if sqlite3_blob_reopen() is called on a blob-handle that has already hit an SQLITE_CORRUPT error. 
FossilOrigin-Name: b5dc7aba036cfd6d09c68dd17608328063634ca99ff341f97bab2dc2a1f59b11
 2021-04-14 15:25:10 +00:00
dan
8505d73dc0 Fix a potential crash when using json_group_array() as a window function. 
FossilOrigin-Name: 3c266690c753d093c2cb74138a46ed69276d85cd119d687a6858c84211e84eaf
 2021-04-14 12:11:39 +00:00
drh
f817189e1b Fix an assert() in the code generator for expressions so that it is valid 
even after an OOM.

FossilOrigin-Name: 427e83eb583a4f63650912f078122e7373fe8c7ea11acfdab464d748b4235261
 2021-04-14 11:20:44 +00:00
dan
304cbc17c2 Fix an undefined signed integer overflow in fts5. 
FossilOrigin-Name: e6f0adb00da84561e686a8db83858c7fd6b008756dd1aef807ea68f878ca3db7
 2021-04-13 17:45:36 +00:00
drh
3bb9d75aa6 Do not leave a WITHOUT ROWID table without a primary key index structure 
due to an OOM error.  This prevents downstream troubles in the case of
PRAGMA writable_schema=ON.
dbsqlfuzz 69fb32cc82d59b4d790881566e3f6c727e616122

FossilOrigin-Name: 608b6644b932c4d0c26ab870322639deefde4606f9e335575f99995bc7ed08b5
 2021-04-13 13:48:31 +00:00
drh
569143c851 The SQLITE_NoSchemaError flag should not apply to OOM errors while parsing the 
schema.

FossilOrigin-Name: 9cc484ad1a42f0821e53be6df46b1811dc8059e5aaf2f6c3e667105a55893b97
 2021-04-13 13:20:55 +00:00
drh
6000e08d33 Earlier detection empty_result_callbacks in sqlite3InitCallbac() to avoid 
problems with corrupt schemas an writable_schema=ON.
dbsqlfuzz ca4ca43bdb22eab9859de4979aec615af851e111.

FossilOrigin-Name: fb305fe077a0058861427f107957fcc3d2b1443cdd11a7f145df138ca3bb9f4e
 2021-04-13 13:01:07 +00:00
drh
b3d2ba7cb0 In the rtreedepth() function, detect OOM when converting a zeroblob() on 
input.  dbsqlfuzz ed23eda7cc3a8a054f85ea19d55c59ba2ca72744.

FossilOrigin-Name: 69f843c8fa6e21500b5777169c3b394453ba818b4e32427428480dca5b4ed615
 2021-04-13 12:28:55 +00:00
drh
0e5cd34915 Fix an error in the inversion function for json_group_array(). 
dbsqlfuzz 68a4b0f668b7bc27235e3f1c5cff8a2d94cfa17e.

FossilOrigin-Name: e718a62ed1d5ba9b1404ba67fae1ad731809e2ebd9253edc57d2b34a19fbef24
 2021-04-13 01:12:32 +00:00
drh
5cc9daf8a2 Fix a faulty assert() inside sqlite3ExprDup(). 
FossilOrigin-Name: 59812e7ef705226c801f95ec7f78cc931f9957ffb66715607d63874813b280cb
 2021-04-12 23:18:18 +00:00
drh
4aab6fae57 Fix an assert() in OP_ParseSchema so that it works even after an OOM. 
FossilOrigin-Name: 79b883537910274518cadbda7b5088811f59287b9385fc28ab54d837d41b995a
 2021-04-12 22:39:46 +00:00
drh
f1f12661c3 Avoid taking the address of a NULL pointer following an OOM in FTS5. Doing 
so is harmless in actual practice, but it technically UB so we want to
avoid it.

FossilOrigin-Name: 1cfcd9dceb56b5987e6900a36a0ec092f0e1b13a7e754b8c3d8efb943e5bcc66
 2021-04-12 18:32:33 +00:00
drh
9920bf975b Add an assert() to show that the SF_Resolved flag does not get set if 
errors are being suppressed.

FossilOrigin-Name: f455c5b0bda3d303f9269db37efaa8ff0b356622b2df0a7544f83bb334118180
 2021-04-12 17:34:03 +00:00
dan
d487e37367 Fix a segfault that could occur if the ORDER BY clause of a compound SELECT contains a sub-select that uses one or more window functions. 
FossilOrigin-Name: 5ba15ebb34c3af85ef6c54bbb3acb57176d629cda83774881b2a6467e138e904
 2021-04-12 16:59:28 +00:00
drh
ff37491874 Fix the display of SrcList in the sqlite3TreeView debugging routines. 
FossilOrigin-Name: 28ecb3810b40ca58c2e04a752bbc2234c64c27185aef2cb3fe7c933082dc2578
 2021-04-12 12:58:55 +00:00
dan
cd0b245934 Avoid an assert() failure when a compound scalar sub-select is, due to a "WHERE (sub-select) AND (... OR ...)" clause, coded twice by the code generator. 
FossilOrigin-Name: a4e3f13329332f91a250bc18459fd4100990a1ac0516f8a0a6b21ff117db9795
 2021-04-12 12:02:49 +00:00
drh
1d6d737cb7 Fix harmless comment typo in main.c. 
FossilOrigin-Name: 785a553e71e2ecf108ec4140d470d718ceeb2d03896f7aab36ce10cf0e99e72e
 2021-04-12 11:51:32 +00:00
drh
0003d87893 Add NEVER() to a branch that is no longer reachable due to 
check-in [a1d823f6879ce1ac].

FossilOrigin-Name: 5fda21feda2448de880088f4f53f20875ef02b47172c48091638b80173f983d7
 2021-04-11 00:11:56 +00:00
dan
7f65b7af42 Avoid an uninitialized-memory valgrind error by tightening up corruption 
detection in internal routine defragmentPage().

FossilOrigin-Name: 8096f7aee497f852b1404e13cdc8bafb54fcf6c540cd58addbc01eb2e27011b3
 2021-04-10 20:27:06 +00:00
drh
21c7ccb9ba Add NEVER() to a branch that became unreachable with 
check-in [58f36af2271517ab].

FossilOrigin-Name: e07ce463967521ab53463b21f80c8f90c337c15c250f69c3fccc1305f54f32df
 2021-04-10 20:21:28 +00:00
drh
1fd1cc4433 Avoid invoking sqlite3Atoi64() will a null pointer following an error 
from ExpandBlob().

FossilOrigin-Name: 780412f2ca7576ce90861b2bd499f953504125b200e9aeae685def4a943f9d2b
 2021-04-10 15:34:30 +00:00
dan
677e62aacd Fix a problem with handling expressions like "(col IS NULL AND <expr1>) OR col == NULL" in WHERE clauses. 
FossilOrigin-Name: 40852ca8e215e51f63652a67817361b835b6fbbff7f66af50089af91007505f1
 2021-04-10 14:49:45 +00:00
drh
050611a79b Refactor NameContext.nErr into nNcErr to avoid confusion with Parse.nErr. 
Do not abandon sqlite3ResolveExprList() on nNcErr if nErr is still zero
as we might have hit a problem with ORDER BY resolution that should be a
suppressed error.  dbsqlfuzz 41b9dad40919d3549ca7e52d893da81a6dded4ad

FossilOrigin-Name: 7d674970741bd9b228b818c701c1ae010b90cc287a4c60a872f18b66353d164d
 2021-04-10 13:37:04 +00:00
drh
d78fe4e1a4 Remove a NEVER() in a corruption detection conditional in allocatePage(). 
dbsqlfuzz 9c61c33802600b2b01dfb09b0386ceb4ade02a19

FossilOrigin-Name: c174f5d32b8c6bbad102065b2d5acae70ddb153f863a2842da836cf7db3f683f
 2021-04-09 22:34:59 +00:00
drh
2be1f2afe8 Remove an ALWAYS() that is actually reachable following an OOM on an 
UPDATE FROM of a virtual table.
dbsqlfuzz aa03237ef7c4a028c7cdaf8bbcde2b62e2bcd36e

FossilOrigin-Name: 49eac38926b3391b185d20fae6588c213f7f020f028173d4a4aa3c7a62b94140
 2021-04-09 22:20:20 +00:00
dan
a3a91dd5f1 Have the VFS in memdb.c return SQLITE_IOERR_NOMEM instead of SQLITE_NOMEM when an OOM error is encountered. This is required to get the pager module to handle such OOM errors correctly in some cases. 
FossilOrigin-Name: 09c96b4c026746f285a8aef5199bd247ecca590095ee42dde4f4dfa4996ce0bd
 2021-04-09 20:50:40 +00:00
dan
bfd6f1bcd5 Fix a use-after-free error that could occur when processing "SELECT aggregate(DISTINCT <expr>)..." queries. 
FossilOrigin-Name: 0e4789860b81c31d3a6d1f9f8340042ce1d08a82bf6119c783fcab85180b1b63
 2021-04-08 20:29:12 +00:00
drh
55938b5fa0 Remove an ALWAYS() that might be false under very unusual circumstances. 
dbsqlfuzz 300261f469ace7ecc57ed32ea7b0de3ea9d7dbf.  Test case in TH3.

FossilOrigin-Name: 466f508973e7adc983a4c9bd7c86b4d9269e3b990183fc7f95a50fe72b832ad0
 2021-04-08 19:56:58 +00:00
dan
f5ea93b432 Handle the corruption fixed by the previous commit in a different way so as to also fix dbsqlfuzz crash 753de0a0ac5b25b18f1e4d41e650d3333cdc270c. 
FossilOrigin-Name: cb27ce25095ab9b5acbe4bf010c7f6d8a71191c2f79b3bf3e63d8655b4fe0769
 2021-04-08 19:39:00 +00:00
dan
1bae648b73 Handle a special case of corruption that can present if "PRAGMA writable_schema=1" is set. Fix for dbsqlfuzz test case 6229ad63de49e3ba0630aaf0058868f36008bcca. 
FossilOrigin-Name: 58f36af2271517abafa9f4a46f2a5f97e66c001675c17868282197d599603d1b
 2021-04-08 15:19:46 +00:00
drh
d4f7ec7663 Hardden the filter_over grammar rule against OOM faults. 
dbsqlfuzz e47c54502a9c36778a5ed553199d5870e2ebd9f2

FossilOrigin-Name: f375f541efee520042be83548ad96dfa889e2c349eda5db7612ac2336dd4e4f9
 2021-04-08 14:15:26 +00:00
drh
a77d52f63c Remove an incorrect assert() from sqlite3EndTable(). 
dbsqlfuzz 4af45bcda779592449b1985433bca90b0e683b9b.

FossilOrigin-Name: 38a1085cbd5b6dd5f418efa15c6da05de781f794b8f3dad3f871c96019fed099
 2021-04-08 13:52:11 +00:00
drh
6af2a728e4 Fix an obscure memory leak in FTS3. dbsqlfuzz 26a51001beeff35649d2e328b05ec06f93c577a5 
FossilOrigin-Name: be7cd9ebb1ba360c60469073b2e526cb1cceea702e43fcc07f47b47986908c8f
 2021-04-08 13:41:20 +00:00
drh
4ad9673d00 Do not allow the use of rowid for views and subqueries unless compiled 
with -DSQLITE_ALLOW_ROWID_IN_VIEW.

FossilOrigin-Name: a2ddb89b206c13876d34c5f9e3db41cda72d6eb3fea31ffa8cc6daa1e1580e16
 2021-04-07 18:17:53 +00:00
drh
a875b72d6b Add the SQLITE_ALLOW_ROWID_IN_VIEW option to omitttest.tcl. 
FossilOrigin-Name: 83b8e4c281c5295950fbf2330a45193b73054b0749b51a6c2c4fbc79a7a5f82d
 2021-04-07 18:08:23 +00:00
drh
6e5020e8da Also prohibit the use of rowid from a subquery. Add the 
SQLITE_ALLOW_ROWID_IN_VIEW compile-time option to restore legacy behavior
in case somebody actually needs it.

FossilOrigin-Name: 14b1d56ef84b0e62b7f9c4e5f7f985ca10e770c8db59f54004ad892c2a2dcbfb
 2021-04-07 15:45:01 +00:00
drh
252d582a35 Unnecessary local variable initialization to fix a harmless compiler warning. 
FossilOrigin-Name: c22e47c77a35ebcd1fdfc0caea9119dd5e24e76d5fdd0f2ffbb58205a7242297
 2021-04-07 13:20:34 +00:00
drh
e7e7481a29 In FTS3, if the xBegin method fails to start a transaction due to an OOM 
error, then make sure that the virtual table is left in a consistent state.
dbsqlfuzz 85ef48423fda4eef79a551654445d8ef3537a590.

FossilOrigin-Name: dd553578333f49950a197fe894d02e08cce011c9ae1a7270604186af204dcf6d
 2021-04-07 12:59:09 +00:00
drh
d6a33de77c Fix an assert in the automatic-index constructor that can be false following 
an OOM error.  dbsqlfuzz ee04d66c627ed5b5301e0ce09e24db47e0f1544e.

FossilOrigin-Name: cc6463fe6d23febeea5171f9a1bcb1e5f980f7f44b7e85022d5fd8662b471160
 2021-04-07 12:36:58 +00:00
drh
0781219fd2 Earlier detection of page 1 on the freelist (which is impossible) and 
reporting of that as database corruption.
dbsqlfuzz 6fe6c504b320be5e3eed66896cb0db28bfb38a93.

FossilOrigin-Name: b1bf0d987578160f002035ff41ec7c82011288f1c0449414a4b3da39b20f871c
 2021-04-07 12:21:35 +00:00
dan
755ed41f5a Fix a possible crash that could occur when executing a drop column operation on a corrupt database schema. 
FossilOrigin-Name: c337849416c588142a5066db3feb1716b7a9d02536bdb73cc9da7d162c0d5494
 2021-04-07 12:02:30 +00:00
larrybr
6536c4f18e Fix seg-fault upon appendvfs attempt to open non-existent file. 
FossilOrigin-Name: 04f6439f4d9b9b1f717c3aa243a93585df7e7844c216fab5d15bebb050ab00b1
 2021-04-07 09:31:32 +00:00
drh
204b634222 Do not apply the optimization that omits DISTINCT if all result terms are 
part of a UNIQUE index if the index is also a partial index.
Fix for the bug reported by
[forum:/forumpost/66954e9ece|forum post 66954e9ece].

FossilOrigin-Name: c2f940b02883e165172a4ca21c7095ffbef84ddc5367853dfeca93fda20d6056
 2021-04-06 23:29:41 +00:00
drh
a74364ae13 Detect OOM earlier in the geopoly extension. 
dbsqlfuzz 0986e7b020e6137fc6b96331f91d15753d18e42d.

FossilOrigin-Name: 7237117595a3519717a0a4b03eb427c6ec55b214e7ecd6d0f63a613adec355d4
 2021-04-06 22:56:28 +00:00
dan
cc26301ec3 Modify the drop column code to handle WITHOUT ROWID tables for which a single column appears more than once in the primary key. 
FossilOrigin-Name: e0d2507021c5a04016c442f954b542c0920678737ae7c710eb8ac50d6337db1c
 2021-04-06 21:20:39 +00:00
drh
a6c54def42 Raise an error if a query tries to access the "rowid" of a view, as views 
do not have rowids.

FossilOrigin-Name: 7a73c6166bb1d9f2e2de280fa4e973db152caaf6cc76b8e6a92cfe9560ddc224
 2021-04-06 19:13:44 +00:00
dan
5a9fd231ea Restructure a loop in window.c to avoid hitting an assert() following an OOM. dbsqlfuzz test case 6ef74a9659de87e9be3d8694ad062c448aa7ef1d. 
FossilOrigin-Name: 887c19a15ba60a5dc375dda7e289d476ba24d4adb38086a013df9709b88f32a7
 2021-04-06 18:40:27 +00:00
dan
112501fec2 Update an assert statement that could fail when using "PRAGMA writable_schema = 1" to access a database with a corrupt schema. 
FossilOrigin-Name: 55cad6f628a4313c6652b36474c3397f097ac5c2503ae94605c030a54dc40916
 2021-04-06 18:02:17 +00:00
dan
d73ade7d87 Fix issue with failing --enable-debug --enable-fts5 build. 
FossilOrigin-Name: e7491acc0c93b7b0b5a27130d956bb23f876b90ced11cdd416a86727af076ee1
 2021-04-06 17:51:18 +00:00
drh
4ffaffe657 New test cases added to fuzzdata8.db. 
FossilOrigin-Name: 039ad662dd899048da04238c05b8cf384323f6e8c1087b96428ea9e20726c8c0
 2021-04-06 16:55:30 +00:00
dan
11fbee24b6 Silence an msan warning triggered by a corrupt database by initializing a local variable in sqlite3Insert(). 
FossilOrigin-Name: f64deecee1691cf21b4f3d27d8490ecc8eae65cf26df7a22f8d15317f0cecd5b
 2021-04-06 16:42:05 +00:00
dan
d4b646997a Avoid a use-after-free that may occur when accessing a corrupt database schema with "PRAGMA writable_schema = 1" set. 
FossilOrigin-Name: a1d823f6879ce1acfd251de35ffdfdf5ce7d8e0552205c2c4a1fee179e3a6972
 2021-04-06 16:16:15 +00:00
dan
f22c590bab Remove some test routines from release builds of fts5. 
FossilOrigin-Name: 3088bf15ca53fac3bad94f241e648836631b6d801d42837c238ff27d85074ca4
 2021-04-06 14:46:50 +00:00
dan
1408bf176e Fix incorrect RETURNING test cases in wherelimit.test 
FossilOrigin-Name: 20d21ff9be558c5f7773efa4efba7d36752f56c9a0caf1fd9c601aab5562dcef
 2021-04-06 13:57:23 +00:00
drh
d22ecfd38c Earlier detection of OOM errors during window function processing. 
dbsqlfuzz b08676f5a0437552c95d2a5d7ef285f8c451ea35.

FossilOrigin-Name: 8e04f52e32c9655b703ab0a6dc6d57e6bd134db9e7168807b7b2ce81974f9274
 2021-04-06 13:56:46 +00:00
dan
2a1aeaa36e Handle "RETURNING rowid" clauses attached to INSERTs on views without causing an assert() to fail. Fixes dbsqlfuzz crash 0081f863d7b2002045ac2361879fc80dfebb98f1. 
FossilOrigin-Name: 9c5b7386d013a7f22a93c69722c4648e2ab60eef180f48b5470bfea6fa74b3da
 2021-04-06 13:53:10 +00:00
drh
8119aab3c8 Further improvements (subsequent to [d91450847a3a3a72]) to handling of attempts 
to delete a journal using the memdb VFS.
dbsqlfuzz ac61dab357279a6a531de067f040e9a4828d2df0.

FossilOrigin-Name: a0839406426a0d8ec52cc3116ea7d8b582344b44f3f8c9365bbf5187370c3386
 2021-04-06 13:03:06 +00:00
drh
4c4a25727f Earlier detection and handling of OOM problems. 
dbsqlfuzz 39f2963ea5559aa3a16e24e0e3cb42aac85a7371.

FossilOrigin-Name: 8d46df73132e46abb32b9dc129b6beb978d34dac3d372fb004ca283b0832d04c
 2021-04-06 12:50:24 +00:00
drh
e0cc26734e Relax an assertion on the sqlite3WhereEnd() routine after dbsqlfuzz found 
a counter-example.

FossilOrigin-Name: e6b591e76523034c41884b39d71d4b721f1df709bdafd842e2d4b4084c158ec0
 2021-04-05 22:42:15 +00:00
drh
9ce612a66f Add a missing CORRUPT_DB to an assert in the OP_ResultRow opcode. 
FossilOrigin-Name: 82f92d79e1901911b0ce57d0aa30d462847748159443c7db8af16e6b37e8212c
 2021-04-05 22:30:56 +00:00
drh
7ac08e8be6 Adjust the README.md file so that build instructions work for Fossil version 
2.12 and later.  [forum:/forumpost/51f28bb701|Forum post 51f28bb701].

FossilOrigin-Name: 51f87adc7f90935484eadad82f751f1df8c1607d463dae9589a71aeda2184b3a
 2021-04-05 19:23:18 +00:00
dan
6b6ec407ab Do not allow floating point rounding errors to cause a window function xInverse() function to be invoked before the corresponding xStep() call. 
FossilOrigin-Name: 7a19fed4f222bc6c20e13a1367c8235916d21ba5e6f5a31cd26842efe748e744
 2021-04-05 19:05:18 +00:00
drh
e3814ee026 Fix an assert() that can be false when doing an incremental vacuum on a 
corrupt database file.  dbsqlfuzz cced0668cfd4da4eb2382cb9dd26c17c64aaff76.

FossilOrigin-Name: 15b801016fa204b8e4b7c89e236adb73dd57687959d825664de5097370b24030
 2021-04-05 17:50:38 +00:00
dan
240e36c0e3 Avoid coding unindexed WHERE constraints if an equivalent transitive term has already been coded by an outer loop. 
FossilOrigin-Name: 644bb77f8bb2c3499db7c280440c92fd2649a98ce714ae0d5d690eabfdc04326
 2021-04-05 16:20:59 +00:00
drh
d5e7fff2ca Do not invoke the xDelete method when converting to PRAGMA journal_mode=OFF 
if the underlying VFS does not support that method.
dbsqlfuzz 39d6af88ef5242f866c4f9b21ede330c5c1e36a8.

FossilOrigin-Name: d91450847a3a3a7217f8f5947adea9a4d12cf77607d40f9724d6ba093919b524
 2021-04-05 13:41:42 +00:00
drh
2389048f29 As a continuation of [1f66a85b7757754f], ensure that an OOM that occurs 
while checking the validity of the schema is reported out as SQLITE_NOMEM
and not as SQLITE_SCHEMA.

FossilOrigin-Name: 5045c8a748f0065638d0ff4f6e3ccd124183fbc518cb9b0418d125b04dbc1491
 2021-04-05 11:39:55 +00:00
drh
319deefdb9 Fix an assert() in sqlite3BtreeLast() that needs an "|| CORRUPT_DB" term. 
Dbsqlfuzz case b92b72e4de80b5140c30ab71372ca719b8feb618.

FossilOrigin-Name: ad718388a1f6e25ceba43a40160fac0d9d9d3f26888e98d7b9db478c0b1780be
 2021-04-04 23:56:15 +00:00
larrybr
b0e62b0a21 Avoid compile error when SQLITE_OMIT_VIRTUALTABLE defined. 
FossilOrigin-Name: 0ee0ef476ba9e17794c088a1347a136df3eb1ef864da884cfe81e3b2e94e9719
 2021-04-04 14:22:02 +00:00
larrybr
dabada6020 Make shell .parameter feature type-agnostic. Hush harmless compiler warning. 
FossilOrigin-Name: 35cf295e026d067c9f059fde6b150e65163fe171d37501eb1e5742e691793340
 2021-04-04 12:52:58 +00:00
drh
57f90189a5 Improved robustness to OOM conditions in the window function logic. 
dbsqlfuzz 0c123f7d80b29beaafc8411c12129e46f7ffdac3.

FossilOrigin-Name: 35ff7cbf547d41109b7cd4217a5439b3b4a1a4c310309c572c88f596fbc1b099
 2021-04-03 23:30:33 +00:00
drh
ad3930be46 Take care not to change an SQLITE_NOMEM error into SQLITE_SCHEMA. 
FossilOrigin-Name: 1f66a85b7757754ff9aa0a626f66250c5fabc5fc8ab67bbc4b2ae8e6d9231a72
 2021-04-03 20:35:08 +00:00
dan
f330d53ff3 Fix a crash in handling queries of the form "SELECT aggregate(DISTINCT tbl.col) FROM ... LEFT JOIN tbl ...". Fixes a problem introduced by [ef4ac0ddd297bbd3]. 
FossilOrigin-Name: 0dcf808ddf23da834da724d88b1715ed06565f1f1290713ff42a3fcf6ffb802e
 2021-04-03 19:23:59 +00:00
drh
9af69ff547 Correctly capture the error when a RETURNING clause appears on an 
attempt to UPDATE an eponymous virtual table.
dbsqlfuzz 486f791cbe2dc45839310073e71367a1d8ad22dd.

FossilOrigin-Name: 778a9a6e6f8d960fd55ac9be7eea20b1875a46192db85e63dddc61b632b30173
 2021-04-02 20:43:26 +00:00
dan
aecc04d642 Add experimental SQLITE_FCNTL_EXTERNAL_READER file control. 
FossilOrigin-Name: e16da5af822ef31d7e05992403cf9787fbb3d9abb0b5283aba55ea07e1830a72
 2021-04-02 19:55:48 +00:00
drh
ec435c40ed Fix a problem with the geopoly_bbox() function. 
FossilOrigin-Name: f3a2eb979f1003e8249e613b34afd345f157c0d54b4f05ea0db230ef70e71351
 2021-04-02 18:59:13 +00:00
drh
22af584e3e When resolving names in the RETURNING clause, do not accept trigger names 
even within subquires.  See
[forum:/info/34c81d83c9177f46|forum post 34c81d83c9177f46] for context.

FossilOrigin-Name: fd4ea3f626b6e4957d56c2369be711895735cfc37cfde65650a6682ad5a3eb1a
 2021-03-31 23:56:55 +00:00
drh
d75aeee535 When resolving column names in the RETURNING clause, do not ignore an 
incorrect table name qualifier.  Raise an error instead.
See [forum:forumpost/85aef8bc01|forum post 85aef8bc01] for context.

FossilOrigin-Name: 51d5c50b2fb373e4c7ddb7e26657c26ad39dc9c2fc629bba5c2522b4150d8fac
 2021-03-31 17:42:24 +00:00
drh
b3ad4e6118 Defer deletion of expressions that are optimized out by the AND optimizer 
in the sqlite3ExprAnd() routine until the corresponding Parse object is
deleted.  This avoids a dangling pointer in AggInfo if sqlite3ExprAnd()
is invoked by the push-down optimization.  The dangling pointer appears
to be harmless in release builds, only showing up in debug builds.
Problem found by dbsqlfuzz.

FossilOrigin-Name: c36b43589abd9f62a709bdb47b8748e0c1e8743487a3d83d1eb35eb06b65d763
 2021-03-31 13:31:33 +00:00
dan
b03786ad6e Ensure that negative numbers may not be used in frame offset clauses even if they are initially text value. e.g. (RANGE BETWEEN '-1' PRECEDING ...). 
FossilOrigin-Name: 8b681b274dd01c3e0f76d5bbddcbb2450c6d9475b9cfa0db961a3ab5edf51db1
 2021-03-31 11:31:19 +00:00
drh
0d23f678b1 Raise an error if a term of the form "TABLE.*" appears in the RETURNING clause, 
as SQLite does not (yet) know how to handle that.
Ticket [132994c8b1063bfb].

FossilOrigin-Name: 3039bcaff95bb5d096c80b5eefdaeda6abd1d1337e829f32fd28a968f663f481
 2021-03-30 01:52:21 +00:00
dan
28a314e74d Do not do the EXISTS-to-IN transformation if the sub-select has LIMIT clause. 
FossilOrigin-Name: d07e246f9b6d4d7aef63a6debcb7ab2832bff6f80a245f50bcebb3f8de1bacc7
 2021-03-29 20:28:27 +00:00
dan
acbae3ba10 Add "#ifdef SQLITE_DEBUG" blocks around test variables sqlite3_fts5_may_be_corrupt and sqlite3_fts3_may_be_corrupt. 
FossilOrigin-Name: 004559544e661f9afa60306c4ac6842c29a8630b3663d62aa0cdc637f176932e
 2021-03-29 20:04:31 +00:00
drh
269b7d09bd Simplify the comparison opcodes in the bytecode engine, for a performance 
improvement.

FossilOrigin-Name: f2af5868be83c65dbc593dafd4357fdb7d5d740128e9225dd1b2de16947012b3
 2021-03-29 20:01:04 +00:00
drh
529df929de Fix VDBE coverage macros. 
FossilOrigin-Name: ebe100de55ccdf6abccde5d8e6e96099b6e8dc3527f1441265e2b86b6661a66b
 2021-03-29 19:47:39 +00:00
drh
4bc20452b5 Omit the SQLITE_STOREP2 and SQLITE_KEEPNULL options from the comparison 
opcodes, allowing them to run faster.  This required refactoring the
vector comparison logic, which in turn required changing OP_ElseNotEq into
OP_ElseEq.

FossilOrigin-Name: 380b46054b6a9b67e57357815e8e94057253fa3cce838ae76e5d5031c6bd26b2
 2021-03-29 18:53:47 +00:00
drh
871e7ff43d Add the OP_ZeroOrNull opcode and use it to compute boolean values for 
scalar comparisons, rather than the SQLITE_STOREP2 parameter to the comparison
opcode.

FossilOrigin-Name: 93781b6f10a94fb273204b95156a8b90e07071f28c89e7966c659a0f44f60e98
 2021-03-29 14:40:48 +00:00
drh
1f97d2618b The comparison opcodes (ex: OP_Eq) now set the iCompare flag so that the 
result of comparison can be used by subsequent OP_Jump or OP_ElseNotEq
opcodes.

FossilOrigin-Name: bd00df8f07b7163b0712590d2bb517e838a36c994dc47d7b39b5a07d14e6e6af
 2021-03-29 13:47:20 +00:00
drh
1af3fd562f Alternative implementation of the comparison opcode speed-up of 
check-in [4a8805d9a66dc888] that should pass muster with UBSAN.

FossilOrigin-Name: afb18f64541effaeaada2d72c7c91adfe5ec3e2b1418c0bc281083125fb5badb
 2021-03-28 23:37:56 +00:00
drh
9cffb0ffb9 Document the "%token" directive for Lemon. This directive has been in place 
for a while, but was previously undocumented.

FossilOrigin-Name: 36624d3740a8d095eee061bcc5037deabddb88a53444ec1a956a8af7684efa43
 2021-03-28 20:44:01 +00:00
drh
5e23ae500b For the sqlite3_bind_text16 TCL binding used for testing, ensure that there 
are at least 3 terminating zeros, so that there will always be a \u0000
character even if the original byte sequence is an odd number of bytes.

FossilOrigin-Name: c23d092f37c535f88a47e9f55aa7b2fd40cfd5c50eec9191a68073d7f9141ecd
 2021-03-27 16:21:34 +00:00
drh
639ae98c63 In the sqlite3_bind_text and sqlite3_bind_text16 TCL commands of the test 
suite, ensure that the string is zero-terminated if the size argument is
negative.

FossilOrigin-Name: f472fd64434cb2eac169587faa34bec489bc82002d529bc72dbfbba5251e5517
 2021-03-26 23:59:37 +00:00
drh
126aab142e Remove old testcases() macros. Also remove surplus end-of-line whitespace. 
FossilOrigin-Name: 54b41915ed8ef993b4116b2de00f3f4bba7570a1d28ad6bb93ba158a6b89eff3
 2021-03-24 23:30:06 +00:00
drh
9be1339faf Comment improvements to on the distinct-agg optimization. Show a line in 
the EQP output when using an ephemeral table to implement DISTINCT on an
aggregate.

FossilOrigin-Name: 037ca79e6032ca962b4f6182187bc12a7d91170d73630c8cd6fb191d2c183ee4
 2021-03-24 19:44:01 +00:00
drh
6db1c9da67 Improvements to distinct aggregates such that they can sometimes avoid 
using an ephermeral table to test for duplicates if the column that is
distinct is part of an index.

FossilOrigin-Name: ef4ac0ddd297bbd38351410c5a387e1628561b3f1bec9e4c2c9d76fbe29f955a
 2021-03-24 17:28:11 +00:00
drh
29821b46f5 Fix a harmless compiler warning. 
FossilOrigin-Name: 26b005a95e4f3e378e3bc40f57321ffbab72b6fc990d13b56b3121990d325f63
 2021-03-24 17:04:32 +00:00
dan
1d14ffe63d Fix a problem with renaming a column when there is a quoted string immediately following the column name somewhere in the schema. 
FossilOrigin-Name: 4719fae6262aa3563f3df6aca0170c6d847bb18ab7b0e6e7609a0e7b6f0c6b1b
 2021-03-23 22:15:34 +00:00
drh
5191ae06ab Add an ALWAYS() on a branch that is always taken. 
FossilOrigin-Name: 0646d2260c523d368e3f6bc3d110a9011d35ce83bd6751ad412d8fd9a253cb7a
 2021-03-23 21:02:24 +00:00
drh
0227d9304d Test result adjustments in test/misc7.test due to the EQP format change. 
FossilOrigin-Name: d3ade8c7fe58e05af9d44a79478776b050a680c1338188f2d4b222b937e682ea
 2021-03-23 19:39:27 +00:00
drh
ed42b98056 When doing schema updates, try to convert (incorrect) double-quoted strings 
into (SQL-standard) single-quoted strings.

FossilOrigin-Name: 0770470488e140fa21cb5097c26d58e21da85544af8b69faced1670bbc6d6089
 2021-03-23 16:34:13 +00:00
drh
46bee2aa12 Tweaks to test/scanstatus.test to account for the new EQP format. 
FossilOrigin-Name: 2eb28afd01f43143a9c0cd6cea68f3095f993952d54ee06b781514a7754490cd
 2021-03-23 15:39:02 +00:00
drh
06c7cc7694 Changes to test/analyzeG.test to conform to the new EXPLAIN QUERY PLAN syntax. 
FossilOrigin-Name: d8afde1bf1d41a349a161a293533a9fdf23ff23b8f1bcc323e79e806c5c526f1
 2021-03-23 15:07:17 +00:00
drh
695c83ac0e Fix a test case in bigmmap.test so that it works with the new 
EXPLAIN QUERY PLAN output format.

FossilOrigin-Name: 9ac064fe2aee4aa1423e7c8043dfec52ecf2af3e8361ebb7d9c104cca82b4d23
 2021-03-23 14:33:35 +00:00
drh
50e43c5094 Add the ExprList.nAlloc column and use it to make the sqlite3ExprListAppend() 
routine much faster.

FossilOrigin-Name: 1d3c4662c2f522ac695d97441324069f3fc65f3fa0b87194c7094dfb8cd549f2
 2021-03-23 14:27:35 +00:00
drh
a7fc252b0a Enhance the EXPLAIN QUERY PLAN output to use symbolic names to describe 
subqueries, where possible, instead of cryptic subquery index numbers.
And in other ways, make the EQP output cleaner and easier to read.  Little
code is changed, but many of the test results had to be tweaked to align
with the new output format.

FossilOrigin-Name: f8e28308fdb45fbdef30003320d653410d69bb8ec92eef35c4245a99e2d0603b
 2021-03-23 01:06:02 +00:00
drh
e3e8f5ce9c Merge recent fixes from trunk. 
FossilOrigin-Name: 4a343698b4ec3364b0eecb7fa074512ecac8b586aff1f977ca77f215e96e0ce5
 2021-03-22 18:53:26 +00:00
drh
f93ff6b9f4 Increase the version number to 3.36.0 to begin the next development cycle. 
FossilOrigin-Name: 5cee689d647087a5e796da2acb247a4f469a8b39b54f59bb4ad2386647cef1bd
 2021-03-22 16:50:39 +00:00
drh
d01206ffc2 Fix an assert() that in preupdate-hook logic (not normally built) that 
can be false when running VACUUM on a corrupt database file under
PRAGMA writable_schema=ON.

FossilOrigin-Name: 6bb2134027a12801de8e0c73482d94682f902024800a7e426614f65a2fe4f64c
 2021-03-21 18:23:48 +00:00
drh
97060e5aa2 Add a better comment and an assert() on the code inside sqlite3CreateIndex() 
that REPLACE indexes come at the end of the index list.
[forum:/forumpost/ceb51d83f7|forum post ceb51d83f7]

FossilOrigin-Name: 71e4da136bd1b5b75a699d69fbaaaec0f9dd1a87e2a9d049a55154892b06647b
 2021-03-21 17:52:47 +00:00
drh
01a8ad231a Fix the "box" output mode in the shell when statement returns zero-column 
rows (for example from "PRAGMA incremental_vacuum").

FossilOrigin-Name: 34439fe3aeea7cbbc817245d39c345a7f5df7a82ac15ee4d71bb9a4d818198ed
 2021-03-20 23:15:52 +00:00
drh
2f2091b10e Use the canonical name, not the AS name, when showing the MATERIALIZE or 
CO-ROUTINE lines for a CTE.

FossilOrigin-Name: 1b83e232c490fe6e9f999d30399faebfac6094bf940dc21dc459ed2c97657cb2
 2021-03-20 15:46:01 +00:00
drh
8210233c7b Revise tests cases to align with the new EXPLAIN QUERY PLAN output. 
FossilOrigin-Name: 50fbd532602d2c316813046ed6be8be2991c281eb5f295c4c28520a0de73862c
 2021-03-20 15:11:29 +00:00
drh
3c48ee9e0e Fix a faulty assert() in the OP_SkipScan opcode. 
dbsqlfuzz a15a9b2ca82e812ad52f62c86cc93dca0dc72f01.
Test cases in TH3.

FossilOrigin-Name: 1805b9aaf1172e36e08271f78ebb7676bba9f3c4c28e077ee94cc31b8e7ec741
 2021-03-20 01:00:26 +00:00
drh
6610e6a54f Further simplification of the EQP output. Only show "SUBQUERY n" if the 
subquery is anonymous.

FossilOrigin-Name: 1fadd30525dbf22678ba014b78af3a0fb33047692f073b7c62a90a028081ac48
 2021-03-19 19:44:56 +00:00
drh
d218decec5 Merge enhancements from trunk. 
FossilOrigin-Name: d192d737755876293a2914fcb9a0d5efbe07f3cd281c038666ea5aa879c06321
 2021-03-19 19:09:24 +00:00
drh
49e6e5a04f In the wholenumber virtual table, increase the cost penalty for running 
open-loop.  This appears to fix the problem reported by
[https://sqlite.org/forum/forumpost/b52a020ce4|forum post b52a020ce4].

FossilOrigin-Name: f12b54042e27b2fe99f23f97c103ee4371f8d4df3b049d9bb5d64891db56eee5
 2021-03-19 17:54:43 +00:00
drh
340fd0bc23 Dbsqlfuzz found a new way to make that branch in codeVectorCompare 
reachable.

FossilOrigin-Name: 959272c27555e39f180d46257afe45d41da1f5df38ea269196c06741ff6a278e
 2021-03-19 16:29:40 +00:00
larrybr
4cf34a5e73 Fix tokenizer's classification of EBCDIC newline. 
FossilOrigin-Name: 8680f6a8fb34b9c0ea9b4286888b4df5df427d2df10c782d198bc3f2fdcd0704
 2021-03-19 15:02:59 +00:00
drh
66f9655599 Restore the NEVER() that was taken out by [f481636f1a0333c6] because that 
case is no longer reachable after the previous check-in.

FossilOrigin-Name: e3a78b2a237a2e101faf01dde913f63641da8854720a9daa4b45a9c5dfe30b1b
 2021-03-19 14:51:15 +00:00
dan
93eb906488 Fix a crash that could occur when an INSERT has more than one ON CONFLICT clause, at least one of which contains an unresolvable symbol. 
FossilOrigin-Name: 74208386508012326a0e88ec5b4a995d1b99607720bb05785a01c2d89ea03543
 2021-03-19 14:26:24 +00:00
drh
d685dd6be6 Correlated CTEs should not generate a materialization subroutine. If they 
need to be materialized, each use case must be materialized separately.
dbsqlfuzz 01b8355086998f0a452cb31208e80b9d29ca739a.

FossilOrigin-Name: d72d865d3e8503a545603038eb26044bee42e4e8725522be678059ce6517fc8d
 2021-03-19 13:53:34 +00:00
drh
a979993b25 Improved labeling of EXPLAIN QUERY PLAN output. Many test failures due to 
the different output format.

FossilOrigin-Name: 6f8faec0222a7ca07cc1a5ed16cc08d92c6e20bbcb34851b4eff9e624de53601
 2021-03-19 13:00:28 +00:00
drh
080fe6dec9 Add a NEVER() on a branch that was made unreachable by the 
"circular reference" fix.

FossilOrigin-Name: 114d9780aecdd9f03f235fc1f2ab81ef89cb00b3bafa61cff612e939595ff5f0
 2021-03-18 20:04:46 +00:00
drh
f09a1794d8 Disable a test case requiring generate_series when virtual tables are not 
available.

FossilOrigin-Name: ee86e2f4c5999a090a5d2fe8251107cf55e621a6b988f315eb82f462cc1e377d
 2021-03-18 18:27:37 +00:00
dan
ca237a8b7b Fix a problem causing spurious "<cte>: circular reference" errors to be reported when there is actually a different error in the SQL statement. 
FossilOrigin-Name: 9981223618782bf867dfc8988d0c634a42f569228880c5c5e00aa4ae762cfff2
 2021-03-18 18:25:43 +00:00
drh
42d2aec1e9 Increase the patch level to 3.35.3. 
FossilOrigin-Name: 259b7c3e219873f3f679b00d3a89ecdac8a02c3472176d3a260f399e1faf3611
 2021-03-18 16:52:06 +00:00
drh
8d81aac13f Fix the OP_OpenDup opcode so that it is able to duplicate a cursor that 
was itself opened by OP_OpenDup.  Add additional verification of
ephemeral tables.  Fix for ticket [bb8a9fd4a9b7fce5].

FossilOrigin-Name: bcbe5308f3a3b94f965b0f5627cb29cce2e09343b86d757e2de889f7773576e7
 2021-03-18 16:47:24 +00:00
drh
76f7b16f1e Remove unnecessary code from sqlite3BtreeClose() and add test cases. 
FossilOrigin-Name: edbfdcaefae1e9a42c046c058341bf5b0f533c0b0cbd39543fcaa2a83d67561d
 2021-03-18 16:36:31 +00:00
drh
5a4a15fd2e Further sanity checking of the OpenDup cursors. 
FossilOrigin-Name: 0ec71cf16983697f68ab8d921d80a5f39611e4cb5e6e19cbc4a9ad6d49bfc835
 2021-03-18 15:42:59 +00:00
drh
8df014979e Fix the dbsqlfuzz-derived authorizer in fuzzcheck to avoid creating junk 
files when running rogue tests.

FossilOrigin-Name: eca21a620630b0c8d21a91ad6a8760a6c87270ab2a45cafa18bd31b305c53dba
 2021-03-18 14:36:19 +00:00
dan
eeee8a5f01 Automatically close ephemeral b-trees when their last cursor is closed. 
FossilOrigin-Name: 39b5af18c0580c8e92516d410f8c465bfec31b2d0be9df1cfd6a1d1a19b4fc14
 2021-03-18 14:31:37 +00:00
drh
8e7c82ca3f Fix a problem with the filename normalizer in unix, discovered by dbsqlfuzz. 
FossilOrigin-Name: ff1eca7fcdcbc550a5f23db9d85281e5373500912699a7c7ae54bc0df0547e26
 2021-03-18 13:55:25 +00:00
dan
918232aadb Allow instruction OP_OpenDup to duplicate cursors created by OP_OpenDup, as well as by OP_OpenEphemeral. 
FossilOrigin-Name: b8de980b2fb78088ef74e053cb987bb84319d13dc96ce1e89baaaa3fe8cf1efc
 2021-03-18 13:42:53 +00:00
drh
e44ac3858c New assert statements associated with Ephemeral cursors in the bytecode engine. 
FossilOrigin-Name: a8ce73e2573b271d5d45838802ed1905ce5e18d5fafe0078700e79fab85457e2
 2021-03-18 13:19:41 +00:00
drh
2b994ce5d3 Change the name of the iDataVersion field of Btree to iBDataVersion to make 
it distinct from Pager.iDataVersion.

FossilOrigin-Name: e4c44c0bca317c03f8e6d3aa7cc88e5f96159a3d91c07257d408f7db028fd151
 2021-03-18 12:36:09 +00:00
drh
176b04c476 Version 3.35.2 
FossilOrigin-Name: ea80f3002f4120f5dcee76e8779dfdc88e1e096c5cdd06904c20fd26d50c3827
 2021-03-17 19:07:21 +00:00
drh
8b04094c4f Fix a harmless compiler warning in the appendvfs.c extension. 
FossilOrigin-Name: 0ed7eb9115510511f13dca715bb2b178580648517d8d30436a992d70a2e85ac1
 2021-03-17 19:05:59 +00:00
dan
51ddfef74d If there are already 500 or more simple SELECTs in a query, do not add more by flattening UNION ALL sub-queries into parent join queries. 
FossilOrigin-Name: 9520bed2bd87dc56543ee58123323d293e960ecd84707b77f15f41669a2c9c3d
 2021-03-17 14:29:37 +00:00
dan
42470513b7 Fix a problem in sqldiff virtual table hanlding to do with tab and other non-space whitespace characters in the CREATE VIRTUAL TABLE statement. 
FossilOrigin-Name: 1737e4fdfc9a3628415b234338a68a64cbbaadb23598517761e571ab7ed7ad14
 2021-03-17 11:25:42 +00:00
drh
a7d8d4a07a Date/time functions with no arguments (ex: date() or time()) should be 
non-deterministic.  Fix for ticket [2c6c8689fb5f3d2f].

FossilOrigin-Name: 1734c332e7f609769fc30f82cf7af097c2964e08900ee3e297f6a25e6df60555
 2021-03-16 18:41:20 +00:00
dan
1fffa73ea2 Add tests for sqlite_rename_quotefix(). Fix a memory leak in the same. 
FossilOrigin-Name: 531550056c38589c99c9a97b6afdbf8f34ff8d2131d74e9d42af3506e8045064
 2021-03-16 18:24:49 +00:00