mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
24,178 Commits 1,487 Branches 166 Tags 416 MiB
d59ac28d4f
Commit Graph

24178 Commits

Author SHA1 Message Date
dan
07fd1bf323 Fix problem with SQLITE_OMIT_VIRTUALTABLE builds. 
FossilOrigin-Name: a99ee612b9bd6d75b63e557ef5bdac2143425a558cf023a0480cc28c8300a9a8
 2022-04-28 18:33:02 +00:00
drh
a087eb8f6d In treeview.c, show the columns of the table associated with each SrcItem. 
FossilOrigin-Name: 3aafccb5c3c780c29090ee5eb428a6c3153627ce8bf834bbd392e79a30e9389b
 2022-04-28 18:17:51 +00:00
drh
4bea8c6b56 Tweaks to the name resolution on parenthesized joins. A small number of 
tests fail now due to extra columns appearing in the expansion of "*".

FossilOrigin-Name: c86804917e3fffcf0c19bbf11875667f7968275210fc768e650826bd9c87a5d2
 2022-04-28 17:35:58 +00:00
drh
09121b0523 Merge trunk enhancements into the right-join branch. 
FossilOrigin-Name: 3fd9706bba4a71cb5c7ce1341c3be0a7727941445820a073e7b2f0f32512e8ef
 2022-04-28 12:52:49 +00:00
drh
22b541b55a Fix a harmless typo in a comment. 
FossilOrigin-Name: e1f4a115df34e45cf1bcf98961c699b582f564a58a979e95853b219bda06212c
 2022-04-27 18:38:46 +00:00
drh
609959285b When computing STAT1 values using ANALYZE, if a ratio comes out to be between 
1.0 and 1.1, then round it down to 1 rather than the using the default rounding
rule of changing it to 2.  The reduces the estimation error for the
case where a column value is very nearly, but not quite unique.

FossilOrigin-Name: eb59c46a5aed69bc6fd096997bf24c082e533c1085439f6ec1fbe5ff78e8b374
 2022-04-27 16:41:56 +00:00
dan
9684d71081 Fix a test problem in rbubusy.test causing a crash under some circumstances. 
FossilOrigin-Name: bc5bbd9fa636cc9ef0cbbc0600b8fc1404b9732670ac4e7a8b5a230fbce758d5
 2022-04-27 13:33:48 +00:00
dan
5487cdcc0a Update corruptL.test so that it works with SQLITE_ENABLE_OVERSIZE_CELL_CHECK builds. 
FossilOrigin-Name: b1bec72043f798f4d4d30e6b60a45ed4dc521115c8a9f97bb8228e3f089deefb
 2022-04-26 19:16:11 +00:00
drh
3e4314b4f8 Fix a problem with automatic indexes introduced by 
check-in [664b461bb5063d980] and reported by
[forum:/forumpost/0d3200f4f3bcd3a3|forum post 0d3200f4f3bcd3a3].

FossilOrigin-Name: 134cfb18ff930e4bccc1a7412a02be353bf67c6d5080bc0673afaac81afa889c
 2022-04-25 20:56:55 +00:00
drh
0e464b5f51 Do not allow the push-down optimization on the right table of a RIGHT JOIN. 
FossilOrigin-Name: 05917bfa02a7b6678c147d10fb53f55532ab15fd5d82d925ae921ae3759f0115
 2022-04-25 20:47:58 +00:00
drh
5eb6e09795 The pushDownWhereTerms() routine should be using 
sqlite3ExprIsTableConstraint(), not sqlite3ExprIsTableConstant().  This fixes
many problems, but still an error persists in join7.test.

FossilOrigin-Name: 10bf0e613809f71cc1a47ad40b517e2a66671212a6464e179c9d377e8b70d499
 2022-04-25 20:38:42 +00:00
drh
a9cdb90421 Fix a problem with automatic indexes introduced by 
check-in [664b461bb5063d980] and reported by
[forum:/forumpost/0d3200f4f3bcd3a3|forum post 0d3200f4f3bcd3a3].

FossilOrigin-Name: 7ca3456c00998a429418ff29cf251b381586b330b88344c94a40c5df0b71da85
 2022-04-25 19:40:33 +00:00
drh
95fe38f2fc Add a new optimizer disabling bit to disable just the UNION ALL branch of the 
query flattener.

FossilOrigin-Name: c0f9ebab5455d8541a562122d3270b95ce571c3fd870b0048dda2b036c2b66c0
 2022-04-25 14:59:59 +00:00
drh
7f417569f7 Avoid unintended side-effects on Parse.nSelect in the 
sqlite3ViewGetColumnNames() routine.

FossilOrigin-Name: 59789fe1e745bb6f81898176e7e9c6064ac9f4bbefb4dc3c8f3e4c1379568f69
 2022-04-25 14:49:48 +00:00
drh
1a6bac0d2f Remove NEVER() on branches formerly thought to unreachable 
(see check-in [71272caff5874137]) in order to fix the first bug reported
by [forum:/forumpost/28821db852|forum post 28821db852].

FossilOrigin-Name: bd6811d8110d5f00596e2eff6d4b02af8b6d8557d41990e6f50518ead0fa01fb
 2022-04-25 10:43:19 +00:00
drh
7980fadcef Merge enhancements and fixes from trunk into the right-join branch. 
FossilOrigin-Name: 2fb165cf8bd1e43248612aa2922bd311df30dcbb3c2f1daee73c363e409c501f
 2022-04-23 19:26:34 +00:00
drh
ecb386b71f Prevent the ORDER BY LIMIT optimization from running if the innermost loop 
is a right-join, as doing so will get an incorrect answer.

FossilOrigin-Name: 3aefc874d31885c64a5e02868edb2aa56a2b4429252d494e67e4088a9298ce5b
 2022-04-23 19:21:47 +00:00
drh
30d2aab5fd In debug builds, add extra code to verify that there are no jumps that try to 
escape from the right-join body subroutine.

FossilOrigin-Name: 45fe919266ba1843f3eeeb511ab43126069d4976c9fc64e57e0390c21f110b6e
 2022-04-23 18:46:03 +00:00
drh
6c7e89b48a Fix false-positives in sqlite3VdbeNoJumpsOutsideSubrtn(). All tests pass now. 
FossilOrigin-Name: 1300d978d5a072780e0f16722e42461dc983de9b4dfb2f5a7023c74c92ab9bc8
 2022-04-23 18:34:55 +00:00
drh
b77c312956 For debug builds, if the RIGHT JOIN body subroutine contains a jump that 
escapes the subroutine, then abort the prepared statement with a descriptive
error and SQLITE_INTERNAL.  This extra sanity check causes many tests to
fail.

FossilOrigin-Name: 2c5bb2bff26cc70d8cac78ddd12d5ac37ab1472f5f88afbd975950a18ac2804d
 2022-04-23 18:04:31 +00:00
drh
d63c07e6c5 Fix an operator typo - This indicates that the branch needs further 
investigation and verification.

FossilOrigin-Name: f6ab67965b718b0c6d7faf769c7e47384cfd2ddbb03df518e0c5d367f8583387
 2022-04-23 14:30:22 +00:00
drh
0748e8bf9a Correctly resolve left and right USING columns of an outer join in a 
parenthesized subjoin.

FossilOrigin-Name: ea91aba88c31a042f4e32d66dfa089f95d0f9d316ab26f298085eb34dbf73e86
 2022-04-23 07:31:50 +00:00
drh
ab843a51d3 Fix minor problems with the new join table name resolution logic. 
FossilOrigin-Name: 3a6b0db4519072dbd41b1c105bf1a0c6b4dd90380e94a5662645d8d41483c707
 2022-04-23 07:29:34 +00:00
drh
45e41b7371 Add the ability to access the USING columns of the right or left tables 
of an OUTER JOIN even if the OUTER JOIN is in parentheses.  Prototype code
only.

FossilOrigin-Name: c3a427575fe71de3061495059e253c72c7213e2925ee2873e4f59fc73bfae103
 2022-04-22 23:18:21 +00:00
drh
f054c34372 Merge the latest enhancements and fixes from trunk onto the right-join branch. 
FossilOrigin-Name: 7f8983345d1e3ac28d736fce9f90772aa0e4654670a1db3dd0ee45b55e92f2e4
 2022-04-22 19:52:51 +00:00
drh
d6bb6000ef Make use of the "%!S" format when running ExplainSubquery. 
FossilOrigin-Name: 9425d79cb407dedc259655625369e023d22a04ef7db606ea3eefe7e4d662be1a
 2022-04-22 18:07:38 +00:00
drh
da653b897d Improve EXPLAIN QUERY PLAN output and comments on bytecode listings by 
distinguishing between "subquery" and "join" and using consistent names
across EQP and bytecode.

FossilOrigin-Name: a2d3ee92420ec564e31eb0005367cf7ff3d00bfaed5a98ffdbe17c91c95d9d97
 2022-04-22 17:36:10 +00:00
drh
67f70bea06 Honor the MATERIALIZED keyword on a common table expression by not flattening 
the CTE into an outer query.

FossilOrigin-Name: 8d631a6b9eb06b54b10eda595a4c588ca38f909b4afa653b24d1f720b55d72f7
 2022-04-22 16:15:48 +00:00
dan
9b843f0ce0 Add test cases to check the handling of SQLITE_BUSY in rbu. 
FossilOrigin-Name: 6fccc733c6041a2946fb3d37e4737ae37defae5c110225dd746cdc038cc64957
 2022-04-22 15:18:41 +00:00
drh
1ca14b74ed Simplification of data structures in the wildcard expander for 
SF_NestedFrom queries.

FossilOrigin-Name: f7c18262347ff430879d5afc7a118d2b9b0050c845c6b1fe6c047062ea2ba8fe
 2022-04-22 13:34:45 +00:00
drh
9c2d7aa7d0 Minor simplification to the result-set wildcard expander for SF_NestedFrom. 
FossilOrigin-Name: d942530a6550a0cbe31790e462b0f0d57b9b4a896161878b7d45d11cbc1cb7a3
 2022-04-22 12:46:46 +00:00
drh
8318b55d87 Merge the latest trunk fixes into the right-join branch. 
FossilOrigin-Name: c74dc574c3b24a7d3533202f33b15341b043cfd89a80250563e6771ab6b6b8a7
 2022-04-22 09:57:57 +00:00
drh
1c69bc912d Previous fix to join8.test needs a return. 
FossilOrigin-Name: 7b4cd705a0339ddacad19564b07e50e4f68f54bf14dd2cd5d59b39314a4d2523
 2022-04-21 23:34:35 +00:00
drh
abb4e7598c Disable join8.test if the build lacks support for virtual tables. 
FossilOrigin-Name: 94e1916a2f594e6b8a54734027deb99688244d05cefb3c78f23afab49af1e08f
 2022-04-21 23:01:24 +00:00
drh
11140addbb Add support for RIGHT and FULL JOIN. 
FossilOrigin-Name: f766dff012af0ea3c28a8ce4db850cd0205729a8283bce1e442992aded7c734b
 2022-04-21 19:38:17 +00:00
drh
6dab33bf40 Fix harmless compiler warnings. 
FossilOrigin-Name: 29255664127a975e5b0d5767cd4e56d93ff2ea1994702cdfbdca1b700952502e
 2022-04-21 19:25:51 +00:00
drh
a74b4c4d45 Fix a harmless uninitialized variable warning in MSVC. 
FossilOrigin-Name: b870d2a2fa54ddab6ffc9b9d95f52420a5a6831aeb73dac75355ca1ab15a190e
 2022-04-21 19:20:38 +00:00
drh
7e9a56f70f Fix harmless compiler warnings in the CLI. 
FossilOrigin-Name: dfd2100bc4f316825fd199b347849d1a2b941837f9eedcf36f3c3d280692b991
 2022-04-21 19:14:23 +00:00
drh
503ad9c72d Make sure the code generator knows to invoke row-value subroutines which 
running the right-join post-processing loop.

FossilOrigin-Name: fd328e52aee1dace12b1c2f44b6f7e9d15d8f77c8e9d9e3d85840a129a4b1808
 2022-04-21 14:48:40 +00:00
drh
825a6bffc4 Ensure correct fg.isNestedFrom values even on crazy parses. 
FossilOrigin-Name: e611e8e62c948d28cd3f28452d3096bab06998a685ed9434061cc2054f5cac32
 2022-04-21 14:08:29 +00:00
drh
18f8600fe6 Avoid materializing columns of SF_NestedFrom subqueries that are never used. 
Other code improvements manually imported from the right-join-paren branch.

FossilOrigin-Name: cd8272fc2a34d1b245fd95208b9b601266ee7d2ff0f5ce52d03752f2c4e852a2
 2022-04-21 13:11:26 +00:00
larrybr
6403e77d3b For CLI, fix how columnar mode fills in empty portions of wrapped row outputs. 
FossilOrigin-Name: 77aed89192bdbad819ac17bf5d08728278a9b8cbbbef1d805df230caff79b417
 2022-04-20 22:41:10 +00:00
drh
22b410d894 Small correction to the new bUsed logic of sqlite3ProcessJoin(). 
FossilOrigin-Name: ba04142e09bb1ccc86824760a2e11df47e070285a2d09c2f61b75255886597cd
 2022-04-20 18:12:42 +00:00
drh
e60ffa3350 Merge window function fix from trunk. 
FossilOrigin-Name: b6b9e185f8c44b5f2f51111f7c5e4e2d77c8b853c5be271467ce138e8066340c
 2022-04-20 16:54:47 +00:00
drh
910e57b9df Remove an unnecessary assignment operation. 
FossilOrigin-Name: ed46527aca170ccbe9ed9ea4ae065db72c82dec17da7b99c928fae4495f05c2b
 2022-04-20 16:53:23 +00:00
dan
41150bf35b Fix a problem with using multiple SQLITE_SUBTYPE function as window functions in a single query. 
FossilOrigin-Name: 9430ead7ba433cbfce99f4f364a0c08499230e3a04f167326b0f131f098ffa09
 2022-04-20 16:42:57 +00:00
drh
bc656e220f Comment fixes and improvements in sqlite3ProcessJoin(). 
FossilOrigin-Name: 1118655f4d58da1273e83954c80d8bc17fa3bde7a39e81cb9947d59894d5ab93
 2022-04-20 16:26:22 +00:00
drh
815b782e99 Improved tracking of nested SELECT objects used to implement 
parenthensized FROM terms.

FossilOrigin-Name: 0da2232624571f4020c05d775ea518514d748fba8dacd4caba2e2e6ed1ae399f
 2022-04-20 15:07:39 +00:00
drh
b465a83353 Also show the ENAME_SPAN value in sqlite3TreeViewExprList(), if there is one. 
FossilOrigin-Name: c1d42861778d65f7014c43fbaf09972a69ff0d81bfc2f4720160a989489cf2c8
 2022-04-20 12:15:51 +00:00
drh
d4e9caf987 Improved TreeView output for ExprList: Show the ENAME_TAB value, if there 
is one.

FossilOrigin-Name: eb3f883b45f1bf3f388823360f4aec2d4b8776bfd96185b4fb44b7bc95c62318
 2022-04-20 12:14:20 +00:00
drh
2627cbd4b5 Add a new comment to the body of lookupName(). No code changes. 
FossilOrigin-Name: 22fa9b9b450fbbf7578597714eb1094f7d7433ac13497dc7d4a9affc4a2652ad
 2022-04-20 12:02:52 +00:00
drh
befbb40f44 Merge the ALTER TABLE fix from trunk. 
FossilOrigin-Name: d5ceaef3fca8cb4791ead9cbfe00d0eafa1bdc2b0522c3599c68b40fe6a7efe2
 2022-04-19 23:00:32 +00:00
dan
cbde37d8e4 Fix a problem in ALTER TABLE with handling "table.*" expressions within SELECT statements in triggers. 
FossilOrigin-Name: 24755fd0657252e49793bb1fe906973a2dd84a1bde03bea9a762de36cc96c2d2
 2022-04-19 20:47:18 +00:00
drh
4d0d071a53 Improved comment on the JF_LTORJ constant definition. 
FossilOrigin-Name: e0744da95fc010dc3a2e030ff491bcfa08a18691ee6ebc7d4e8aab3850f56eec
 2022-04-19 19:51:51 +00:00
drh
3117b7b081 Fix a NULL-pointer dereference that can occur on an aggregate query that 
uses FULL JOIN.  dbsqlfuzz 496a35dd4eefcd7935aaaeb0c69056bf49785d28.

FossilOrigin-Name: 63b8f8aec2a9ac3fbbd02715aa308eaf43c9ffde9d7c6db026d46edc575e7bdd
 2022-04-19 18:23:01 +00:00
drh
e32d6a0bbf Mark an unreachable "just-in-case" branch as unreachable. 
FossilOrigin-Name: b966d52437f08a6759a83a45cafb0d706a8933a8e55dee38ae78166d1a5b3ba4
 2022-04-19 15:56:03 +00:00
drh
de75638b33 Add 512 new join test cases derived from PostgreSQL output. 
FossilOrigin-Name: 78d58e461f99366d2749ccd6d02ab4cba0cab20bb80c097e7128da1e50303549
 2022-04-19 15:01:57 +00:00
drh
2e61588931 Remove unnecessary cases for the resolver. 
FossilOrigin-Name: 5bc9aa68e2f938f6a70dd4b08703fe52416d17efe461ec65d37332b57b827fdd
 2022-04-19 09:39:39 +00:00
drh
d737b16f92 Add the omitted "finish_test" to the end of joinA.test. 
FossilOrigin-Name: 0907505cc9bb051280108fe5074211374b31836fae1ae6667a3de69f9d83fc01
 2022-04-19 02:03:18 +00:00
drh
3b8c7545df New test cases for RIGHT and FULL JOIN. 
FossilOrigin-Name: 5c2f670e0fb35648e1d6e1c48f4d8af815cd57d59eac6ba22e253511bb078870
 2022-04-19 00:24:52 +00:00
drh
1c2bf41a12 Fix the query flattener so that it does not flatten a RIGHT or FULL JOIN into 
any position of the outer query other than the first.

FossilOrigin-Name: 837322aa95b1c46201b7dd0c2e6c7b9915b4276d997949f1ecf961fb7f3514cf
 2022-04-18 23:20:02 +00:00
drh
ec39c96473 New test cases, including one that gets a different result than Postgres. 
FossilOrigin-Name: 49ea11a4a5fd630db44f458304d4f45fa103529ed6b36d538c78074965e8d799
 2022-04-18 22:51:24 +00:00
drh
f80bb195b3 Disable the unused EU4_EXPR mode for the IdList object. 
FossilOrigin-Name: 5bcf4aa3bf6b1b9f47142bc37683bb3bf0adeffd052d07449af7c9b415add052
 2022-04-18 19:48:31 +00:00
drh
7466d5665a Even more test cases. 
FossilOrigin-Name: 5f4310a104443ac3fc56f9d9cd2d428dd3e7a2a0285c8e74de6f499439fd6868
 2022-04-18 19:34:41 +00:00
drh
23f240b325 New test cases for parenthesized NATURAL FULL JOINs. 
FossilOrigin-Name: e34250efd34b526373bf072a43a7984ca19690836d7d2464dea8338066eaee8f
 2022-04-18 19:28:08 +00:00
drh
a20922cb20 New test case demonstrating the ability to invoke OP_NullRow on a cursor 
that has never been opened.

FossilOrigin-Name: d173edc242f295f5812a58cad184695881d9b1b160cd5b25e303e22848e90ce1
 2022-04-18 18:01:38 +00:00
drh
25f2ce6e71 Merge the btree bug-fix from trunk. 
FossilOrigin-Name: a333c0b50c3af7cd818470a647d78c7c691ef15418ec7cffe80dd88405393069
 2022-04-18 16:23:01 +00:00
drh
7348ca4e0b Ensure that left-hand side WITHOUT ROWID tables are set to OP_NullRow prior 
to running the right-join loop.  This fixes a problem introduced by the
previous check-in.

FossilOrigin-Name: aab7665ce6c004df701a72aef1a5135f2c78f16c6ff728a00076afb66ba9d3a0
 2022-04-18 16:20:59 +00:00
drh
2e1bcc9dd0 Fix problems with WHERE clauses that follow multiple FULL JOINs. This 
introduces some new faults in the tests, probably due to something
unrelated.

FossilOrigin-Name: 95b242d4c2fed7c713299565ac1010f8a7534a5695589e87d5a0204c7bf5f3dc
 2022-04-18 16:10:07 +00:00
dan
1942d1f236 Avoid an assert() failure in allocateSpace() triggered by a corrupt database. dbsqlfuzz f022eb0ce64d27808574d1dcde5cf7d002dabde8. 
FossilOrigin-Name: 2de7f8cc7fe18f0828bb53f1fd11f5eb828faf4d6dfaf39693dff4f8926c1c7a
 2022-04-18 15:56:58 +00:00
drh
41db500274 Merge the latest fixes from trunk. 
FossilOrigin-Name: 1ba3b3ccf145d84fa75afabe2fa925f65e43f815b25b15bd60073a41aa97bf57
 2022-04-18 14:41:24 +00:00
drh
e98b71e65d Improved comment field in the bytecode generated for OP_Column and OP_Rowid. 
FossilOrigin-Name: 1b2c5cef9560123344db391cd065090d1914724715ec6643d2d9b5fac2051a21
 2022-04-18 14:15:07 +00:00
drh
088b615acd Improved comment field in the bytecode generated for OP_Column and OP_Rowid. 
FossilOrigin-Name: 009bbf8026106c5a74cced06cced48badb870a4b6e6a2f8104a544d2a8d79e45
 2022-04-18 13:57:57 +00:00
drh
01a6c16e0c New RIGHT JOIN test cases, one of which is currently failing. 
FossilOrigin-Name: 9168cbbedd1c9d735279295a78212d830e24269f6d7e445e71faa2c06973223d
 2022-04-18 13:08:17 +00:00
drh
a1848a5d22 Change the row-value initialization subroutine call from within the 
right-join body subroutine from an issue to an optimization opportunity.

FossilOrigin-Name: 829d49f27c041651ffeadc1397e4dd87a9994c9290e13b93542dbd2c514769cd
 2022-04-18 11:22:46 +00:00
drh
d875c7eefe Do not allow an empty table bypass to jump outside of a right-join body 
subroutine.

FossilOrigin-Name: 1549dcd2353903b70abadd428eeef971ab940df04fb05a6b83b04ee30932db6d
 2022-04-18 10:26:50 +00:00
drh
d973268ccf Fix the sqlite3SrcListAppendList() routine so that it correctly adds 
the JT_LTORJ attribute to the first SrcItem, if needed.

FossilOrigin-Name: 07ed0dca310d828f9fe152efa8ee2a89202771a8f661afa1dbeee34aaabef67a
 2022-04-18 10:09:29 +00:00
drh
abf86bd313 Leave sqlite3ProcessJoin() early if an OOM is encountered in the NATURAL 
to USING converter.  This avoids NULL pointer dereferences further along in
the code.

FossilOrigin-Name: 0ccb224e13ad44c7e1a3aa186821a929faabc0075fe15799476c00d9a92e9d91
 2022-04-18 09:59:33 +00:00
drh
79a25ee021 Fix to the coalesce() function generation in the resolver. 
FossilOrigin-Name: 584bd55e20669d09b7efe3429ba847c42c32fb1eb960784c4e0dedcd96899313
 2022-04-18 00:57:11 +00:00
drh
d0453f7ec5 When converting a NATURAL JOIN into a JOIN USING, make sure to insert the 
name correctly into the IdList even if it is a wierd quoted name.

FossilOrigin-Name: e62156b696f2496e2697cb3b46f136551b58644e2a5824aa3d759596694b2f4b
 2022-04-18 00:04:15 +00:00
drh
a3e2518bb3 Fix to the logic that computes coalesc() functions to resolve USING terms. 
FossilOrigin-Name: 20388548d868511f8c8437718985d75fe9801835811fec716f1700727b9aa367
 2022-04-17 23:46:18 +00:00
drh
f68621fe83 Deal with OP_Return bypass in the RIGHT JOIN subroutine by adding extra 
OP_Returns where needed.

FossilOrigin-Name: 71abe5641f599f27d1f0c800f6182e1168909f8aa99389b835b07d4b5f5483eb
 2022-04-17 22:58:23 +00:00
drh
2bd9f44a18 Change OP_Return such that if P3 is 1, the Return is a no-op when the 
P1 register contains a NULL.

FossilOrigin-Name: c90602328a4b26f06d76c5343d29ebb7a782186c86ea88f5965a41040cff5346
 2022-04-17 20:30:52 +00:00
drh
fe14699765 Further improvements to USING() processing for RIGHT and FULL JOINs. All 
currently known issues are now resolved.  Performace is improved.

FossilOrigin-Name: 9fd3f22e2228dfba127f6ffe549109f3a4e910fa124adcc9c5483931bd6d5cd7
 2022-04-17 18:46:17 +00:00
drh
6fda176ba6 New test cases, one of which is failing, indicating a bug that needs fixing. 
FossilOrigin-Name: bd5fd68435ff068c18d7d46b33cf7591263a03c32a917a7df7c087b08c573cc8
 2022-04-16 23:38:29 +00:00
drh
052953a4e6 Fix the USING to ON translation so that it works correctly for a sequence 
of two or more joins where one of the joins to the right-hand side of the
list is a RIGHT or FULL JOIN.

FossilOrigin-Name: 9ffc2b231956cde1bc90519aa174b0e2dc30ef671ed745f4f3ffa9fbb7ffab4b
 2022-04-16 22:57:41 +00:00
drh
fdc621aece Since the query planner is unable to cope with a LEFT JOIN on the left-hand side 
of a RIGHT JOIN, detect that situation early and raise a parsing error.
This is a temporary measure that needs to be fixed.

FossilOrigin-Name: 6d5d6e0403241c99ab4a47d7b6eedcd8ebc615a8ca8d66d7e81171f901b170d7
 2022-04-16 19:13:16 +00:00
drh
cebc8009ed Additional SELECT trace logic: Show the tree after result-set wildcard 
expansion but before name resolution.

FossilOrigin-Name: a7babf75418adffa27dec7a9d382a60e1b9364fb51d72b0a10e2769b308b3c54
 2022-04-16 18:33:22 +00:00
larrybr
2d27d36cba Make shell auto-column work with lots of columns when log() is missing. 
FossilOrigin-Name: 82366436ef74838dae1f379f3e5b8ad187225a30ec58fb49f047ab7c08a263cf
 2022-04-16 17:53:25 +00:00
dan
b192970809 Fix a problem with "ON DELETE RESTRICT" and "ON UPDATE RESTRICT" foreign keys in attached databases scanning child tables in the wrong schema. 
FossilOrigin-Name: 04d5b637f087520cd58211505f9b5c086ff96d864a1908f60464b6fe22c62b7d
 2022-04-16 15:46:23 +00:00
drh
977eef6cdc New test cases. One of the new test cases shows a flaw in the base design 
of RIGHT JOIN.

FossilOrigin-Name: 4c3ce6475a67b1e207a5b63d9e2d38ee5bc45c899ad00ee327f292bf59039b9c
 2022-04-16 13:55:48 +00:00
drh
bdbda1eb1f RIGHT JOIN USING now appears to work the same as PG-14. Legacy tests pass. 
FossilOrigin-Name: 5bfb862419541de955dae35fc91f6e9fc70e2744bb786d49fa26bede80b9091d
 2022-04-16 12:40:52 +00:00
drh
be60896485 Revamp the USING clause processing so that it works (mostly) with RIGHT 
and FULL JOIN.

FossilOrigin-Name: 719c8d920b435b0f234d47467a2abe2941ab7d55ecca886e211cfce577ae648c
 2022-04-15 19:53:35 +00:00
drh
e62d9149a6 Avoid deleting substructure of the Expr node in lookupName() until after 
the error message is generated.

FossilOrigin-Name: b8e717663957dfd84e580bf21bc8e8881b33fdb94a2cc0c664a230e54d5e5076
 2022-04-15 19:49:28 +00:00
drh
bb3c62a758 Progress toward a working USING for FULL JOIN. 
FossilOrigin-Name: fed2646adecb0a05dd674dc1cd2c0ae205078fe552ba93b8d68891c728c67637
 2022-04-15 19:27:02 +00:00
drh
4ce7bf9156 When expanding "*" in the result set of a SELECT, do not attach a table name 
to columns that are in subsequent USING clauses.

FossilOrigin-Name: 91530990e018580ec5322ace6f0c369a32a3529a0bfb4defb25ca20223a2a80f
 2022-04-15 18:30:48 +00:00
drh
22c4bc8991 The sqlite3ProcessJoin() routine converts a NATURAL JOIN into a JOIN USING so 
that henceforth the NATURAL keyword can be ignored.

FossilOrigin-Name: 8378e1e0d289627fb294ccd3f5865ef49df3a42b8a5aa211e21be1b42d9da753
 2022-04-15 17:08:40 +00:00
drh
a99e325468 Enhance the IdList object to exist in a single memory allocation (rather than 
a separate allocate for the base object and the array of IDs).  Also permit
an IdList object to store an Expr pointer together with each name.

FossilOrigin-Name: 40f3c95871e6f40f287ef2756abafb8fc56dffdd0af69436e5c7d8e95022d94e
 2022-04-15 15:47:14 +00:00
drh
358424aeff Add the "3" in the name of the sqlite3ProcessJoin() function. 
FossilOrigin-Name: b925f72b6f679c61b0d6be16fabe64dc7605550b7bd86f35c586dcecd8217673
 2022-04-15 15:15:01 +00:00
drh
a51379ad78 Record the three known big issues with the current RIGHT JOIN design in 
the join8 test module, with tests that deliberately fail in order to remind
us to fix the issues.

FossilOrigin-Name: 2c4ee723f4d0591d09776adfb82246bfa89153ab390b8b3f1878d1cdc43d68c8
 2022-04-14 20:43:22 +00:00
drh
b3ebf3043f Cherry pick subroutine indentation improvements and the hardening of 
OP_Gosub from the right-join branch back into trunk.

FossilOrigin-Name: 12645f100d902690630a2925674aedbb01d41a53426a26a2f56de5b8fdec955f
 2022-04-14 19:48:32 +00:00
drh
79f60034ee Another instance of indenting a subroutine. 
FossilOrigin-Name: 73f4036b04798660b30e540cbab69420078df9fb62a6a39944e078c36272f905
 2022-04-14 19:05:17 +00:00
drh
d549a702b3 Check for interrupts and invoke the progress handler following a Gosub 
opcode, to avoid and recover from infinite subroutine loops.

FossilOrigin-Name: 647211e044a5856ceb6bf3e7b78e650fe7d81f8b7bf34568b99b346405ba520c
 2022-04-14 18:19:06 +00:00
drh
2c31c00bfa Rerun the subroutines that compute row-values if necessary from within 
the RIGHT JOIN body subroutine.

FossilOrigin-Name: 9b9038bcd0ab5c4f01661456635526cef764f854ff24018a5e6e43825d07eb59
 2022-04-14 16:34:07 +00:00
drh
37f5584a2f Adjust the output formatting of bytecode listings so that subroutines used 
to implement subqueries are indented one level.

FossilOrigin-Name: 079b7b125206fb295720612f4853a5b786ec431ab595d35407195844779c149d
 2022-04-14 15:55:34 +00:00
drh
d345dcf39a Disable autoindexing for the RIGHT JOIN loop. 
FossilOrigin-Name: 402a89e33e39b00352dc9fb3301d03c6f75d8bb5c2ad540cd22506bff10b4d85
 2022-04-14 14:58:50 +00:00
drh
375f182b1d Adjust assert() statements to account for the new always-NULL cursor type 
added by [4526c5d316508093].

FossilOrigin-Name: 7822faa48a058c0b0313b9241d290153fbe74ab84f58369a70014118a9085d1d
 2022-04-14 14:40:29 +00:00
drh
c504f677b6 Previous check-in accidentally inverted a test on an assert(). Fix that. 
FossilOrigin-Name: 5ec4f806c569428851b6f0159451aa3ed66b3bc61a845fd7c543cffb694b882d
 2022-04-14 14:19:23 +00:00
drh
eab6c125bd Fix assert() statements associated with artifical null-value cursors 
created by RIGHT JOIN.

FossilOrigin-Name: f5bce5f152259767497ae6826c558003822d976b3f35f4d74edee59a3490efb2
 2022-04-14 12:59:25 +00:00
drh
95b1036e9a Fix a harmless (false-positive) unused variable compiler warning on MSVC. 
FossilOrigin-Name: 63b04c63de680261a0d3eaf27154a1e8e77e3e166c3f2dbaea985603991c74f7
 2022-04-13 19:00:57 +00:00
drh
b60d1fbe8e Make the sqlite3TreeViewSrcList() routine a no-op if called with a 
NULL SrcList object.

FossilOrigin-Name: 185d2720e7775e3060a1647353c10aada435244db53a0732ee786788a6ecae3f
 2022-04-13 18:32:04 +00:00
drh
7c96039492 Fix an assert() in OP_Column so that it accounts for the new type of 
pseudo-cursor that always returns NULL for any column.

FossilOrigin-Name: 371ddc97bef8e0d88ad965f00d27e010880174312ea36c4f1165dcf08441f40a
 2022-04-13 18:20:23 +00:00
drh
3ac624344d If the OP_NullRow opcode is given a cursor that has not yet been opened, 
then go automatically open it to a special pseudo-cursor that allows returns
NULL for every column.  Used by the new RIGHT JOIN implementation.

FossilOrigin-Name: 4526c5d316508093b7f3aeda1ce9d16ceb0be79842015a6d51f28c22b4473ca2
 2022-04-13 17:41:03 +00:00
drh
f7ecd956ce Move the explain comment for the RIGHT-JOIN post-processing loop to the 
verify beginning of the loop - to make the start of the loop clearer to
human bytecode readers.

FossilOrigin-Name: 7ed2a271e6fcbb5e69a7f3a88d3f45fe6318819c0cc6a0dcc06c3dae5aa1503f
 2022-04-13 16:46:35 +00:00
drh
94e615a6ac Add support for RIGHT and FULL OUTER JOINs. 
FossilOrigin-Name: fa9d206f904280e3eafc6f4ba6c0c7325948364c62eeeb9f0fdc5825d622ec35
 2022-04-13 12:34:54 +00:00
drh
12c35ec322 The rows of a RIGHT JOIN might come out in any arbitrary order. So disable 
the ORDER-BY/GROUP-BY optimizations if a RIGHT JOIN is involved.

FossilOrigin-Name: d168f245ecf497368feea4697769930c00420ef47a584904dac85371b61fb78a
 2022-04-13 12:12:01 +00:00
drh
3b79f7580a Fix an assert() in btree.c that might not be true for a corrupt database file. 
FossilOrigin-Name: dbd8e2e46cfb2de0ebdbb62cda2fe669df3eda98f5d6112d541f581995b1361d
 2022-04-13 10:49:50 +00:00
drh
146e64d2e4 Add missing VdbeCoverage() macros on new branch byte-code opcodes. 
FossilOrigin-Name: 218c7167e562f5c327124f02a92de85079315320a221fb0508310d927596b14c
 2022-04-13 01:52:32 +00:00
drh
f7309bce10 Ensure that the JT_LTORJ bit in the SrcItem.fg.jointype is preserved during 
query flattening.

FossilOrigin-Name: 61259050152321bc57dbdfdc3edcabb4f18c021b1ee0491c1e04ae24c7a59d89
 2022-04-12 20:20:54 +00:00
drh
0879d5f9e0 For the bad join type error message "unknown or unsupported join type" 
remove the "or unsupported" clause, because we now support all valid join
types.

FossilOrigin-Name: ab0a0562dd3594cf50ee56f6b3a5847fa5dcadf69146d560e3e7a95651b8f405
 2022-04-12 18:40:14 +00:00
drh
949e2ab49a Factor out the RIGHT JOIN non-matched row loop from sqlite3WhereEnd(). This 
reduces the register pressure on that routine and helps it to run faster
in the common case where there is no RIGHT JOIN.

FossilOrigin-Name: beeecf1604d4fb11e45058f48cb2289c6542e0bc218d63a245198113d8d5476b
 2022-04-12 18:04:29 +00:00
drh
57d4b5bde1 Merge the latest enhancements from trunk into the right-join branch. 
FossilOrigin-Name: b3e57ba120067c79e0398e39da9f00ecb11a5e18c36479da4c36a39e88a78a27
 2022-04-12 17:43:30 +00:00
dan
6625d6d873 Earlier detection of corruption in balance_nonroot(). dbsqlfuzz 9191ade77ebd3b7a3356e074957aa85b0c669d14. 
FossilOrigin-Name: bff4f083eb1c35544988493a5d73a42e646c4250b841f5aae38c2183f0867a0e
 2022-04-12 17:02:27 +00:00
drh
61dac44eb9 The multi-index OR optimization does not work for RIGHT join, so disallow it. 
FossilOrigin-Name: 34c2f7b237fa4e0e1cd94fb9c44ebe194b86b88dc575055cc46c7f3695d02756
 2022-04-12 14:23:45 +00:00
drh
a70782407d Always explicitly set each table cursor to NullRow before doing the RIGHT-JOIN 
unmatched row pass.  This is a cheap opcode, and it adds an extra layer of
defense against incorrect results.

FossilOrigin-Name: a3d14e61ca22167296fee125a3e9aa63413408955e03bb3f9d85fa9f22df1b79
 2022-04-12 13:46:21 +00:00
dan
f7413d9acf Modify utility function sqlite3SetString() so that it may be used safely on Parse.zErrMsg. Fuzzer test case "crash-1604e5d76c92574e21e437049dab9b672e06b767.txt". 
FossilOrigin-Name: 09c5a4ec13b02efd6207e26dab7beaf184f0d8ccea0bd0dfe94fc803fe5636ce
 2022-04-12 11:02:06 +00:00
drh
b087de063b Fix RIGHT JOIN for virtual tables. 
FossilOrigin-Name: 75a9116e98b9ac5c1a4c62a01143a016d9ba6a0b495ff7af7468c11947a3e888
 2022-04-11 21:00:38 +00:00
drh
c133bab72a The query flattener must add TK_IF_NULL_ROW opcodes on substituted values 
that land on the left operand of a RIGHT JOIN, just as it already does for
the right operand of a LEFT JOIN.

FossilOrigin-Name: 8e02cdf5b1128f5e5b82d93903063415ec312694e5ccdd19e99fa35433f1b68a
 2022-04-11 20:15:52 +00:00
drh
ec27077c4f New test cases added. 
FossilOrigin-Name: bdd1499c0fa4f8aadf4857a0ccc0d839c250369f29766ebef80330964905e63b
 2022-04-11 18:54:23 +00:00
drh
6134b2dff2 Fix handling of "continue" and "break" from inside the loop for the right 
operand of a RIGHT JOIN.

FossilOrigin-Name: b6e773a26c2c6ee76ea61acb059b4e676d07ea62f6db9c513638f8986557cf04
 2022-04-11 17:27:38 +00:00
drh
ff02ac7f07 Do not attempt the LEFT JOIN strength reduction optimization on a FULL JOIN. 
FossilOrigin-Name: 7ef3e99a73d70405a185d5d31f2d97d3bd99568fd6f10941e75d6c0baa27dc4f
 2022-04-11 14:43:11 +00:00
drh
c583719b65 Show LEFT and RIGHT JOIN processing in the EXPLAIN QUERY PLAN output. 
FossilOrigin-Name: d91faeffea5cf0585fb71e5311fdcc6b8be85c7e9c732050b4448e617c970101
 2022-04-11 14:26:37 +00:00
drh
37259f4e6b New test cases. 
FossilOrigin-Name: d5f6791b86f946b348f5ddc9cedc0df4a86b17854a97554140799caf74c602f3
 2022-04-11 13:13:57 +00:00
drh
3a6e4c59c4 Make a distinction between (1) WHERE clause constraints, (2) ON/USING 
constraints on outer joins, and (3) ON/USING clause constraints on inner
joins.  Formerly, there was no distinctionb between 1 and 3, but RIGHT JOIN
needs to know the difference.  Make RIGHT JOIN aware of this difference and
add test cases.

FossilOrigin-Name: 0f6f61c3664cc87209c2a6f9b6df3a750d1510723fcde209c33db8feaf48bcf3
 2022-04-11 12:38:06 +00:00
drh
b77c07a715 Fix some comments that refer to LEFT JOIN that should refer to OUTER JOIN. 
No changes to code.

FossilOrigin-Name: 5be5ede5cca1cd5ef863fe0feb2b4a990f4a42865281a6c2e4eb816f48847dc6
 2022-04-11 11:59:25 +00:00
drh
189c065942 Merge the Expr.w.iJoin name change from trunk into the right-join branch. 
FossilOrigin-Name: 29927926eb32acd963e2c496ad67d55177615ec4150fd218afaf2f9a730cabec
 2022-04-11 11:48:17 +00:00
drh
d198526289 Rename the Expr.w.iRightJoinTable to just Expr.w.iJoin, so that the words 
"RightJoin" in the former name do not lead readers to believe that this has
something to do with RIGHT JOINs in particular.

FossilOrigin-Name: e8c00442d2daedec079748d13147bf73b0ec3c3cf432bce2cdccb706bdff2853
 2022-04-11 11:25:28 +00:00
drh
79d2658671 Ensure that the JT_LTORJ flag is preserved when flattening a subquery that 
is on the left side of a RIGHT JOIN.

FossilOrigin-Name: ccb61fb1f30e2741b19c1a0cbd2951715224852c86234a3c6a4bbd2e1187634a
 2022-04-11 10:38:28 +00:00
drh
8a28ce7bc2 Show the JT_LTORJ flag in TreeView debugging output. 
FossilOrigin-Name: 21eb44919f38abad30b75181ca8aec38b453b94dba2815caf7e946e07faa40d7
 2022-04-11 00:54:30 +00:00
drh
41798d5bbc Do not allow query flattening nor the push-down optimization on the 
right operand of a RIGHT JOIN.

FossilOrigin-Name: 5aa0c9ea9cf53c13bf266278b479b2e7af3aa5c6b144bd49ff155a4eb3c23c96
 2022-04-11 00:21:53 +00:00
drh
529394e5c1 Cannot use an automatic index on the right table of a RIGHT JOIN because 
automatic indexes must be WHERE_IDX_ONLY, but the RIGHT JOIN post-processing
does not know how to work with an index-only scan.

FossilOrigin-Name: beb4401dc09fb68e85ddcf3f99598527691535d0eb7693168f440e5a5a076e3f
 2022-04-10 23:48:47 +00:00
drh
9debb58e48 Revisit [f84b2beca7197589]: disallow co-routine implementations of tables 
that are to the left of a RIGHT JOIN, to avoid other complications.

FossilOrigin-Name: cf00ebfc4b77f45ec466b0d57d7c22c7f48acab19e4e55b168eb4b53f390d887
 2022-04-10 23:01:20 +00:00
drh
62ed36bb5d Minor improvements to the sqlite3SrcListShiftJoinType() routine. This started 
out to be an effort to convert RIGHT JOIN to LEFT JOIN if the join was on
the first pair of relations, but that messes up the "*" expansion and so won't
work.

FossilOrigin-Name: a48902c71ed30c83de7dbd26d1c7956136c35dc53b1076bc8b1ebcba568a3fd3
 2022-04-10 20:28:41 +00:00
drh
fcde633f7c When the left-most table of a RIGHT JOIN is implemented as a co-routine, 
make sure all its columns are flushed to NULL when it finishes so that
they appear to be NULL during the RIGHT JOIN post-processing.

FossilOrigin-Name: f84b2beca719758979d7a5a63c3d16d5121a7518b3fbe5039af474a83dd569c2
 2022-04-10 19:51:22 +00:00
drh
e21e36dd2c More test cases and bug fixes. 
FossilOrigin-Name: 140e97fde94fdc3babdd456ce1b22900ead0e40e2afe63d89d21ccdbf141b607
 2022-04-10 17:14:48 +00:00
drh
a20c71e9e8 More RIGHT JOIN test cases and a bug fix. 
FossilOrigin-Name: 19e8ad690a140ca40838bf31a377c19010fcbbc2554a4f1746737543043e334b
 2022-04-10 16:13:37 +00:00
drh
ac8c438a79 Add a simple test case. (It is not difficult to create additional test 
cases that assert, at this point.)

FossilOrigin-Name: f2201d5dcfc552bdddd0780b3f466bdaa886e557f147335c085395bfc001f6b0
 2022-04-09 20:11:05 +00:00
larrybr
039132be20 Fix .import bug reported at https://sqlite.org/forum/forumpost/14db09d7e765b819 . zAutoColumn made to deliver characters, not bytes. 
FossilOrigin-Name: 21e96600d90c1cda84777abe22a11058eba46c9faefeb05f8c31bc0e7fa84b19
 2022-04-09 18:51:49 +00:00
drh
de24dd706e Bug fixes. A basic FULL OUTER JOIN now works. 
FossilOrigin-Name: 34bbeeb77bd530b2b1f0390e9e552f65ae35f09a74d80a09dd327e64f9be51a1
 2022-04-09 18:48:11 +00:00
drh
86c1beb402 Add byte-code that computes unmatched rows on the right table of a RIGHT JOIN. 
Compiles, and the code looks semi-reasonable, but still does not run.
Incremental check-in.

FossilOrigin-Name: 2db5a498e74241dd19ef51c601f1a2b3b687faed3e1be2d1e3ada737406ac8e9
 2022-04-09 14:48:35 +00:00