mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
21,095 Commits 1,487 Branches 166 Tags 416 MiB
d3c468b758
Commit Graph

21095 Commits

Author SHA1 Message Date
dan
14e3e22773 Fix an assert() in fts3 that could fail when accessing a corrupt database. 
FossilOrigin-Name: 601ce9532d34f97a5faa170b6d8a272e5c54f2eabff84660201a1840e0fd9929
 2019-09-19 13:51:52 +00:00
drh
6d2566dfc2 Always clear the temporary register cache after coding a subroutine. 
FossilOrigin-Name: b6f2a7f9cdb547c925f08306df82519e41a7a0dd2cabd9861a48917bb6eef845
 2019-09-18 20:34:54 +00:00
dan
572b0dddee Add extra tests for the handling of corrupt records in fts3. 
FossilOrigin-Name: 40e29a47d1266c16a4992e43579a51addcc632503099c4cd128f77dd4e67da3c
 2019-09-18 17:22:00 +00:00
drh
aa16c603ab Fix another potential "jump depends on uninitialized value" warning. 
FossilOrigin-Name: 633b214e9b9d99788ed72ab4823a69a43c7c40ed07fb76c7d56c50453c0e58ab
 2019-09-18 12:49:34 +00:00
dan
4b48c72721 Fix a "jump depends on unititialized value" valgrind error in fts5 triggered by corrupt database records. 
FossilOrigin-Name: 6b6751cd90601a1e2744a7d233c973291ecb783801b9327c3b99734dd22bcd27
 2019-09-18 11:46:34 +00:00
drh
9d70284022 Fix an OOB read in the INSTR() function introduced yesterday by check-in 
[3fb40f518086c1e8] and detected by OSSFuzz.  The test case is in TH3.

FossilOrigin-Name: d49047c1b59bbfd05204af9973cdb0fab51b4d2661b550aec10d917fff94dc9b
 2019-09-18 11:16:46 +00:00
drh
ec722c1088 Do not change the OP_String8 opcode into OP_String until *after* any necessary 
encoding conversions are accomplished.  Otherwise, a rerun of the prepared
statement after an OOM can result in errors.  Test case in TH3.

FossilOrigin-Name: 8efd62594eae725decb719aa7777c020f982b7cdc2c92bab3b91bf349a5bc298
 2019-09-17 21:28:54 +00:00
drh
e691dcb506 Test cases for ticket [587791f92620090e] 
FossilOrigin-Name: ca0e3a83a1c015b346a791e6de03904d17a769c52dad0e3d71316c6e2e3f43c7
 2019-09-17 13:30:30 +00:00
drh
97b0250599 Fix the instr() SQL function so that it makes a copy of its argument 
before changing the datatype, since the datatype affects processing.
Also fix the sqlite3_value_text() routine so that it always works even
for values obtained form sqlite3_value_dup().  Ticket [587791f92620090e]

FossilOrigin-Name: 3fb40f518086c1e8d11eb1f4134e965450dbedfa4277bce39ef1e969fc747d38
 2019-09-17 03:16:29 +00:00
drh
70738712de Improved type information display when tracing VDBE execution. 
FossilOrigin-Name: ee83d8e30d6f9ca8f1cce653ee094ff151f633f4b6a21dd814ab07e8cfb901eb
 2019-09-16 20:16:17 +00:00
drh
91f473b5cc Do not attempt the LIKE optimization for non-text columns and a pattern 
prefix of "-".  Ticket [0f0428096f17252a]

FossilOrigin-Name: 6fe0367f9a337b7c62886b7771f3ce0642faa13f4e4f3d9a0c848abbab514cd0
 2019-09-16 18:19:41 +00:00
drh
130dbc3d96 Add recent interesting cases from dbsqlfuzz. 
FossilOrigin-Name: f06ef3d75d85545dd58c6dda10f7ad04fafbb7ae8706b3821be21f86a94795f1
 2019-09-16 15:15:38 +00:00
drh
2ad35d980b Documentation updates for the SQLITE_DIRECTONLY flag. 
FossilOrigin-Name: 5beb6dc9bc2d3d0003e33488df9c01aaf28c41c30fd9ca35543cbe3ec5a8d9ce
 2019-09-16 14:42:07 +00:00
dan
b42eb3571c Fix a problem with processing CTEs that use a WINDOW clause. 
FossilOrigin-Name: ca564d4b5b19fe56842a04f31bb61352e6ae9d72a7e7634eb27ebcf5f670545a
 2019-09-16 05:34:08 +00:00
dan
8cce6b8310 Add the --no-rowids option to the ".recover" command. 
FossilOrigin-Name: 01d71b947a7422081d5c7d6ac2c91b9c936dc41926ab58c92f4a088a64e8c051
 2019-09-14 16:44:51 +00:00
drh
d44c617ad4 Extra comments on fields of the Window object. 
FossilOrigin-Name: 3dbed162518a73213bbfb137c763064518fdc2daeae3952cfab39ce0e6813d3f
 2019-09-14 16:21:02 +00:00
drh
fab5b07395 Fix the windows inverse function on the JSON aggregates. 
FossilOrigin-Name: f464d847af490dd3ec45565dcc4c2e6ff4ed1ebb65036f30ca0b3ce2e73080e6
 2019-09-14 00:21:34 +00:00
dan
51a75aaa76 Fix a problem with using json1 window functions with an EXCLUDE clause. 
FossilOrigin-Name: 4a1978814da41608a16f6953bd575c97d587a34bd80b7ac0e619d62bfdc903d2
 2019-09-13 20:42:46 +00:00
drh
e087a7c35b Fix the windowB test module so that it works even if SQLite is built without 
JSON support.

FossilOrigin-Name: 807975c76b36347f02aa0ce9661d608adbffe1f7e77c15f8da677e47e1187153
 2019-09-13 18:59:04 +00:00
dan
cd9cb85a41 Add the SQLITE_SUBTYPE flag, which may be passed to sqlite3_create_window_function() to indicate that the window function uses sqlite3_value_subtype() to check the sub-type of its arguments. 
FossilOrigin-Name: ba2ebc3a348decc5cedaf14960e30e7ae26a26824cfa198727f2499162142ef3
 2019-09-13 18:27:17 +00:00
drh
477f1f12e2 Fix a typo in the carray extension header comment - the comment that serves 
as the documentation to this extension.

FossilOrigin-Name: 658a42d3633b31fda260f2c5a1a2c7dd8eb4eb0114d322369017c56faf5ecd42
 2019-09-13 17:30:24 +00:00
dan
01a3b6b1b2 Change the meaning of the SQLITE_SUBTYPE flag so that it indicates that the user-defined function cares about the subtypes of its arguments. 
FossilOrigin-Name: af1bc20f502816db460d2b2d353f715da5cf660e59095de5214c829c1cb20981
 2019-09-13 17:05:48 +00:00
dan
945a3527d5 Merge latest trunk changes with this branch. 
FossilOrigin-Name: 14ef7543465dd14d8fa141fcceb1950b5c2d265a3e862323969d747b39c0cd8c
 2019-09-13 16:19:53 +00:00
drh
3f3f2c7357 Ensure that the idxStr for FTS5 is always zero-terminated. 
Fix for check-in [e6db945454a0dae2]

FossilOrigin-Name: 090cd07d37904da4610d6a6787a3cc825c9a8bdcc5f051267d4608bba9b49d03
 2019-09-13 13:23:13 +00:00
drh
fbb9a5b1e3 Fix harmless compiler warnings. 
FossilOrigin-Name: a8927d14f88c44828e794787bab080455ab62705c93f65ce7d8db83478aa5a8e
 2019-09-13 12:24:58 +00:00
dan
685b2ee0c3 Allow fts5 to filter on multiple MATCH clauses in a single scan. 
FossilOrigin-Name: 9d418a7a491761eeb38a70898677a493e2631e5d62e75ee88431f52d3dfd2344
 2019-09-12 19:38:40 +00:00
mistachkin
acf6e08d20 Fix typo for one instance of line number handling in the Lemon tool. 
FossilOrigin-Name: 980be1730dc1239c63a107923bf2e32b4ec7d4bc31b9190e711cc35f18cc2bb4
 2019-09-11 15:25:26 +00:00
drh
c204d81a6c Enhance treeview to show SOFT-COLLATE for TK_COLLATE operators that omit 
the EP_Collate flag.

FossilOrigin-Name: a97804620a27acc30bebd2aaa04e38f2f36de48b0931038ca8bdc9cb0c36b8f4
 2019-09-10 17:51:27 +00:00
dan
fa50834914 Ensure the columns of views and sub-queries maintain their implicit collation sequences when the "push-down" optimization is applied. Fix for [18458b1a]. 
FossilOrigin-Name: 36997c4ade2ef3a274cd1ac52b44118fb3a05325adb650b7b338ecb43d060575
 2019-09-10 15:33:52 +00:00
dan
d5deb6b3c4 Ensure the columns of views and sub-selects in the FROM clause of a select are always assigned implicit collation sequences, just as table columns are. Fix for [a7debbe0]. 
FossilOrigin-Name: b9ec72203c19c2b95e648ac1dfad74eec98d4ff82581cdc10dc4221ba551728f
 2019-09-09 20:17:24 +00:00
dan
e08663946e Ensure the columns of views and sub-selects in the FROM clause of a select are always assigned implicit collation sequences, just as table columns are. Possible fix for [a7debbe0]. 
FossilOrigin-Name: 1863b7bf12521bdd2b51c5b8d3a4634bff3e15d3713e0b5343952df7da02f794
 2019-09-09 19:49:42 +00:00
dan
e2ba6df9f0 Add the SQLITE_SUBTYPE flag, which can be passed to sqlite3_create_function() and similar to indicate to the core that a user function is likely to use sqlite3_result_subtype(). 
FossilOrigin-Name: 6aa438ce41d460a6782ae63503128b9140c28ff59c2b2eed48b004acf83e0560
 2019-09-07 18:20:43 +00:00
dan
1a97c413f8 Fix handling of NULL, text and blob values in window queries that use "RANGE BETWEEN A FOLLOWING AND B FOLLOWING", or "B PRECEDING AND A PRECEDING", where A>B. 
FossilOrigin-Name: cb3e2be674316e1d39968eb6567f1fe1b72f9d89af49640a9e83f944979c4cf0
 2019-09-04 06:56:43 +00:00
drh
7dc3547eeb Updates to the default settings in Makefile.linux-gcc. 
FossilOrigin-Name: 3044cf6917ea8324175fc91657e9a5978af9748f72e1914bc361753f0b2d897d
 2019-09-03 16:23:41 +00:00
drh
c7d12f4ad4 When we play games with COLLATE in order to commute an operator in the 
WHERE clause processing, be sure not to use the commuted operator to qualify
a partial index, as insufficient COLLATE information is preserved to verify
that the expression will correctly qualify the index.
Ticket [767a8cbc6d20bd68]

FossilOrigin-Name: 5351e920f489562f959ab8a376ff720f845ea165e0cdc7c3a271aac53c2aa64a
 2019-09-03 14:27:25 +00:00
drh
4fc836546e Fix a bug introduced earlier today by check-in [88833a9c2849c959]. 
Ticket [29f635e0af71234b]

FossilOrigin-Name: 6e7b4527d32cc1be0294614b9d7363d4b59cf654a954b86515b3f6888975ce73
 2019-09-02 22:13:06 +00:00
dan
229ae1ae72 Fix a potential crash in fts5 caused by using an auxiliary function on a "special" query like '*id' or '*reads'. 
FossilOrigin-Name: 9490683ae883561fa347cbe54ebdd61188d849b4852d904b508250ba5d0807ef
 2019-09-02 14:46:12 +00:00
drh
dd668c26b5 When applying the IN_INDEX_NOOP optimization and the LHS has REAL affinity, 
also apply REAL affinity to each element of the RHS.
Ticket [2841e99d104c6436].

FossilOrigin-Name: 88833a9c2849c959a37a80e0e4d2b211ce3c83a48319724c89b172b060c876b4
 2019-09-02 02:21:58 +00:00
drh
0167ef202b Fix an obsolete comment that defines the meaning of one of the parameters 
to the sqlite3FindInIndex() subroutine.  No changes to code.

FossilOrigin-Name: 0c946f0846b2835f8facca806a4d4ecc2b2e97343de245a0d91716d998b2a829
 2019-09-02 01:25:07 +00:00
drh
bffdd63633 When computing an expression value for an index-on-expression or a CHECK 
constraint and the expressions uses a REAL table column, but the value of
that column is an integer (in other words, when it is using the 
store-real-as-integer optimization) be sure to promote the value to real
before evaluating the expression.  Ticket [57af00b6642ecd68].

FossilOrigin-Name: 0658c16e311393c8a347b1bd41fa5dbfd2e184aa75d84c011aa8dbac79b632e9
 2019-09-02 00:58:44 +00:00
drh
cc80db69e9 Remove an obsolete paragraph from the OP_Column documentation. No code 
changes.

FossilOrigin-Name: f6d8956cf8b5993a4332b9330e89d5c3d5f8872ea5a2ce3d2e91127406cc1839
 2019-09-01 23:36:33 +00:00
drh
35a38e0836 Fix a harmless compiler warning. 
FossilOrigin-Name: 63c67a54b4d3e501f3059dcdfc6bb50c6b8dad63a34eb773e4408d9e4e780d7a
 2019-08-31 20:29:28 +00:00
drh
81d25cf53d Mark new VDBE branches never taken. 
FossilOrigin-Name: 83c2adffbfb6dcdddb38ad9f888647b0e39fa24dc0bff344238e1f75a6c7d2ed
 2019-08-31 20:26:06 +00:00
drh
80f6bfc064 Improvements to the algorithm that determines which SELECT in a sequence 
of nested SELECT statements that an aggregate function belongs to.  This
resolves an issue identified by dbsqlfuzz.

FossilOrigin-Name: d768007473f4ed40abbdf2c7e501b580b1cc37c1620c7cb90af1f208a8c35145
 2019-08-31 20:13:30 +00:00
dan
f66bfcb740 If a DELETE trigger fired by an UPDATE OR REPLACE statement deletes the row being updated, do not attempt to proceed with the original UPDATE operation. Fix for [d6a0fbc1]. 
FossilOrigin-Name: 4145b3e05051ba6729105157a876793ad14a05d895fc10fe704f437eab16ea93
 2019-08-31 17:14:35 +00:00
drh
6a19865ff2 Remove some affinity tests that became unreachable due to the prior change. 
FossilOrigin-Name: e2db1123faac26c0e0b6a1ebef1685ea7633bfcafd1ff743ba5380700f7745af
 2019-08-31 01:33:19 +00:00
drh
7314495ff8 When the affinity of a table column is INT or REAL, make the affinity of 
corresponding index columns NUMERIC.  This increases the precision of
index lookups for large numbers so that it matches the precision of
ordinary comparison operators.  Ticket [40812aea1fde9594]

FossilOrigin-Name: e0d909c740b774d8a46731696e33342be83206cc4a95d07f42fdb3d8cc2d7a8e
 2019-08-30 23:56:34 +00:00
drh
a7ce167e5b Make sure OP_RealAffinity has been applied to all columns of type REAL 
in the excluded.* pseudo-table of an UPSERT.
Ticket [5a3dba8104421320]

FossilOrigin-Name: 67381dadede98a55d8d9e085d021e6fa6473071978967b6302e03b28cf2245e1
 2019-08-30 23:15:00 +00:00
drh
efb5f9a173 Improvements to VDBE tracing. No changes to code in normal deliverables. 
FossilOrigin-Name: 54553bf16fabd72d1967acef317beb518e086707ccd45890b7c7256b8da08b75
 2019-08-30 21:52:13 +00:00
dan
9889ede28d Add test case to window8.test. Also fix an error in a comment in window.c. 
FossilOrigin-Name: 2925bfa5971c8557ecaa6ac18df0825ebbbd1622017509e83451d90640146fa8
 2019-08-30 19:45:03 +00:00
drh
db3a32ed1c Back out the change at [47cd634c98b502d4] which was incorrect. Add a test 
case so that we don't accidently back out that change again.

FossilOrigin-Name: 596ac2a4eab28b74f4050fb4eb71883f2a1421fdbccf302413e4653391bb52c9
 2019-08-30 18:02:49 +00:00
dan
1cac1766df Add further comments to window.c. 
FossilOrigin-Name: 900464567b2a5ce0c278a3297e4be1968f609258608aa0fbe2fc67709aa22a4b
 2019-08-30 17:28:55 +00:00
drh
ac6627327c New test cases for window functions with RANGE BETWEEN and DESC NULLS FIRST. 
FossilOrigin-Name: f7002f86c780e279c9f8a6268f317586519c059c9de2115ff6f1cad272570c29
 2019-08-30 16:46:12 +00:00
dan
8b47f52082 Fix a bug in RANGE window functions that use "ORDER BY <expr> DESC NULLS FIRST" as the window-frame ORDER BY clause. 
FossilOrigin-Name: 39b4cad4a51bb5116d62ffb16ac36d96a9280321b049eb2d008605392f52a459
 2019-08-30 16:14:58 +00:00
drh
ae144a1c9f The expression "(X IS FALSE) IN (FALSE)" does not imply that X is NOT NULL. 
Ticket [f8f472cbc77ba9c9]

FossilOrigin-Name: dd66134817ecbda01c59a05ad0d6ac44bee700ab10cd2119c869dd69af293fe2
 2019-08-30 16:00:58 +00:00
drh
7a231b4973 The expression "(X IS FALSE) BETWEEN FALSE AND TRUE" does not implie that 
X is not NULL.  Ticket [fba33c8b1df6a915]

FossilOrigin-Name: 057fb8b1809b8b9c8fff0fd0804153b9644f0545c23c6ddc4758bda3381094b9
 2019-08-30 15:11:08 +00:00
drh
38cefc83c8 The expression "(x IS FALSE) IS FALSE" does not imply that X is not NULL. 
Ticket [a6408d42b9f44462]

FossilOrigin-Name: 45ff2b1f2693bb0231a864a511bb82cf2a5945ab3d806a5bbaf1517ecb287883
 2019-08-30 13:07:06 +00:00
drh
f4d9c9822d Remove a faulty testcase() macro. 
FossilOrigin-Name: 80124ae55246b79023d23d3f55487ac3c0b40e8ff301c5daf4dd0631de8ddb29
 2019-08-29 23:24:18 +00:00
dan
bd717a4d2e Improve vdbe branch coverage of NULLS LAST code. 
FossilOrigin-Name: e8e9f77d52974f6ba0a536d05837b280a996745deb3a2169bb29379f10e49df4
 2019-08-29 21:16:46 +00:00
dan
9d23ea74d4 Fix other problems similar to ticket [c0390363]. 
FossilOrigin-Name: 96ff2ba9c4bb71d5f7c6f359986a76a5364b7ac3e1a612441543a9eabecf31df
 2019-08-29 19:34:29 +00:00
drh
db586e4843 Add a missing VdbeCoverage() macro. 
FossilOrigin-Name: 33da6092d3d04b6eb6ab396b8c4f668e3529e26bf11e26f5fcb9b61fe3470197
 2019-08-29 16:48:10 +00:00
drh
f76ccb7d54 Remove an unreachable branch in the NULLS LAST logic of RANGE window 
functions.

FossilOrigin-Name: 47cd634c98b502d40a493455ba6d73cbd0dae74944f9cf06fcbcd025f4b49d6e
 2019-08-29 16:17:59 +00:00
dan
b6a9121bb3 Fix another case where SQLite assumes that if "~(? AND FALSE)" is true, "?" must be non-null. 
FossilOrigin-Name: 616f5663b3dbd0929128c0990fc6d8bba1513c7ae196b87c450ac0b3b3203ecd
 2019-08-29 15:50:16 +00:00
dan
1cd382e350 Avoid assuming that for "~ (? OR TRUE)" to be true, "?" must not be NULL, just as we do for "NOT (? OR TRUE)". Fix for ticket [c0390363]. 
FossilOrigin-Name: 84ae41fd2f50cb7c0c3f6522d0f94817e1bbf96eae5316279e3e32cee4e46e91
 2019-08-29 15:06:35 +00:00
dan
50b3ea2daf Fix a potential buffer overrun in fts5 caused by corrupted database records. 
FossilOrigin-Name: c465d0eb478e42045e08efe8b6fa64d4bd4d747cdf743beae4608562b014169e
 2019-08-29 14:25:44 +00:00
drh
0b79824ec5 Improve Lemon so that it enlarges some of its tables slightly in order to 
avoid having to index range checks on table lookups for a performance
increase.

FossilOrigin-Name: 4be6a23a188bd1fea445283d6dcc2f5c3470c28852dc4895d63117ad0c773fcf
 2019-08-29 00:27:12 +00:00
drh
6ee3fa87fd Fix an unreachable branch in sqlite3ParserFallback() 
FossilOrigin-Name: e059178b47109caee2c2211b2db6e594c014af636677118a64e10edf01ac017d
 2019-08-28 11:49:45 +00:00
drh
010bdb4c79 Further improvements to parser speed by enlarging lookup tables to eliminate 
the need to do range checking on the index prior to lookup.

FossilOrigin-Name: 47d3e091ae49eb7947af5abef9b5b96b16b86d349e51fe0677795649be6db473
 2019-08-28 11:31:11 +00:00
drh
2e51716b15 Increase the size of the yy_lookahead table so that it is never necessary to 
down bounds checking on the index.

FossilOrigin-Name: bafd872398e58766e996963372c7acc03a1e20a6d39a3867ca45d3ea0ed2ac1d
 2019-08-28 02:09:47 +00:00
dan
8085d53d3c Add support for "ORDER BY ... NULLS FIRST" and "ORDER BY ... NULLS LAST". Use this to fix ticket [f8a7060e]. 
FossilOrigin-Name: 94085fb3e756bc984237b74b6e29c68462ad860870c64dcb5124feaeec387660
 2019-08-27 19:59:21 +00:00
drh
e893759cac The ALWAYS() added by the previous check-in was incorrect. Take it back out. 
FossilOrigin-Name: 336235db2b1167cdb2feb64b47eb6368c97c43ee9641b7bfccc5775a41dd0d0e
 2019-08-27 17:59:01 +00:00
drh
7ec796d002 Add ALWAYS() to an always true conditional that results from the 
previous check-in.  Add a test case for ticket [dbaf8a6820be1ece] to
supplement those already checked into TH3.

FossilOrigin-Name: aff209804722ac902c7abfde80ad2677e0f51beb2c7f28f65d51105d984a1640
 2019-08-27 17:28:05 +00:00
drh
790b37a240 Omit the "x IN (y)" to "x==y" optimization of check-in [e68b427afbc82e20] 
(and ticket [e39d032577df6942]) as it causes difficult affinity problems
as demonstrated by ticket [dbaf8a6820be1ece] and the original assertion fault
is no longer a factor due to countless other changes of the previous 5 years.

FossilOrigin-Name: 7f5168a76a400fc2e1e40c6950470b1bfb38a0be54fc5518c17c29fdae7d8f1f
 2019-08-27 17:01:07 +00:00
drh
6397a78b2b If a TEMP TRIGGER references an auxiliary schema, and that auxiliary schema 
is detached, move the trigger to reference the TEMP schema before completing
the detach, so that the trigger does not hold a dangling schema pointer.

FossilOrigin-Name: 069c2f4c61f06211a8981abc412afcc1536ece13380b13a70aa99123f8f527cd
 2019-08-27 10:05:45 +00:00
drh
512e46a74c Merge in recent fixes from trunk. 
FossilOrigin-Name: ad816d01d4bd3908ff2c574d79d1a29b6d732df308f2f1b1cdf7c0bc7c1bd7cf
 2019-08-26 20:41:33 +00:00
dan
d790c9a161 Tweak the shell tool ".recover" command so that it can recover rows that consist of a rowid and no fields. 
FossilOrigin-Name: 279ac7fdec0b1409cd400b7b093f89089d93c49f596f378c6a3032434a85bf83
 2019-08-26 14:57:58 +00:00
drh
554a9dc78a Improved detection of number of column mismatch for vector assignment 
in UPDATE statements.  Ticket [78acc9d40f0786e8]

FossilOrigin-Name: bd4bda73df3794eef424eb13e08fc7cc54347d1ac69febaeec41f6b6cb4a42bc
 2019-08-26 14:18:28 +00:00
drh
d86fe44ab5 Fix typo in a comment. No code changes. 
FossilOrigin-Name: d0cc06d8a30444125e5655f6587a6355471c3447c08a2e5f7a046a4ed5cc5f09
 2019-08-26 13:45:49 +00:00
drh
e2754c1fba Enforce 80-character line discipline in the CLI. Minor improvements to the 
CLI built-in help.

FossilOrigin-Name: 9690013a00d73a8047b25149ded50d20c74b5c62c0725eec50ed8477688e58a0
 2019-08-26 12:50:01 +00:00
dan
666a42ffb3 Minor performance improvement for balance_nonroot(). 
FossilOrigin-Name: d7434cae3edc321e2f1f8d340a0e656b1613b736f8400fb271a0e80f59401b9e
 2019-08-24 21:02:47 +00:00
dan
298680d15a Fix a potential buffer overrun in fts5 caused by corrupt database records. 
FossilOrigin-Name: 156d612800a7282fe0ebb20feb31d3fd577f4ab60fab8c00940c87143997aefb
 2019-08-24 17:11:29 +00:00
drh
ee37f8b0a3 Fix the built-in edit() SQL function in the CLI so that it works with 
zero-length blobs.

FossilOrigin-Name: e32490128684cfeeb8213baecc78a7942b8fb63d00e375edd965bf236faeed18
 2019-08-23 23:05:32 +00:00
dan
ee6c5e5ae7 Move some things in parse.y so that TK_COLUMN and TK_AGG_COLUMN are assigned the same values as they are on trunk for a very small speedup. 
FossilOrigin-Name: d26fdfa3bc5f8d9c4a6000462080b0dd508e5cae9a83e0d126be48195224da8c
 2019-08-23 20:33:01 +00:00
drh
a31d3554c5 Revise the VDBE comments for NULL-scan so that they also work make 
sense when reading a NULLS FIRST plan.

FossilOrigin-Name: bfe793780fa6fc7a1e7d0ee60606dda272985de9573887dca118e9510fc609f2
 2019-08-23 17:09:02 +00:00
drh
5f6a4ea2e2 Additional simplifications of the WHERE loop code generator logic for 
NULLS LAST.

FossilOrigin-Name: 1383680d927d7d703933be7653c0019199845e7f7e82bcc76d9ca3808093e9d8
 2019-08-23 17:00:22 +00:00
drh
0086e07865 Simplification of the WHERE loop code generator for NULLS LAST saves a 
few CPU cycles and about a hundred bytes of code space.

FossilOrigin-Name: e3ed2f496f51234a8f81d90d47ba603b06dbed38b8bd8f1934294379cde74d3a
 2019-08-23 16:12:20 +00:00
drh
ec3dda5b11 Invert the meaning of the regBignull flag so that it is 1 when doing the 
normal scan and 1 when scanning nulls.  This enables the re-do jump at the
bottom of the loop to be coded with a single OP_IfNotZero opcode, rather
than a sequence of OP_If, OP_Integer, OP_Goto.

FossilOrigin-Name: bf875e1a259a4167694e06349458452dc36c1d38aa6843518d9ae46ce74e5559
 2019-08-23 13:32:03 +00:00
drh
74e1b861ad Extra VDBE comments in the NULLS LAST logic provide landmarks to help 
understand the EXPLAIN output.

FossilOrigin-Name: 649b08ead50f10a9ec0357a5e1ed020195d9f93be61ef703ea036a8e53f07a34
 2019-08-23 13:08:49 +00:00
drh
505ae9def8 Add additional VDBE coverage marcros. 
FossilOrigin-Name: d3531f5be7d3769689e2cd8bdc9bab5608759de027d44cc123996f32a4a89583
 2019-08-22 21:13:56 +00:00
drh
a677eecad3 Merge fixes from trunk. Also fix a reference to the KeyInfo.aSortOrder field, 
which should now be KeyInfo.aSortFlags

FossilOrigin-Name: 63e625c8eb06720eef30573aa562e38c90d228a9cf493f8bb59f09e50f0e3168
 2019-08-22 19:35:24 +00:00
drh
0d950af311 Fix the likely(), unlikely(), and likelihood() functions so that they have 
no affinity, just like any other function.
Ticket [7e07a3dbf5a8cd26]

FossilOrigin-Name: 44578865fa7baf9760e355691ca9ce753295aaba7a4ee0bba29d4f85d9335bab
 2019-08-22 16:38:42 +00:00
drh
af8664020a Fix a false-positive in sqlite3ExprNeedsNoAffinityChange(). 
Ticket [ac184eb571d5e6e0]

FossilOrigin-Name: e62eddbb048cbc2c15cb8eeb5b7a907e7cb08c21a27ebba96a069f62dbcb0f30
 2019-08-22 11:11:28 +00:00
drh
3e36480232 Fix the OP_SeekGE, OP_SeekGT, OP_SeekLE, and OP_SeekLT opcodes so that they 
preserve the datatype of the value in the register used as the key.
Ticket [d9f584e936c7a8d0]

FossilOrigin-Name: 81b9f0f55042777b37de78069f7089041a9ee21dd0a0c86b879053fb46e140b4
 2019-08-22 00:53:16 +00:00
dan
f236b21f4b Add missing VdbeCoverage() macros to new code. 
FossilOrigin-Name: b1cbcdc6eb42cca0c42a05e0d6ba4c6c7f09adff0c59ecfc5b434a94dec07a41
 2019-08-21 19:58:11 +00:00
dan
37874d7dcc Disable broken test case in expert1.test. 
FossilOrigin-Name: 73e30c2e92ccab274ff7cee48511c461de148786bb9d338921c1ecb193822282
 2019-08-21 17:46:34 +00:00
dan
2ebb550824 Update this branch with latest trunk changes. 
FossilOrigin-Name: 6153bcf41a9aa0497f8210311c99ac23846223068f2b6a3a1c2d9dec7673c7e1
 2019-08-21 15:41:50 +00:00
dan
f7c92e82d2 Avoid assuming that "column IS ?", where column is declared UNIQUE, matches only a single row (as "?" might be NULL). Fix for [b8689402]. 
FossilOrigin-Name: d02490a2f0cae047087130b4ad8f55f265845c2ffb3bde3b7d507edb54acea6d
 2019-08-21 14:54:50 +00:00
dan
6fcb9f3ad9 Fix a broken assert() in the fts3 snippet code that was failing for queries containging more than 64 phrases. 
FossilOrigin-Name: 4c01e0170e113ad052b6c3980beb4be9f1dc03fb3cf34132b90e8b82b23f654e
 2019-08-21 11:31:48 +00:00
dan
546738f855 Further tests for the special null-handling on this branch. 
FossilOrigin-Name: 0dbbb51f4d39cafb01d625d65c12dcb232a9c1da7ed5a9397bf55cfea1b980d2
 2019-08-20 20:09:51 +00:00
dan
35fb866ea3 Fix a problem with fts5 "ORDER BY rank" queries when the fts5 table name requires quoting. 
FossilOrigin-Name: 00e9a8f2730eb7239bf7fd107c97c409e4f9fbd968510766373440a9079898eb
 2019-08-20 19:11:29 +00:00
dan
2a0c16f276 Add tests for sort-by-index cases that use IN() and non-default NULL handling. 
FossilOrigin-Name: 09d660ecde723fb30f3bb3684bbb7f95825d78da6a6f33ddf57846054cd563e0
 2019-08-20 17:51:13 +00:00
dan
4fcb9caa60 Do not pass ORDER BY clauses with non-standard NULL handling to virtual table implementations. 
FossilOrigin-Name: a9a82ee88d2d12209a674bd19167277aa91a6912e7a8bbf3714f90d559307fee
 2019-08-20 15:47:28 +00:00
dan
4780b9ad46 Fix a segfault that could occur following an OOM while processing a SELECT statement for which one or more of the expressions in the window frame declaration are themselves sub-selects that use window functions. 
FossilOrigin-Name: 75aec4fc886c04fe098828cc03bc72c197cbf40f0a1890fe5bbb98d4fd5c3c7e
 2019-08-20 14:43:01 +00:00
drh
95da9d5d46 Add the new sqlite3_drop_modules() interface to the loadable extension 
mechanism.

FossilOrigin-Name: 658bd51623787be4ca87b066a051d119f39056286e223afef3691629cf1ab0e1
 2019-08-20 13:49:12 +00:00
dan
b6ce71bd26 Retain the affinity of an expression in a WHERE clause when it is transformed to a reference to an index column on the same expression. Fix for [f043b113]. 
FossilOrigin-Name: 511da0815673ca4a176aa61dc23a8231b2ab77e8363fc184a78b6e17dba64d49
 2019-08-20 11:43:44 +00:00
mistachkin
3722b3abf1 Fix a typo and a harmless compiler warning. 
FossilOrigin-Name: ec4c63e00c957f98d61ddc1b9d20406c7e1072d6ab0c12ac6939db6c63d90cb8
 2019-08-20 02:19:26 +00:00
drh
b6e0286c49 Add the sqlite3_drop_modules() interface. 
FossilOrigin-Name: e2c6fed8f84929ed51a4e876bb09c85ac4b86a2e4cf0832a7da724bb9f4df5bf
 2019-08-19 20:44:07 +00:00
drh
8c754a3613 Omit the "_except" term from the name of the new interface. 
FossilOrigin-Name: e5ba47c2d8eb9f48a0e0d325e57d0092d536f85983819634c871ebd51829f1d1
 2019-08-19 20:35:30 +00:00
dan
ae8e45cb0c Fix problems with window frames that use ORDER BY ... NULLS LAST etc. 
FossilOrigin-Name: 75d665a494dd7d6e77d5a80af386ee5accc0a53416d5493424dc0fef6c7b01a0
 2019-08-19 19:59:50 +00:00
dan
9105fd5189 Prevent NULLS FIRST/LAST from being used in CREATE INDEX and other statements. 
FossilOrigin-Name: bb9767a287097a615aeb4abdba689b10e1a1c36c016c8e55905b508075e62c86
 2019-08-19 17:26:32 +00:00
dan
dac7e69dc2 Add some extra tests for the lsm virtual table module. 
FossilOrigin-Name: 4cb009b0f724f72eaea90e45488122f7c2a7d0caf31a8422da4060469507e921
 2019-08-17 19:58:26 +00:00
drh
5976b2c805 Fix to the query planner for the LSM1 extension. 
FossilOrigin-Name: 7496e872a1a50ac65ad04709365a43038fb015ac9c690196de3cb02ce54c2e57
 2019-08-17 19:55:26 +00:00
drh
5df8428069 The experimental sqlite3_drop_modules_except() interface. 
FossilOrigin-Name: 0851db4d337a87f8b2d3ce2ae9f9c928b9483591ca41a9e39cc01548059b1888
 2019-08-17 19:45:25 +00:00
drh
87ca8067af Fix the new ability to unregister virtual table modules so that it works 
for the automatic PRAGMA virtual tables.

FossilOrigin-Name: 5d6f4dfeea75c7dcd8c511545accb9eb4b405a02db034332249ba54794e313d2
 2019-08-17 19:31:09 +00:00
dan
c324d44690 When populating an ephemeral b-tree for the RHS of an IN(...) clause, avoid applying an affinity to a value that may be used later on for some other purpose. Fix for [c7a117190]. 
FossilOrigin-Name: 43e8b14314d876178d487c3b519296ac1de065fdcaa70768e40d684015bceb9d
 2019-08-17 19:13:49 +00:00
dan
8328369740 Add tests to ensure that this branch really does fix ticket [f8a7060ece]. 
FossilOrigin-Name: f892066425671a8a0ac923e3ad4744677f6434a66f97b91afa8141f11f179975
 2019-08-17 18:16:59 +00:00
dan
cc491f4b1b Fix problem with DESC indexes on this branch. 
FossilOrigin-Name: b49df1fe9b7174ebc60023179e8da628c926e59df3dc01b15d4a28e17807bb97
 2019-08-17 17:55:54 +00:00
drh
9e9a67adb0 Ensure the functions that appear to be constant are not factored out of 
expression that originate on the right-hand side of a LEFT JOIN.
Ticket [6710d2f7a13a2997]

FossilOrigin-Name: 500c9152daaf11cf69d778aa8592175f6088337c6667c59af6df3a24cd81eb0e
 2019-08-17 17:07:15 +00:00
dan
5b32bdff80 Merge trunk changes into this branch. 
FossilOrigin-Name: db1e60800bc260cdcd604739daaba72c6b486158123fc62a3898aca4ead33cd3
 2019-08-17 15:47:32 +00:00
drh
cc3f3d1f05 Activate introspection pragmas by default. The new option 
SQLITE_OMIT_INTROSPECTION_PRAGMAS must be provided to keep them out.

FossilOrigin-Name: 9c4bca64fb5f635296a8d7d7c1bf2808e02ca734a9983e5cee9132f5352a9a6d
 2019-08-17 15:27:58 +00:00
drh
217ca657d8 The SQLITE_DIRECTONLY flag, when added to sqlite3_create_function() prevents 
the function from being used inside a trigger or view.

FossilOrigin-Name: de767376987f7668b0770c4920f1532e341b5a27f797d69c0f5e92b87d036170
 2019-08-17 00:53:29 +00:00
drh
cc5979dbd3 Add the ability to unregister a virtual table module by invoking 
sqlite3_create_module() with a NULL sqlite3_module pointer.

FossilOrigin-Name: 31e34fa3390196cdc3178bf120224b08df5ec58fa2c77079ede6e9461a430dad
 2019-08-16 22:58:29 +00:00
dan
15750a26fa Add support for using indexes for some ORDER BY clauses that use non-default NULL handling. Still some problems on this branch. 
FossilOrigin-Name: 81069d7196857e909c94195d67388f71bc9f832eafd9156d8c5cdddb63513b4a
 2019-08-16 21:07:19 +00:00
drh
4043cfef75 Fix harmless compiler warnings in the TCL interface. 
FossilOrigin-Name: f17e72291f197a92b3e15e054271b997d45211a5a31ca4ea6c7fbb33026d5f1f
 2019-08-15 23:11:42 +00:00
drh
11d88e68ab Add the SQLITE_DBCONFIG_ENABLE_VIEW option, together with a "db config" 
command in the TCL interface that can access that option as well as all the
other sqlite3_db_config() boolean options.

FossilOrigin-Name: 61b4bccd2984f4c2cf50f58ef08677588e57aa7e079af07473b2e188d9ce4f52
 2019-08-15 21:27:20 +00:00
drh
42d2fce7f5 Provide the SQLITE_DIRECTONLY flag for app-defined functions that prohibits 
the use of those functions within triggers or views.

FossilOrigin-Name: fc745845d8d76adc165575e2192f4176e3c28e614c72571d56f4011560499fe1
 2019-08-15 20:04:09 +00:00
drh
725dd72400 Ensure that the optional "sz=N" parameter that can be manually added to the 
end of an sqlite_stat1 entry does not have an N value that is too small.
Ticket [e4598ecbdd18bd82]

FossilOrigin-Name: 98357d8c1263920b33a3648ef9214a63c99728bafa7a8d3dd6a1241b2303fd42
 2019-08-15 14:35:45 +00:00
dan
a3fcc000cb Ensure that SQLite does not attempt to process incompatible window functions in a single scan. Fix for [256741a1]. 
FossilOrigin-Name: 4f5b2d938194fab7627486e2ced633def2c90d9d3328e3700612feb9dbfa3d9a
 2019-08-15 13:53:22 +00:00
drh
d4da4936cd Avoid downgrading SQLITE_CORRUPT errors detected by the schema parser into 
SQLITE_NOMEM or SQLITE_ERROR errors.

FossilOrigin-Name: b2e79f8ff0836fcc98a2df9377aad9137307c34058030ecd1b5d4ec3277ed36a
 2019-08-15 13:46:39 +00:00
drh
27e80a3b68 Ensure that the cell overwrite optimization does not overwrite the header 
of the b-tree page.

FossilOrigin-Name: 4cc5694cbd69749c146679c367860952fdf3f5356426ddfd1dce470569702bc1
 2019-08-15 13:17:49 +00:00
drh
b9fc45534d Early detection out-of-bounds page numbers on the direct-overflow-read 
optimization gives consistent error messages regardless of whether or not
the optimization is enabled.

FossilOrigin-Name: b517a52fa36df0a0854a75858b5e81861771d2e9032a5a0ad79aa76ae64130a2
 2019-08-15 00:04:44 +00:00
drh
908e7c43a7 Always check for reads past the end of the file on the in-memory journal 
driver.  This used to be an assert().

FossilOrigin-Name: 4d41ca7d6efbdac70890a8d4159488fc7f59bf78a550b00597b4df990c4fcaef
 2019-08-14 15:17:21 +00:00
mistachkin
87ae34ba1a Add some static to the 'regexp' extension. 
FossilOrigin-Name: a21d1dde73f811244b5b43f9fed5877263a9c5061470221f417e501f5530edfa
 2019-08-13 20:34:35 +00:00
dan
7c2321fdf3 Update test cases so that they work with ICU enabled. 
FossilOrigin-Name: 408144a1832569ced8e04840f0dd36a3867405f36b13631b0f13c0f7b8a0fb01
 2019-08-13 17:56:56 +00:00
dan
3c1970fcee Update some corruption test cases to take [724f4df9c] into account. 
FossilOrigin-Name: 927cd7b4c52fae665e57fb6039c6829e339cff5ad5c405800cac3ee149ef5be1
 2019-08-13 17:27:43 +00:00
dan
b8a8d523cb Fix a problem with RBU function sqlite3rbu_bp_progress() when used during an RBU vacuum. 
FossilOrigin-Name: 8c44b02f1479cec61554800702a3c1d806e4ee64b41ba2af17320f62794a02fe
 2019-08-13 15:11:25 +00:00
drh
554a19dbee Make sure the btree cursor overflow cache is cleared when overwriting 
a cell in sqlite3BtreeInsert().  Ticket [3cf9bb227e9a5d32]

FossilOrigin-Name: 7dae7b969ed314605a3a2da2cfdce4d81152740f5d3bfbc2a6e311b13ee325a7
 2019-08-12 18:26:46 +00:00
dan
6e11892db8 Experimental implementation of NULLS FIRST/LAST. This branch still has problems - the most significant of which is that ORDER BY clauses with a non-default NULLS FIRST/LAST qualifier can never use an index. 
FossilOrigin-Name: 07babb0f897fc8c9cb5b30481899c32fdd743f3f3ca508d8d957826252107dd5
 2019-08-12 16:36:38 +00:00
drh
41428a97b8 For the ".testctrl prng_seed" command in the CLI, if the argument is "random" 
then select a random integer seed and print the seed value on stdout.

FossilOrigin-Name: 636ca4472c9f41eb3989f28854d4968867837399a2092f389d1b814d98cccbae
 2019-08-12 16:25:11 +00:00
drh
30842990b2 Add a TESTCTRL that disables the verification of type, name, and tbl_name 
in the sqlite_master table.

FossilOrigin-Name: 48d9b48ab4ace234eb1a055cf33cb533a1c3aa82d0a6e086d96226bd9474ceca
 2019-08-12 14:17:43 +00:00
drh
c5a93d4c85 Validate the type, name, and tbl_name fields of the sqlite_master table when 
loading the schema, unless writable_schema is engaged.

FossilOrigin-Name: 724f4df9ccc2b683f7091a3f7a8c20ee210f44d7a610cd1b4c49da1c274add08
 2019-08-12 00:08:07 +00:00
drh
14c865e859 Fix the sqliteExprImpliesExpr() routine so that it recognizes that 
"(NULL IS FALSE) IS FALSE" doe not implie "NULL NOT NULL".
Ticket [9080b6227fabb466]

FossilOrigin-Name: da01ba4fa47c6508b31533ccd769e637af04bd37f51463372fbc6c848d892a4d
 2019-08-10 15:06:03 +00:00
dan
b6299681c6 Add extra test cases related to the previous commit. 
FossilOrigin-Name: 3c690b2b05b7338f3325c50a0750c6023e1173afa4388e836ecb2cc49f19a0ac
 2019-08-10 14:35:06 +00:00
drh
3251a2031b Remove two incorrect assert() statements from the logic used to derive 
column names and types from subqueries.

FossilOrigin-Name: 712e47714863a8ed7ff73324d9fec569633e8b901c436c633b0220d16a7a9302
 2019-08-10 14:16:17 +00:00
drh
cb99c57a66 Allow the RHS of a row-value IN operator to use a compound query with 
an ORDER BY clause.

FossilOrigin-Name: eaf15d9bae6773058341d6219241f44ce728ad1cb9cf649f2efd4dddd81ec461
 2019-08-09 20:26:01 +00:00
mistachkin
044388cf98 Modify signature of sqlite3VdbeChangeOpcode() to accept int instead of u32. 
FossilOrigin-Name: 68b7f2acf4d228f32250e37cbc0eb5d275b512d49071bbb38e1f5634b705f7d3
 2019-08-09 01:59:14 +00:00
drh
3728b84c03 Fix more compiler warnings. 
FossilOrigin-Name: 1b85442b614df0808c10c34ec281282e5dfd93d6d5f9737b51263ffaa4da5c72
 2019-08-09 01:11:32 +00:00
drh
51755a78a9 Fix harmless compiler warnings. 
FossilOrigin-Name: 1eef4ddea9a2a8c97b97183402c774caa40ef906ea9cccade307381b29a9785d
 2019-08-08 19:40:29 +00:00
drh
690f04a0d7 Remove support for SQLITE_ENABLE_STAT3. The sqlite_stat3 table is now ignored, 
if it exists.  Run ANALYZE using STAT4 to get the equivalent functionality,
which presumably everybody has been doing for a long time now.

FossilOrigin-Name: f1cd234c9888142e0ac542d866d7fb55a81fb7edd0a5cd810191b4e0395ffc7d
 2019-08-08 19:19:42 +00:00
drh
af97c3f35a Fix a case of the Expr.affinity to Expr.affExpr refactor that was missed 
in the [a29f2a7d07beff64] check-in.

FossilOrigin-Name: 83450d10707e2c7c075f3930a8c231c49c593b9cdf0e6097b0187eb877755d2d
 2019-08-08 18:49:16 +00:00