mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
19,504 Commits 1,487 Branches 166 Tags 416 MiB
ba3a4072b4
Commit Graph

19504 Commits

Author SHA1 Message Date
drh
142066d4b0 Add a comment to restriction (6) of the push-down optimization. No changes 
to code.

FossilOrigin-Name: 0c8a2f257fb71b2b053c4a2028db063e92dd9ff585a17fa22a70f9223fb11e75
 2018-07-09 20:58:43 +00:00
drh
f710345303 Add an ALWAYS() around a branch in sqlite3BtreeSkipNext() that we believe 
must always be true.

FossilOrigin-Name: 12be361a532df0c22a7e4d97658b82a69b1a205d4cca8d092b9e6b7790c1ee40
 2018-07-09 20:41:39 +00:00
dan
77f3f40292 Avoid leaving view-definitions with an incomplete set of column names/types in 
the in-memory schema if an OOM strikes while allocating the same.

FossilOrigin-Name: 1ddbb5372e7ea8407369b88698b3fb922b62dcac72be633a17bd0e41baa369f4
 2018-07-09 18:55:44 +00:00
dan
e6fcd1d5de Add a couple of OOM tests. 
FossilOrigin-Name: 50de2a0d2d96b6b5b8de7ac6277d60859a8d9a56f6a792950734386bb9f10b79
 2018-07-09 18:11:52 +00:00
drh
7999cc434e Remove redundant branches in window function processing. 
FossilOrigin-Name: 8fdaf3f37e5ddac9b7337a50f32f5d2bcdd64780797f08cfd3fccfa95819edfe
 2018-07-09 17:33:24 +00:00
drh
a57aac262f Simplification to the grammar rules for window functions. Fix a memory 
leak that can follow an OOM while parsing a comma-separated list of
window definitions.

FossilOrigin-Name: a568f9c9db594f3b194c6e870305c9d6f2392ce6bc8ac00e9688883e97560fff
 2018-07-09 16:24:00 +00:00
dan
a1a7e112fe Throw an error if the second argument passed to nth_value() is not a positive 
integer.

FossilOrigin-Name: 1a06e57a0b4279fa580c7ff4f152645f005794aaf86eeabf694637b7da11f763
 2018-07-09 13:31:18 +00:00
dan
f5e8e31399 Fix a bad assert() in window.c. 
FossilOrigin-Name: fe8aaf0c806413965f50a03e34b5fdfaaa8b09dc0af73f41e830f7b664bd1ced
 2018-07-09 06:51:36 +00:00
drh
1e80ace47a Simplification to the logic that detects misuse of the application-defined 
function creation interfaces.

FossilOrigin-Name: 8f21d778450e1e5d2bc7f109d614fe018eb3d228b0bfc91cd3c6a5204415998f
 2018-07-09 02:37:12 +00:00
drh
8ff21f47f0 During WITHOUT ROWID table creation, if the sqlite3CreateTable() call fails 
due to an authorizer denying the INSERT into the sqlite_master table, then
detect this fact and abort the CREATE TABLE early, to avoid an assertion
fault.

FossilOrigin-Name: 164b1641e346994f0b9f91261c3cbc86b68e1c96cc401b78e48e186e26916abe
 2018-07-09 02:02:09 +00:00
drh
19dc4d40e7 Identify specific FuncDef objects for window functions using the pointer to 
the function name (FuncDef.zName) rather than the pointer to the xStep method.
This allows xStep method pointer to be replaced with a single noopStepFunc()
procedure, and thus save having lots of different no-op step functions.

FossilOrigin-Name: 410e13b0e0fb6e040808f076014d55ecf2b541c5439b4fd53c5bdcb8d800098e
 2018-07-08 01:02:26 +00:00
drh
a546ef219e Simplifications to the implementation of the sum() SQL function. 
FossilOrigin-Name: a8b13002378fc4ef0b41c367b44b67bf2b28b6624303c087a3c6d657b5bfe32e
 2018-07-07 20:55:16 +00:00
dan
51a6b19337 Fix another problem with reusing LSM cursors for range scans. 
FossilOrigin-Name: ae3fc7652f27ba0a86f4c26f64c2e148d9496a5edb7f54dc9980edd91c326e4f
 2018-07-07 20:26:30 +00:00
drh
491d4c89f5 Fix the JSON extension so that it can be compiled separately from the 
amalgamation.

FossilOrigin-Name: 4b8cfe7bfe5f049eb4607fd480429fcd2060e691891d8bffc9917f13fa373988
 2018-07-07 20:23:46 +00:00
dan
8f0c712a1f Fix an LSM problem caused by using the same cursor for equality and range 
scans.

FossilOrigin-Name: f05bead371d41ca5beef1f82e4c920c90e2eb9cd9fd537a5c91973bf9bd4eedb
 2018-07-07 20:13:32 +00:00
drh
fd4b72853a Add ALWAYS() macros on results of sqlite3_aggregate_context() calls in 
xInverse() implements, since they can never fail.

FossilOrigin-Name: fdef2a921d451c66ca535021d08af3ec1ab53283da2d2979378a799fd8731ef9
 2018-07-07 19:47:21 +00:00
drh
2c885d0575 Add an assert() to help verify that OP_AggInverse is never called on an 
accumulator that has not previously been processed by OP_AggStep.

FossilOrigin-Name: 4213889103fa37f3f11802aea81989522048a0752820603dd556f612128ddfee
 2018-07-07 19:36:04 +00:00
dan
a5ef149c4e Add missing VdbeCoverage() macro to window.c. 
FossilOrigin-Name: 63f4d306ba19f6ba900a7d7480ccaa3d1e4a204e7c82bf5eb2e4bd849ef3a22f
 2018-07-07 17:38:49 +00:00
dan
d4fc49f735 Fix a problem with the handling of NULL values in the min() window function. 
FossilOrigin-Name: b76f35b09235d44dc3d176377bbb9c18b7cdc9392800103ff53c54730a427a5c
 2018-07-07 17:30:44 +00:00
drh
e4984a2bf4 Try to improve the error messages for misformed frame specifications in 
window definitions.

FossilOrigin-Name: 927b95a0812787bcb3c28d1a0ea94717dc2cc60f6d480623f0c7cbce0c546fc9
 2018-07-06 17:19:20 +00:00
dan
bfead59b3b Also disallow non-constant expressions in "<expr> PRECEDING" or "<expr> 
FOLLOWING" clauses.

FossilOrigin-Name: a6dffecc6b35c618cc5e5a06892765bdbec587dcd0ae8686c231a21516e38eab
 2018-07-06 14:31:26 +00:00
dan
5d764ac9e6 Ensure an error is returned if the user specifies an unsupported frame type. 
FossilOrigin-Name: 0f3f8fcde1a535bcf93e23a68d2411c21785d8c0cac1f9481a06e7225755cdbc
 2018-07-06 14:15:49 +00:00
dan
287fa17b78 Prevent "UNBOUNDED FOLLOWING" from being used as the starting boundary of a 
window-frame. And "UNBOUNDED PRECEDING" from being used as the ending
boundary.

FossilOrigin-Name: e51fdf66a24c27ba6491391fffcc88fc5ca2ae79cfc4ab769a149b19c394e308
 2018-07-06 13:48:09 +00:00
dan
cf0343b699 Remove some bad assert() statements from the implementations of window 
functions percent_rank() and cume_dist().

FossilOrigin-Name: 443f0c286f1659937fd61b4ef2de17d0d015369e5ff5249a9e0c3d0ee4925158
 2018-07-06 13:25:02 +00:00
dan
e33f6e7c91 Return an error if DISTINCT is used with a window-function (.i.e. 
"count(DISTINCT <expr>) OVER (...)".

FossilOrigin-Name: d59bcc8eea4fcf0ee3c2263d31ee42f9f26c28434d2f0045f2d3329f18791d1c
 2018-07-06 07:42:42 +00:00
drh
8f26da6c5b Use separate opcodes, OP_AggValue and OP_AggInverse, for the new callbacks 
associated with Window Functions, for improved readability of EXPLAIN
output.

FossilOrigin-Name: fa6538050938ffeb042fbee31512514d6d3ace514b2a3dfd8365bbeb13f35a78
 2018-07-05 21:22:57 +00:00
dan
6ea9a7282a Update the recipe for resetting a database using 
SQLITE_DBCONFIG_RESET_DATABASE.

FossilOrigin-Name: c43dd23fb00f7e0b6274de435d8e31f6a4cb74c3e86e8313a5098ff089e27574
 2018-07-05 20:33:06 +00:00
drh
8be47a7e86 Get the json_group_array() and json_group_object() SQL functions working 
as window functions.

FossilOrigin-Name: 916cdc83f5a45e0b6f61c52ff5fde70d54bcd0dfaa4a32f9ac709fe0ddbb480b
 2018-07-05 20:05:29 +00:00
dan
7a606e1ab2 Return an error if a "RANGE" window-frame uses "<expr> PRECEDING" or "<expr> 
FOLLOWING".

FossilOrigin-Name: 786c87ba4150509e141baab32c51e64bbd3ce323735e0f47d65ed54d14215bc4
 2018-07-05 18:34:53 +00:00
dan
683b0fffee Fix a problem in the xInverse method of window-function group_concat(1). 
FossilOrigin-Name: 73391283101288251fe5d030ba12bcdabe8a781d41086afe3564c58c05d0fd5c
 2018-07-05 18:19:29 +00:00
drh
f213b33c37 Fix the .dump command in the command-line shell so that it does not show 
extraneous SELECT statements when ".echo on" is enabled.

FossilOrigin-Name: 11763cac33fa809bcf0294d1a381394fcf860b020b51fff81217ee709ba99272
 2018-07-05 17:35:46 +00:00
dan
8bf6d705f3 In wal mode, if a "BEGIN EXCLUSIVE" command (or any other command that 
upgrades from no transaction directly to a write transaction) hits an
SQLITE_BUSY_SNAPSHOT error, change the error code to SQLITE_BUSY to indicate
to the caller that the condition may be transient.

FossilOrigin-Name: e6108047cb136119d8ed19af010a669ed9750b4e7f991ccabc9e3d15774eda31
 2018-07-05 17:16:55 +00:00
dan
b775104357 Fix a typo inside an assert() statement introduced by the previous commit. 
FossilOrigin-Name: e3357728472d5e57db6d7eef0ce008bdee071b5b07b60e242f383440eebe85bd
 2018-07-05 17:03:43 +00:00
dan
b07db116e7 In wal mode, if a "BEGIN EXCLUSIVE" command (or any other command that 
upgrades from no transaction directly to a write transaction) hits an
SQLITE_BUSY_SNAPSHOT error, change the error code to SQLITE_BUSY to indicate
to the caller that the condition may be transient.

FossilOrigin-Name: 221ff63e7902226ebf728bb7442727420636831163708f360724506ce9487ab6
 2018-07-05 15:46:55 +00:00
dan
7fee0bfad2 Test that a race condition can cause a "BEGIN EXCLUSIVE" to return 
SQLITE_BUSY_SNAPSHOT in wal mode.

FossilOrigin-Name: 5a12db75d1da65daa92413a6b5892309e9d9479bb3610764e1015abe5bf28dbe
 2018-07-03 20:17:27 +00:00
dan
d736829e8b Fix a problem in the xInverse callback for the built-in sum() window function. 
FossilOrigin-Name: b6563647382634588ebe5c6a3c35c65a321dc1b3732c809d48ce46759b9dd80f
 2018-07-02 17:45:59 +00:00
dan
f607bec749 Fix a segfault caused by having identical window functions in the select-list 
and ORDER BY clause of a SELECT statement.

FossilOrigin-Name: 693b4350d741391226a33ab6a05eaad61e8ef1590176f01e8aed2a212e2d6419
 2018-07-02 17:14:37 +00:00
dan
6b4b88208e Fix a crash caused by a LIKE pattern that consists of a single escape 
character.

FossilOrigin-Name: bb9bfc3a12dfb89b1c58f5551cdc89ab7b0fbe03f285f2ed86611786ed02ffd9
 2018-07-02 15:03:50 +00:00
dan
7262ca94cb Fix a segfault caused by invoking a regular aggregate as a window-function. 
And some problems with count(*) when used as a window-function.

FossilOrigin-Name: 4f3c8a82fd1c5b14d84f2301e34cfc8d52fe4b3a60840c39e895c11f2da529d9
 2018-07-02 12:07:32 +00:00
drh
9f607e9c23 Quick patch to the Lemon parser template to avoid an array overread reported 
by OSSFuzz.  A proper fix involves enhancements to the table generators in
Lemon to make the overread impossible.  That fix will take longer to
implement.  The current check-in is a stop-gap.

FossilOrigin-Name: 3f6730be4cb712a28401be6d96e56ccb3f2e98dd8961b477befec3f363715178
 2018-07-01 16:05:40 +00:00
dan
d2ac43ea38 Avoid a warning in fts5.c due to not using generated routine 
sqlite3Fts5ParserFallback().

FossilOrigin-Name: 65ff5144a55f1ba2b2ef812a0c988fa2522441177038b8d686eb1d0c558c75d5
 2018-06-30 20:26:52 +00:00
dan
9592320b91 Merge implementation of SQL window functions from the exp-window-functions 
into trunk.

FossilOrigin-Name: 17198a1206e2fbc9e555881468e8c6980b00e25b5b78a6798a6264ca7384f1ca
 2018-06-30 20:15:58 +00:00
dan
2b5f152601 Fix a minor problem in the code for determining whether or not an SQL 
statement is SQLITE_TOOBIG.

FossilOrigin-Name: 763e6c9e2bbc0a6ef8d8361069bf7160790c9064f24f0e336b7ed85668735da9
 2018-06-30 20:00:35 +00:00
dan
5001b3314d Merge all changes from the weak-fallback branch except those related to the 
weak-fallback feature itself.

FossilOrigin-Name: aad718fb1afacf1c921966796ab1e149207c31b16409c5672f0371f4fb9d6565
 2018-06-30 19:12:36 +00:00
dan
6e2210e0a1 Have the tokenizer handle fallback for tokens "OVER" and "FILTER" in the same 
way as it does for "WINDOW".

FossilOrigin-Name: 12d819e1c17d8036900352b0989c4bfcbc34193c3735bb9af7ab051f0f129d3d
 2018-06-30 18:54:56 +00:00
dan
34a7d790ba Further performance related tweaks for sqlite3RunParser(). 
FossilOrigin-Name: 5eb4776598f5bba7ef21a2c58c03105544da73d642d7ffc146f84eff1993d71e
 2018-06-29 20:43:33 +00:00
dan
d437ac0c58 Further tweaks to sqlite3RunParser(). 
FossilOrigin-Name: eef61ffab7fa36b126f57bf7028dd35c67ed4617c47145be059f91e58023b0a4
 2018-06-29 20:21:24 +00:00
dan
769309fcf3 Improve on the previous checkin. Still a bit slow. 
FossilOrigin-Name: c1fb41aa7b7207b81ee1d5d32da3380b36d694033b87a2873981e0c6437ba956
 2018-06-29 19:54:51 +00:00
dan
59ff42516c Instead of using a lemon %fallback directive, have the tokenizer try to figure 
out whether an instance of "WINDOW" should be TK_WINDOW or TK_ID.

FossilOrigin-Name: 022079cb0d67be5ac0a50dd9a4d41ee55ce8df681ecd0a544170d75fc8649978
 2018-06-29 17:44:52 +00:00
dan
04a8e0cd54 Modifications to parse.y to better support backwards compatibility for the 
"window" keyword.

FossilOrigin-Name: 7c4b879bdb10f30260f0fb28fcb559ab0949865d10f4ff2cf13834a326198998
 2018-06-28 20:05:04 +00:00
drh
3773c25f16 Introduce the concept of "weak fallback" in the parser. A weak fallback 
only occurs if a syntax error would result otherwise.

FossilOrigin-Name: c41d7079fb63831bd2f009b64cbf5a423e8119e6b841bfd9bd5a2d85fba3b142
 2018-06-28 03:38:49 +00:00
dan
01e1229063 Add missing VdbeCoverage() and VdbeCoverageNeverTaken() macros to window.c. 
FossilOrigin-Name: 4383cb68a1241768ddb3f180f8cbb9ea1638f8806210b10aac1384b8a7ecdca2
 2018-06-27 20:24:59 +00:00
dan
f02cdd379a Avoid redundant ORDER BY operations when rewriting SELECT statements that 
contain window functions.

FossilOrigin-Name: 336de43a47e206fe7629072e5b8c80d4ede17ead8ef4dcf5d8da6833ff22d2f9
 2018-06-27 19:48:50 +00:00
dan
c994b0225b Merge latest trunk changes. 
FossilOrigin-Name: d9f814b4437eae4c49ba8abec7b58ef9dbb49d4ba8d1c95e08a2e717ef3839ee
 2018-06-26 20:19:44 +00:00
dan
e618dd9b5d Add documentation comment for sqlite3_create_window_function(). And further 
tests.

FossilOrigin-Name: 3f2705b93368f7b0dfd2e03387c3d0b55eddb04940ec83e226e420d8ab10c77f
 2018-06-25 20:34:28 +00:00
dan
867be212bc Fix another problem that could cause a crash when a window function was used 
in a view.

FossilOrigin-Name: e954145a3addf60247954b9161473cd02ae2400f469840523093e25e23fbc54d
 2018-06-25 11:42:08 +00:00
dan
c316307315 Fix problems with using window-functions in correlated sub-queries. 
FossilOrigin-Name: 3e23cfc8133342a4de6813afdc33d726f06d625424b16d0999fb22be51bf8913
 2018-06-23 19:29:56 +00:00
dan
efa3a3c9cc Fix a problem with using LIMIT in window-function queries. 
FossilOrigin-Name: c1abd2dda4154cb573bdf627cdef794d3697f874c3b70357aaf5e4ed95ad1d5c
 2018-06-23 16:26:20 +00:00
dan
ce1037352d Fix a problem with using a window-function SELECT as a FROM clause sub-query 
in some circumstances.

FossilOrigin-Name: 11d733396f75ef1f206cd6f35630ff176484279861772918b9ea69412c13c62d
 2018-06-23 07:59:39 +00:00
dan
67a9b8eded Omit all window-function related code when building with SQLITE_OMIT_WINDOWFUNC. 
FossilOrigin-Name: 5f04b016467342b5a796bf702ed25b621eb86f2961c1e703d276c93f2cb6aa89
 2018-06-22 20:51:35 +00:00
dan
17074e3a9e Merge latest trunk changes. 
FossilOrigin-Name: ebe65b2386a6132f4ef2cce6668a2da7db0798a70d2fba652882d5bccfd6672b
 2018-06-22 17:57:10 +00:00
drh
875ad8ceb1 Improved context for error_log message coming from sqlite3_prepare(). 
FossilOrigin-Name: fea7ade649ae72303078782f7bc510e0a17f082ffde10e769f1aeb1cf37b5554
 2018-06-21 23:53:54 +00:00
dan
b7306f6f6e Fix a problem with handling single row partitions in the percent_rank() window 
function.

FossilOrigin-Name: b84fbf16eac718c151731e2b2dcc73f2f2a144e3670f8566a30793f1e4e6a3ec
 2018-06-21 19:20:39 +00:00
dan
9c27758eb4 Add tests to improve coverage of code in window.c. Fix a problem with "SELECT 
row_number() OVER ()".

FossilOrigin-Name: f41b6b7317e2b5ac5721a3adff49f298ded29f9e0f887af98faeb0cb7e865ab6
 2018-06-20 09:23:49 +00:00
dan
85b9a1c2fb Merge latest trunk changes with this branch. 
FossilOrigin-Name: 6ad0e64b465959c50d4c895c053b15ee7efed11b6427604d2eab88635d9f7319
 2018-06-19 19:15:25 +00:00
dan
cc4644183b Fix a problem caused by a sub-query containing a window function in the FROM 
clause of a query that itself uses a window function.

FossilOrigin-Name: f4b1b6f85b53d72e735a1382f7c3de75af405a7878dd8cdcb10394e859ea3d69
 2018-06-19 18:11:05 +00:00
dan
6fb2b54ceb Fix a problem with using min() or max() as a window function. 
FossilOrigin-Name: 801074ce63d3f4825cc9fa508c42629a9f74e7f9e35c5f238343bb1cff4fbae1
 2018-06-19 17:13:11 +00:00
drh
ca5aa59453 Minor change to the input grammar to make the parser tables slightly smaller. 
FossilOrigin-Name: 320fa69e6aa2a7d67f6444d6c13de9893e27b85c36a933b06da113d753b6aafc
 2018-06-19 11:15:19 +00:00
dan
c95f38d456 Fix problems with using window functions in CREATE VIEW statements. 
FossilOrigin-Name: 943bccd2a6bd4cf3e0534c1fa46885bfa2ba7b780ddcdff9f1ea4cbb3f04e786
 2018-06-18 20:34:43 +00:00
dan
3a6b258ec3 Add test case for the fix in the previous commit. 
FossilOrigin-Name: 39434262d5cf1af197ce0abb1f1ee84ee0797823e290a493c5bf8376fbe287a6
 2018-06-18 20:08:08 +00:00
mistachkin
5bce7d8f6c Fix typo in the 'normalize' extension. 
FossilOrigin-Name: 0c9163ea232d4008105939910565b0d1e533cbb38067d7900dc732b911786d37
 2018-06-18 19:09:30 +00:00
dan
f87e10c75e Ensure that all four callbacks are provided when registering a window function 
(otherwise SQLITE_MISUSE is returned).

FossilOrigin-Name: 5720dcd8b111b1f8712c8fb4b441ccb129e838db8c26a6e9e0f095dc6a851f6b
 2018-06-18 17:36:41 +00:00
dan
660af939b0 Add new API function sqlite3_create_window_function(), for creating new 
aggregate window functions.

FossilOrigin-Name: da03fb4318fd2613ec5c5b109a3974ac1120c19ed16bed4ca85bbdc4b35c998c
 2018-06-18 16:55:22 +00:00
dan
13b08bb6ff Add extra OOM test. 
FossilOrigin-Name: ac251f72608c27c1512a0b3457524f5378a0b13d93d829cf0ed8bc178bc54a73
 2018-06-15 20:46:12 +00:00
dan
6fde1799f8 Fix another problem in lead()/lag(). And some errors that could occur 
following OOM faults.

FossilOrigin-Name: fadd4dc119d8df0d871f4d839b7a11070e2ffb8927e84b3e7a94f34196db3de3
 2018-06-15 19:01:35 +00:00
dan
e0a5e20fa8 Fix a bug in the lead() and lag() window functions causing them to fail when 
used in queries featuring multiple window functions.

FossilOrigin-Name: 3839fb18f917e4f705821198d624b19d84eb07f1ee29ad23314ab7cec6bf6a2b
 2018-06-15 16:10:44 +00:00
dan
303451a8f7 Fix a problem with handling of statements containing two or more different 
windows.

FossilOrigin-Name: 567e09ef2a8cd84a2481117e52595bed0f3b588745a9e441aae0f87680f3a2e8
 2018-06-14 20:52:08 +00:00
dan
9a94722d48 Fix problem with window functions min() and max() when used with a PARTITION 
clause and a frame starting point other than "UNBOUNDED PRECEDING".

FossilOrigin-Name: 43eb1e75a4d7ac0973ed8589bbaf379c24cdc8eacc4e613610d2d4c24d385dc1
 2018-06-14 19:06:36 +00:00
dan
09882a75c4 Merge latest trunk changes into this branch. 
FossilOrigin-Name: 5cf5f1808a51f9c2cfc98dd49b4f1ce860b53e935287f89868ce2fdbace8eb06
 2018-06-14 14:30:51 +00:00
dan
54a9ab3f13 Improve comments and code legibility in new file window.c. 
FossilOrigin-Name: bb915854d435bdd78f141d70e23527e97922ec176acd3ed8060c78dffc96bab8
 2018-06-14 14:27:05 +00:00
dan
13078caac4 Fix problems with "RANGE BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING" window 
frames.

FossilOrigin-Name: c34f31dbd79891249ee9485e91f6ea558ee1db62e04fb0fff2c051612b8fa5e7
 2018-06-13 20:29:38 +00:00
drh
2f1f8801ed Output infinity as 1e999 in the ".dump" command of the command-line shell. 
FossilOrigin-Name: ee431d55eba618cfba414c3946b3162bc205a70dd4e43d74a7623be332b94c92
 2018-06-13 17:19:20 +00:00
drh
4449437b56 Pad out the sqlite3_value structure to be a multiple of 8 bytes. 
FossilOrigin-Name: f76dc33bde4b2180b935d1261492d9535772ed37e54489c1a33e9f11c7c90433
 2018-06-13 16:52:38 +00:00
dan
c5861ce88f Fix some test case numbers in expert1.test. 
FossilOrigin-Name: b90c3c16c04589583d2d1619320bb45a0b012c5960f23bd4e3f9dbe7c84b2eae
 2018-06-13 16:08:22 +00:00
dan
45f318275e Unless SQLITE_OMIT_AUTOINIT is defined, allow sqlite3_vfs_unregister() to be called before sqlite3_initialize(). 
FossilOrigin-Name: ab6c1ae46d992f91ce0995274f48d545eb02ba92544aee89b188f2fc92b66f2a
 2018-06-13 11:41:54 +00:00
dan
466ea9b1e2 Check that malloc() has not already failed when invoking the xUpdate() method 
of a virtual table implementation. This fixes an assert() failure in FTS5 that
could occur following an OOM condition.

FossilOrigin-Name: e9a7e4d58f3716991309ca0e3f080717e473c7c231685954aceee36172f19cf2
 2018-06-13 11:11:13 +00:00
drh
ea74c1db64 Add the unused SQLITE_CANTOPEN_DIRTYWAL result code. This code was used 
in some historical versions on the apple-osx branch but was removed
by check-in [27e20d699872b2b8].  Restore it so that old code that actually
references that result code will still compile.

FossilOrigin-Name: 9f40383eed936a6921ef8dc94775eb55d03a761f36eda7be1b9cdd0a0d30fa80
 2018-06-13 02:20:34 +00:00
dan
c0bb4459d3 Fix another issue to do with window-functions in aggregate queries. 
FossilOrigin-Name: 6413e38a174044c28fa9b8b937e6c972d144547a246e6f2882e782538300d042
 2018-06-12 20:53:38 +00:00
drh
5174f17485 Documentation update: clarify that sqlite3_errcode() and related interfaces 
do not themselves modify the error code.

FossilOrigin-Name: 858fc52b237702b5e0381eebf5c158bffd7371ff0053a8583b8c175f8f691c82
 2018-06-12 19:35:51 +00:00
drh
3086529f7c Documentation updates: clarify the behavior of sqlite3_column and 
sqlite3_value interfaces following an OOM error.

FossilOrigin-Name: 428c581e4bed1d140cfb670633c9c61b36be7bb30a862d2e1ae7eaee26dccb4f
 2018-06-12 19:22:30 +00:00
dan
7392569f5e Fix some problems with using window-functions in aggregate queries. 
FossilOrigin-Name: fe7081e0952950f577234fcbb58f3c1efa4579267654fd2f713dc4804e470e7e
 2018-06-12 18:40:17 +00:00
drh
58773a533c Improvements to SCopy correctness tracking when SQLITE_DEBUG is enabled. 
FossilOrigin-Name: b2973f2357a2c5e22e0d612c970adbc6d51cbc5e4ff7ac6d2b678722e553e8ec
 2018-06-12 13:52:23 +00:00
drh
cd9e01427d Fix the "Synopsis" on the OP_BitNot opcode. 
FossilOrigin-Name: acd78df61188591d33ddb9b1b8c16bcc015f4dffac66314529caa747d4395c70
 2018-06-12 13:16:57 +00:00
drh
dd2a8f5ee9 Improvements to the --enable and --disable options for the 
amalgamation tarball.

FossilOrigin-Name: 02e337e0808947c7ef376b5a300cd3c461f1a368c9fe7ffd7ca5744f102641c2
 2018-06-11 21:33:08 +00:00
dan
2a11bb23eb Clarify the relationship between a Window object and its associated Expr. 
FossilOrigin-Name: 0cd55e98a478740032f5569ddc00fa5b0e063e90db6e00ac7598c9b7c2fffeee
 2018-06-11 20:50:25 +00:00
drh
8fa622d62b Fix various --enable and --disable options on the top-level configure 
script.

FossilOrigin-Name: 6fd7e8ceb96981cff023653a54b85bea0e1da3d706cd9f4383f5c5533213ef4d
 2018-06-11 19:47:14 +00:00
dan
26522d1c45 Fix handling of window frames containing negative number of rows. e.g. "ROWS x 
PRECEDING AND y PRECEDING" where (x<y).

FossilOrigin-Name: b6d9c7eda853420ae46a05bd432711e8bf9ebaa448c7d90ccfc0bcc338a87706
 2018-06-11 18:16:51 +00:00
drh
ea64715976 Fix the column cache invalidation logic in the code for ROWID uniqueness 
constraint checking in the INSERT command.  This fixes ticket
[c2432ef9089ee73bd].

FossilOrigin-Name: 0b485a571c805a5bc431a231a196ff6034342c6548d92b09c52814dd57c89c75
 2018-06-11 18:06:48 +00:00
drh
299bf7c2f0 Add the OP_SetTabCol and OP_VerifyTabCol opcodes, only when compiling with 
SQLITE_DEBUG, to do run-time verification of the column cache.

FossilOrigin-Name: b37614a3670770919a7c7f8157c5fd6578d736447998640b52e5cef8174cadc2
 2018-06-11 17:35:02 +00:00
drh
8d7b212c4c Strengthen the sqlite3VdbeMemAboutToChange() run-time verification mechanism 
to better detect missed calls to AboutToChange().

FossilOrigin-Name: 793e942205a12eedb7ecc5ad8a27e3e52bbd4e1d50a0d1453d04a83ba728884e
 2018-06-11 13:10:45 +00:00
dan
72a9f0233b Fix a typon in main.mk. 
FossilOrigin-Name: e74f86f271d6ab1ecd17c1ee63ab2aa0885ca56624be7382872f04d46c48ed86
 2018-06-11 11:19:35 +00:00
drh
9c3549aa2f Always initialize the WhereClause.hasOr field that was added by check-in 
[292724ffc4].  Error detected by OSSFuzz.

FossilOrigin-Name: 9faf41713e865f26485d9e90918d77c25be211384941eadda6a36237f52c25de
 2018-06-11 01:30:03 +00:00
dan
980cf25b10 Update Makefile.msc to include window.c in the build. 
FossilOrigin-Name: 16db73842ade5eb0fe02f257b91d1c7b41d830d3f17f8638b8fbaed309d9a852
 2018-06-10 07:42:35 +00:00
drh
074544d181 Fix a typo in the amalgamation autoconf file. 
FossilOrigin-Name: de0857f39620b7f5c921ddf8d11b11723b4ba3cfe52e43cf77e883697b7c1c4c
 2018-06-09 20:52:45 +00:00
dan
96f55d0fa5 Merge recent trunk changes with this branch. 
FossilOrigin-Name: c71f23590c25b4cecd27722e6c0fc8e3bf320d399c7d9398b7016dd5cf5b05eb
 2018-06-09 18:09:44 +00:00
dan
d31e7addd6 Update the amalgamation build script to include window.c. 
FossilOrigin-Name: 21d2f4a62eceab0de0b4669bf3e81eb71512211ed710ce0eb525695fb7309d6b
 2018-06-09 17:58:51 +00:00
dan
8b98560d6e Add support for FILTER clause on aggregate window functions. 
FossilOrigin-Name: ceaf798ea09184bc0e7d3dcf3ad4d909d2e4e7018754a8417a813f33010140a7
 2018-06-09 17:43:45 +00:00
drh
4ece2f2657 Slightly smaller and faster code by encapsulating wal-index hash table 
location information in a separate WalHashLoc object rather than passing
around the various elements as separate variables.

FossilOrigin-Name: 538a365b7a32ab7fa84f59d7556242cfb59b76d287b6417eb3a823197a354e8e
 2018-06-09 16:49:00 +00:00
drh
a46ba6cca5 Improved comments an presentation for the recent IN operator decision 
improvement.

FossilOrigin-Name: 31e480f68dfd887cfd9114f9f9fec53d751d3ecc27e36f55c0166b51b2fbb08c
 2018-06-09 14:13:46 +00:00
drh
ccf6db5e64 Performance improvement to sqlite3WhereExprUsage(). 
FossilOrigin-Name: fd0934139076848f2f2edfd3d74d54608531031a05a60ca6ac1d7016dcd538df
 2018-06-09 02:49:11 +00:00
drh
1fe3ac7347 Compute the bitmask of indexed columns for each index once when the Index 
objecct is constructed, instead of recomputing it every time it is needed.

FossilOrigin-Name: d735872ec383bbd220b08c61d25db9ff3675d2542b9e7867e7d6323a12e0cc23
 2018-06-09 01:12:08 +00:00
drh
da230bd484 Avoid invoking the whereLoopAddOr() routine in the query planner if there 
are no OR operators in the WHERE clause, thus speeding up query planning
slightly.

FossilOrigin-Name: 292724ffc4bfca435fff309383d488ffdbe1e314e5eb26da21cf2f621b64bce5
 2018-06-09 00:09:58 +00:00
drh
7128b7c1f4 When the query planner has the opportunity to use an IN operater constraint 
on a term of an index other than the left-most term, use the estimated number
of elements on the right-hand side of the IN operator to determine if makes
sense to use the IN operator with index looks, or to just do a scan over the
range of the table identified by the index terms to the left.   Only do this
if sqlite_stat1 measurements are available as otherwise the performance
estimates will not be accurate enough to discern the best plan.  Bias the
decision slightly in favor of using index lookups on each element of the IN
operator.

FossilOrigin-Name: 2cbbabdf5ef624d809fbb40d2d312a29e0b5f02756fc0dbf6985fc8b0c8d1ade
 2018-06-08 23:23:53 +00:00
drh
6d6decb8d9 Only choose to scan an IN operator rather than use an index if we have 
real STAT1 data to suggest it is advantageous.

FossilOrigin-Name: 30e874661dcc1a2ecb40df2ef74582151d85bb36c754a38548829a3b6285f18d
 2018-06-08 21:21:01 +00:00
dan
e3bf632cc2 Add support for the WINDOW clause. 
FossilOrigin-Name: 19c983b511f1c823fdfb051713681b4c779f02fa83b41189afca0a9b8b72048d
 2018-06-08 20:58:27 +00:00
drh
982c41977c Merge the btreeNext() assertion bug fix from trunk. 
FossilOrigin-Name: 11bd66e09035039fbfc4c5631196962dd3f2e6634f5123a7b2fec17aeaaab07b
 2018-06-08 19:54:07 +00:00
drh
f3cd0c82df Fix an assert() that can be false for a corrupt database and a strange query 
that uses a recursive SQL function to delete content from a corrupt database
file while it is being queried.

FossilOrigin-Name: 99057383acc8f92093530e216c621d40386a06fe98131ff0af6df524d80a6410
 2018-06-08 19:13:57 +00:00
drh
da4c409aea Consider doing a partial table scan to fulfill an IN operator rather 
than using an index.  Try to pick the plan with the lowest cost.

FossilOrigin-Name: 1fa40a78fef4516c39b217bff67efe7e7d2077cca00aae0ef5c2c9cff94f008b
 2018-06-08 18:22:10 +00:00
dan
dacf1de95c Do not flatten sub-queries that contain window functions. 
FossilOrigin-Name: 236cb75bd1f0d5eb86aa5f52d8d548e7263c34633833dcea9dfc934f142113b8
 2018-06-08 16:11:55 +00:00
dan
03854d2ecc Fixes to allow group_concat() to be used as a window function. 
FossilOrigin-Name: 89bbc9ba8f66853a7530453f146c9df1baacd8558468016cefa7602911f7578a
 2018-06-08 11:45:28 +00:00
dan
07509f8c1e Merge latest trunk changes with this branch. 
FossilOrigin-Name: 251022034219819a1dc356542770ff46e3147a080f072eb20af6106771dadd92
 2018-06-07 20:35:28 +00:00
dan
fe4e25a0f6 Add window functions lag() and lead(). 
FossilOrigin-Name: ef34207073c21ce8618486777671ae78d23f290acd6d3c37e91a49b69cb506ac
 2018-06-07 20:08:59 +00:00
drh
83193d0133 The IN-early-out optimization: When doing a look-up on a multi-column index 
and an IN operator is used on a column other than the left-most column, then
if no rows match against the first IN value, check to make sure there exist
rows that match the columns to the right before continuing with the next IN
value.

FossilOrigin-Name: 09fffbdf9f2f6ce31a22d5a6df7a45f19a16628da622f12d6e33171cce09fb21
 2018-06-07 18:13:49 +00:00
drh
cf025a8c18 Fix the assert()s in the byte-code engine that prove that cursors 
are unidirectional.

FossilOrigin-Name: 4b0b4e14039469b656662312a5f80f086ede293e9ad04c7bc99a202b683a1e55
 2018-06-07 18:01:21 +00:00
dan
7095c002b8 Add support for window function first_value(). 
FossilOrigin-Name: 060b26402880daab085ad01f5f0dbde957c7a22cd219be5b8ec94fba883051a0
 2018-06-07 17:45:22 +00:00
drh
f1949b6634 Remove the NextIfOpen and PrevIfOpen opcodes which are no longer needed 
when the IN-early-out optimization is working.

FossilOrigin-Name: 439c8162272795b422a0e01b01b832fbc12b39914c9632a674162af8bdecff98
 2018-06-07 17:32:59 +00:00
drh
056f5396fe Test cases. 
FossilOrigin-Name: 085e863713a3f2d420c0076b275a6ac445a59d4d93f9eb0e8503b4e3f5589249
 2018-06-07 16:07:00 +00:00
dan
2e60568fef Fix problems with the nth_value() function. 
FossilOrigin-Name: 63002b9a090397668b94fe341a035c42f84e4837af85395bce4cd1c2777c5209
 2018-06-07 15:54:26 +00:00
drh
64c1f77a8e Merge the ".stat/.eqp" CLI fix from trunk. 
FossilOrigin-Name: a91cad3381bb843d6f58975251bf99f0fa1a1398fae53d97a98a6c8ee65e718e
 2018-06-07 15:28:40 +00:00
drh
3c49eaf4be Avoid using a prepared statement for ".stats on" after it has been closed 
by the ".eqp full" logic.  Fix for ticket [7be932dfa60a8a6b3b26bcf76].

FossilOrigin-Name: bb87c054b1b76959e46258ac66b24027f468b390a4148ac67f208a1fbeda4060
 2018-06-07 15:23:43 +00:00
drh
f7b0a5f3c3 Add the WHERE_IN_EARLYOUT flag and use it to clarify the logic of this 
optimization.

FossilOrigin-Name: 522f1eacc20f11002cad58232a7c2610f369568653510e54f46088f579f778dc
 2018-06-07 14:59:22 +00:00
drh
bd573c459b Merge recent trunk enhancements. 
FossilOrigin-Name: e9d7bf4f7b9d6f8dabc4c95d43ebf12f2149bed1c5e750048b1b684128073c38
 2018-06-07 14:32:16 +00:00
drh
df12595c09 Change a comma into a logically equivalent but semantically clearer semicolon. 
FossilOrigin-Name: 71f97f0f82b3abfb07feb78d64a182fc50ff396e85d6f5aac479dbf58ba4d00a
 2018-06-06 23:31:26 +00:00
drh
6eb3480bd7 More space and performance enhancements to sqlite3VdbeRecordCompare(). 
FossilOrigin-Name: 83a60ff056a63f18479030e9dfb10926fbb0d906d51f2cf88233098e15c75534
 2018-06-06 20:55:10 +00:00
dan
ec891fd40c Add implementation of nth_value() window function. 
FossilOrigin-Name: eb1fb420ac70857e7ca4cbad78be15a27bee8f915ba2da080c7efa1879c06c31
 2018-06-06 20:51:02 +00:00
drh
d882108a01 Small performance optimization in sqlite3VdbeRecordCompareWithSkip() for 
the common case where the comparison is equal.

FossilOrigin-Name: 1e616e256a4fb1b64271706fdfa77dc5790eba0a2f0e619544e169bc61d7c805
 2018-06-06 20:29:19 +00:00
drh
4011c44322 Rearrange the order of some checks in the integrity_check pragma for a very 
slight performance gain.

FossilOrigin-Name: 4b853f020570bf4af1b14e03f35764c7d7a03a40af58efc783e06f2b883cef78
 2018-06-06 19:48:19 +00:00
drh
685a50ad74 Fix the sqlite3BeginTrans() calls within the snapshot extension. 
FossilOrigin-Name: 1fef7ad25b6a8e59163ac57f5cf0412bfc5b0e9446fd782f5f0a7d7ee11741fc
 2018-06-06 18:50:50 +00:00
drh
397776a823 Another minor optimization to OP_Transaction. 
FossilOrigin-Name: d80077aee3904e5d93164b342cae14d813de8e84e567462412751e06c7487d41
 2018-06-06 17:45:51 +00:00
drh
bb2d9b1bf1 Change sqlite3BtreeBeginTrans() to return the BTREE_SCHEMA_COOKIE, for a 
small speed improvement when starting new transactions.

FossilOrigin-Name: a10662aa915ae2b5a78b3e10920350d32255b2d6b1a8aac0aba1ad173b07ed2b
 2018-06-06 16:28:40 +00:00
drh
0cfd46a1ad Fix the ".archive" command in the CLI (and the corresponding -A command-line 
option) so that it silently ignores filenames that contain "../" in their
names.  This prevents the "Zip Slip" attack.

FossilOrigin-Name: 27291f2d7fd4dadf2ee9b9a7d1373158cadfbaf83c3654b00d7030dc921770c6
 2018-06-06 01:18:01 +00:00
drh
bb777d517d Update the version number to 3.25.0 for the next development cycle. 
FossilOrigin-Name: 7598236c356cdb548c6188d69dfef99f7a08b89e512a3addfe1433ccd85e7b68
 2018-06-05 23:51:52 +00:00
drh
48baed4f77 Avoid unnecessary loads of columns in an aggregate query that are not 
within an aggregate function and that are not part of the GROUP BY clause.

FossilOrigin-Name: e15e100660d290249ef235e7a8927b88296e56ec0f80ec626eecbd542adc7633
 2018-06-05 23:21:11 +00:00
drh
8c2b6d784b Add the OP_IfNoHope and OP_SeekHit opcodes used to reduce the number of 
unnecessary sqlite3BtreeMovetoUnpacked() calls when checking for an early
exit on IN-operator loops.  Futher optimizations are likely possible here.

FossilOrigin-Name: 6bf251af4347165a470d39457d61ab6d2a06c206db8f30bd8be5dbb388ae8a5b
 2018-06-05 20:45:20 +00:00
dan
280c894b74 Calculate non-aggregate expressions in the SELECT list of an aggregate query 
that does not use min() or max() once per group, instead of once per row
visited.

FossilOrigin-Name: dce2dfbe1590deb3ef5661230ae2d232bd492441195defbf698ac56f9629211c
 2018-06-05 20:04:28 +00:00
dan
1c5ed624a0 Add implementation of last_value() window function. 
FossilOrigin-Name: 2493ce1a402888f6a8f25e03052c25a4e9bca740639e98cb614f5e5160ac25d3
 2018-06-05 16:16:17 +00:00
drh
86d0ea7558 Use an OP_NotFound opcode to cancel futile IN operators early. The current 
implementation is suboptimal because it always runs teh OP_NotFound.  This
still needs to be enhanced to only do the OP_NotFound if no results have been
seen on the current loop.

FossilOrigin-Name: 87a9fc504f9a78caf7a7949cc7ada0a19d61bfab51bb49a00a1607194c116212
 2018-06-05 15:16:25 +00:00
drh
995bbbf993 Merge trunk changes. 
FossilOrigin-Name: 047295c588e9fdf2ffa4e69e166f177fd193309531dc6a9ac755fb7a763adb72
 2018-06-05 13:54:06 +00:00
drh
8e9deb61af Update and correct the documentation on the OP_OpenRead, OP_OpenWrite, 
and OP_ReopenIdx opcodes.  No code changes other than the addition of
an assert().

FossilOrigin-Name: 8a0b730d0ea640d5cf75febe39b2162411a12eb5275765a85882158b5a085681
 2018-06-05 13:43:02 +00:00
drh
00583291bd Version 3.24.0 
FossilOrigin-Name: c7ee0833225bfd8c5ec2f9bf62b97c4e04d03bd9566366d5221ac8fb199a87ca
 2018-06-04 19:24:41 +00:00