mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,705 Commits 1,487 Branches 166 Tags 416 MiB
a7d6db6ac0
Commit Graph

7479 Commits

Author SHA1 Message Date
dan
fbf6136c78 Do not attempt to test the shell ".trace" command in SQLITE_OMIT_TRACE builds. 
FossilOrigin-Name: 3839e9098107604e1526c2b1e813c019607077dfe39d7eeb92f3466518dec3b1
 2019-02-06 13:48:04 +00:00
drh
4acd754c79 If the query flattener detects an error, cause the SELECT code generator 
to abort immediately.

FossilOrigin-Name: 3d3b142f1045080beb775a9cfe88ec143aa460750132e20059fd510291449850
 2019-02-06 00:55:47 +00:00
dan
dee9be9b3b Update the tester.tcl --malloctrace option so that it uses eu-addr2line instead of addr2line. 
FossilOrigin-Name: 79c073878d56fc638b751b0e61295df182f7ee6f8ebd7319c1eeac1608abbac8
 2019-02-05 16:53:26 +00:00
drh
d57936721b The IS NOT NULL operator does not imply that the operand is never NULL. 
Fix for ticket [5948e09b8c415bc45da5cf]

FossilOrigin-Name: d840e9bb023a1e84a7739d764a0f6cf608fc3183ff8c366fcdb486ebd932f0c1
 2019-02-05 14:36:33 +00:00
dan
41e0717bcb Update test file "resetdb.test" so that it works with the "prepare" permutation. 
FossilOrigin-Name: 95d338124be2e0e18f17354b28f4320336202f1a4ec1177df753b2800e954bfb
 2019-02-05 08:55:43 +00:00
drh
a790882d63 Add the -memtrace option to dbfuzz2. 
FossilOrigin-Name: 67fecbc79d3e927a7e22f3589be3184114322635874e4b3170666e352d0bfe9d
 2019-02-04 19:50:44 +00:00
drh
88862d49a6 Enhance dbfuzz2 so that with the -v option it shows the return code and 
error message for any failing SQL statements.

FossilOrigin-Name: 3a127ef9f7feafe6ba8c75e4eb29e28aa61a30249082cc8767ada1ec0cc0b7f1
 2019-02-04 19:45:26 +00:00
dan
4fc4ba771c Do not run shmlock.test as part of the inmemory_journal permutation. 
FossilOrigin-Name: d3fea69cbb071867a90ad56ca05123ebf8e44689a92577a525a883c176c791bd
 2019-02-04 16:42:57 +00:00
drh
e2d2ad6ece Update the test/fuzzdata8.db database with new interesting cases from 
dbsqlfuzz.

FossilOrigin-Name: e467e4c8fa256ddd6c26c1f21bc26289a21f18b781737eaf706bc813ed8234fa
 2019-02-04 16:36:24 +00:00
dan
41fc545147 Fix an assertion failure in fts3 triggered by a corrupt database. 
FossilOrigin-Name: 560ebd4269fad07b8e988d070454017123593eb6762597d08e8c32d7b4fb92ac
 2019-02-03 07:46:07 +00:00
drh
150edadf58 New testcase added to test/fuzzdata8.db. 
FossilOrigin-Name: 2f5c1925b94d85489533549c58191feb1d803ad9d58b43f47fef42b72c531a38
 2019-02-02 18:24:28 +00:00
drh
38a28a7434 New test cases added to test/fuzzdata8.db. 
FossilOrigin-Name: e5924939c9c8f39367900360fa294cdb1220e9f68d183e32882e0926f775869d
 2019-02-01 14:54:18 +00:00
drh
8bf4126c84 Change the error message slightly for when two or more indexes have the 
same rootpage.

FossilOrigin-Name: 916c52dad414b224695d455a42af36f85dff216504c2aa67d1d2c5818cdca8d6
 2019-01-30 19:50:07 +00:00
dan
da7a4c0f7a When parsing the schema, check for duplicate index root page numbers before adding the index to the schema hash table. 
FossilOrigin-Name: 6b360bc0b9ad18ccda9d58d43a8388d19999432bfdf294abcf5beb44ef990cb4
 2019-01-30 19:12:13 +00:00
dan
56b99ebc32 Add test case for the previous commit. 
FossilOrigin-Name: 197edb235b785c68fda7be788efbc61137d9452886599415a927b959ade93c65
 2019-01-30 18:47:35 +00:00
drh
4551005332 Load all the latest dbsqlfuzz finds into test/fuzzdata8.db. 
FossilOrigin-Name: e744d2dd93a78235e6c1d938b08232183b5ce7e355d1b7daf2199e585b03c106
 2019-01-29 16:47:46 +00:00
drh
a046643820 More robust handling of corrupt database file in the rebalance operation of 
the btree logic.

FossilOrigin-Name: 97704cb7d29fa7cc4ea9a6761a7844c1946d637ea2b22d287fc787ae0f63c407
 2019-01-29 16:41:13 +00:00
drh
4a7e9a25b6 Set a low limit on the length of strings and blobs in the OSSFuzz module, 
in an effort to avoid timeouts when the fuzzer does things like
"randomblob(1e12)".

FossilOrigin-Name: 119d1609fa415894fdd0aa19440ca1c658bd01910838a4cfadbe0e304b033bfd
 2019-01-29 02:37:22 +00:00
dan
95d5a88058 Make indexes on CAST(...) expressions work. 
FossilOrigin-Name: 3ef711d98fb239cf24472f124e7b36b0dde33355de5a2c9a3a978bbdd042a735
 2019-01-28 18:08:59 +00:00
dan
c7def600bd Fix a buffer overread in fts3 that could occur when accessing a corrupt database. 
FossilOrigin-Name: a9faf9033910927c74553e66c474d84ed3386f263cef3eec299e25d8306f410d
 2019-01-28 16:50:42 +00:00
dan
6c43dbad98 Do not assume that text parameters passed to fts4aux queries do not contain embedded nul characters. 
FossilOrigin-Name: df04859a995571cd6faf1abe088725708f35e81195760274df9e2ec9bd47f69f
 2019-01-28 13:27:25 +00:00
drh
9e35a61e59 Add a new test case to fuzzdata8.db. 
FossilOrigin-Name: ce8e279a7d37594e865c2d9197a5efe5d647e11f074dbaf4a4ee31c74c71dbc9
 2019-01-28 11:54:13 +00:00
drh
05d49d1442 New test cases form dbsqlfuzz 
FossilOrigin-Name: 9cf8ebd141aa2eb661d457624c76433bd9e4abfdef04aa52e28bc169172c2c8f
 2019-01-27 02:45:32 +00:00
drh
e5da9356e0 Update fuzzcheck so that with the --load-dbsql options it screens its 
inputs to ensure that they are valid dbsqlfuzz cases.  Add new dbsqlfuzz
finds to the test/fuzzdata8.db database.

FossilOrigin-Name: 004f7d9bbeee049c22a7e1c82c6cc0ea79a237967de3ff57686acea3060d5f45
 2019-01-27 01:11:40 +00:00
dan
32bb700a95 Fix a broken assert() in fts3. Also some test script issues causing failures with builds that do not support fts3. 
FossilOrigin-Name: d59567dda231e7ffec437d5e055676cf42d791196406cdc696cafa2583eb483b
 2019-01-26 21:05:54 +00:00
drh
0814acd981 Do not accidently truncate zeroblob values when doing an arithmetic 
operation.  Fix for ticket [bb4bdb9f7f654b0bb9f34cfba].

FossilOrigin-Name: 13f6942eb0da2d92a0830f18640ce64208bd0cd6ff6d0c97e4a4c57ac3d65ba6
 2019-01-25 20:09:04 +00:00
drh
ed457037c4 Fix harmless compiler warnings in fuzzcheck 
FossilOrigin-Name: a82539665718c8183d9d0bb7bcb3adcb1a23294b8c30f364829a982dab89a332
 2019-01-25 17:51:06 +00:00
dan
c2ea77e5b2 Fix a segfault that could follow an OOM when querying a table that has one or more columns with default values "true" or "false". 
FossilOrigin-Name: 202f9919c222ee933924c63c15ad36ec4481457b1e4d9179af14c9f284117c0c
 2019-01-25 17:26:59 +00:00
dan
c1f6618217 Add an assert_fts3_nc() macro to fts3 - for assert() conditions that are only true when it is guaranteed that the fts3 database is not corrupt. 
FossilOrigin-Name: 3498908cd7f3d0e35b70796537124e3da0bd99d48750ba51bcb9eba87e28ed4d
 2019-01-25 14:48:18 +00:00
drh
31ab7d8e5c Extend fuzzcheck so that it can process dbsqlfuzz cases. Add a collection 
of interesting dbsqlfuzz cases to the standard test suite.

FossilOrigin-Name: e2991a7ecf5dd241c4bab7c7cadc4901043fb0c3ea1fac70b684f6d8332677f1
 2019-01-25 14:23:36 +00:00
dan
ba14c69b4f Fix a couple of assert() statments in btree.c that could fail with corrupt databases. 
FossilOrigin-Name: 5eb5e8289fa71e5e29e081d33d4a59c64b463bf6b06d7070c05c46d77d808ad4
 2019-01-25 13:42:12 +00:00
drh
725a9c7f6c In fuzzcheck, activate vdbe_debug for dbsqlfuzz cases when using the -vvvvv 
verbosity level or above.

FossilOrigin-Name: 2e6f7c2aced49824a38b3494b796a8ec73aa7a90b51159f670596df15ed1c5ab
 2019-01-25 13:03:38 +00:00
drh
df21659a40 Improved automatic detection of dbsqlfuzz cases in fuzzcheck. 
FossilOrigin-Name: 1ef24e89c9630fd383ba32f5aefcf9c27907f27f5072f3537a1cfd75a093a8d7
 2019-01-25 04:43:26 +00:00
drh
a47e709e89 Add the ability to process dbsqlfuzz cases in fuzzcheck and add an initial 
set of interesting dbsqlfuzz cases.

FossilOrigin-Name: fb9074ff450a67feaa62ca61d19154de26d5c8a8d147409ee6d1fbd667b2914f
 2019-01-25 04:00:14 +00:00
dan
813ed78054 Fix a buffer overread in fts3 that could occur in a prefix query on a corrupted database. 
FossilOrigin-Name: d0d5689371577b2861d4a9464443d055f3256f3f51d89e0388233a4cbe2601ee
 2019-01-24 17:41:12 +00:00
dan
f467744d5f Fix a problem with running ALTER TABLE on a schema that contains expressions of the type "col IN ()" (empty set on RHS of IN operator). 
FossilOrigin-Name: 2d9cd06715092c312c8c0ec392696a0e90ed090b074e2082e0b830f1399aa941
 2019-01-24 16:27:10 +00:00
dan
b0c4c94996 Fix a potential problem with "INSERT INTO ... SELECT * FROM" (or VACUUM) statements on a corrupted database. 
FossilOrigin-Name: db4b4c2c1e9f1adacfb1b2fedb717a4d8bb0a299c3b11835404a99fcd67bf24b
 2019-01-24 15:16:17 +00:00
drh
55469bbafb Use memmove() instead of memcpy() in a place where buffers might overlap 
if the database file is badly corrupted, to prevent warnings
from ASAN and valgrind.

FossilOrigin-Name: 65ad6c55f1ba9bc2f75afffa3adaf19f145fad7ac9a00ccce6372e9a2cc4341b
 2019-01-24 13:36:47 +00:00
dan
b4738ddb20 Fix an assert() in vdbemem.c that could fire if the database was corrupt. 
FossilOrigin-Name: a70958cd7d5cf750c293537856918e5789013b70f6a827f724d83559b38629c8
 2019-01-23 20:31:56 +00:00
dan
a5f9f42a0e Fix a problem with renaming a table within a schema that contains a composite query that uses a column alias as an ORDER BY term. 
FossilOrigin-Name: 2ca6b8f84ec07e313aa4e1c0894827401b418dcc4221e9c54c384f1c3893952a
 2019-01-23 19:50:46 +00:00
dan
d99950310f Fix problems with sub-selects in WINDOW definitions. Also rename-column operations when the column being renamed appears in a WINDOW definition that is part of a VIEW or TRIGGER. 
FossilOrigin-Name: 0387cb3add992b2028efe4f2100188d8f9fdfdcb233329857aa4b46a293cfc97
 2019-01-23 16:59:24 +00:00
dan
8e4fe01dda Do not run shmlock.test as part of the journaltest permutation. 
FossilOrigin-Name: 5b7d0c784e6467154d9549af0163d788b69d5e5a6478a735834cdea945e7dbb7
 2019-01-22 20:18:29 +00:00
drh
178edcd774 Update dbfuzz2 to set a maximum database size of 100MiB by default, but 
with the new --max-db-size N option to change that limit.

FossilOrigin-Name: 21d6bb78ef2979d011b917d2d6519d7cd0009fcad83ed23ab2e9a5e02d8e51ab
 2019-01-22 16:11:31 +00:00
drh
6ca644818b Enhancements to deserialize: (1) Add the SQLITE_FCNTL_SIZE_LIMIT file control 
to set a maximum size for an in-memory database, defaulting to 
SQLITE_MEMDB_DEFAULT_MAXSIZE or 1GiB.  (2) Honor the SQLITE_DESERIALIZE_READONLY
flag. (3) Enhance the TCL interface to support -maxsize N and -readonly BOOLEAN.
(4) Add the --maxsize option to the ".open" command and on the command-line for
the CLI.

FossilOrigin-Name: 30f08d58882819a69e353bcc1b6b349664bbfbe00aa1c115ba44a9fd899fcc5b
 2019-01-22 16:06:20 +00:00
drh
247c1b4a0b Make sure cursors are opened on all indexes for an UPDATE OR REPLACE 
regardless of whether or not the indexes are partial or contain columns
that might need to be updated.

FossilOrigin-Name: e148cdad35520e6684cfeba23b003f60b55f83a6bf621aff16be8aa5612cdcee
 2019-01-22 13:45:48 +00:00
dan
2c7a73eaea Fix another segfault caused by a corrupt fts3 database. 
FossilOrigin-Name: ba3b8412726548a0716c1a2d67260c3b7e31956474f4cd4ce607cf2cebc667dd
 2019-01-22 12:21:28 +00:00
dan
129371553c Avoid deferencing a freed pointer following an OOM or SQLITE_CORRUPT error in 
the fts3 xDestroy method.

FossilOrigin-Name: 505ed9a47825240979338a24044559613fbbd2a7850bdff70c7164da054ec63d
 2019-01-21 17:57:31 +00:00
dan
ac30553f76 Remove a faulty assert() from fts3. 
FossilOrigin-Name: 6c33a303ebbb0f5193ead535280ba63118e14fb4f9977ce80dc716a0b082ec99
 2019-01-21 16:12:20 +00:00
drh
7c04c69204 Minor fix the fallocate.test module change from [7cd56cad5efead5] 
FossilOrigin-Name: 94fb7a47003c3c1a52e833e98d27399cfec5382afde2b3990e8223c8bff7cfa0
 2019-01-21 14:49:14 +00:00
drh
5976552a72 Add the --max-data and --max-as options to dbfuzz2. Also cause dbfuzz2 to 
show its maximum RSS size upon exit in standalone mode with the -v option.

FossilOrigin-Name: 7ce93e824a954d1e0cf8d7343e59a2660175f42bd4dac02aed8ad77644e7eb2f
 2019-01-21 13:47:55 +00:00
drh
8ed07d1274 Add the --max-stack option to dbfuzz2. 
FossilOrigin-Name: c11ae4fed89484f0a0061002861b5d599bbda8e40a1f0c33fdbe8cb072134d5c
 2019-01-20 00:03:59 +00:00
dan
b8852ae083 Remove a broken assert() triggered by a "PRAGMA max_page_count = N" 
invocation, where N is larger than the number of pages in the database image,
but smaller than the number of pages in the database file.

FossilOrigin-Name: 7cd56cad5efead5097e9918c87313bb46e583fe62bae0df1be60e10117e2c3cb
 2019-01-19 15:27:09 +00:00
dan
93b6c1666d Fix a problem with using ALTER TABLE to rename a table or column when the 
database schema contains a trigger or view that itself contains an expression
 "<column> AND 0".

FossilOrigin-Name: 908ff7fffa302255a74e2334ca3a1779ed43acb0268fce5a83a56fd16794dc88
 2019-01-19 14:07:37 +00:00
dan
a86b20820d Fix an infinite loop caused by a corrupt database in fts3. Also an undefined 
left-shift in fts5.

FossilOrigin-Name: 55c5d72af9510e2f27c33544d804a58d4282b0efb384ead38484129ce91b574f
 2019-01-18 21:03:15 +00:00
dan
451297752c Fix problems causing undefined left-shift operations in the fts3 snippet() 
function.

FossilOrigin-Name: b90dbaed3092236e97f9796fa63989a3648060e16189e1267c430f4a7e799fac
 2019-01-18 19:26:48 +00:00
dan
0e14e98706 Fix a fairly obscure problem allowing an "ALTER TABLE RENAME col TO ..." statement to modify the schema in such a way as to break a reference within a trigger program. 
FossilOrigin-Name: 64bec9e6214c6932fab5a3fb8c569ae14cd2d603bd0f8b26104815c3bb9d396a
 2019-01-18 16:06:18 +00:00
drh
29c992cb04 Revamp the SrcList allocator routines to be methods of Parse instead of 
being methods of the "sqlite3" object, so that they can leave better error
messages when the SrcList object grows too large.

FossilOrigin-Name: df08d472b090b212fb77ce2aae0e1ffe79ae5db4b1accf55e6fdb18e8b0a7098
 2019-01-17 15:40:41 +00:00
drh
0ad7aa8182 Limit the size of SrcList objects to 200 entries (compile-time configurable 
using -DSQLITE_MAX_SRCLIST=n).  The maximum number of tables in a join has
always been 64, so this is not a real constraint on capability.  Limiting the
size of a SrcList prevents DOS attacks (discovered by OSSFuzz) using crazy
nexted CTE joins.

FossilOrigin-Name: 7cac614d5df55eb092b863163483b6782b942b21bd15fd787576fef5619fa849
 2019-01-17 14:34:46 +00:00
drh
04fcef00ee Fix a corner-case for the logic that cause an insert of a NULL into an 
INTEGER PRIMARY KEY column to be converted into a valid integer key,
when the NULL results from a CASE expression that lacks an ELSE clause.

FossilOrigin-Name: 9a425051e7ba59e797636f5cf32b5f6efafdb21c8d5300e099b8008b829c1439
 2019-01-17 04:40:04 +00:00
dan
8b20e4a3eb Fix a problem with fix [b4b57413]. 
FossilOrigin-Name: ca7b7aaed010ec67bec5355a9ac1d7f229d6d5f2ba2d796b76f5e908b1267688
 2019-01-16 20:48:13 +00:00
dan
e011ee2830 Fix a problem in the fts3 matchinfo() function with corrupt database handling. 
FossilOrigin-Name: 24ed5fb6aea30b098d2faf3cf9d638933e518657217e903239ffaa1e25d34f66
 2019-01-16 19:44:09 +00:00
drh
375afb8bda Fix a problem in the code generator for sorting results with SRT_EphemTab 
and a LIMIT clause.

FossilOrigin-Name: 49fcde2f1f981ac0c75728bed3444e7c1d3167311db282d3375c96ce090b2210
 2019-01-16 19:26:31 +00:00
dan
5e970a8f40 Fix a problem with renaming a column that is used as part of an ORDER BY on a 
compound SELECT within a database view or trigger.

FossilOrigin-Name: b4b5741366578b25ec6e4c415ab8239215e53b1c900be613575f40a826cfccc9
 2019-01-16 14:58:37 +00:00
dan
fb8ac325d7 Avoid a dangling pointer comparison when renaming a table that has a trigger 
that itself contains a window function with an (illegal) column reference in a
FOLLOWING expression.

FossilOrigin-Name: d45bee36f2c1091a2d32c16ca8921bf4e7c9e40c46d0a36fbcb179ecfafcfbf0
 2019-01-16 12:05:22 +00:00
dan
4ccb41fc99 Fix a memory leak that could occur in fts3 when handling a corrupt database. 
FossilOrigin-Name: 65cebb06a0afcbcb4157c3d518a62ed188b1e90d9e9b69d88fece484bcb6e380
 2019-01-16 11:38:06 +00:00
dan
dfb5c963a0 Fix a problem with ALTER TABLE and vector assignments in UPDATE statements 
within triggers.

FossilOrigin-Name: cc6cd7531fee39b4c2a9f522f1089c1d79254a9e25acae59468322031f94c25a
 2019-01-15 20:51:35 +00:00
dan
a783931794 Fix a buffer overread in fts3 caused by a corrupt record. 
FossilOrigin-Name: e54efd60c20bbfc5d70ddb9e1dd6ffb68cbbcfa57b4f07cb104767ef08c1a559
 2019-01-15 16:14:31 +00:00
dan
9c039d9f2e Add scalar function "prefix_length()" to ext/misc/prefixes.c. 
FossilOrigin-Name: 0bf1550507d9d3c8a41f8a50db3a59bf808f0a4e24637dc0905d35579305eca7
 2019-01-14 20:44:00 +00:00
dan
9274ad898f Fix a problem causing some Tcl test cases to fail with errors like "expected: [<multiline-whitespace>], got: []". 
FossilOrigin-Name: 11b8a4cba747ca214fe3506caa3b711c87be4d55412754e673cc0603afefb086
 2019-01-14 19:13:30 +00:00
dan
94ec92a1f7 Fix a problem with querying a corrupt fts3 database. 
FossilOrigin-Name: 65e50706a017751d72d0f9c7f575955194977decd0acf13aaca90c3cb925f20e
 2019-01-14 15:09:00 +00:00
dan
68c1f9ce9a Have fts3 ignore empty sets of parenthesis if built with 
SQLITE_ENABLE_FTS3_PARENTHESIS.

FossilOrigin-Name: c93c6b45a317c40eb5c0abb6620d21f5821a601632c791e11e5ce62e039eccda
 2019-01-14 11:56:13 +00:00
drh
b10a50e7f8 In dbfuzz2, avoid using a malloc in the LLVMFuzzerInitialize() initializer 
routine, so that no memory leaks are reported.  Also, show the version of
SQLite being used when the -v option is on.

FossilOrigin-Name: 824f93246988ffa213bbd41a7de08886999b1a8ae00fdf6b9767acb6e3ec6a1f
 2019-01-13 20:23:34 +00:00
dan
b4439eef10 Fix a problem with corrupt database handling in the fts3 matchinfo() function. 
FossilOrigin-Name: 703646b1b5c84d550fe0d74e399c0eeb729da1d263e4693320f69e6509678985
 2019-01-12 14:58:35 +00:00
drh
a2dc7494ef Indicate that the database may be corrupt in the fts3corrupt4.test test script. 
FossilOrigin-Name: 473626d5579dd19023abccaf7c1822ac0c883a0b98904837ea096fa16e4f41c4
 2019-01-12 00:07:48 +00:00
dan
90294961da Fix a segfault in fts3 prompted by a corrupted database. 
FossilOrigin-Name: 2d7b1d1d41ff69d5465fcb861420816ecb066c25a9015eefdab5fae15a2e1c9f
 2019-01-11 21:34:25 +00:00
dan
e6370e9c29 Fix a problem handling a negative value in the "number-of-pages" database 
header field. Also a problem with running "REINDEX tbl" against a virtual
table for which the SQL passed to sqlite3_declare_vtab() contains PRIMARY KEY
or UNIQUE constraints.

FossilOrigin-Name: 556dd8922f65af93084ee725c638b8dc696b611dd508c212a3b507d6ca474031
 2019-01-11 17:41:23 +00:00
drh
2a58dbde30 Improved detection of cell corruption in sqlite3VdbeRecordCompareWithSkip(). 
FossilOrigin-Name: fa47f4c6589c431cf678560ac33dea6b695052012bea2096b2c92869ed51c688
 2019-01-11 16:44:16 +00:00
drh
1972c8cf07 Add the --vdbe-debug command-line option to dbfuzz2. 
FossilOrigin-Name: 599b4df43c64ce295517c804b6bb4c3ab77d77e0ba585dc0657274f55489a3b1
 2019-01-11 14:38:47 +00:00
drh
26391eeefe Add the "dbfuzz2" target to main.mk. Remove an unused local variable 
from dbfuzz2.c.

FossilOrigin-Name: 05c7609cfd02f49114876267d7090f4e0ea2467f3aa7c65019c5986ec8f60a87
 2019-01-11 14:22:33 +00:00
drh
e65b9c6a5e Separate makefile targets for "dbfuzz2", "dbfuzz2-asan", and "dbfuzz2-msan". 
FossilOrigin-Name: ea119641a7edcd0e1ec14371d93e35f860971888bd98cb0019253358a2ef123b
 2019-01-11 13:03:06 +00:00
drh
69ab18d213 More aggressive early detection of orphaned and malformed autoindexes when 
parsing the schema.

FossilOrigin-Name: 10f9e39d6ed2413fa9abc6c82da3ed48f32a42b6190b6219fca7faf850d05113
 2019-01-10 14:33:15 +00:00
drh
5f913ecb62 Use the new SQLITE_IDXTYPE_IPK values (3) on Index.idxType to indicate the 
fake INTEGER PRIMARY KEY index used during query planning.

FossilOrigin-Name: e22d2f905fe840bea51b536ebedc9b637190ea0a37f16559668d99a61e971411
 2019-01-10 13:56:08 +00:00
drh
885eeb676b Enhance the ALTER TABLE RENAME COLUMN feature so that it works on tables 
that have redundant UNIQUE and/or PRIMARY KEY constraints.
Fix for ticket [bc8d94f0fbd633fd9a051e3]

FossilOrigin-Name: f09aa3248e2b4a32ff5b5d37084cb2a27445322cb06a3354cef723f4f0b2cd34
 2019-01-09 02:02:24 +00:00
drh
b042d92128 Give a meaningful error on an attempt to use UPSERT on a virtual table, 
rather than simply not working.

FossilOrigin-Name: fa98748f956cff95fcfda3a513cea4df27aa573ae795a6855c40bfeca661d0b2
 2019-01-04 23:39:37 +00:00
drh
48cd0f28c5 Remove debugging pragmas accidently left in by a prior change. 
FossilOrigin-Name: 26275fc7e89eb2542a65d01fd271cef016a4a1815bc3845c599cf2f4fbf7513d
 2019-01-04 12:46:01 +00:00
drh
1baae57a72 Fix the csv01.test module so that it works on systems with \r\n line endings. 
FossilOrigin-Name: 36eaf5a5e51b20699328aae67c2bfd325f81bea342e2b167fddd859a50a26e28
 2019-01-03 16:03:48 +00:00
drh
94e02d9c2c Fix the shmlock.test script so that it works with the Windows restriction 
that UnlockFile must exactly correspond to a prior LockFile.

FossilOrigin-Name: df939c89fa90b7f9ccf961027ca4eca4f987c49eabf530b5719a83e5ab0d346d
 2019-01-03 16:00:23 +00:00
dan
ca076bf26e Add another test case to vacuum-into.test. 
FossilOrigin-Name: 0465d2fc0d3f8beaa1b6b0bd7bd51d69a524f30d889c9402e7d02cc06164a310
 2019-01-02 16:01:59 +00:00
dan
992e927281 Add test cases for commit [6c6fb1c6]. 
FossilOrigin-Name: 3961995cb56b43f1753c53fc869edf336f1c17ec994d67dc74e44e8e02493894
 2019-01-02 15:27:27 +00:00
drh
ee751fab4c Raise an error if the argument to VACUUM INTO is an identifier. 
FossilOrigin-Name: 6c6fb1c6ea452c70b56fd4ac796affebee21512adba0455ae81c291b715f544f
 2019-01-02 14:34:46 +00:00
dan
97c8cb3ed8 Ensure that when a new cursor is opened by OP_OpenDup, any existing cursor 
with the same id opened by a previous OP_OpenDup is closed first.

FossilOrigin-Name: 5c188361a91407805c0feb4bf6d3214522ce3e55013efcf63a4613ecd416bcbc
 2019-01-01 18:00:17 +00:00
drh
0de6efe59e Merge enhancements and bug fixes from trunk. 
FossilOrigin-Name: 9fb646f29c05bca5f677a2c7c4f45c36bfe0a0c6a88cb7968b4a0459bdd63bb2
 2018-12-31 18:30:41 +00:00
drh
4afdfa195b Fix the OP_OpenEphemeral opcode in the bytecode engine so that if it is called 
a second or subsequent time, it merely clears the existing table rather than
creating a new one.  Proposed fix for ticket [d0866b26f83e9c55e30de0821f5d].

FossilOrigin-Name: 4678cb1044f0b4dc813e48f3bd0f85240a66e2ecf8763280d66726cc031c93a7
 2018-12-31 16:36:42 +00:00
drh
64919e9b00 Merge patches and enhancements from trunk. 
FossilOrigin-Name: da53f3d3ff26cc32d3a5ac788b6785baa3d1688e50d9354025a3130dc7e71a38
 2018-12-28 19:23:20 +00:00
dan
1d4b16405b Fix a problem causing the sqlite_master entry corresponding to a virtual table 
to be removed by a DROP TABLE even if the call to the vtabs xDestroy() method
failed.

FossilOrigin-Name: 0140f6dbfbea93eadcd7f727d84064a0c0d1f0806dbe3e5ef1017da603157e3b
 2018-12-28 17:45:08 +00:00
drh
aa243aa7cd Modify the btree02.test module so that it does not depend on whether TCL 
interprets a value as a string or as an integer.

FossilOrigin-Name: d9e4f9574659c6285deba3dca68eca9989e615971cea3a901ffcda12fb4ee36f
 2018-12-27 16:55:01 +00:00
drh
bdefaf08ee Fix a problem in which nested CTEs with the same table name trick the 
code generator into thinking they are the same CTE, which then tries to
use the manifest them both into the same transient table.

FossilOrigin-Name: 202dd033019dd27428e3cc5f6e164c95b37efe39e2753515112b201ddefca67b
 2018-12-27 02:16:01 +00:00
dan
f6febee0e2 Update the coverage-wal permutation to cover branches enabled by 
SQLITE_ENABLE_SNAPSHOT.

FossilOrigin-Name: 6821c61f1d71be2be7f867e59fd94582a1eaf45a4d1fb88be995807a77cc22ea
 2018-12-26 18:34:56 +00:00
dan
89dec01e48 Add a few more test cases to walvfs.test. 
FossilOrigin-Name: 14a64df36efe0dc36795311d58385f9c65dc465b214059e07c2ee6b95ea99c87
 2018-12-26 17:49:57 +00:00
dan
d8f3b4c320 Fix a problem with corrupt fts3 database detection introduced by [95a9a39f]. 
FossilOrigin-Name: c80bb15b44e9b6a3c0c5a49d5e93e66376c3520ecefc1db7425c8a7e09d3eade
 2018-12-26 14:15:09 +00:00
drh
8625221444 Fix a problem with the CSV extension when it uses the "header" option on 
a real file.

FossilOrigin-Name: 7acaed08f946633fca3ab8434dd6349ea6f1bac4fd9ec21f476db013ee06de30
 2018-12-26 12:50:47 +00:00
drh
bd462bcc10 Improvements to EXPLAIN QUERY PLAN formatting. The MULTI-INDEX OR now shows 
a separate "INDEX" subtree for each index.  SCALAR SUBQUERY entries provide
a subquery number that is related back to the .selecttrace output.

FossilOrigin-Name: 7153552bac51295c56a1c42ca79d57195851e232509f9e9610375692f48c7e86
 2018-12-24 20:21:06 +00:00
dan
92107a38dc Add a few more test cases to walfault2.test and walvfs.test. 
FossilOrigin-Name: 3873941c4fb9aa2d0de1129722c5fcdf2be1ea261677d4841ed99f896c778459
 2018-12-24 20:00:27 +00:00
dan
76e4990b25 Add test cases to test file walvfs.test. 
FossilOrigin-Name: d697f6f3ca47350dad30feb529914fc5254fa662ece783408eea963d912918c1
 2018-12-24 18:51:13 +00:00
dan
94e95ea46e Copy some extra test infrastructure from the mutexfree-shmlock branch to trunk. 
FossilOrigin-Name: 883337ffdb434b6856ceaada121c0be67e2fdec7b447675f45e85568ef28d7d9
 2018-12-24 15:22:47 +00:00
drh
5198ff5767 Do not generate subroutines for non-static SELECT and EXISTS expressions. 
Fix up some test cases to account for the minor changes in EXPLAIN QUERY PLAN
output.

FossilOrigin-Name: 06de44ec9e173992ca9afb89dd2b4e40d2a7e35512c7959603cdceb606f5dfbd
 2018-12-24 12:09:47 +00:00
dan
8d69a58119 Improve the coverage of wal.c provided by the "coverage-wal" test permutation. 
FossilOrigin-Name: 6231485114eb07b258cd0e6e163ca05f7e9cf5664e071808fcb1329b33e4c4f5
 2018-12-22 20:32:28 +00:00
drh
3a07548b0d Remove unnecessary whitespace from testcase result strings. 
FossilOrigin-Name: ad70f03ceda74163903d247a975666b35fae722a27c48dd3efd31c1164b5627e
 2018-12-22 15:46:23 +00:00
dan
583521fbb0 Fix cut-and-paste error in test file fts4umlaut.test. 
FossilOrigin-Name: cad5da1bf5f65ad87d97b72e9a84081fde455ba4085e79943fdf6c0144b1ef83
 2018-12-22 07:16:42 +00:00
drh
9bfb079409 Do not all REPLACE to sneak a NULL value into a NOT NULL column. Detect that 
situation and ABORT instead.  Fix for ticket [e6f1f2e34dceeb1ed61531c7e98].

FossilOrigin-Name: db8d1d12f5c1673404b2afb5426d5ea3afe3b69d01f8f2bc47ffdf70684fdf24
 2018-12-22 01:13:25 +00:00
dan
1ea0443c2d Add new sqlite3_prepare_v3() flag SQLITE_PREPARE_NO_VTAB, for preparing 
statements that are not allowed to use any virtual tables. Use this to prevent
circular references in triggers on virtual table shadow tables from causing
resource leaks.

FossilOrigin-Name: 25666e3d03950caf753295cdb55df162e07dbcf6840b05875c6e0b127c469ecb
 2018-12-21 19:29:11 +00:00
drh
afdc9e23fc In FTS3, avoid calling memcpy() with a NULL source pointer, even if the 
transfer amount is zero bytes.

FossilOrigin-Name: 1abb83d29a06308c96bea379311b390240347c5f81824749348d18ad75840c96
 2018-12-21 18:51:27 +00:00
drh
8bcc686614 The fts4umlaut.test module requires FTS5, so do not try to run it without that 
module.

FossilOrigin-Name: dee3ae900129d39d69aff3ec6187376be100803ee6170bbf39529f37b4253260
 2018-12-21 18:50:43 +00:00
dan
e1e28ec35c Remove an assert() that could fail on a corrupt db from fts3_write.c. 
FossilOrigin-Name: 4cdcda408a4edcd2845584ddef64f0efdd2b4cc030afbc05fc2b8b555c69d3f6
 2018-12-21 11:53:43 +00:00
drh
94f4f873b2 Do not set the Cursor.seekOp test variable in the OP_NotExists opcode. 
This is a change to test logic only and does not affect deliverable builds.

FossilOrigin-Name: 98f343077887c4d3fc2ca3bbc7f20c80ec37b0e521d70af9c986ab80bb2c7903
 2018-12-20 22:08:32 +00:00
dan
e46201e264 Fix a bug in the code that detects self-referencing rows as part of foreign 
key processing. Fix for [50d2a6c2].

FossilOrigin-Name: 16fff05347f42fe9fa0f3150290b98b59a9bb921e49dc07ca397aa1de7a7e17d
 2018-12-20 17:32:33 +00:00
dan
16dd3985f0 Fix a segfault caused by using the RAISE function incorrectly (library now 
returns an error instead of crashing).

FossilOrigin-Name: ddf06db702761d663119d508afe21d7dfebe963d576bb42fc2f2024205ab86f8
 2018-12-20 15:04:38 +00:00
dan
397a78d4a1 In defensive mode, do not allow shadow tables to be renamed using ALTER TABLE. 
FossilOrigin-Name: 23e200da5cfbde0798e67cd9e016e4a1cd73b67981e1af841493fcd123d8f547
 2018-12-18 20:31:14 +00:00
dan
fffaf23013 When saving the position of a cursor at the b-tree layer, allocate a few extra 
bytes at the end of the buffer used to save the key. Otherwise, if the key is
corrupt, the code that restores the cursor position may overread the buffer by a
little.

FossilOrigin-Name: 160b1e31c0f27257c06c2987af9ec3a64abfacb2150325b72e8ccd3d217b5baa
 2018-12-14 13:18:35 +00:00
dan
7525b87b6c Posible fix for [d96eba87]. 
FossilOrigin-Name: 89a25abfcd069aebdf817890e5c27f46de3000fb858ae01029e4528f9d677567
 2018-12-14 08:40:11 +00:00
drh
e45985b595 Fix a bug in the custom in-memory VFS used by fuzzcheck. This bug masks 
other bugs that should have caused some existing fuzzdata7.db entries to
fail, and so this fix is initially on a branch until those other bugs can
be repaired.

FossilOrigin-Name: e0994e99955cf11f23dba029b5ed7f150f467887558848d5f03510e2fb5855f9
 2018-12-14 02:29:56 +00:00
drh
6301c43f23 dbfuzz2 found a NEVER() that is sometimes true. 
FossilOrigin-Name: 1201615cbbd3070158ea5fab3d2c8c95f41b25d6da096a44cb9257a7b7405efc
 2018-12-13 21:52:18 +00:00
drh
8061ad8abd Add extra tests for database corruption inside the defragmentPage() routine, 
as dbfuzz2 has found ways for corruption to leak into that point.  Add test
cases in fuzzdata7.db.

FossilOrigin-Name: 997b65117f8c12dba5fb85434fde9765cdb0d2a49cc3e31979abba3e21350086
 2018-12-13 21:11:22 +00:00
drh
1641f11f4c Fix a problem in sqlite3BtreeDelete() in which deleting an entry from a 
corrupt database can leave a btree page with zero cells.

FossilOrigin-Name: 682053d1e603c21b8085c39db618a39b23ec8d2c4d822fd19634db0e03038ea2
 2018-12-13 21:05:45 +00:00
drh
f7e74904cc Add the "decode_hexdb" TCL command to testfixture. Add the dbfuzz001.test 
module to demonstration how to use decode_hexdb to deserialize a dbtotxt
database description for use in a corruption test.

FossilOrigin-Name: 1f583c53f3b7318c69f6e235934d97ef9493278feeab0837217076d7d071c35b
 2018-12-13 20:49:43 +00:00
drh
5881dfea2c New database corruption test cases discovered by dbfuzz2. The new cases 
have been added to test/fuzzdata7.db, but have not yet all been fixed,
so tests will not currently pass.

FossilOrigin-Name: b4210d320c6426d2838d4cc08709fdfd015c1c95fcad9a5f9e8fd390c23b9fad
 2018-12-13 03:36:13 +00:00
drh
cb0e04f929 Fix another problem found by Matthew Denton's new fuzzer. 
FossilOrigin-Name: 2b690dbdffe144bd69ca0aa291c230faf3d9d73f7a2985d50f016fe54003f9a9
 2018-12-12 21:34:17 +00:00
drh
9042ff214b Fix issues with the new normalizer. 
FossilOrigin-Name: 057d7d40c56b7416a59a79cb627b2b3e5837eca2d6dbcb50127baaadf1941f51
 2018-12-10 16:49:33 +00:00
drh
4d342827d6 Fix the shell1.test test for the new format of the .backup command. 
FossilOrigin-Name: 9748d7995bc1dd632d66d2d326048d50e29c6f5e6993d5a6294d14421d2cb72f
 2018-12-10 00:41:28 +00:00
drh
2134eb5721 Merge fixes from trunk. 
FossilOrigin-Name: ab1e58fac9e3f9d7d90cefb39f8f145d211d38ec0cb393208c4531cc646056c1
 2018-12-10 00:40:43 +00:00
drh
ce706c2cf3 New test case for ticket [1d958d90596593a77420e59]. 
FossilOrigin-Name: b7bf3c9832bde26b359f4d58ebcf7788c500586d311387d022192ed65a126252
 2018-12-09 18:55:05 +00:00
drh
d4a4a36171 Do not use a partial index as a table scan in an IN operator. 
Fix for ticket [1d958d90596593a77420e59].

FossilOrigin-Name: 15bc915dd7ae25bfdfbe357c3792db3639799e4d121c6b5b24297af2d6d7129e
 2018-12-08 20:30:31 +00:00
drh
2f6239ed4e Allow the INTO clause of VACUUM to be a text-valued expression. 
FossilOrigin-Name: af172b53b46759f491f522356e14c5e2374d3f25ec70fbc1e100cadded8f9b22
 2018-12-08 00:43:08 +00:00
drh
7464f578ed Do not allow VACUUM INTO into a file that already exists. 
FossilOrigin-Name: 92f70e0fa3c9de7fde046f11cc0a7c2800511bb5ace8e68c845133931607616e
 2018-12-07 23:48:41 +00:00
drh
893bd3751b Fix the sqlite3_normalized_sql() interface so that it renders 
double-quoted string literals as "?".

FossilOrigin-Name: 0d8e150434bbd179696f1ffe71d1e06cb3d43e6468496c7e481fca8486387bad
 2018-12-07 16:32:11 +00:00
drh
62a88294e8 Fix dbfuzz2.c so that it works with -DSQLITE_OMIT_INIT 
FossilOrigin-Name: 9ad796a8822f1b7e1e99b73c2cc5be59dbfd85e9c27f3e795c29a2c002c611d1
 2018-12-07 03:01:07 +00:00
drh
bb383df7c6 New test case that still hits an assertion fault, just to prove that the 
previous checkin merely made the problem more obscure and did not completely
fix it.

FossilOrigin-Name: a9a3b532643b5f106509bb29c3e6bc9d41ec5b2da5a0cd4067898f376eb626a2
 2018-12-06 19:56:20 +00:00
drh
11df7d2839 Simplify the query flattener so that it does not duplicate the WHERE clause 
of subquery that is being incorporated into the outer query - copies it
directly.  This is more efficient.  And it also fixes the specific test case
show for ticket [f09fcd17810f65f71789525] but it does not resolve the more
general problem that sqlite3ExprDup() does not correctly duplicate expressions
that contain subqueries with window functions.

FossilOrigin-Name: f1b18d44ff855573542c1947a42d4025dff54cacc13dac14d044521762ea9736
 2018-12-06 19:15:36 +00:00
drh
253a6af532 The sqlite3_normalized_sql() interface should not be transforming quoted 
identifier names into wildcards.  Fix this, and at the same time simplify
the code substantially.

FossilOrigin-Name: e8540377ec66fa5f9ae3c93bedb5c094057698199c37fc211f7ea95429e815e4
 2018-12-05 23:45:46 +00:00
drh
d4a4dd6ebc Fix an imbalanced lock problem in sqlite3Normalize() introduced by the 
simplification in [94ea6379178e3ff6a].

FossilOrigin-Name: f69624373e33c4d370a9264a317ffdb0adbce967a950f243de2b41161a8c7ded
 2018-12-05 21:55:39 +00:00
dan
ea41251eb0 Ensure that ALTER TABLE modifies table and column names embedded in WITH 
clauses that are part of views and triggers.

FossilOrigin-Name: f44bc7a8b3fac82aa5598e9bdaf65ea4dd3c331cf90c1d5ba26ff1698e92c230
 2018-12-05 13:49:04 +00:00
drh
707821ff72 Enhance the sqlite3_normalize_sql() interface so that it works even if the 
prepared statement was not initially compiled using
SQLITE_PREPARE_NORMALIZED.  Enhance the ".trace" command in the CLI so that
it is able to access the full scope of functionality provided by 
sqlite3_trace_v2() and in particular so that it is able to show normalized
SQL output using the newly enhanced sqlite3_normalize_sql() interface.

FossilOrigin-Name: 7da617e97eb905cb009c47403786682b911e32a630f266e1c53ea72836fc88b5
 2018-12-05 13:39:06 +00:00
dan
e89feee5c3 Add the "remove_diacritics=2" option to the unicode61 tokenizer in both FTS5 
and FTS3/4.

FossilOrigin-Name: 06177f3f114b5d804b84c27ac843740282e2176fdf0f7a999feda0e1b624adec
 2018-12-03 16:14:49 +00:00
drh
4a5cff73a7 Fix a parser bug in the use of parentheses around table-valued functions. 
FossilOrigin-Name: 58a51123d1a6381cc67d3c64ba3468ec5a92c299ad6fd86de0b843d0ffafb846
 2018-12-03 01:47:41 +00:00
dan
3a85a298c9 Update incrvacuum.test so that it works with builds that do not support mmap(). 
FossilOrigin-Name: 8eb62fd5fa9adb88de51aa812270dbdb32ee5cacd636d200e658c507a14a035b
 2018-11-29 01:20:51 +00:00
dan
909f78cbd8 Update some test cases to account for SQLITE_OMIT_VIRTUAL_TABLE builds. 
FossilOrigin-Name: b53a9a3dc6b0422a102b245451769b0cd8c0d67090fefabf7cb3a65137a73771
 2018-11-28 11:49:46 +00:00
dan
1af016b7f4 Remove -DSQLITE_USER_AUTHENTICATION from the "Unlock-Notify" configuration. 
Create a dedicated "User-Auth" configuration for testing this feature.

FossilOrigin-Name: 8c41024fbba8c70b671c63a5719c6757f0e6dc731ce52caa755edbb8e21d6944
 2018-11-28 08:09:08 +00:00
dan
63e50b9ed6 Fix a failing assert() in sqlite3ResetAllSchemasOfConnection(). 
FossilOrigin-Name: 0ea049f342d11c676e148239e45d252164081362e921a4beb735d6899eb77344
 2018-11-27 19:47:55 +00:00
drh
fcee090746 Improvements to two cases in pragma4.test. 
FossilOrigin-Name: 3c893d9bcc34c391505b08cc35808dd3abddf3c5d952798334c296547bcae6a6
 2018-11-27 17:02:38 +00:00
drh
60ce5d3135 Add a simple test case for Lemon. Always include assert.h in the 
Lemon-generated parser.

FossilOrigin-Name: 9c9c46dcbe92aeabe3d5675bb69681b6dfd53798bc67e6a2ceba67ed3c4fb0af
 2018-11-27 14:34:33 +00:00
drh
eea8eb6d04 Do not allow direct access to internal-use SQL functions such as 
sqlite_rename_column() and sqlite3_rename_table() except when the
new SQLITE_TESTCTRL_INTERNAL_FUNCTIONS flag is set.

FossilOrigin-Name: 6e1330545e7b74fe5f1f20751a3425e2788441485fc07fcb7626e448c72027ce
 2018-11-26 18:09:15 +00:00
drh
eafb9a0ae5 Make the winTruncate() method of the windows VFS be a no-op if there are 
outstanding references to the memory-mapped pages.  Otherwise, memory might
be deleted out from under those references when the file is remapped during
the truncate operation.

FossilOrigin-Name: ffce4aac18dacbf2a3112ae2ab56c7db20cb164f179683d90a66ef38f4a98f2b
 2018-11-24 17:46:07 +00:00
dan
09236755ee Fix a problem reading from temp databases in SQLITE_DIRECT_OVERFLOW_READ 
builds.

FossilOrigin-Name: 81629ba91475938b6ad528e7b1dbef4ad22239782bb2e9c1bb59413aba11da87
 2018-11-22 19:10:14 +00:00
drh
8055a3ead4 Improvements to the ossfuzz.c fuzz-testing module so that it works with 
-DSQLITE_OMIT_PROGRESS_CALLBACK and with -DSQLITE_OMIT_INIT.

FossilOrigin-Name: d343f7d6b05865c282eb73a0e39dc396f2927982af45b3d045de03ef73715693
 2018-11-21 14:27:34 +00:00
dan
3c425484a7 Fix problems in pragma.c causing some PRAGMA statements to test the wrong 
schema-cookie before proceeding, or to try to open cursors on the wrong
database ("PRAGMA foreign_key_check" only).

FossilOrigin-Name: 6982f52f579d20b8a2965373731d41622bda7f09fbf82cc005bb378321829f4c
 2018-11-20 18:09:59 +00:00
drh
2d588b8c08 Fix the regexp used to recognize libdl errors on OS-X. 
FossilOrigin-Name: 1740025307531a52e4f0641e2e74dc14715130858f2e9236be13b66924f00220
 2018-11-17 14:59:35 +00:00
dan
8e2d4ad30c Fix a problem in test script e_fkey.test. 
FossilOrigin-Name: acfd0a05a8957728c1f0eb936f4121ce26f291f20dd583bd57ce2bb271617d3f
 2018-11-17 13:08:07 +00:00
drh
d905113e97 Fix a test case so that it works on windows. 
FossilOrigin-Name: 2d92d25fae5d9757866a0d0b30427b50d635e9b05e12df9464f095419fd7ef3e
 2018-11-16 20:50:53 +00:00
drh
32dcc847b5 Enhance the xBestIndex interface of virtual table so that if the xBestIndex 
method returns SQLITE_CONSTRAINT then that particular combination of
constraints is considered unusable and does not participate further in
query planning.

FossilOrigin-Name: 684013cef6bfcfd920a4aec645df9f5d41ace8b34e75fca61759c1b4f82cc89e
 2018-11-16 13:56:15 +00:00
dan
cbfaa076d7 Fix a problem with virtual table "fsdir" and some join queries. 
FossilOrigin-Name: 7fffcee0fc3fe8d036f0d93ec17673992c3edcf2bb454dc90d80142435b37946
 2018-11-16 08:36:15 +00:00
drh
6f147c54ef Improvements to the CSV virtual table. 
FossilOrigin-Name: 0406ecbbe75513e342040b71fdd342462222dbb3820486b5f745d7865805c00b
 2018-11-16 01:42:26 +00:00
drh
b1b4a3dbca New fuzztest cases. 
FossilOrigin-Name: e8316ba47f566c8d2cb48d9d54308e8869743ef39d35b662a8764b0479aed9e0
 2018-11-15 13:51:48 +00:00
drh
1ca9a8b9df Merge fixes from trunk. 
FossilOrigin-Name: bf88efcec40036e0805940ff6371643dbc518442457d2bc18c711753607ae36c
 2018-11-10 03:47:40 +00:00
dan
b430701823 When a table is renamed using "ALTER TABLE RENAME TO", update any REFERENCES 
clauses that refer to the table, unless "PRAGMA legacy_alter_table" is true
and "PRAGMA foreign_keys" is set to false (i.e. so that when "PRAGMA
legacy_alter_table" is set behaviour is still compatible with versions 3.24
and earlier).

FossilOrigin-Name: ae9638e9c0ad0c366f93c88a850f6b4cc86881e9f3f9f1e39574d9d83ddd8a6a
 2018-11-09 20:04:05 +00:00
drh
0b57d312b7 Fix for ticket [787fa716be3a7f650cac] 
FossilOrigin-Name: 531eca6104e41e4301fa2cf58bb8fec811da31e151a0f766c93aece5521d235b
 2018-11-09 14:17:51 +00:00
drh
b7c2cf0aaf More test-case adjustments for defensive mode. 
FossilOrigin-Name: 911e8a17a3810cd7042e91a32aba80dc3d6be88320c208e48f7bcee8b22a0ff2
 2018-11-07 14:41:08 +00:00
drh
6b758e1d96 Merge the permutations fix from trunk. 
FossilOrigin-Name: b753d849fe0524e14ae9367a47e29be76332fafb77bfe13e266aeef1ef6742ce
 2018-11-07 13:41:27 +00:00
dan
7d0fa14c03 Partially revert [3e1a2f661], as some test scripts require separate $presql 
and $dbconfig variables.

FossilOrigin-Name: cbf85284beb60d068b446c52f000d694a810d4de9096ad2951523a4c88e7334c
 2018-11-07 11:56:23 +00:00
drh
6ab91a7a7a Add the SQLITE_DEFAULT_DEFENSIVE compile-time option. Fix up test cases 
so that they work with DEFENSIVE enabled.

FossilOrigin-Name: 3212733cb6d1a59516d67a86df7c7b1d2456a1b2e5d7080c26b0e87b2609c65d
 2018-11-07 02:17:01 +00:00
drh
0f0d3ddf71 Enable DEFENSIVE mode by default for tests. This requires lots of case of 
turning DEFENSIVE off in order to dodgy things to the database for testing
purposes.  No all of those cases are yet handled, so "make test" does not run
to completion.

FossilOrigin-Name: a1d6c6712c3304fd736077432c8c180692cf7d79be7f3a073510b6dab0eb951f
 2018-11-06 19:26:04 +00:00
drh
aef15e74c8 Turn on defensive mode for running test scripts. Does not yet work. 
FossilOrigin-Name: 1c1d24edbb732f2a2002a741c7a7afdd010b67e1b5e6d90ff36c6428897e7612
 2018-11-06 15:57:59 +00:00
drh
2d13f6016b Add the SQLITE_DBCONFIG_DEFENSIVE flag. 
FossilOrigin-Name: 11d98414eac467affb0b3cf0c7e5cc3d43184fc2b6e7e898bb5277b51ea9e1fa
 2018-11-05 19:37:30 +00:00
drh
9196c81406 Eponymous virtual tables appear to exist in all schemas. This is an alternative 
and improved fix to the eponymous virtual table in trigger problem that
was previously addressed by checkin [1fa74930ab56171e].

FossilOrigin-Name: b8d35c4a7c99ce3753761e5b81269d52c3c910c603fa70b72549883ba68bc485
 2018-11-05 16:38:10 +00:00
drh
383bb4fa62 Disable the IS NOT NULL optimization when the IS NOT NULL operator is part 
of the ON clause of a LEFT JOIN. Fix for ticket [65eb38f6e46de8c75e188a17ec].

FossilOrigin-Name: af39661e60f562b9eb10343fd83e8fe21be4d7276111e7853c1179a24cab09ce
 2018-11-05 07:53:17 +00:00
drh
0f1c2eb5f2 Correct the internal logic for SQLITE_DBCONFIG_DEFENSIVE. 
FossilOrigin-Name: 76094345821246c887a31a234b339d03a78eddbb9fab33b06c3c20797c038349
 2018-11-03 17:31:48 +00:00
dan
29d77dc450 Add extra defenses against strategically corrupt databases to fts3/4. 
FossilOrigin-Name: d44318f59044162e229a444582692e9788f17b5c404b4eb702f4c2114b22fefe
 2018-11-03 16:51:30 +00:00
drh
c6e519f335 Fix a assert() in the query planner that can arise when doing row-value 
operations on a PRIMARY KEY that contains duplicate columns.
Ticket [1a84668dcfdebaf12415d].

FossilOrigin-Name: dcb8c73594ea6b12bad98dc883a585d3e6b925c2ead267dc40332b3d266db5e8
 2018-11-03 13:11:24 +00:00
drh
147ad061f6 Enhance triggers so that they can use table-valued-functions that exist in 
schemas outside of the schema in which the trigger is defined.

FossilOrigin-Name: 1fa74930ab56171e2e840d4a5b259abafb0ad1e0320fc3030066570a6dd10002
 2018-11-02 17:38:39 +00:00
drh
a60c63013e Add support for the SQLITE_PREPARE_NORMALIZED flag and the 
sqlite3_normalized_sql() when compiling with SQLITE_ENABLE_NORMALIZE.
Also remove unnecessary whitespace from Makefiles.

FossilOrigin-Name: 790ea39a6585ea9f4dad9e132e1fb0447ac1558f728196580d2c3edee84823f7
 2018-10-31 19:01:13 +00:00
drh
f8181eaa20 Tweaks to the test_intarray documentation and tests. 
FossilOrigin-Name: 7107f0dacf4467430d1ca157cb848dde984e48e529e7d67a88b7594b0f8159c9
 2018-10-31 18:24:29 +00:00
drh
c985c2822c Add new fuzzer cases generated by dbfuzz2. 
FossilOrigin-Name: 79fdad8b42869100845eed36224602452486d0166c18cec7d343040fdac7379e
 2018-10-30 23:45:18 +00:00
drh
ad9bfa5e07 Improvements to the -fsanitize=fuzzer based database file fuzzer. 
(Cherrypick from the rubust-against-damaged-db branch.)

FossilOrigin-Name: 3cc01a0eaf54e3d5adf206825cfcab15edf73bd5aea10dfc497efd78071a17d0
 2018-10-30 15:20:35 +00:00
mistachkin
8bee11a41e Add the sqlite3_normalized_sql() API. 
FossilOrigin-Name: 592b66e8058dd03a056a036e2606247c9efdb06d15eebe9bcc455f7f55e30ae6
 2018-10-29 17:53:23 +00:00
drh
d811d844cd Improvements to the dbfuzz2.c test module. 
FossilOrigin-Name: d60eff493b875366981c5a25000bb65cde9f6e628192914910790acc562c17b9
 2018-10-27 21:06:44 +00:00
drh
65da285e6a Initial code for a fuzzing tool on database file that works with the 
-fsanitize=fuzzer option of clang.

FossilOrigin-Name: 90d12094d36957fbded71545add8a5dc206798fdacc17d4d161d715569a7f991
 2018-10-27 00:47:33 +00:00
dan
f689400dc7 Prevent an == constraint specified using the table-valued-function argument 
syntax from being used to optimize any scan not related to the virtual table
for which it was specified as an argument.

FossilOrigin-Name: 4d46685f282409f7154be288719cbea4b743d7ea5315a55a91462003497469f7
 2018-10-26 15:36:53 +00:00
drh
8e5bfedd22 In the WHERE-constraint propagation optimization, if there are duplicate 
constraint, make sure only one of them propagates.  Proposed fix for
ticket [cf5ed20fc8621b165].

FossilOrigin-Name: 5d5b596f152bb2781011a05f75f9e200774d4f69d648ef68de577b4ace973e07
 2018-10-25 14:15:37 +00:00
dan
0f5f54062c Fix a problem with using window functions in compound (UNION, INTERSECT etc.) 
queries.

FossilOrigin-Name: 059ff53a46c7f1e4bf3e7dc558312beef67826c2753e2ab7e4e7df498b37b617
 2018-10-23 13:48:19 +00:00
drh
bafad06139 Test case modifications to support SEE. 
FossilOrigin-Name: 02b6f8f2778c371130c512e980c3db07c7e76dcf7dd92a878b86e4b6a47ca307
 2018-10-12 15:01:56 +00:00
drh
b6c4d59e89 In the unix VFS, fix the heap shm allocator (used for unix-excl) 
so that it works even on systems where the page size is larger than 32KB.

FossilOrigin-Name: 7fbb083c5cf0948af3624b7538ffa086f77de27a3e84a7039ae7d6574f1a3a54
 2018-10-11 02:39:11 +00:00
dan
07052d5535 Add test cases and assert() statements to ensure that the authorizer is being 
called as expected from within ALTER TABLE.

FossilOrigin-Name: ff10d2c7de430c88167b1e6e4f5307eee5d69e22c8d24b2ef4fcb3aea25a92e1
 2018-10-06 13:46:22 +00:00
drh
bfbf7d9daa Test case for PRAGMA table_xinfo. 
FossilOrigin-Name: 7694b9bc3003db6ba0b41c5029c8f7b84c07724e7a518e835e98b3c46e4ea227
 2018-10-01 21:36:38 +00:00
dan
5351e884aa Fix a problem with ALTER TABLE commands when the schema features an INSTEAD of 
trigger that uses NEW.* or OLD.*.

FossilOrigin-Name: c52f457e56eb9d573eb67093731eb231aaf6fd6dbdc397e6f948b82736fbe3ab
 2018-10-01 07:04:12 +00:00
drh
ca9a5faf70 Fix test cases so that they work with ICU. 
FossilOrigin-Name: d04b2013b5436430ebbf7053d637fd89c1b15affcb42787dcf1cf5ffc3ae54e2
 2018-09-28 23:53:24 +00:00
dan
6afa35c985 Disallow the use of window functions in the recursive part of a recursive CTE. 
FossilOrigin-Name: 7fc2994434c7d9ed29c96a69c07e8eb4e97be776473c170c63f9a1bbaa09fa68
 2018-09-27 12:14:15 +00:00
drh
98aa2abc45 Begin revamping the ".help" command in the command-line shell so that it 
can accept an argument and will do a search for commands that match that
argument.

FossilOrigin-Name: 209afb8d06466536863b89a8acb9a1a18477a06331d8cce95fc6380e1666b6f5
 2018-09-26 16:53:51 +00:00
dan
6705584a5b Fix a problem in releasetest.tcl causing configuration "Fast-One" to fail. 
FossilOrigin-Name: 42e04fefbc241dd33f12abd66344a87720ae4cda6d82f2882217b3cb71be8733
 2018-09-25 13:51:31 +00:00
dan
2fae150402 Fix a problem with views that use window functions as part of complex expressions. 
FossilOrigin-Name: 507d892c3a40a0bacbd47ed3c4fe2d8925a82716ae08da8401750a42782ba454
 2018-09-24 14:51:59 +00:00
drh
f8937f9034 Fix a faulty assert() in the validation logic for the LEFT JOIN strength 
reduction optimization.  Problem found by OSSFuzz.

FossilOrigin-Name: 2fd62fccd13e326dbd7dd730112542c6faa56e466bf4f7b8e22ced543031280c
 2018-09-23 02:01:42 +00:00
drh
2c3ba94969 Enhance WhereLoopBuilder.iPlanLimit to handle a case involving the OR 
optimization discovered overnight by OSSFuzz.

FossilOrigin-Name: 7b59930a1d7b664b54d5a2bc9fa385925b5f4c8f34bf401c798307e3e2dae2c6
 2018-09-22 15:05:32 +00:00
dan
34566c4434 By default, make all "ALTER TABLE RENAME" statements executed within a virtual 
table xRename() method exhibit the legacy behaviour.

FossilOrigin-Name: 71947337e98b90debb13b390119bc2a6b39dd41535151b836071ee327a31e45d
 2018-09-20 17:21:21 +00:00
dan
674b894269 Add a PRAGMA that restores the legacy ALTER TABLE RENAME TO behaviour. 
FossilOrigin-Name: 5acad2e92c11c209bedc6ac8a709595e8070eed028ffc82af61499e5ceaa5e2b
 2018-09-20 08:28:01 +00:00
dan
85c6892aa4 Fix a compilation issue in the "userauth" extension. Also fix a few test 
script errors that occur with SQLITE_USER_AUTHENTICATION=1 builds.

FossilOrigin-Name: 221f3f572ed49d7af69a2e7c88741fa5206ea33ca59ee791eac7698bdd11ca4d
 2018-09-19 17:09:09 +00:00
drh
c6727c8342 Fix the "sqlite3" command in the TCL interface so that it correctly returns 
an error if invoked with no arguments.

FossilOrigin-Name: 2034fa8089676132b5e2f71bdebf1af9ca141da2e173920c6e84fb974ab0f022
 2018-09-19 15:08:21 +00:00
dan
c4b1e5e758 Avoid incrementing the SQLITE_LOOKASIDE_MISS_SIZE stat before sqlite3_open() 
returns. Fix test script problem in lookaside.test.

FossilOrigin-Name: e461cb281959d8517296e3e4e934eba8206770b1a592cd7655b6567268da1634
 2018-09-18 17:50:34 +00:00
dan
253c6ee1bf Enhance tester.tcl so that when "--malloctrace=1" is specified, the test 
generates self-contained Tcl scripts that present GUIs instead of *.sql files
that require a separate program to interpret.

FossilOrigin-Name: de2e3cbd08c00d235106c040fa472ec267ef8f1ec13c34ed7d16deac8d50b6cc
 2018-09-18 17:00:06 +00:00
dan
b1e1a0fd2d Minor improvements to the permutations.test script. Most notably, a command 
like "permutations.test alter%" now runs all test scripts with names that
match the LIKE pattern "alter%". Or, say, "permutations wal alter%" to run all
alter% tests in wal mode.

FossilOrigin-Name: 3e1a2f6614eacb65e1dffe64c6292c809fc5808be2d9d7d103cfc57d7b32fcd9
 2018-09-18 16:06:42 +00:00
drh
d4cb09e3d2 Disable the ORDER BY LIMIT optimization in queries using window functions. 
This fixes a problem that was introduced by check-in [206720129ed2fa8875a286]
which attempted to fix ticket [9936b2fa443fec03ff25f9].  This changes is
a fix for the follow-in tocket [510cde277783b5fb5de628].

FossilOrigin-Name: c6c9585f294710829ca24b64d70a36fd9f409261dd0661367c6c4198cdbc4c81
 2018-09-17 15:19:13 +00:00
dan
0208337c16 Add extra test for the fix on this branch. Also fix a 
pointer-compare-after-free problem that occurs in similar cases.

FossilOrigin-Name: 1856ea63b3186c2c8fa716ffe01c731397bdbbc3fbb56dc72ad0686cb7f152ca
 2018-09-17 08:27:23 +00:00
drh
95f78d98b9 First proposed fix for the ALTER TABLE problem described by ticket 
[b41031ea2b5372378cb3d2d]

FossilOrigin-Name: 05a9d129254e01a5f6b5e4033c105190eae386575a94b020ef3e0cbd30bbf056
 2018-09-16 23:27:37 +00:00
drh
9b84f03556 Add the new "explain" virtual table in ext/misc. Use this virtual table 
for additional test cases for the optimization that avoids updating indexes
on expressions when none of the columns changed by the UPDATE are in the
expression.

FossilOrigin-Name: 2404304cc15eaeee2744cf3c8f9cac0a544631c4f1060c5a17a78b43ca86edf0
 2018-09-16 16:18:01 +00:00
drh
e9816d82a7 Optimization: when doing an UPDATE on a table with indexes on an expression, 
do not update the expression indexes if they do not refer to any of the
columns of the table being updated.

FossilOrigin-Name: a71b101635ed28a4c99734dabb20bd65ef1018c1d63ac143b7321cdb0fafa5d7
 2018-09-15 21:38:48 +00:00
dan
f86ff13206 Update releasetest.tcl to run "make test" as part of the "Fast-One" 
configuration.

FossilOrigin-Name: d5ebfe1c75d336dac374d9cfa257e45e77ab51f9c2f24d1af615cbbe9dd83d9b
 2018-09-13 17:11:51 +00:00
drh
396a103612 Fix a requirement mark on a test script. No changes to code. 
FossilOrigin-Name: 628d5c0aa057c05c7cf84c330a51b8a44720c97250eadf0e5e8c750b7a2969c3
 2018-09-13 13:17:14 +00:00
dan
e8ab40d219 Fix an invalid pointer comparison triggered by renaming a table column when 
there are views with explicit column names in the schema.

FossilOrigin-Name: 572de7e4e33562c72cd90790b267ba389370f21ddcaebc4db609fd76ae9b7ada
 2018-09-12 08:51:48 +00:00
drh
15c42942b3 Do not do the byte-by-byte modifications in the resetdb.test script if the 
reserved-byte flag in the DB header is non-zero, because in that case the
bytes will be in the wrong place and the test won't work.

FossilOrigin-Name: 0af18674ca5b34e67e1685be3adcdd99a7b8650589c6a7cde7ad9ef1852a8777
 2018-09-11 19:05:32 +00:00
dan
e3e79213b1 Fix a problem causing ENABLE_CURSOR_HINTS builds to segfault. 
FossilOrigin-Name: e7033104fa8bd974a9a3d173200aa07a3aa3daade86e7eb65cad5d00b086969e
 2018-09-11 13:38:35 +00:00
dan
30a7d7ddc5 Fix a test script issue in fts3ao.test. 
FossilOrigin-Name: 74c381b573817d0212153278b5ee5d2238a27a727dcf7ee769365c47bb9fc40d
 2018-09-10 19:34:06 +00:00
drh
b7a002f836 Fix the LIKE optimization so that it is disabled when the LHS of the 
expression does not have TEXT affinity and the RHS is the pattern '/%'
or the RHS begins with the escape character. Fix for ticket
[c94369cae9b561b1f996d0054b].

FossilOrigin-Name: f191431d63aba187000b5cbaf3e072ff5f1b1eef6a2a407fb4d1629bda4e4e8f
 2018-09-10 12:40:57 +00:00
dan
eb3fe0b9d4 Fix a problem with processing a "vtab.col IS NULL" expression within 
the WHERE clause of a query when "vtab" is a virtual table on the rhs of a
LEFT JOIN.

FossilOrigin-Name: 83da4d4104ee1870a2a95bb5fa15ee6584c655d8b314b6b8ab97592dad4ee811
 2018-09-10 12:17:16 +00:00
drh
6ee5a7b481 Fix multiple issues with the ORDER BY LIMIT optimization. This is the 
proposed resolution to ticket [9936b2fa443fec03ff25].

FossilOrigin-Name: 206720129ed2fa8875a286266d05b99fb2caf8671e4b74b26a6286a2073fcd8b
 2018-09-08 20:09:46 +00:00
dan
b2802128d6 Add extra test case to altertab.test. 
FossilOrigin-Name: 64c3ee3c255e4630ccd5002116d66fd2af6b12dbdd4a3bee5ed413c3ef87d33a
 2018-09-07 18:56:31 +00:00
dan
d5e6fef2a1 Fix a problem with renaming a non-temp table that has at least one temp 
trigger and shares its name with a temp table.

FossilOrigin-Name: ceb60bd7e5f2a0a4247bff476fc6468227305467339ae0c24591be9d2b14bdde
 2018-09-07 15:50:31 +00:00
dan
202a0274db Minor fixes for problems revealed by releasetest.tcl. 
FossilOrigin-Name: 1a8aedc3376b7ae32fa7b2c367eedd483e2629908836efd10ee5bd1fe0784675
 2018-09-07 11:51:21 +00:00
drh
9fd88e8db7 Fix an uninitialized variable in the OP_ParseSchema opcode that comes up 
only if the schema is corrupt.

FossilOrigin-Name: 725808d4c59176f71787452c7e500b563fd99cfc8ece47b1efe01d5e207efe0d
 2018-09-07 11:08:31 +00:00
dan
803507f863 In all.test, do not attempt to run the RBU tests in non-RBU builds. 
FossilOrigin-Name: 10c3e5a0314470ee1ffc37b68445a2cb2054530346d5f5ed3ffbd6df8003cad0
 2018-09-06 20:33:11 +00:00
dan
c50f75df96 Fix a problem with ALTER TABLE when there are views or triggers in the schema 
that contain "<expr> IS NULL" expressions.

FossilOrigin-Name: 91aab32e71fcb924e24c02d5f0901f7a474760fc993a7e7436e667512cf5d3c3
 2018-09-06 18:56:36 +00:00
dan
1041a6a817 Fix a problem in ALTER TABLE with SQLITE_OMIT_VIRTUALTABLE builds. 
FossilOrigin-Name: fa835145e63749e06e04bd50ff992afaeae05dcdd1df597d13911f944e62076b
 2018-09-06 17:47:09 +00:00
dan
7ea1edb703 Fix test script problems causing SQLITE_OMIT_VIRTUALTABLE builds to fail. 
FossilOrigin-Name: 37ad064e5f5704cf345d23b38b3f6d627fbcf20dbb78c8a91e96c9704760a1b8
 2018-09-06 17:23:08 +00:00
dan
71998f03b5 Add new test file "alterauth.test". 
FossilOrigin-Name: 00940265b18a3cf848602e1e0b3edbd935cb4309ef91a34b0d5746a258a47ae6
 2018-09-06 16:24:23 +00:00
dan
1d85c6bf48 Ensure that the tbl_name column in the sqlite_temp_master table is updated 
correctly as part of a RENAME TABLE operation.

FossilOrigin-Name: ffecfca511718e39e0003b380d5113755b8a11405a5bd80cc04503d9557f0842
 2018-09-06 16:01:37 +00:00
dan
5921f2b9e7 Fix some test script errors. And an incorrect assert() in fts5. 
FossilOrigin-Name: f804336f083d8d26314bb1ba34cec427675065a67cbe2bf00bb42e40752aeb33
 2018-09-05 17:45:17 +00:00
dan
65372fa963 Improve the error messages emitted by RENAME TABLE. 
FossilOrigin-Name: 6805b5900df5e6d3329cbad2660875ebe4069efe37b19575f527d153dc0882a1
 2018-09-03 20:05:15 +00:00
dan
143df55d24 Add another test case to altertab.test. 
FossilOrigin-Name: 828e8849faed85812c03215b00a2ba34cbb00dfa4d4afdcbd11300ba7fcf9743
 2018-09-01 20:38:42 +00:00
dan
b87a9a8a5e Fix a problem with renaming a column in a table that has a temp trigger that 
references another attached database.

FossilOrigin-Name: 336b8a0923bf65b7a2c35811cb6dec0e262a0b31e534d2a6ab093d2afdb05c1f
 2018-09-01 20:23:28 +00:00
drh
010f8ee2fb Merge fixes from the alter-table-rename-column branch that occurred after 
this branch separated from that one.

FossilOrigin-Name: 22e785aa2bbce4ae0852bc3d127d4b12222a192eb6e3ee874bf8e5c8582d05f3
 2018-09-01 15:55:44 +00:00
drh
c840b428fc Merge fixes and enhancements from trunk. 
FossilOrigin-Name: 589186c083ff3af8d5a6d5ad34e1cefea57806ebf3831ea3bf5a48ef1e173140
 2018-09-01 15:49:13 +00:00
dan
6ae2454a67 Update test script snapshot_fault.test to account for the new 
sqlite3_snapshot_open() error code.

FossilOrigin-Name: c1aca7673ab04740bc8ad76af0a72a229c79a0cd51cf84d1c689a77424ff17c6
 2018-09-01 06:13:07 +00:00
dan
8d4b7a3fa8 If a call to sqlite3_snapshot_open() fails because the requested snapshot no 
longer exists, return SQLITE_ERROR_SNAPSHOT instead of SQLITE_BUSY_SNAPSHOT.

FossilOrigin-Name: e07923128bb164efbafde29d49175b61f2ef44b2dfac5ae4ed61937945dfcf4c
 2018-08-31 19:00:16 +00:00
dan
141e119a17 Ensure b-tree mutexes are always held when sqlite3FindTable() is called. Do 
not invoke the authorizer callback when parsing schema items as part of ALTER
TABLE commands. Fix test script issues.

FossilOrigin-Name: eac2aa7dce577f1998cc2078dd8ac384070f8acf1ceb565999a5cf719092024e
 2018-08-31 18:23:53 +00:00
dan
9d324823a8 Test the schema after renaming a table. Ensure that temp database triggers and 
views are updated when renaming a column.

FossilOrigin-Name: f3c27d916d4837f8fc3dd812bd004535f04c7a53bd2a0a2419613275f48bec76
 2018-08-30 20:03:44 +00:00
dan
0ccda96867 Fix an ALTER TABLE problem with processing temp schema views and triggers. 
FossilOrigin-Name: 72cfb1be29971d91a164f1d4f20cb054de68960a0bd547630bcd1160565971c5
 2018-08-30 16:26:48 +00:00
dan
c9461ecc28 Extend RENAME TABLE to edit triggers and views. Still buggy. 
FossilOrigin-Name: 01308bae3acf33f78b5bb90892085eab340df093aafc17e6ccf6a7d6cf324897
 2018-08-29 21:00:16 +00:00
drh
8ab114c6a9 Disable the server1.test script on old PPC Macs due to problems in the 
pthreads implementation on those archaic machines.

FossilOrigin-Name: 43efdd8c7e468405c9d4956a8caa66548059499289cbcc091628de7b055268cd
 2018-08-28 21:12:02 +00:00
dan
f5778751f7 Fix a problem causing spurious SQLITE_CORRUPT errors when using the snapshot 
API to read from old database snapshots.

FossilOrigin-Name: 535155be584ad8c1836e6b1c62de836d9872056d39608c995221c928cb5b365d
 2018-08-28 11:23:52 +00:00
drh
050398bdf1 Fix a minor issue in the altercol.test script so that it runs on Windows. 
FossilOrigin-Name: 62089c6daf9ea51be769c077c23d6fa881ba797255fa22d71baaac191a9c1ba7
 2018-08-25 16:22:33 +00:00
drh
0d019b9243 Invoke the authorizer for ALTER TABLE RENAME COLUMN. 
FossilOrigin-Name: fc293bcb3402f049fb9e22aacfb4fdcd13f8609edf29c97d6cb95ce351363873
 2018-08-25 16:14:46 +00:00
dan
aa42e9816b Fix a problem by renaming a column when the schema contains an trigger program 
featuring an UPSERT that uses an "excluded.*" reference to a different table.

FossilOrigin-Name: 83d5f5abce6be2f6d342a6fc68839289400d7bcb80eaa38194789142c93a80c3
 2018-08-24 20:20:33 +00:00
dan
85a9d508df Fix a problem with renaming a column that occurs as an "excluded.colname" 
construction in an UPSERT that is part of a trigger program.

FossilOrigin-Name: bb2f7234968157b605522dea8e115d8772ab4234147894089d6e48fedf5d6a5d
 2018-08-24 20:10:22 +00:00
dan
0d5fa6b979 After modifying and reparsing the schema as part of an ALTER TABLE RENAME 
COLUMN, check that no new schema errors have been introduced (e.g. ambiguous
column names in views) before committing the operation.

FossilOrigin-Name: a0e06d2c5e3abb3f300491e7651bb177a436899efd4506de9239359096b6a9e7
 2018-08-24 17:55:49 +00:00