mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
21,417 Commits 1,487 Branches 166 Tags 416 MiB
51676fab72
Commit Graph

21417 Commits

Author SHA1 Message Date
drh
594b124f21 Changes to extensions and test logic so that the build works with gcc 
and with -std=iso9899:1999

FossilOrigin-Name: 2575a68c3965e72f2ab211d933012442755afe6a9b7de9e9e50cdd2155fd1ec8
 2019-11-20 12:07:40 +00:00
drh
cde342df70 Enhancements to DBSTAT: (1) Make name=? queries efficient. (2) Add the 
ability to aggregate results across each individual btree using the
aggregate=TRUE constraint in the WHERE clause.

FossilOrigin-Name: a48f6e17599d7ec794cfcd60858d6a69cf05caaae9321048b111fedd86a3b5b2
 2019-11-19 21:22:16 +00:00
drh
012b15e2d7 Get the aggregate=TRUE feature working on the DBSTAT virtual table. 
FossilOrigin-Name: 16fef3db063830884de46d53a289f637a7204fe84fcdee7ea81dbb8bca578952
 2019-11-19 18:48:11 +00:00
drh
ad84bd849e Begin an enhancement effort for the built-in DBSTAT virtual table. 
FossilOrigin-Name: 9b5722f0fe666b99677e5f333dd8413aefb9ace7a461d74f6558f0ac53768719
 2019-11-19 14:01:51 +00:00
mistachkin
4a4c1bf856 Make the result of sqlite3_normalized_sql() survive its statement being reprepared. 
FossilOrigin-Name: 4330f0795dbc2ab41dddd41d5979331fb9b78c477c66367c4be52f929531a45f
 2019-11-19 00:13:42 +00:00
mistachkin
3c161e07af Add support for the SQLITE_ACCESS_SYMLINK flag in the Win32 VFS. 
FossilOrigin-Name: 175c15008e9f19b8f6762c2fe4a545735128765081980eed01d5e46ca4acb500
 2019-11-18 23:48:03 +00:00
mistachkin
dc96192eef Ensure all file names passed to the VFS layer are double-zero terminated. 
FossilOrigin-Name: 251230cf43c591cf49cf9d2f392581c57d334b791bc3407814d216b5999c32f4
 2019-11-18 22:34:07 +00:00
drh
3c904885b1 In the SQLITE_OPEN_NOFOLLOW processing, distinguish between an I/O error 
on the xAccess() call and an actual symlink encounter.

FossilOrigin-Name: 2e98b42fcb7bc38e22808a9dc1d7a4231ed08ffa97c9f08f33e6e8cd8726856c
 2019-11-18 18:43:19 +00:00
drh
0933aad72c Add support for SQLITE_OPEN_NOFOLLOW. 
FossilOrigin-Name: cb79c828496a703f1410f61458ebc1e15a92a63412b36f51945b2b5a32ec6e88
 2019-11-18 17:46:38 +00:00
drh
804725a6b9 Improvements to detection of corruption in the %_stat shadow table of FTS4. 
FossilOrigin-Name: 6b67eba54e7b4887a8cdab7537b12a95e9f17bcdaa0b423af5ed5bd91f69f2c6
 2019-11-18 14:04:21 +00:00
drh
13a8f203d9 Further improvements to shadow table corruption detection in FTS3. 
FossilOrigin-Name: e35d8c76aae59f57cc5193f79b21b4298029bea78e1aab7af67432162ce63e00
 2019-11-18 12:04:17 +00:00
drh
3e72bdb5fe Detect and prevent infinite recursion in fts3SelectLeaf() due to a 
malformed FTS3 btree.

FossilOrigin-Name: dfcf081d842629a0b177be7eb2eb8ce719324068991040a581e33ea1d5db3d27
 2019-11-18 11:14:59 +00:00
drh
19d4175d65 Improved detection of corruption in the %_stat table of FTS4. 
Chromium ticket 1025467.

FossilOrigin-Name: 10f8a3b718e0f47be528fba086c318e1dfe18ead383d01cfa24dedabad41e0a2
 2019-11-18 10:37:57 +00:00
drh
ac801803a5 Fix an assert that can fail if the schema is corrupt. 
FossilOrigin-Name: ed57c48e4bb337810521bda2da79614313e4835a317ca4eadb52bd67e4eadf98
 2019-11-17 11:47:50 +00:00
drh
feb5dcf1a6 Better detection of corruption in the %_stat and %_docsize shadow tables 
of FTS3.

FossilOrigin-Name: 1e449687881f4d388e54a0e51bcabba41ab10cf7e596ff65e31e88a23c70d497
 2019-11-17 02:41:06 +00:00
drh
fd6bf04bba Remove a reachable NEVER() in FTS3. 
FossilOrigin-Name: 8bd75bf636f72f32d66c6c38e1918f27daf2f13290f00a001f41d50838bbda47
 2019-11-17 00:08:24 +00:00
drh
c72f2fb7fe More improvements to shadow table corruption detection in FTS3. 
FossilOrigin-Name: 51525f9c3235967bc00a090e84c70a6400698c897aa4742e817121c725b8c99d
 2019-11-16 23:47:40 +00:00
drh
94febb3a77 Improved detection of corrupt shadow tables in FTS3. Enable the debugging 
special-inserts for FTS3 for both SQLITE_DEBUG and SQLITE_TEST.

FossilOrigin-Name: 04b2873be5aedeb1c4325cf36c4b5d180f929a641caf1e3829c03778adb29c8e
 2019-11-16 21:40:49 +00:00
drh
3a5f9bc49c More restrictions on changes to shadow tables when in defensive mode. 
FossilOrigin-Name: bae76a5c40703871e5ce4cd23d6fae5a3836606f524a63b01ac828c7a602c5e9
 2019-11-16 16:54:53 +00:00
drh
527cbd4a10 Do not allow CREATE TABLE or CREATE VIEW of an object with a name that looks 
like a shadow table name.

FossilOrigin-Name: 6aef58b629d89955f85f65191ba2be67b2adfac4f0327fe9a7141cb2705dbc00
 2019-11-16 14:15:19 +00:00
drh
070ae3beea Break out the test for writable shadow tables into a separate subroutine. 
FossilOrigin-Name: 8ad34d36a141fa8f5d9bd784dfeb892c983897a6dc6b867607cc668508acf944
 2019-11-16 13:51:31 +00:00
drh
d0c51d1a04 Do not allow shadow tables to be dropped in defensive mode. 
FossilOrigin-Name: 70390bbca49e706649ca5b7c031f0baf416fc38798c17e5f3b73746b3e66e3b5
 2019-11-16 12:04:38 +00:00
drh
47bcc34271 Fix a potential NULL pointer dereference on a RENAME TABLE that references 
a VIEW with a logic error in a window function in the ORDER BY clause.

FossilOrigin-Name: 0adb273f7e7671efb0e0a1619887e369500dfd2db7ef1b1e125c2414ea96e96f
 2019-11-16 11:33:39 +00:00
drh
5710f1ad48 Modify three test cases so that they work even with unusual versions of the 
library printf().

FossilOrigin-Name: 8f4a3750b7d272daf96831655ffee80d457875ee121fc4537008046b9a00d0e7
 2019-11-15 21:16:34 +00:00
drh
8103a03607 Fix table-valued functions so that they will work as the right table 
in a LEFT JOIN.  Ticket [2ae0c599b735d59e]

FossilOrigin-Name: 2c35d3f67b67a53ead08b1c395e7ca8e5bf65f94a5a962a0562994a3c66c95d9
 2019-11-15 00:52:13 +00:00
drh
195a843691 Add support for the sqlite3_hard_heap_limit64() interface and the 
hard_heap_limit pragma.

FossilOrigin-Name: 6399c47ea89c5766274bd6abdc9b6a85fe5b7f6c1078972c2f58e624bae59b7c
 2019-11-14 18:07:28 +00:00
drh
31999c5cac Fix a bug in the hard_heap_limit pragma so that it returns the new value of 
the hard_heap_limit, not the soft_heap_limit.  Change SQLITE_MAX_MEMORY so
that it works by setting the default hard_heap_limit value.

FossilOrigin-Name: 33fd0c3abcad5555a150990a22d9c1bab99e79be01143fccb9fafc9b52cf92c8
 2019-11-14 17:46:32 +00:00
drh
803f06bf62 Merge recent enhancements from trunk. 
FossilOrigin-Name: b8a631fd30d0732505679230684b3362c965438197a2b11518f01a77599c9202
 2019-11-14 15:21:15 +00:00
drh
39d1a2a100 Minor documentation enhancements. No changes to code. 
FossilOrigin-Name: 6153f3aada0cc9c5e773753797892ee78b518b0d76568382f5fbc9ee960f814c
 2019-11-14 15:10:48 +00:00
drh
01d1801cab New test cases added to fuzzdata8.db. 
FossilOrigin-Name: 5baffcda7d5a42a99fa905faa834f14b94b1e2a26b5221f15d8ae8f1f5e3236a
 2019-11-14 13:57:15 +00:00
drh
ba01634cd3 Ensure that the same subquery does not go through the window-function rewrite 
more than once, even when that subquery is part of a virtual table constraint
that lacks the omit flag.

FossilOrigin-Name: d0bc7db6b0a53edc04815622c46250d26f526f56e59f14875f4e18c75b49000d
 2019-11-14 13:24:04 +00:00
mistachkin
b88eaf1619 Add header guard to the expert extension. 
FossilOrigin-Name: 7e3151855fd4370fb7d4fff20516c2c2d1980134620df924106e6989bc130583
 2019-11-13 18:50:36 +00:00
drh
dbf1c4ba8a Fix the sqlite3TreeView() output to consistently use a colon and not a 
comma after the table number in the AST dumps.

FossilOrigin-Name: fa2416f623d83fe93253137302a74fcd6cdd041da337a0756df344d7d09a19f5
 2019-11-13 16:50:06 +00:00
drh
d2c40e9310 For for the previous check-in: Always enable the nUri variable, even 
when debugging is turned off.

FossilOrigin-Name: f84a15394c369cbdb6fba87c603a609722cf1f499626c7f20699060273ab5081
 2019-11-12 16:21:27 +00:00
drh
746461f1b8 Ensure that the main filename and the journal filenames in the pager 
object are all correctly double-zero terminated.

FossilOrigin-Name: df51ae19c1aa4c26f2dcd427eddc1c9cc24b698e1ab0a948b198a57432e25e1e
 2019-11-12 14:43:47 +00:00
drh
4c8056079f Remove a harmless unused variable. 
FossilOrigin-Name: 28091a48aa6994f8d7c142b5851bcd6b4e9a93a7bbef6c927a6182d24f3245b4
 2019-11-12 03:45:23 +00:00
dan
a3b75e982a Remove an asm() block from build tool mksourceid.c, as it causes build failures on some systems and performance is not important at build-time. 
FossilOrigin-Name: 8e100e6c35c30e0d7e4014b9435f81f9f61ddab2386dfe9a4218d8190a6da3be
 2019-11-11 15:13:11 +00:00
drh
48eb03bd0e Proper surrogate pair decoding added to JSON functions. See the mailing list 
bug report and [https://bugs.python.org/issue38749].  More test cases
needed here, but it seems to work so far.

FossilOrigin-Name: 51027f08c0478f1bf9d7545d9e268c772c0a5cd5dda4b03d78f16c7d94f2f50d
 2019-11-10 11:09:06 +00:00
drh
9576802dba Remove an incorrect ALWAYS() macro. 
FossilOrigin-Name: f7a74f89dbd58b47bbcb58ea2af71fbe1eb5ec2dbe36d90685c39cb28ecf5250
 2019-11-10 10:08:03 +00:00
drh
12bf712707 Change the COLFLAG_NOTAVAIL bitmask so that it fits in the single-byte 
Walker.eCode field.

FossilOrigin-Name: 53847f5c28bdecfbc7b08685d4dcd0565526f6191491b4827c3c966a4b8d4a85
 2019-11-09 15:31:34 +00:00
drh
675f73bcab New dbsqlfuzz test cases added. 
FossilOrigin-Name: 18c3a17dc8c07b12427e372ff86668d5bcb6b34d653c46c48561ed576acefa5b
 2019-11-09 14:44:18 +00:00
drh
46a31cdf6b Make sure the WITH stack in the Parse object is disabled following an error. 
FossilOrigin-Name: de6e6d6846d6a41c4821454dfdc042096234df753be08c5567b79fe535d9b6ea
 2019-11-09 14:38:58 +00:00
drh
ff1032e5c2 When a virtual table reports orderByConsumed, that tells us nothing about 
whether or not the SQLITE_DISTINCTBY constraint is met.
Fix for ticket [7e59041f9c4e5102].
Test cases in TH3.

FossilOrigin-Name: b59f94e4da9b1653f2004b214407a50340dd476b27e6ec7e29e501a95db9c963
 2019-11-08 20:13:44 +00:00
drh
1e7c00e695 Fix the xferCompatibleIndex() function so that it recognizes that a PRIMARY KEY 
index for a WITHOUT ROWID table is different from a UNIQUE constraint index
on the primary key.  Ticket [302027baf1374498]

FossilOrigin-Name: 34f64f11ca481996b1ff1686bdc5e278946635b6856cd1fe2355fce8e298e0f8
 2019-11-07 14:51:24 +00:00
drh
4e8e533bf7 Restore generated column loop detection logic that was incorrectly removed 
from the previous check-in [9e07b48934e9a972].  This fixes ticket
[299b50ba812d8e54]

FossilOrigin-Name: 104a2beb57037f9353ffa77096aae0eb64e4682e667f31623bfd3d064dd8d881
 2019-11-07 02:32:54 +00:00
drh
dfa15270c4 Change the way generated columns are computed so that no column is computed 
inside branch code that might not be taken.  Ticket [4fc08501f4e56692]

FossilOrigin-Name: 9e07b48934e9a972dcf62e3538b3b21ffa044c553feba0441675ac0bbe13bcb2
 2019-11-06 22:19:07 +00:00
mistachkin
bde3a4f680 Minor simplification to the changes from check-in [36c11ad51f]. 
FossilOrigin-Name: 7bc8205dd9c1657c736a9c6a1a90dd9dad442accfbb77d296eaae2c09ab46bd1
 2019-11-06 19:25:45 +00:00
drh
4fb24c82cd Fix the OP_DeferredSeek index-to-table column map in P4 so that it works 
with generated columns.  Ticket [ce22a07731530118]

FossilOrigin-Name: 36c11ad51fe9ab1bde0b98d0ea9b8588e07d168cd8027486749372894941ad93
 2019-11-06 17:31:18 +00:00
drh
b1129c423f Fix the handling of NOT NULL constraint violations for generated columns in 
a REPLACE statement.  Ticket [2399f5986134f79c]

FossilOrigin-Name: 77b1c90add514050fe62f22751362fecacd99f9775346cffc60e09c326e64e10
 2019-11-06 14:49:43 +00:00
drh
06fc24555f Changes an unreachable testcase() into an assert(). 
FossilOrigin-Name: 5710845b6314f924b490434b4446169f4bb50576aaa940472af68150db16e127
 2019-11-04 12:49:15 +00:00
drh
6c68d7592f Fix a false-postive in the sqlite3ExprImpliesNonNullRow() decision routine, 
that resulted in an incorrect LEFT JOIN strength reduction when the
WHERE clause contained a row-value comparison.
Ticket [02aa2bd02f97d0f2]

FossilOrigin-Name: ea20068e6d97c9349ebcc7d0a01e99ebf08c6f44363f71a0218a1abea209adc5
 2019-11-04 02:05:52 +00:00
drh
db535390db The optimization of check-in [9b2879629c34fc0a] is incorrectly reasoned. 
The WHERE clause of the partial index might not be true if the table of
the partial index is the right table of a left join.  So disable the
optimization in that case.  Ticket [623eff57e76d45f6]

FossilOrigin-Name: 3be19e1151af1850b65991edb82420f9412a7798dd756c86eaa9ffdde573263a
 2019-11-03 00:07:41 +00:00
drh
0383661414 Fix a problem in VIEW creation that was introduced by the generated columns 
feature.

FossilOrigin-Name: 9c795c4d2b042d2932774bd1274fa0167ca2dc9838e127e0cf31eb9273a32f2c
 2019-11-02 17:59:10 +00:00
drh
089c4bc2e2 "STORED" is not actually a keyword. The parser looks for STORED as an 
ordinary identifier.

FossilOrigin-Name: 167cd574d6a1d4fe2253f5bc5aaa7b031cbc82853e4d33b8d9b72eaf049003d4
 2019-11-02 13:45:03 +00:00
drh
39b30a7d6b In sqlite3GenerateIndexKey(), do not attempt to reuse column values from 
the previous index if the current index is a partial index as the partial
index test may have corrupted those values.  Ticket [a9efb42811fa41ee]

FossilOrigin-Name: 17e9f65814264de9c35bc5ba94e0a66fbbf1200c00d33ab9a19a0b6f92bc685a
 2019-11-02 13:32:50 +00:00
drh
978256f3d8 Restore the on-line ".help" for the ".explain" command in the CLI. 
FossilOrigin-Name: 28b8f1036d569bccce56b4e7042348024b5dd1ffa04850cbeddab1e35c49e5b7
 2019-11-02 00:00:14 +00:00
drh
9c6a92982f Fix a harmless compiler warning. 
FossilOrigin-Name: f0ebea35d9d6b69a7bb4242fb79ff3db4267e429855fa6969f9f52ffee1c7a99
 2019-11-01 18:52:09 +00:00
drh
bc4974c81b The SET DEFAULT and SET NULL conflict resolution actions for foreign key 
constraints should cause an error when they appear on a generated column.

FossilOrigin-Name: b47513d2b32b61ba42c1e9b59287d28f6fee231e6c65de2a3aa19effbbaf1e7f
 2019-11-01 17:31:27 +00:00
drh
f2b9d7c605 Fix a potential use-after-free bug that follows an OOM error in code 
added two days ago by check-in [84e02d773d60cffe].  Problem discovered
by OSSFuzz.

FossilOrigin-Name: 0a2eb949f8a759e5745d9468c8183d3c0b4b30e0fa2a14b3062620eb9e1d5c1d
 2019-11-01 16:37:53 +00:00
drh
dc2e331ab2 Add another missing column number translation to the foreign key logic. 
FossilOrigin-Name: 32df5edcfef2605009f45d6ef1b97c63a99df07c7b4e00dc70f93001cfb8d81f
 2019-11-01 16:08:20 +00:00
drh
1a9082f6d7 Omit the optimization that reduces the column-count on rowid-table cursors 
when the table has generated columns, because we do not know what columns the
generator expressions might try to access.

FossilOrigin-Name: e6c96ed91e7a96d2bd30ea9df132644ac02d5a321a62f81f8f3984a8e49ed94b
 2019-11-01 15:19:24 +00:00
dan
b1c479b61d Fix an fts3 assert() that could fail when operating on a database containing corrupt records. 
FossilOrigin-Name: 7c52f5478f9ecf5c078208759143ae9de43c1bf191dfcd74acb8bd169d4dc883
 2019-11-01 13:37:26 +00:00
drh
f09a14fbc3 Add missing column translations to foreign key logic. 
Ticket [c28a01da72f8957c]

FossilOrigin-Name: bc6a43e7ee6353b9ef3dea4309c77e170a1c798eefcfaa7636bf5a93e51c47ee
 2019-11-01 12:14:30 +00:00
drh
e7d9814fe4 Fix a potential array bounds overflow in the mkkeywordhash.c code generator. 
Also add marks to omit keywords specific to generated columns when building
with -DSQLITE_OMIT_GENERATED_COLUMNS.

FossilOrigin-Name: cc6a40818387f78f89499f09e3f1c4655c7396af1cba2596c7fb2f23f3e9755f
 2019-11-01 10:49:15 +00:00
drh
bd0f0eb037 Slightly faster keyword hash table. 
FossilOrigin-Name: f12e743e19a04ecbf7eb69b675082f2e4dda05b38cd81f6588a1ce95dfc57ada
 2019-11-01 02:30:54 +00:00
drh
ff37c40787 Correctly generate pre-UPDATE content for virtual columns that are used 
by foreign key constraints.  Ticket [b9befa4b83a660cc]

FossilOrigin-Name: 40d3282ec285d9f724f6548283f48b601510cf5284da17485723fd650a68f436
 2019-10-31 20:54:20 +00:00
drh
29974f7b91 Add a few simple TCL test cases for generated columns. (Full test coverage 
of the generated column logic is provided separately by TH3.)

FossilOrigin-Name: acedb5c7f7dc1d68bef62098d42ca59e1be7a5083bb03dc07c03b9f9d817158b
 2019-10-31 17:13:17 +00:00
drh
04307c8a3f Ignore differences in Expr.op2 in sqlite3ExprCompare() in cases where it 
does matter.  Ticket [1d2a8efc6c3a595a].

FossilOrigin-Name: 329820673a12ff6a6c8759f40989d4ccf272441064b0366a5f491695b55ad0e9
 2019-10-31 13:16:26 +00:00
drh
d493353e99 Enhance the TreeView logic to show information about Expr.op2 for 
FUNCTION and COLUMN nodes.

FossilOrigin-Name: aceeaf9e28767a0880a16872867a1f57bff163acd0f10d19d5688068077590fa
 2019-10-31 12:30:38 +00:00
drh
20cee7d0bb Always disallow the use of non-deterministic functions in CHECK constraints, 
even date/time functions that use the 'now' or similar keywords.  Provide
improved error messages when this requirement is not met.
Ticket [830277d9db6c3ba1]

FossilOrigin-Name: 2978b65ebe25eeabe543b67cb266308cceb20082a4ae71565d6d083d7c08bc9f
 2019-10-30 18:50:08 +00:00
drh
920cf596e6 Simplify the bytecode generation for SQL function calls such that the 
OP_Function or OP_PureFunc opcodes are coded directly, rather than using
the intermediate OP_Function0 or OP_PureFunc0 - opcodes that are now removed.

FossilOrigin-Name: 84e02d773d60cffe619104991d21d7f0c68616c0f6bb99686bf54f5306c756d0
 2019-10-30 16:29:02 +00:00
drh
9ee94147f0 New tokens ALWAYS, GENERATED, and STORED used by generated columns should 
all be fallback tokens.

FossilOrigin-Name: 13fe6978b7de208d2e27460d824f7fc778cf6ea0aabfe566b32bb410b8816f63
 2019-10-30 13:00:23 +00:00
drh
66c48907a2 Remove the legacy_file_format PRAGMA. In its place, provide the 
SQLITE_DBCONFIG_LEGACY_FILE_FORMAT option to sqlite3_db_config().
Fix for ticket [6484e6ce678fffab]

FossilOrigin-Name: 4d424f3047b48fc441475137f30a719d2f079390c86fe2617710ddfb05c5e240
 2019-10-29 16:18:45 +00:00
drh
f4658b68fa Tighten the generated column requirement such that every table must have 
at least one non-generated column.  Ticket [166347c6fc994155].

FossilOrigin-Name: 4fba090e678ef184736277c9ec9a9374c8bd4df4d41f51a3dc6818e2efcc103b
 2019-10-29 03:39:17 +00:00
drh
b6d861e523 Add a missing translation from table column numbers to storage table numbers 
while processing constraints on an UPDATE statement.
Ticket [9621dd78a024d07a]

FossilOrigin-Name: 361ea81ae8a13e7d2ec4c2412f30e049bb6ee320980d502c86bedc315cdd3bc0
 2019-10-29 03:30:26 +00:00
drh
2c40a3eb35 Disallow tables that have only virtual columns. 
FossilOrigin-Name: 591973217f1caf24cde91dc15b7edca2edda05dac8ae2b2cd8d71e7aa072f7d1
 2019-10-29 01:26:24 +00:00
dan
9930cfe878 Fix a problem in fts3 causing it to report corruption if a doclist contains consectutive rowid entries that differ by more than 2^63. 
FossilOrigin-Name: 0b0a3048f9df88bbc8979f2ac5247bee7d7bc1e585faca252610d2fcbe36d51d
 2019-10-28 13:54:59 +00:00
drh
0f28e1bdd9 Remove a NEVER() comparison from sqlite3ExprCompare(). 
FossilOrigin-Name: f4285297e1e7ebef90bfc0f71402a4e1726d31bc15b69fec13a1f0d98fed1f08
 2019-10-28 13:07:01 +00:00
drh
76baf799a2 ALWAYS macro added for coverage. 
FossilOrigin-Name: a1e1ba9145049491c593ac70d9e05149662d34770129c270d702f284cd19a481
 2019-10-28 04:20:28 +00:00
drh
a0e16a2261 Improved detection of attempts to use a generated column as part of the 
primary key.  Ticket [91e86951016a6802]

FossilOrigin-Name: 6d1bbba9a004a2491c76b4a7d09edb9b738102c46fdcb3e0f7b22bffa719518e
 2019-10-27 22:22:24 +00:00
drh
1231b4773d Remove code from the constraint checker that generates virtual column values 
with the incorrect time.  Turns out the the regular code for all other
columns works correctly and so the incorrect special-case code is not
actually needed.  Fix for ticket [3ea175512444b0d1].

FossilOrigin-Name: 5b4c0f2ddc6f324e23bbde0ee3d1ab672cfe8ab5044c9b693f4c33cdd75c211e
 2019-10-26 23:51:44 +00:00
drh
c34f05cca7 Remove redundant code resulting from a merge error on the previous check-in. 
FossilOrigin-Name: 713fe86b8c9f3c9ef8af952019e99ba2f4741326226264de6a66baaeb1803d2a
 2019-10-26 18:56:12 +00:00
drh
a88c8c1ae4 Add support for generated columns. 
FossilOrigin-Name: b855acf1831943b3914491ed0bc333131321930cab480a5281012a3aebbba492
 2019-10-26 18:47:47 +00:00
drh
cbda9c7ac7 Performance optimization on sqlite3GenerateConstraintChecks() - bypass the 
loop that checks each column for NOT NULL constraints if it is known in
advance that the table has no NOT NULL constraints.

FossilOrigin-Name: e3c3f4d7872f431a95627d52553101388c1e39458cc7e7f93fc81255f49a89a5
 2019-10-26 17:08:06 +00:00
drh
d3c468b758 Clarify some comments and add assert() and testcase() macros to the 
replace-trigger recheck logic for ticket [c1e19e12046d23fe]

FossilOrigin-Name: 8c0042bd5ccd83f8794d19cbb1ec7564584f0dce54bfebc0ada00b836aca065f
 2019-10-26 16:38:49 +00:00
drh
a015d3c82f Fix a problem in the legacy ".explain on" formatting when it is used on 
a query with more than 8 output columns.

FossilOrigin-Name: 070b49825c5f87cce15be4b758f0dfdd65226ec379465ca527a18706a1f3b8f4
 2019-10-26 16:02:34 +00:00
drh
166bc383e2 Minor changes to help ensure the pointer returned by sqlite3VdbeGetOp() is 
not used after it becomes invalid.

FossilOrigin-Name: 346bdd49fb93aa58e8bd14250974d8c0c32cc7e8317c8b12da1fa44db10d8a3a
 2019-10-26 15:40:17 +00:00
drh
d901b168b5 Overnight, OSSFuzz helpfully pointed out a potential use-after-free bug in 
yesterdays changes, involving continued use of a pointer after the memory
pointed to had been realloc()-ed.  Thanks Google.

FossilOrigin-Name: c422afb507dc875751e6a72e4ba5f4f0793097c0de4533c1600311f689e76ed7
 2019-10-26 12:27:55 +00:00
drh
0660884ea0 Add missing VdbeCoverage() macro. Fix an off-by-one error in partial index 
handling.  New test cases.  Ticket [c1e19e12046d23fe]

FossilOrigin-Name: 41cc8e3dab998f7efc898d18837ca7fdac94ea3f89954990c5231456bf725fee
 2019-10-26 01:43:14 +00:00
drh
a407eccb61 If replace triggers are run during uniqueness checking, then rerun all 
uniqueness checks a second time using the ABORT algorithm.
Fix for ticket [c1e19e12046d23fe]

FossilOrigin-Name: fbac0c65d8464b126d385262d176864add55452ec9e3d5eb76ffee06e820cb9c
 2019-10-26 00:04:21 +00:00
drh
db561bceda Performance optimization in sqlite3BtreeCursor(). 
FossilOrigin-Name: ea068b099c96b8b9526114732d2a6be186cf381b7329d102778ad25b95510c9e
 2019-10-25 14:46:05 +00:00
drh
1b22c1b816 Merge fixes from trunk. 
FossilOrigin-Name: 4ec57d88415fa4ea2e99d4a5671074ec6829d6824bc8509d5ae9c978d47d1419
 2019-10-24 23:43:32 +00:00
drh
4485ac1a25 The previous fix was incomplete. It is also necessary to disable the 
Expr.y.pTab field when making the translation.

FossilOrigin-Name: b99d5701312f7472e6b606bd824f9273617e2655920485bf50aa96d408064721
 2019-10-24 21:02:06 +00:00
dan
ef2df8f343 In fts5, fix a case of overreading a buffer by 1 byte when counting characters in malformed utf-8. Fix for [dd1f67bf]. 
FossilOrigin-Name: 8d964e1c21d4cea699023e02b0616a75c5859dd083c9365cdcbc0676ebbdaae4
 2019-10-24 20:35:27 +00:00
drh
c7476735c9 Fix handling of covering indexes that use virtual columns. 
FossilOrigin-Name: e0f7e321eca91c49102649f70728de69347cbd7b16599b854203c24cfdc348e6
 2019-10-24 20:29:25 +00:00
drh
06baba54b4 Correction to check-in [bec5b6d4d083556d] so that it detects *all* 
triggers that might perturb the insertion cursor.
Ticket [50c09fc2cf0d91ce].

FossilOrigin-Name: 521f1d36282549488a47a434484a24924ee970d29f05a8ae499b7d536bcd692b
 2019-10-24 19:35:26 +00:00
drh
035f6d909f Do not allow ALTER TABLE ADD COLUMN for a STORED column. 
FossilOrigin-Name: 42fc08bc1528a34a603c2c085b515766a8d33ae7ea0350a52b0ca24b94ebcbc5
 2019-10-24 01:04:10 +00:00
drh
31269a9f5f Add an experimental set of UUID processing functions as the uuid.c 
extension in ext/misc/uuid.c.

FossilOrigin-Name: 1a6e009372cf9571e540812c8607e95a86740112a1091f03e3f632339eccb629
 2019-10-23 21:00:40 +00:00
drh
269d322de2 When a vector comparison appears in the WHERE clause and the constraint side 
has a COLLATE clause on the first term of the vector, be sure to honor that
COLLATE clause.  Ticket [135c9da7513e5a97].

FossilOrigin-Name: 978b2d20cf95d0b7143e3104ce1e9d5c85002867b554dc6b21deb528b730bbc7
 2019-10-23 18:09:39 +00:00
drh
6ab61d7052 Minor adjustments for clarity and test coverage. 
FossilOrigin-Name: 30065716878d4058e75eb510b0b27b68e5193d04625eb173210de8061f20f499
 2019-10-23 15:47:33 +00:00
drh
ab0992f022 Fix incorrect arguments to testcase() macros. 
FossilOrigin-Name: 812467fbf04ce00228a8381a5eee471e4e35cc63184a4538129fcd70b7cec979
 2019-10-23 03:53:10 +00:00
drh
a1a01ffb5e Fix the foreign key logic to be compatible with generated columns. 
FossilOrigin-Name: 3de57145a18c62ff9b556c7218d8b276000d0052e4890212fa9335235f22d03c
 2019-10-23 00:31:01 +00:00
drh
e70fa7feba Take the declared column time into account when computing the values for 
generated columns, and apply appropriate affinity.

FossilOrigin-Name: 9e04ba22dfce3998e61331ac229ff543ecccc590284c9dd5def21efbe594fba0
 2019-10-22 21:01:34 +00:00
drh
7b8ab230dc Merge the row-value fix from trunk. 
FossilOrigin-Name: 1fbd7438611174aa594485241c8cc2f4ea6d09c57ef2fc16c8995e8061fdfdd6
 2019-10-22 20:16:04 +00:00
drh
db36e255d5 Disqualify row-value comparisons for use by an index if the right-hand side 
has an affinity that does not match the index.
Fix for ticket [6ef984af8972c2eb]

FossilOrigin-Name: 5c118617cf08e17a6edfdfba86e3fc49132a780990b68b52724c2aaeac85f506
 2019-10-22 19:51:29 +00:00
drh
f4b1d8dc17 Do not allow generated columns in the PRIMARY KEY. 
FossilOrigin-Name: 1a54743a3d327efc8ecc45b9fde91ddfea3fca36408f9b753453c31f2e4cc69c
 2019-10-22 15:45:03 +00:00
drh
7e7fd73b25 In UPDATE processing, include generated columns in the set of columns being 
updated if and only if their generator expressions reference some other
column that is being updated.

FossilOrigin-Name: d38176e93a628e03f1bd8b689fbc4152a1495388da917c2d89cefed04353d2d6
 2019-10-22 13:59:23 +00:00
drh
427b96aedf New testcase() macros. Fix a problem with INSERT when the IPK is to the 
right of generated columns.

FossilOrigin-Name: 412799fc5527aaca987e4e04b8a4f774dcdb70fb80e3a126dc3a26d48a66935c
 2019-10-22 13:01:24 +00:00
drh
6b910364bb Merge changes on trunk into the generated-columns branch. 
FossilOrigin-Name: ba123b8c201053d8f9387de38f3513b06f7721b28d79fab8489f96d336105117
 2019-10-22 12:02:09 +00:00
drh
98c94e60d0 Previous check-in to fix [b47e3627ecaadbde] was incomplete. This check-in 
completes the fix and adds a test cases.

FossilOrigin-Name: c7da1c01f1f239e68c2173ac5748b8c5798271e43bdcee68f51f97cd0ca92bd5
 2019-10-22 11:29:22 +00:00
drh
a5d0911546 Move the sqlite3LocateCollSeq(), sqlite3FindCollSeq(), and 
sqlite3GetCollSeq() routines so that they are all beside one another in
the callback.c source file.  No logic changes.

FossilOrigin-Name: 9ff80a9bf8fee776e2f282d0597215b77d48093ebc71d047ad1457da0582ddbc
 2019-10-22 01:00:16 +00:00
drh
898c527eaf When flipping ("commuting") a comparison operator, set the new EP_Commuted 
bit rather than adding extra EP_Collate bits, to single later processing that
the order of precedence for COLLATE operators is inverted.
Fix for ticket [b47e3627ecaadbde]

FossilOrigin-Name: 90f7c477354d67d22d5eb0da22dac579f384ab44743fdc19887220e32203ebc2
 2019-10-22 00:03:41 +00:00
drh
2c3de90da1 Add a VdbeCoverage() macro that was omitted from check-in [eea1e7aa57e74c43]. 
FossilOrigin-Name: cd2317d04c1c4bcf5fe63aa02a6051bdfae8f5566a098e3f45bf9ec1dd0c3ea6
 2019-10-21 23:41:56 +00:00
drh
276d7f7847 Try to fix a harmless compiler warning reported by ICC. 
FossilOrigin-Name: 7f41b44ca2ecb907ea0fd09a974ac9dbdf911463a94f0f77c826cf1b1d9c3e8c
 2019-10-21 16:15:57 +00:00
drh
f5f1915d59 Changes to the INSERT logic to make it simpler and faster and so that 
it works with generated columns and BEFORE triggers.

FossilOrigin-Name: bc368cb090376d33d3844e3689c4f6bd19eed758e39b878ee67fef93b1c839ea
 2019-10-21 01:04:11 +00:00
dan
52612bec3c Fix a resource leak in fts5 that could occur if an auxiliary function is called from within a query that does not use the full-text index. 
FossilOrigin-Name: b528bdcd45db1b783ecd9739c3d3c890f04de7003f079668970eafaf8e23b2f3
 2019-10-20 08:26:08 +00:00
drh
dd6cc9b52a Work toward getting generated columns to work with triggers. Still more 
work to do in this area.

FossilOrigin-Name: 932a37275d7e932f8237d32c8fc6087ed8cd342fe01ef2f7a43c7237ab84c9ac
 2019-10-19 18:47:27 +00:00
drh
c5f808d85e Add testcase macros. 
FossilOrigin-Name: fb9c9bb284d441bd7aa34c87b6fd8ce57d036c17623d82354154fc6286bdd134
 2019-10-19 15:01:52 +00:00
drh
b9bcf7ca60 Refactor names of column index transformation functions, for clarity. 
Get generated columns working with ALTER TABLE RENAME COLUMN.

FossilOrigin-Name: 27ab41c9102e7801ff829488fc123a8040da008bef373d6704efbe2f93e1da90
 2019-10-19 13:29:10 +00:00
drh
f95909c764 Fixes for WITHOUT ROWID tables with VIRTUAL columns and an INTEGER PRIMARY KEY. 
FossilOrigin-Name: 86074da0fd2949e231898ef0bc672d90fd89cefa49fb0eb50ff398fbdd91d1ad
 2019-10-18 18:33:25 +00:00
drh
4102deb962 Merge trunk enhancements into the generated-columns branch. 
FossilOrigin-Name: 85bc4524d76999080faa4474e8880d2b6a2ac3a7f6a76239af4de1a42f8138c8
 2019-10-18 17:47:47 +00:00
drh
8e10d74b21 Get generated columns working for WITHOUT ROWID tables. 
FossilOrigin-Name: 9f409649ec4282a47f0a8b079b419f1922e0c24779b297f477ced168d5b7910d
 2019-10-18 17:42:47 +00:00
drh
491c5bea7a Enhance the ".imposter" command in the CLI so that the first argument 
can be an existing WITHOUT ROWID table instead of an index.  The resulting
imposter is the same table, but with columns in storage order and with
all constraints removed.

FossilOrigin-Name: 9dc0d34586eebf6705d9bd81494c417ac76707b8625d1ff99eda18b4ca2d8a50
 2019-10-18 15:58:50 +00:00
drh
6df9c4b990 Claw back some performance from the sqlite3ExprGetColumnOfTable() routine. 
FossilOrigin-Name: e8426acb94179ff49549aced6ea3c26c49ba4761c2f414fa1772d6a031edc79d
 2019-10-18 12:52:08 +00:00
drh
01ef55e0f5 Fix sqlite3ColumnOfIndex() to account for virtual columns. 
FossilOrigin-Name: 447271123e3b467d9271a4c0cf27f47af2f865c9298b8c355d9e766411a1f422
 2019-10-18 12:14:48 +00:00
drh
463e76ff8f Get indexes working on virtual columns. 
FossilOrigin-Name: 450c48766c8e62653d074c95f69b0576de3880d183a1d1e5992d88b6fce6cc39
 2019-10-18 10:05:06 +00:00
drh
9942ef0d95 STORED columns can now reference other STORED columns, in any order, as long 
as there are not loops.

FossilOrigin-Name: 0d236698e64b2a4b46f91a25279c406e0bf392fe66116678456f0a034c11d7b4
 2019-10-18 02:19:18 +00:00
drh
0b0b3a95d0 In the Table object, change the nVCol field to nNVCol - the number of 
non-virtual columns, as that is the quantity that we need most.

FossilOrigin-Name: 4ad66af04a654d92711d2d056ce8f35cd21eac4b99fb8d78be1a314620b6d29e
 2019-10-17 18:35:57 +00:00
drh
d4cd292c2a Bug fix with INSERT using an explicit column list on a table with 
a non-final STORED column.

FossilOrigin-Name: 61b4459ae6a6cc182c11abbc8b1dd629f77beb088d7ccad5e563d8d4769056df
 2019-10-17 18:07:22 +00:00
drh
c143114460 Some (but not all) INSERT and UPDATE statements now work for STORED columns. 
FossilOrigin-Name: fe7517bf4d360597576ab9aba29627d7926d23f2bbbfb3e7bf4d32761617574c
 2019-10-17 17:54:05 +00:00
drh
ae3977a8f3 Fix the xfer optimization for generated columns, so that VACUUM works again. 
FossilOrigin-Name: 8f67b89b04622c1509dc102a83be7a80057dc791625804fc2c294089c98b97e4
 2019-10-17 16:16:34 +00:00
drh
8a53ce2ff8 Basic UPDATE functionality working for VIRTUAL tables. 
FossilOrigin-Name: c21959d4eb5d742a097a98e1874c0bf132dc962a97a65be1ab22d6ca3cf2b261
 2019-10-17 15:59:03 +00:00
dan
b2075011a7 Avoid an infinite loop in fts3/4 incremental-merge in the case where the lowest level in the database contains segments but no data (because there is a delete-marker for each valid entry). Fix for [bf1aab89]. 
FossilOrigin-Name: 35beaee059a6cccead4311886ca928d936f23584cf435e35e265e98feea723dc
 2019-10-17 15:41:36 +00:00
drh
676fa25a0f Bug fixes so that "make test" once against runs with no errors. 
FossilOrigin-Name: 7bfe0f679d8951b3e925bdf549efa0f8d6b514eddeaca69cbfddbd9476cfff5f
 2019-10-17 14:21:07 +00:00
drh
ab3c5f26ab Fix the table_info and table_xinfo pragmas so that they work with virtual 
columns.  Table_info omits virtual columns.  Table_xinfo gives them a
"hidden" flag of 2, and 3 for STORED columns.

FossilOrigin-Name: 069351b85f9a706f60d3e98fbc8aaf40c374356b967c0464aede30ead3d9d18b
 2019-10-17 13:15:40 +00:00
drh
ab45fc0413 INSERT with named columns for a table with generated columns. 
FossilOrigin-Name: 64db39f92d68d1b9f23e48af35e16b969c38b58041fbe900066eeb3ddb291cef
 2019-10-16 22:01:56 +00:00
drh
c27ea2ae8d ALTER TABLE is able to add a VIRTUAL column. 
FossilOrigin-Name: 120c6b78cb51532f783014605f1107d40b2e4f54e3852fb1f8f167d0c0b78c69
 2019-10-16 20:05:56 +00:00
drh
7e508f1ee2 Simple INSERT and SELECT operations working with VIRTUAL columns. 
FossilOrigin-Name: 7f9f90b1b885fa9905b296f2e0fcc9b2341019b42fc839722a93cf60e49a9252
 2019-10-16 19:31:46 +00:00
mistachkin
16fd04cdbe Enhancements to SQL query normalization for UPDATE statements. 
FossilOrigin-Name: bba975c7af3de9aeb5c62fb8b05d61b96e4ecd0b030008442bbdd345e1e5f134
 2019-10-16 17:46:22 +00:00
drh
2da8d6fe74 If an AFTER DELETE trigger fires when a conflict row is deleted by REPLACE 
conflict resolution, make sure the conflict really has been resolved and that
the trigger did not recreate the row before continuing.
Ticket [a8a4847a2d96f5de]

FossilOrigin-Name: eea1e7aa57e74c4329003f4550168e2aed9e33d2301a3ba84b10781a9cebbc1b
 2019-10-16 14:56:03 +00:00
drh
81f7b37270 Initial experimental code for generated column support. Non-functional. 
FossilOrigin-Name: 11d472c1df707b8d03ec57d8fc582a34f5eb89a9d02a154a9871650c65065b45
 2019-10-16 12:18:59 +00:00
drh
4ec3e820a0 Formatting change on a multi-line conditional, for improved clarity. 
No logic changes.

FossilOrigin-Name: 7248e3476511ecd317f54edcfe1e87443bfdcc1b10c89c7734eefcabafec6c0b
 2019-10-15 19:01:55 +00:00
drh
68748ec509 Futher improvements to the IN operator for row-values on virtual tables. 
FossilOrigin-Name: bc751fb64d5b08e5ca4c85cd1c6fbf09590fa9dad7e176ba373082ea373655b5
 2019-10-14 20:32:31 +00:00
drh
4a9f379c9c New test cases in test/fuzzdata8.db. 
FossilOrigin-Name: 344d9cb0c726078af6deb4a26bed3aded5b26914bb286d3446d3a4e9150840b7
 2019-10-14 15:24:20 +00:00
dan
2d82269ca8 Fix a problem with row-value IN(...) operators and virtual tables. 
FossilOrigin-Name: aa57d7abac0bb92d4d5fd4e093a11cf8efc04e4eed748b2a400d01f137250649
 2019-10-14 15:15:50 +00:00
drh
a0fe5fe54f When Select-Trace is enabled (in debugging builds only) do not show the 
result of Window function tree rewrites if there are no window functions.

FossilOrigin-Name: d1acf72ae1ea7484bb9c3a8630094f1a3a9597578c7b9d6e02fc0a4e3f59c57d
 2019-10-12 23:38:00 +00:00
dan
d681626a8b Update the zipfile extension to use deflateBound(), instead of compressBound(), to learn the maximum possible size of a deflate()d buffer. 
FossilOrigin-Name: f5ee30426e8876e70304f852153b56991a2a66e0f6a82597e9dcccf49163272d
 2019-10-11 18:55:10 +00:00
drh
a1698993e6 Futher improvements to LEFT JOIN strength reduction. 
FossilOrigin-Name: 8a39167bd2d46496f7484cfec371e4bad22da882209b01da9459c4ed5877da25
 2019-10-11 17:14:40 +00:00
drh
4a254f98e3 Improvements to the LEFT JOIN strength reduction optimization. 
FossilOrigin-Name: 548082dfab5d9484279ccc11cd2833ac131b54b7481372b576d7c28bbb3294ea
 2019-10-11 16:01:21 +00:00
dan
8b4d0e2cba Ensure fts3/4 prefix indexes are flushed to disk before an 'optimize' command. Fix for [745f1abc]. 
FossilOrigin-Name: 4ed905b18847d4dbf5a2570052abced338065f824137b90300f62d77b3159d80
 2019-10-11 15:33:13 +00:00
dan
9613c9f4a6 Fix the fts3/4 integrity-check command so that it works with "ORDER=DESC" tables. Fix for [8a6fa2bb]. 
FossilOrigin-Name: 5863546df99abd1ad4ebcaba18dec647be4368e2c13ce0b28e48c8608d3e87ef
 2019-10-11 14:27:17 +00:00
drh
656d535ae6 Increase the version number to 3.31.0 for the next release cycle. 
FossilOrigin-Name: ffd4c30620abe6ba38d82f3db934d18cc8468aaac4cd50a4e01be8910854d3f0
 2019-10-11 14:25:00 +00:00
drh
21f6daa2cd Faster response to sqlite3_interrupt() in the OP_IntegrityCk and OP_Count 
opcodes.

FossilOrigin-Name: bf875dc59909f9c22f7c1fc843bc4d9e5d97af5cb4ef43c4fa1d566ddfdeaacb
 2019-10-11 14:21:48 +00:00
mistachkin
af94adf049 Update the autoconf makefile for MSVC. 
FossilOrigin-Name: 9455643eecb74c8ac93ad3b3566f30e380dd912cdce3de993da5af42973ac59c
 2019-10-10 23:58:28 +00:00
mistachkin
6dcf9a451e Fix harmless compiler warning seen with MSVC. 
FossilOrigin-Name: 73a82114733af2a316f20eb8578badef307d14286c6ec03197744a6793425161
 2019-10-10 23:58:16 +00:00
dan
0287c95165 Prevent SQLite from assuming that if ((? IS NOT NULL) IS NOT NULL) is true, ? may not be NULL. Fix for [d51a8696]. 
FossilOrigin-Name: 7833feecfe745e237f239ee4c38a9e4bf7ad66a32919150208da87c00a826473
 2019-10-10 17:09:44 +00:00
dan
cd79010964 Fix a problem in the fts3 integrity-check routine causing it to report as corrupt tables that contain values with embedded 0x00 bytes. 
FossilOrigin-Name: 629e20c9880acc2cb9e2fa6da39a15a90483e9a8f433df29d285c23bdfb03b0b
 2019-10-10 16:41:44 +00:00
dan
3703edf110 Be sure to rewrite column references inside FILTER clauses and window frame definitions when flattening queries. Fix for [1079ad19]. 
FossilOrigin-Name: ccba7202b69d239724c3b589439c9c3b0e1bba237accfeb11c39d492522b8719
 2019-10-10 15:17:09 +00:00
dan
da03c1e65e Avoid assuming that an expression that contains the sub-expression (? IS FALSE) or (? IS TRUE) may only be true if ? is non-null. Fix for [a976c487]. 
FossilOrigin-Name: eb7ed90b8a65748f0721aaf7bdddd2207f552be5015603fbfb7044d815ae2f36
 2019-10-09 21:14:00 +00:00
dan
ae55737fbf Do not allow users to effectively disable fts5 crisismerge operations by setting the crisismerge threshold to higher than the maximum allowable segment b-trees on a single level. Fix for [d392017c]. 
FossilOrigin-Name: 86e497209217abb7bcb491a023cd353f3c7c9c103ebd9f58dd8661b12cf3694c
 2019-10-09 18:36:32 +00:00
drh
92a2824cc6 An improved fix for the dbsqlfuzz-discovered ALWAYS() failure following OOM in 
sqlite3ExprCollSeq().  This time with a test case (engineered by Dan).

FossilOrigin-Name: 907f7965b335d8d5441f2e386bb190d1f93ffcd45ca98d2d1c621dede491fc5e
 2019-10-09 15:37:58 +00:00
dan
a6bd1871d1 Disallow fts5 page sizes greater than 65536 bytes - as there are 16-bit offsets used in the page header. 
FossilOrigin-Name: 75775c5ab44e497cb19be10397229637f1374f05c3244e8f92d6c54fcea94f5f
 2019-10-09 15:26:45 +00:00
drh
76f8318e31 Remove the "fastfuzztest" makefile target. Use only "fuzztest". 
FossilOrigin-Name: e17571c789db31123642d0ed1f3d8764e070019e0deb8b88cce58d2183551cdf
 2019-10-09 15:08:27 +00:00
drh
9fd04bfd29 New test cases added to test/fuzzdata8.db. 
FossilOrigin-Name: b68d21e93a0839b42f49845918df7738ee7fa2a05c7f4ae2f89fdbb5e47ad8eb
 2019-10-09 15:03:45 +00:00
drh
efb02281a4 Change sqlite3SelectDup() to always return NULL if an OOM has occurred. 
FossilOrigin-Name: 01ba4641ab436c6065c8725908fc0913f2abded4ea62e004b7534e0116b9451a
 2019-10-09 15:00:37 +00:00
drh
c0efa4d309 Use the "fuzztest" target in place of "fastfuzztest". 
FossilOrigin-Name: 7129e468fd182c1820cdfa2c66a81d1697e5d1580680b77c0df9bb0ae0049e0d
 2019-10-09 13:52:31 +00:00
drh
07eb7f89a0 Remove the obsolete "fastfuzztest" target from the makefiles. 
FossilOrigin-Name: 3d44f1ee0f606409bc9c091dae2c9d2e78ada318a0de08437f4f4835a1a5d203
 2019-10-09 13:12:55 +00:00
drh
f3ce2483f5 Save CPU cycles in sqlite3Prepare() by, among other things, shifting the 
EXPLAIN column label logic over to sqlite3VdbeMakeReady().

FossilOrigin-Name: 1ca5ef84506aac3e2f08baa36095b3befdeedf2a3443fcd9154a277b55cbf64b
 2019-10-09 01:19:07 +00:00
dan
fbd79cc585 Fix problems with using the fts5 'rebuild' command inside a transaction that contains other updates of the same table. Fix for [e258f008]. 
FossilOrigin-Name: 238e0835714696aba0631f288fcc30ec5fddb43893d469c6bf017f386b3cddee
 2019-10-08 13:34:24 +00:00
dan
b186a622ee Disallow page-sizes smaller than 32 bytes in fts5. Also ensure the fts5 integrity-check works even when "PRAGMA reverse_unordered_selects" is true. Fix for [265e935b26]. 
FossilOrigin-Name: 8ab0aebdb3c2d6fb3160b2c58ce6cc0495a6ddd960878a6395958c837f3d1b71
 2019-10-07 20:36:18 +00:00
drh
38587159dd Omit a pointless memory allocation in vdbeSorterSort(). 
FossilOrigin-Name: 5d76dbc5b0584c15d7d59e5c079868f2077f32b865f406b40ec837b8ab6ef2e1
 2019-10-07 20:33:26 +00:00
dan
03e025e217 Fix a problem with running ALTER TABLE ADD COLUMN statements within a transaction that writes to one or more virtual tables. 
FossilOrigin-Name: 31e85fbbc4cfd09a98b4a6dc6624f863816f376c6a4eef1fafc657c8e1abbc36
 2019-10-07 18:43:21 +00:00
dan
8451e1fa27 Add a test case for the assert() fix in the previous commit. 
FossilOrigin-Name: 32fba11ab72f6300391267eaad64e92fa767c289029e668e4bd6c9165acf1487
 2019-10-07 13:46:43 +00:00
drh
093589de5e Fix a faulty assert() statement in the sqlite3VdbeMemExpandBlob() routine. 
FossilOrigin-Name: 69a26eade2f92029e722a5a654214b1e2a3fc7ed497ce9aa5a7dce944f90e502
 2019-10-07 13:26:58 +00:00
drh
b29ef5ef03 Fix the OP_SeekRowid opcode so that it works correctly with a Real argument 
without damaging the value in the register that is the argument.
Ticket [b2d4edaffdc156cc].  Test cases in TH3.

FossilOrigin-Name: 3cde82c86b963fa75192907d548febd3882c7d8fc7daf1903fadd5ca46623be1
 2019-10-07 01:05:57 +00:00
drh
705e73344e Omit the check for conflicting shared-cache locks in sqlite3Prepare() if the 
database connection uses no shared cache.  We might be able to go back and
remove this code completely, due to the newer Schema.iGeneration logic, but
that will take more analysis.  This check-in gives the speed benefit but not
the reduction in code size.

FossilOrigin-Name: 0b73a09270dfafb27f8d1762b547ef8178c9da66f45e7153ff0b76272dfa92f5
 2019-10-05 19:53:21 +00:00
drh
1de92a64cd Optimization to sqlite3VtabUnlockList() for the common case when there 
is no work to do.

FossilOrigin-Name: fc8d45086dc2bcb9bce756088e99e63cbeedf9129139fb0e6a48b43c4f502180
 2019-10-05 19:24:52 +00:00
drh
a22d2fca33 Call sqlite3Prepare() directly, rather than going through sqlite3_prepare(), 
when processing the sqlite_master.sql column for a schema.

FossilOrigin-Name: cc49380ea76a4a05843d3a0bdfb925464dc9d72c33cf5ab5243dd07d161ad038
 2019-10-05 18:33:25 +00:00
drh
4d29448114 Reorder two comparisons for a small performance gain in OP_Transaction. 
FossilOrigin-Name: d7667f6560318272c8b35b478e29b0ed134105dfd119a2fd53ef0490442c60cc
 2019-10-05 15:28:24 +00:00
drh
31f69626df Performance optimization to the lookaside-memory disabling mechanism. 
FossilOrigin-Name: 17ce1c49cb0ed6fdd8c7c33431bc2afa217f1092c99b8dd608890a8e7aec7fb1
 2019-10-05 14:39:36 +00:00
drh
228a52d973 Version 3.30.0 
FossilOrigin-Name: c20a35336432025445f9f7e289d0cc3e4003fb17f45a4ce74c6269c407c6e09f
 2019-10-04 15:03:17 +00:00
dan
6117a17323 Avoid running a couple of tests in affinity2.test as part of the valgrind permutations, as the way floating point computations are simulated by valgrind causes them to fail. 
FossilOrigin-Name: 7f9a4b6015ac332a04d3e394a6b3210fc95253d8786a261178a5639cb8d9d987
 2019-10-03 16:02:22 +00:00
drh
d1c472dab6 Increase the precision of floating point value display in VDBE debugging 
output.  No changes to normally deployed code.

FossilOrigin-Name: a561a656ff50efc0103da3988626cea3ef05757403b83960f2aa6c0a48c2765e
 2019-10-03 14:51:59 +00:00
dan
b008e4d744 Fix some test script issues that come up with SQLITE_OMIT_VIRTUALTABLE builds. 
FossilOrigin-Name: 3934d2d08ee14d644dc01f967c10f219b76b172c963c90a7a8141f2b08a7d5bf
 2019-10-03 14:36:36 +00:00
dan
367b8d7aa7 Fix issues with command line invocation of wapptest.tcl. 
FossilOrigin-Name: 9e0d5d2640a92070967bc9fdf5c5b1653e41b9c04e04dcb70f18ead10f053aef
 2019-10-03 13:44:08 +00:00
drh
9a50f4c72a Update error detection logic in releasetest.tcl to account for new 
output formats in USAN.

FossilOrigin-Name: 3f36b988360204628d5ad1df2db34818b9a2d6ba989018d4c17757229f4b0f65
 2019-10-02 19:44:42 +00:00
dan
f0578823dd Update corruptM.test to account for the fact that the database schema may be loaded from within the "sqlite3" command for some test permutations. 
FossilOrigin-Name: cb9470fc064aad72a4e42c6a021410401b3b1a32446ae8b9cd9c759f0a2a01ef
 2019-10-02 19:43:38 +00:00
dan
23d3f5d661 Fix a long-standing problem in fts4 incrmental merge. 
FossilOrigin-Name: 67da31e24ebb49c4cac81c9e7cfca37ca422555fd0fdb01d8f180890783c84ff
 2019-10-02 19:33:34 +00:00
drh
e2b7a7693e Disable sqlite3_drop_module() tests when virtual tables are omitted from 
the build.

FossilOrigin-Name: 9f4035f91a9f914797c67afbf19139b2cd25aea48595f7254fe5d18cd693d972
 2019-10-02 00:25:08 +00:00
drh
cfee884e73 Remove references to test scripts analyzeA.test and analyzeB.test from 
permutations.test, since those test modules no longer exist.

FossilOrigin-Name: 2394879698107479270c9d899c704de3756ceae177a338b3c37844e2a31aa6dd
 2019-10-01 21:31:57 +00:00
drh
5e81e9fdae The nodeReaderInit() function in FTS3 may not assume that the node is 
non-empty.

FossilOrigin-Name: 361eb2f682a303bba72b39d322d9de630494ca044fe0508dcb23b6130d312d85
 2019-09-30 19:13:31 +00:00
drh
905d4729d3 Add missing comment to constant definitions. 
FossilOrigin-Name: 661a3789eb329a2487855e49c31067a9dde4c91c1a3a65b65375d079f906b1da
 2019-09-28 18:28:19 +00:00
drh
018dbb17a8 Improvements to a comment. No code changes. 
FossilOrigin-Name: 1a3671c7003bfff817a8239424c2f945d9dfced97daadb5a5acab203b9bda69b
 2019-09-28 16:14:55 +00:00
drh
5c0666d9e3 In FTS3/4, the poslist end marker must be larger than any other possible 
poslist value, even on a corrupt poslist.

FossilOrigin-Name: 752679aea5a6bbde24cbf39e2fa018f7dd1c226d463ca4bd74125303b2255170
 2019-09-28 11:19:56 +00:00
drh
5f419b3bba Update requirement marks due to changes in documentation wording. 
FossilOrigin-Name: 326cdc16f4db23c1d17596e4ef8d9d7abc672d48665950029ba53fd40c1b2d99
 2019-09-27 17:36:37 +00:00
drh
e4079e1fc5 Allow compile-time options -DHAVE_GETHOSTUUID=0 and -DHAVE_GETHOSTUUID=1. 
FossilOrigin-Name: 3bcb9cc104e0265a600b03415ad955187fc6445ea8e46dc656412cba5bc1d621
 2019-09-27 16:33:27 +00:00
drh
ebc6408484 Alternative implementation of the previous check-in which is testable. 
FossilOrigin-Name: 102ef64462cf0d78395ccc7ebb8e3bf6b7647c06b7657a037e051697bc08d6b7
 2019-09-27 15:15:38 +00:00
drh
818a3b5486 Fix sqlite3ExprCompare() so that it ignores differences in the Expr.iTable 
field for IN operators, as otherwise it can lead to false negatives, which
is usually harmless, but can cause problems for an assert() in the window
function logic.

FossilOrigin-Name: 6a204b192a6c6f21988cab217366f21b14c672b81ceadc43675761a6d8c4484f
 2019-09-27 15:01:02 +00:00
dan
7971b7fe92 More minor test file fixes. 
FossilOrigin-Name: 352878fe1cbcf7b6803624544bba5a95565d1638d4dd09e91764ddad17889301
 2019-09-26 20:57:53 +00:00
drh
91f34eab2d Allow DROP TABLE to work on tables name "sqlite_parameters" just as it 
does with tables named "sqlite_stat%".  Fix for the ".parameter clear"
command in the shell.

FossilOrigin-Name: e768179baacb2423205a774cc8149fe58ed86a9320102aff4844b1d8933aa1db
 2019-09-26 20:05:16 +00:00
dan
9d30c8ff8f Minor fix for test file indexexpr1.test. 
FossilOrigin-Name: 0ceab26f15c4c7039647cbccf8939dd5c36a60b70ffeefcd3b415c8d4d8351cd
 2019-09-26 19:53:26 +00:00
drh
ec39707fe6 New dbsqlfuzz cases added to test/fuzzdata8.db. 
FossilOrigin-Name: 49073b7003330027303c4c776e9f85112f8b99b89f848fec3f953eba501d7505
 2019-09-26 16:57:42 +00:00
drh
d79cd92b23 Test for an OOM condition in resolveAlias(). 
FossilOrigin-Name: 322eca7f6ad2234059669015aabb773a790e8bc3da95431c9c851ff5342c969b
 2019-09-26 16:08:35 +00:00
dan
a51ddb1ed7 Fix a window-functions problem that could occur if an ORDER BY clause contains an alias for a window-function that is not a top-level expression. 
FossilOrigin-Name: 1cc6cf6407c6e25aeafeca379a93d0ad2614839c07fb3644e46926fce5f1cfab
 2019-09-26 15:53:37 +00:00
drh
b19131a8c6 Add a missing VdbeCoverage() macro. 
FossilOrigin-Name: 36d35dbd5a80dc4a149ed7409cc4b43712622fc4c6a8915b4fbb62fd1d6b7763
 2019-09-25 18:44:49 +00:00
drh
2829df082c Remove an unused variable. 
FossilOrigin-Name: a19884455b9bafcdc769362d61cfd02df1b5643263e004cb533698bbcfca752b
 2019-09-25 17:47:41 +00:00
dan
e7579a53fb Further simplifications to window-function code. 
FossilOrigin-Name: 5fe15c1d8383989257e11d1806e6b035acacd1b504ae385ba58d20db10f26eee
 2019-09-25 16:41:44 +00:00
drh
edf8a7bf57 In the previous check-in, the variable should be openMode, not openFlags. 
FossilOrigin-Name: 77b0db22d6c7a031f332bfcf1c8fcd94e464de9f2396f0327ee761a30ebc8b60
 2019-09-25 11:49:36 +00:00
drh
1116b1785c In the unix VFS layer, do not attempt to chown() the journal to be the same 
as the database if running in 8+3 filename mode.  Also, update the comments
on the chown() attempt to be more precise.

FossilOrigin-Name: ab853724a7e01ca32167d294c3c80d6632e805bdf39b6d56db82226a00ad72dc
 2019-09-25 10:36:31 +00:00
drh
c5b35ae567 Simplifications to the window-function code. 
FossilOrigin-Name: 489a1eb3aa2f1225b97b50a5f8688cf1a4ab0371973da1badc29616d70386c03
 2019-09-25 02:07:50 +00:00
dan
37d296a717 Bug fixes for window frames of the form (... RANGE BETWEEN b PRECEDING AND a PRECEDING) or (... RANGE a FOLLOWING AND b FOLLOWING) where (a > b). 
FossilOrigin-Name: 040e196a8be3ca41b9365310ab88c2a3cc84b918a6511c77a6d95d4b4e0da3ed
 2019-09-24 20:20:05 +00:00
drh
5776ee5cf5 Omit the sqlite3IntTokens array constant for a code simplification. 
FossilOrigin-Name: f907395ef5a2dc1d084b6a286af00de4c742cf12d4f347c21e1b757786508f57
 2019-09-23 12:38:10 +00:00
drh
7ca1347f59 When a scalar subquery has a pre-existing "LIMIT X" then change it to 
"LIMIT X<>0" rather than just "LIMIT 1" so that if X is 0 the limit
will still be zero.  Ticket [99cd4807dc03f178]

FossilOrigin-Name: 82e5dcf5c1d500ed82f398b38fdae0f30033804e897fbab3c10f1e15e2abedef
 2019-09-23 11:55:22 +00:00
drh
b7fc7c8556 Fix a harmless unused variable warning in the test logic. 
FossilOrigin-Name: d7673a445f4cde8f71153ce81efdc34fbed8b8625714d54afae1a83d548671ff
 2019-09-21 18:49:12 +00:00
drh
e39f388eb1 Fix harmless compiler warnings. 
FossilOrigin-Name: 8ea1dc727d391b15d0c4fa858ff68d5b8a63dde46408f24027dac8d28f044cbd
 2019-09-21 17:31:03 +00:00
dan
8c9bcb2328 Allow SQLite to omit redundant ORDER BY sorts in the case where a SELECT statement has GROUP BY and ORDER BY clauses that use the same expressions, even when the ORDER BY expressions are marked "DESC". 
FossilOrigin-Name: 20f7951bb238ddc0b8932a55145df426b6fdf7b8631e069345902c853c90f191
 2019-09-21 15:44:12 +00:00
drh
e47d5ca737 Add --multithread, --serialized, and --singlethread options to the 
speed-check.sh test script.

FossilOrigin-Name: c17078af6046ba3cb0d7819c915a800c851d7368e13d149140db2a124df32bab
 2019-09-21 13:34:59 +00:00
dan
af9b58b335 Simplify the fix in the previous commit. 
FossilOrigin-Name: 5ef64b0f55d952c7b0016055eaf6bbc1b5b7afc09a62ee8e5e694ffa9863ac7c
 2019-09-20 21:12:40 +00:00
dan
ed09dddece Fix a problem with queries containing a min() or max() function for which the FILTER clause excludes all rows. 
FossilOrigin-Name: b1d7e104e034655fe41bc55c562d91e8074a2973d538b8b29301458db45afc57
 2019-09-20 20:52:16 +00:00
dan
14e3e22773 Fix an assert() in fts3 that could fail when accessing a corrupt database. 
FossilOrigin-Name: 601ce9532d34f97a5faa170b6d8a272e5c54f2eabff84660201a1840e0fd9929
 2019-09-19 13:51:52 +00:00
drh
6d2566dfc2 Always clear the temporary register cache after coding a subroutine. 
FossilOrigin-Name: b6f2a7f9cdb547c925f08306df82519e41a7a0dd2cabd9861a48917bb6eef845
 2019-09-18 20:34:54 +00:00
dan
572b0dddee Add extra tests for the handling of corrupt records in fts3. 
FossilOrigin-Name: 40e29a47d1266c16a4992e43579a51addcc632503099c4cd128f77dd4e67da3c
 2019-09-18 17:22:00 +00:00
drh
aa16c603ab Fix another potential "jump depends on uninitialized value" warning. 
FossilOrigin-Name: 633b214e9b9d99788ed72ab4823a69a43c7c40ed07fb76c7d56c50453c0e58ab
 2019-09-18 12:49:34 +00:00
dan
4b48c72721 Fix a "jump depends on unititialized value" valgrind error in fts5 triggered by corrupt database records. 
FossilOrigin-Name: 6b6751cd90601a1e2744a7d233c973291ecb783801b9327c3b99734dd22bcd27
 2019-09-18 11:46:34 +00:00
drh
9d70284022 Fix an OOB read in the INSTR() function introduced yesterday by check-in 
[3fb40f518086c1e8] and detected by OSSFuzz.  The test case is in TH3.

FossilOrigin-Name: d49047c1b59bbfd05204af9973cdb0fab51b4d2661b550aec10d917fff94dc9b
 2019-09-18 11:16:46 +00:00
drh
ec722c1088 Do not change the OP_String8 opcode into OP_String until *after* any necessary 
encoding conversions are accomplished.  Otherwise, a rerun of the prepared
statement after an OOM can result in errors.  Test case in TH3.

FossilOrigin-Name: 8efd62594eae725decb719aa7777c020f982b7cdc2c92bab3b91bf349a5bc298
 2019-09-17 21:28:54 +00:00
drh
e691dcb506 Test cases for ticket [587791f92620090e] 
FossilOrigin-Name: ca0e3a83a1c015b346a791e6de03904d17a769c52dad0e3d71316c6e2e3f43c7
 2019-09-17 13:30:30 +00:00
drh
97b0250599 Fix the instr() SQL function so that it makes a copy of its argument 
before changing the datatype, since the datatype affects processing.
Also fix the sqlite3_value_text() routine so that it always works even
for values obtained form sqlite3_value_dup().  Ticket [587791f92620090e]

FossilOrigin-Name: 3fb40f518086c1e8d11eb1f4134e965450dbedfa4277bce39ef1e969fc747d38
 2019-09-17 03:16:29 +00:00
drh
70738712de Improved type information display when tracing VDBE execution. 
FossilOrigin-Name: ee83d8e30d6f9ca8f1cce653ee094ff151f633f4b6a21dd814ab07e8cfb901eb
 2019-09-16 20:16:17 +00:00
drh
91f473b5cc Do not attempt the LIKE optimization for non-text columns and a pattern 
prefix of "-".  Ticket [0f0428096f17252a]

FossilOrigin-Name: 6fe0367f9a337b7c62886b7771f3ce0642faa13f4e4f3d9a0c848abbab514cd0
 2019-09-16 18:19:41 +00:00
drh
130dbc3d96 Add recent interesting cases from dbsqlfuzz. 
FossilOrigin-Name: f06ef3d75d85545dd58c6dda10f7ad04fafbb7ae8706b3821be21f86a94795f1
 2019-09-16 15:15:38 +00:00
drh
2ad35d980b Documentation updates for the SQLITE_DIRECTONLY flag. 
FossilOrigin-Name: 5beb6dc9bc2d3d0003e33488df9c01aaf28c41c30fd9ca35543cbe3ec5a8d9ce
 2019-09-16 14:42:07 +00:00
dan
b42eb3571c Fix a problem with processing CTEs that use a WINDOW clause. 
FossilOrigin-Name: ca564d4b5b19fe56842a04f31bb61352e6ae9d72a7e7634eb27ebcf5f670545a
 2019-09-16 05:34:08 +00:00
dan
8cce6b8310 Add the --no-rowids option to the ".recover" command. 
FossilOrigin-Name: 01d71b947a7422081d5c7d6ac2c91b9c936dc41926ab58c92f4a088a64e8c051
 2019-09-14 16:44:51 +00:00
drh
d44c617ad4 Extra comments on fields of the Window object. 
FossilOrigin-Name: 3dbed162518a73213bbfb137c763064518fdc2daeae3952cfab39ce0e6813d3f
 2019-09-14 16:21:02 +00:00
drh
fab5b07395 Fix the windows inverse function on the JSON aggregates. 
FossilOrigin-Name: f464d847af490dd3ec45565dcc4c2e6ff4ed1ebb65036f30ca0b3ce2e73080e6
 2019-09-14 00:21:34 +00:00
dan
51a75aaa76 Fix a problem with using json1 window functions with an EXCLUDE clause. 
FossilOrigin-Name: 4a1978814da41608a16f6953bd575c97d587a34bd80b7ac0e619d62bfdc903d2
 2019-09-13 20:42:46 +00:00
drh
e087a7c35b Fix the windowB test module so that it works even if SQLite is built without 
JSON support.

FossilOrigin-Name: 807975c76b36347f02aa0ce9661d608adbffe1f7e77c15f8da677e47e1187153
 2019-09-13 18:59:04 +00:00
dan
cd9cb85a41 Add the SQLITE_SUBTYPE flag, which may be passed to sqlite3_create_window_function() to indicate that the window function uses sqlite3_value_subtype() to check the sub-type of its arguments. 
FossilOrigin-Name: ba2ebc3a348decc5cedaf14960e30e7ae26a26824cfa198727f2499162142ef3
 2019-09-13 18:27:17 +00:00
drh
477f1f12e2 Fix a typo in the carray extension header comment - the comment that serves 
as the documentation to this extension.

FossilOrigin-Name: 658a42d3633b31fda260f2c5a1a2c7dd8eb4eb0114d322369017c56faf5ecd42
 2019-09-13 17:30:24 +00:00
dan
01a3b6b1b2 Change the meaning of the SQLITE_SUBTYPE flag so that it indicates that the user-defined function cares about the subtypes of its arguments. 
FossilOrigin-Name: af1bc20f502816db460d2b2d353f715da5cf660e59095de5214c829c1cb20981
 2019-09-13 17:05:48 +00:00
dan
945a3527d5 Merge latest trunk changes with this branch. 
FossilOrigin-Name: 14ef7543465dd14d8fa141fcceb1950b5c2d265a3e862323969d747b39c0cd8c
 2019-09-13 16:19:53 +00:00
drh
3f3f2c7357 Ensure that the idxStr for FTS5 is always zero-terminated. 
Fix for check-in [e6db945454a0dae2]

FossilOrigin-Name: 090cd07d37904da4610d6a6787a3cc825c9a8bdcc5f051267d4608bba9b49d03
 2019-09-13 13:23:13 +00:00
drh
fbb9a5b1e3 Fix harmless compiler warnings. 
FossilOrigin-Name: a8927d14f88c44828e794787bab080455ab62705c93f65ce7d8db83478aa5a8e
 2019-09-13 12:24:58 +00:00
dan
685b2ee0c3 Allow fts5 to filter on multiple MATCH clauses in a single scan. 
FossilOrigin-Name: 9d418a7a491761eeb38a70898677a493e2631e5d62e75ee88431f52d3dfd2344
 2019-09-12 19:38:40 +00:00
mistachkin
acf6e08d20 Fix typo for one instance of line number handling in the Lemon tool. 
FossilOrigin-Name: 980be1730dc1239c63a107923bf2e32b4ec7d4bc31b9190e711cc35f18cc2bb4
 2019-09-11 15:25:26 +00:00
drh
c204d81a6c Enhance treeview to show SOFT-COLLATE for TK_COLLATE operators that omit 
the EP_Collate flag.

FossilOrigin-Name: a97804620a27acc30bebd2aaa04e38f2f36de48b0931038ca8bdc9cb0c36b8f4
 2019-09-10 17:51:27 +00:00
dan
fa50834914 Ensure the columns of views and sub-queries maintain their implicit collation sequences when the "push-down" optimization is applied. Fix for [18458b1a]. 
FossilOrigin-Name: 36997c4ade2ef3a274cd1ac52b44118fb3a05325adb650b7b338ecb43d060575
 2019-09-10 15:33:52 +00:00
dan
d5deb6b3c4 Ensure the columns of views and sub-selects in the FROM clause of a select are always assigned implicit collation sequences, just as table columns are. Fix for [a7debbe0]. 
FossilOrigin-Name: b9ec72203c19c2b95e648ac1dfad74eec98d4ff82581cdc10dc4221ba551728f
 2019-09-09 20:17:24 +00:00
dan
e08663946e Ensure the columns of views and sub-selects in the FROM clause of a select are always assigned implicit collation sequences, just as table columns are. Possible fix for [a7debbe0]. 
FossilOrigin-Name: 1863b7bf12521bdd2b51c5b8d3a4634bff3e15d3713e0b5343952df7da02f794
 2019-09-09 19:49:42 +00:00