mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
22,660 Commits 1,487 Branches 166 Tags 416 MiB
46bee2aa12
Commit Graph

22660 Commits

Author SHA1 Message Date
drh
82ab4f6b1a Correctly detect correlated subqueries when resolving names in RETURNING 
clauses.

FossilOrigin-Name: b43cfa04922a401442b9d1708e3e4a88d3cfa2c591f9a6b253d99ba83f4b280a
 2021-02-08 15:56:01 +00:00
drh
d510197276 Improved name resolution for references to a table begin modified from 
within a subquery in the RETURNING clause.

FossilOrigin-Name: 799d205bfa7945ee4a92dfec5fbf90a00b9a535e3171aab2ec46404f7efb0f78
 2021-02-08 13:41:17 +00:00
drh
e1c9a4ebf9 Do not allow RETURNING in the DML statements of a trigger. 
FossilOrigin-Name: 7a8fe6463a9728bc4e34465688a059afb74f3c373cde8fdf570d5d148fdde04d
 2021-02-07 23:28:20 +00:00
drh
8729642112 Fix harmless compiler warnings. 
FossilOrigin-Name: 5f8bf99579e6663fc701cdc94f685584a86398c4687e25e7e241de755398f17d
 2021-02-07 12:59:43 +00:00
drh
5f323787bd Remove an ALWAYS() and NEVER() in the authorizer that become reachable 
as of [078dbff04a95a001].  Test case for coverage in TH3.

FossilOrigin-Name: b469327e2949352325d3db815bd4782f9734239c378f08afd2f00ffa54bef924
 2021-02-06 14:56:30 +00:00
drh
8873aea390 Fix the OSSFuzz-discovered shift problem from two days ago. This patch was 
omitted from [078dbff04a95a001] apparently because I made the edit to
"sqlite3.c" rather than "resolve.c" where it belongs.

FossilOrigin-Name: 864772ffec4e91d8d73f9b97e6e1d7bd4e0537de19d11d30aed7eedd5b7d394a
 2021-02-06 14:37:36 +00:00
drh
29f6a365cc Remove unreachable code. Fix a shift UB problem introduced yesterday 
and discovered by OSSFuzz.

FossilOrigin-Name: 078dbff04a95a001bbd8690ab08038fbb5506899df8290991b53fd1122a4c30c
 2021-02-05 17:34:47 +00:00
drh
70bd2124ed Change the RETURNING algorithm so that outputs accumulate in an ephemeral 
table until all modifications have been completed, and only then do results
start being returned.  This should help prevent problems with interleaved
sqlite3_step() calls on two separate DML statements.  It also seems to be
closer to how PostgreSQL works, which might prevent compatibility problems.

FossilOrigin-Name: c4615eb28c3dd2d473daf104f32e60d02799f3158d9d275a899c39129cc71401
 2021-02-04 23:20:13 +00:00
drh
7dec804d42 Remove dead code. Fix RETURNING for INSERT into a virtual table. 
FossilOrigin-Name: dbfa38699c87ab4bf390666e411dda8d375c7b53b9b4fb131adacbf575867a72
 2021-02-04 22:59:19 +00:00
drh
e1db9343d5 Fix an issue with RETURNING from UPSERT. 
FossilOrigin-Name: 757b74ba0fd64634a365bd73955181191767ad8816a33a362e32ece250299a51
 2021-02-04 21:17:12 +00:00
drh
552562c48f Snapshot. New design appears to work on a simple test case. 
FossilOrigin-Name: 8a65fbeecf3597e30853c5f0ccd9b8b46c508854fa521e58e0db279deebca7d4
 2021-02-04 20:52:20 +00:00
drh
381bdacc8f Preliminary changes for a new implementation of RETURNING that captures all 
results in a buffer and plays them all back after the DML statement
completes.  This avoids problems with interleaved DML statements.
This particular check-in is a non-functional work in progress.

FossilOrigin-Name: 04b77d63216ce11b4e797946953bcde504fc005807c7a5ac757fbf47d78698dc
 2021-02-04 17:29:04 +00:00
drh
8ab79d6135 Add NEVER() to a branch that check-in [5d54d9fd40638138] apparently made 
unreachable.

FossilOrigin-Name: 5c8e6296aa9f69a092364524b716ba894f113f7f1e6024b9a2eaa01c239e65c1
 2021-02-04 13:52:34 +00:00
drh
02c4aa39e7 Performance optimization in sqlite3FinishCoding(). 
FossilOrigin-Name: 0f34f241d37cc4f31dc657a6fc33815fa5e24298487121cb27c29118524b8ee7
 2021-02-04 13:44:42 +00:00
mistachkin
8c333cfc0d Corrections to the 'filepath_normalize' test suite helper procedure. 
FossilOrigin-Name: 32f4d04470bf953b08eea285543f16e03de13d5448c1ebccbba1578ca3b5363e
 2021-02-03 19:38:40 +00:00
drh
17b74817c0 Change the name of Vdbe.magic to Vdbe.iVdbeMagic to disambiguate with 
sqlite3.magic.

FossilOrigin-Name: 6b29e549bb34933bfd0758e31085e65dcc0f75446c478fc775d96cf01c22cf43
 2021-02-03 18:32:25 +00:00
dan
7937f63220 Avoid doing any foreign-key constraint related processing for an UPDATE statement that does not modify any columns that are part of FK constraints, even if the table has a self-referencing FK. 
FossilOrigin-Name: 7f3b036e730153ac22933b03a52d4ec3978c9ecab1399d8cc79fe533893321e3
 2021-02-03 14:20:56 +00:00
drh
c5eb176a09 Fix a harmless compiler warning. 
FossilOrigin-Name: 1eb69c64ed4a11601698000573c507684bc4b0366336ba0748ebd661644d0902
 2021-02-03 13:20:12 +00:00
drh
cd39cda00c Add support for the RETURNING clause following PostgreSQL syntax. 
FossilOrigin-Name: 416c898bfb8ff9639ffbaefcfb47fce3782763af1fc67969fa91c5f01a336676
 2021-02-03 13:08:09 +00:00
drh
78197e0f8b Fix an assert() that might be off-by-one in the case of a prior 
errors in the parse.

FossilOrigin-Name: 06b15b17be38c804dd2641d8616a2a7bd396d2eb9901a0fbf94edd8bd508cf9c
 2021-02-03 12:35:51 +00:00
drh
2aa41c82da Modify the SQLITE_DBCONFIG_ENABLE_TRIGGER setting so that it only disables 
main-schema triggers and allows TEMP trigger to continue operating.  This is
safe, since only the application (not an attacker) can add TEMP triggers.
It will also all us to disengage SQLITE_DBCONFIG_ENABLE_TRIGGER on Fossil
databases since Fossil has no main-schema triggers but does use TEMP triggers.

FossilOrigin-Name: a10c5a2503ff2998f6ee40f721aab8c9579052e535dc141bd57d10551eaea387
 2021-02-03 00:55:34 +00:00
drh
47600083f1 Load enhancements from trunk into the returning branch. 
FossilOrigin-Name: b84c7f60c2e1e7debf9f50622087f87d60c6870061d61e14e59cc1ba0775ee92
 2021-02-03 00:05:57 +00:00
drh
cb83dc9e95 Do not allow aggregates in a RETURNING clause. Fix a memory leak that 
occurs when window functions are used in a RETURNING clause.

FossilOrigin-Name: 2e9bd94b9ad37c7e4123b7324f2fe42d3609a65af449eb8a0064057647709a73
 2021-02-02 20:46:11 +00:00
dan
e0d2096afa Modify the sessions extension to use more efficient SQL when applying a changeset or patchset. 
FossilOrigin-Name: e4ccfac09b6fe8cc3aec29d10f4e4c83097964f29882343db52ed91f6f0dde1c
 2021-02-02 20:41:13 +00:00
drh
709dd13927 Report an error if RETURNING is used for DELETE or UPDATE of a virtual table. 
FossilOrigin-Name: bd5dee8425327fde0429043ce325b910f1b7951988d9a448a8eeeb713a46bc81
 2021-02-02 12:01:22 +00:00
drh
c9be863098 Allow the RETURNING trigger to exist for virtual tables. 
FossilOrigin-Name: 2f244ab4a2ba2bdb608cf44ef02e00738ad58c10a76d9e4222dc843a17103d92
 2021-02-02 00:16:15 +00:00
drh
d33d3a2ba7 Add a few test cases for RETURNING together with UPDATE/DELETE LIMIT. 
FossilOrigin-Name: 7611c77d6baa84086ff18cbd045127fd682c6d5c434af5404e34fbe631fedfe1
 2021-02-01 21:26:09 +00:00
drh
9e673ace5b Improved corrupt database detection in balance_nonroot(). 
FossilOrigin-Name: 5d54d9fd406381383afdf10612bfd590afc4142215d9bca09e227e3aa5baa102
 2021-02-01 12:39:50 +00:00
drh
7baf3d411b Modify RETURNING so that it does not return changes implemented by 
cascading foreign keys or by triggers.

FossilOrigin-Name: 6e62470a737cbde7f3fdcd027b98eb0b3dd11d063c63501d3c18448e93f5959f
 2021-02-01 01:57:55 +00:00
drh
9407b6ef29 Mark an unreachable branch as ALWAYS(). 
FossilOrigin-Name: cb8b797a64f65fca01c5faaeb30cbe4a53b56b81e696d1b62a90362d7ef8f924
 2021-01-31 16:45:10 +00:00
drh
18e5607211 New opcode OP_ChngCntRow used to output the result of PRAGMA change_count. 
Only this new opcode, and not OP_ResultRow, checks for foreign key errors.
Faster performance, and now also works with RETURNING.

FossilOrigin-Name: 154fc2b15465c7c92a1af0a93851421aec42a81bab54840a9701f2c78068e14e
 2021-01-31 15:50:36 +00:00
drh
662fe79647 When setting the number of result columns in a RETURNING trigger, be sure 
to set that value in the top-level bytecode program, not in the immediate
caller of the trigger.

FossilOrigin-Name: 1f1ce7ceb9807d22efea496f33908040ee196a31cd192f27ec0fb3e23afb729c
 2021-01-31 12:41:20 +00:00
drh
28828c550f Improved comments on the new code. 
FossilOrigin-Name: a38f0c1d7c1d7635732ac370d8fbc7e6a2005378e4621da7bc4f51a2f99912d1
 2021-01-30 21:55:38 +00:00
drh
1832f2921d Add an ALWAYS() to an unreachable branch. 
FossilOrigin-Name: 6bb6de42b62acd35ade6c95a11bb4c9b35e7e9a24620731ae36364c4d5c3bc31
 2021-01-30 16:16:42 +00:00
drh
a8a64a078f Chagne the OP_ResultRow opcode so that it does not cancel 
pending statement transactions.

FossilOrigin-Name: fea91e3a511b14dafcc4da92c59188f927ec60ed91441335183da6b4e7866c1b
 2021-01-30 14:17:18 +00:00
drh
0166df0bda Fix a obsolete assert() in the bytecode engine. Improved OOM detection 
in sqlite3AddReturning().

FossilOrigin-Name: 138b10d54a83e1e7d5b3cdbe593a5073b05e632d1823e1b74d85835435b9ee3d
 2021-01-30 12:07:32 +00:00
drh
cf4108bbc6 Fix handling of an OOM condition in sqlite3AddReturning(). 
FossilOrigin-Name: 52204cd768f115d13249ff0e3a252b716620f7ad16a6962e1192a09137a78596
 2021-01-30 03:06:19 +00:00
drh
658f0a3679 Fix a memory deallocation problem that comes up when doing a RETURNING query 
on a corrupt database.  I think I fixed this before, but it got unfixed with
stale editor content.

FossilOrigin-Name: 02b1415efb7d9849499afe4e9dbf7e470484bf144d6ca3d28fdc38fc0ac10afa
 2021-01-30 02:43:26 +00:00
drh
343256b9b0 Another attempt to get trigger selection correct for RETURNING triggers. 
FossilOrigin-Name: 1b8ed52275a54800df90682d694b482f55f26c6c4a420659f9a3b7bfc61e8abe
 2021-01-30 02:34:47 +00:00
drh
16d861ffc2 When running the RETURNING trigger, if it is tagged as a DELETE trigger, 
do not use it as INSERT or UPDATE.

FossilOrigin-Name: 3c7a6e04ddde34961d8e9d0443913e572a80853cf14a8263cec19523c39ca744
 2021-01-30 02:22:38 +00:00
drh
ba71a8a01b Test cases added. RETURNING works with UPSERT as does PG. 
FossilOrigin-Name: f5698f96e27c9b8669ec6016bb9920ef7580c4146eb61d628a0f62be5135ce94
 2021-01-30 01:30:26 +00:00
drh
8f4e2e25c4 Better handling of errors in RETURNING due to corrupt database files. 
FossilOrigin-Name: 6aa2a058d136d0b24d94c5cbe1ce447eb435c1a1c7cdce5e435f1548bb3f05e7
 2021-01-29 22:33:05 +00:00
drh
d086aa0a48 RETURNING works even if "PRAGMA count_changes=ON" is set. 
FossilOrigin-Name: a9122d97577b239704cdee1a90a3b0dbff8bdf9dea2324d7315bd47238dcc8eb
 2021-01-29 21:31:59 +00:00
drh
dac9a5f7df Allow "*" wildcards in the RETURNING clause. 
FossilOrigin-Name: b0e3ae303db2a035583a05848ab7977e612d7e40c77e31ea9e0166de443c901f
 2021-01-29 21:18:46 +00:00
drh
b835247954 Working prototype. 
FossilOrigin-Name: b7ef4dc21f187ff4ff679e823782535188c3814aa6ce720b3a01c6d3ba4ef9f5
 2021-01-29 19:32:17 +00:00
drh
02d6f9b295 Fix possible division-by-zero in the new log() SQL functions. 
Problemm discovered by OSSFuzz.

FossilOrigin-Name: 1ffd321a33b778e87614a26a91a8407ec7b9dec4f0f847b16b1dac4f3b910604
 2021-01-29 16:20:16 +00:00
drh
2c99b84c95 Incorporate the sqlite3TriggerList() optimization from trunk. And move 
the pReturning field to the uninitialized area in the Parse object, to
save memset() time.

FossilOrigin-Name: 29fbaf0e3eabda08500f350bc32e9f339e5732a65bfa62822eefb692a2ff0243
 2021-01-29 14:22:56 +00:00
drh
f54a80fe5c Performance optimization (and size reduction) in sqlite3TriggerList() for the 
common case where there are no TEMP triggers.

FossilOrigin-Name: 0defaf730bdc82212a5d3feeb2e16f16423b1691b0aaa7da1787eb82ea39ae9e
 2021-01-29 13:47:36 +00:00
drh
55d4c84b61 Merge recent enhancements from trunk. 
FossilOrigin-Name: 5fbcb208d24d45169fc53ad8738dd3545d9bbd26b7434e31afc7f6419cd4e958
 2021-01-27 20:35:22 +00:00
drh
16cd8b96d3 Fix an issue with IN operator optimization introduced by 
check-in [4a43430fd23f8835] and described by ticket [ee51301f316c09e9].

FossilOrigin-Name: 9dc7fc9f04d5c14fc436e5ff5b4c06c1969ddde5857ebeb5dccd59b7c748c339
 2021-01-27 19:15:06 +00:00
dan
df1b52e727 Ensure a cursor used by the SeekScan operator does not point to a valid row on the first iteration of the loop. Possible fix for [2d6e8400]. 
FossilOrigin-Name: 390cf60a286b13f454429f4652a133f95a7891a75c1ec6d16cd39990590fd3fb
 2021-01-27 17:15:06 +00:00
drh
e5ceaac446 Add an extra log message in the case of an SQLITE_CORRUPT_INDEX error. 
FossilOrigin-Name: 0571c24177d77ac966bcf42cb8ab00fdf541ce84af1468c8ef0b60c48c45a22f
 2021-01-25 21:24:14 +00:00
drh
8ac090f51d Enhance the query planner to enable it to use an index for IS NOT NULL 
constraints, even if STAT4 is not enabled.

FossilOrigin-Name: 7b2a7c7314d2239992dc1d707280f3b75ba75bb074ba1e77b55cad01ca7fd51b
 2021-01-22 21:23:12 +00:00
drh
17988aae5b Merge fixes from trunk. Omit a conditional in 
sqlite3IsLikeFunction() that was made unreachable by this enhancement.

FossilOrigin-Name: 0b42f9eb5dd710991af3cf4b16464b22db9539361d618e50eaa4d43c811577b4
 2021-01-22 20:28:30 +00:00
drh
906602ac3f Do not allow VACUUM to resize the page_size to 512 if the reserve_byte value 
is 31 or greater. [forum:/forumpost/e807885dc5|forum post e807885dc5].

FossilOrigin-Name: d5ea75a09d4bf61262cead2604e35d8331b727c504807592d09f5d9e01ce794a
 2021-01-21 21:36:25 +00:00
drh
71aff85503 Performance optimizations in exprAnalyze() 
FossilOrigin-Name: 6d60cf540b8cc231448175f1e16e1f4f7a0aee26898570a5b8a09c89fae53c02
 2021-01-21 20:42:36 +00:00
drh
6cca0aa9df Always enable the IS NOT NULL optimization, even if STAT4 is not enabled. 
FossilOrigin-Name: fc98218cf69e63bdb9e5f154521a341508502cd8cfe04cb870cabee2d99e0cb3
 2021-01-21 17:54:41 +00:00
dan
7bb0a7d947 Fix a problem caused by using an SQL variable in an OVER clause within a trigger program. 
FossilOrigin-Name: 02264ab6a02d6cc95cf865920bcbaf4307d034640e6e4f3371b009ae9818540e
 2021-01-21 16:02:14 +00:00
dan
f380c3f13c Fix a problem caused by using an SQL variable in an OVER clause within a trigger program. 
FossilOrigin-Name: 4f676466e60ee2a420b7b2deace76f3a733ce1af278347428285715d9c67f022
 2021-01-21 15:40:52 +00:00
drh
7b88f54914 Improvements to the auxiliary "main.mk" makefile so that it works better with 
multi-threaded builds.

FossilOrigin-Name: d1873054d8e1006a370ea7891dbb9a62e7d36ce98cb92b58dcb0daf271265de3
 2021-01-20 23:01:31 +00:00
dan
a2560ce934 Add tests for sqlite3session_memory_used() interface. 
FossilOrigin-Name: 5596611f96f3401262b9dadc591bf7e3411d2c4a6f5be5cfe524e203d9820fd1
 2021-01-20 10:59:47 +00:00
mistachkin
d6665c51e2 Fix harmless compiler warnings seen with MSVC. 
FossilOrigin-Name: dc7938d2d715301595dee2fac6880af3716c4b3d1cbe7c3578d7fd30ba146a23
 2021-01-18 19:28:56 +00:00
mistachkin
f3ebea8114 Update test helper procedure 'get_pwd' to handle the ComSpec environment variable being absent. 
FossilOrigin-Name: fe1979552f43e0526f16481457e01981f29707401f77079f9854a8d91b35b5a4
 2021-01-18 19:27:56 +00:00
drh
abc6b67aff Enhance the query planner so that it is able to code EXISTS operators in 
the WHERE clause as if they were IN operators, when appropriate.

FossilOrigin-Name: c1862abb44873f06ec0d772469d8a2d128ae4670b1e98c2d97b0e2da18df9a04
 2021-01-18 12:35:16 +00:00
drh
06afa291cf More comments on the EXISTS-to-IN optimization logic. 
FossilOrigin-Name: 92cc29099f796f5f244dd80ee431c48d36d01eaece6f150119ead5ecd14eaae1
 2021-01-18 00:11:20 +00:00
drh
9fcc8c69bb Minor simplification of the EXISTS-to-IN logic. 
FossilOrigin-Name: cac90a9f4ab0a8f3ff77ee1f8549213c2f97169fc3469e55d57caa564079ce2a
 2021-01-17 00:13:12 +00:00
drh
9ffa258a01 Improved handling of vector equalities in the EXISTS-to-IN translator. 
FossilOrigin-Name: ef49ee4a3766146963bfb6b013472f9836afb9c5b0d21a8533871cf961139e38
 2021-01-16 20:22:11 +00:00
drh
4be8bdccd4 Give the EXISTS-to-IN optimization the ability to handle some cases that 
involve vector comparisons, instead of throwing a mysterious error in those
cases.

FossilOrigin-Name: 87e78a19bb3ae1caf57aeeae53a5ab4efdccb57265f25d5c19b62eae53747aff
 2021-01-16 18:55:10 +00:00
drh
2a3be742ca Add debugging output about the EXISTS-to-IN optimization when 
the ".wheretrace" flag has the 0x20 bit set.

FossilOrigin-Name: 0dad5ce34ad8a59200b013453c9334f8898e07f2c0107c8c734ecc34b67de572
 2021-01-16 18:22:10 +00:00
drh
1e2896ec6e Fix a hyperlink in the Lemon documentation. 
FossilOrigin-Name: 2ffb2ffa0ea147edd88632d2bbe29cc1d66d0911ce8e1068c406c81dd5a20242
 2021-01-16 12:15:41 +00:00
dan
f7588d4072 Add OOM injection tests for new code on this branch. 
FossilOrigin-Name: 9a181dbaedcc2117e670e679ca94ed6d1fabd90c835671dee36424dd0646c4e5
 2021-01-15 17:51:56 +00:00
dan
a828d565b6 Update header comments for routines added by this branch. 
FossilOrigin-Name: 950030d679933f9ccd2b86ee650a4a78d338278a3629f0d289cca720a43e686b
 2021-01-15 16:37:32 +00:00
dan
e8f7fcf6f4 Ensure the EXISTS->IN transformation preserves the collation sequence of the comparison operation. 
FossilOrigin-Name: a373baae12c914e48fd84de77998e301fdd3da43b06b9d64ac24a14418ed48cd
 2021-01-15 15:32:09 +00:00
drh
9d326d6793 Fix a potential NULL pointer dereference following OOM. 
FossilOrigin-Name: 8ce3cb90965771530c0021173d98720fc4c76bb99e69f7a879f80471dea0aace
 2021-01-15 15:21:27 +00:00
drh
19ef211d85 Add a new optimizer disabling bit to close off the exists-to-in optimization, 
for testing purposes.

FossilOrigin-Name: a80c9a076d31729282004ca372913c9fdbfb6e74711fbb8c5dc12ee0ecba2b87
 2021-01-15 15:17:14 +00:00
drh
10c9ef65fa Small performance improvement in the EXISTS-to-IN translator for the 
common case where the EXISTS operator is not found in the WHERE clause.

FossilOrigin-Name: dcb7772d7695ddbc0fe89e06c07ff4a6ae4fa05de914e2ec10b5cc07a62ed49f
 2021-01-15 14:25:06 +00:00
drh
19f9cd73ff Merge the latest trunk enhancements into the exists-to-in branch. 
FossilOrigin-Name: 13c4c9088cc8a2426e30a2ad1e9b9969407249281c6ed16653d43a0e6852a2e4
 2021-01-15 14:15:31 +00:00
dan
76cac6ef06 Add simple tests (and a fix) for the change on this branch. 
FossilOrigin-Name: 897f3f40267dc922f0fda287484435e1fd8709bade3e87c3829e2f945bb5e4aa
 2021-01-15 11:39:46 +00:00
drh
41d01407ea Improvements to the min/max optimization. Fix for a performance 
regression introduced at [b8ba2f17f938c035] reported by
[forum:/forumpost/4050026ab8|forum post 4050026ab8]

FossilOrigin-Name: 249a71cc6822d6bdd5bb9e727aac81c6549693b418e9c0987b96850ee332c940
 2021-01-14 20:57:47 +00:00
dan
6bfc167a67 Allow the planner to convert an EXISTS(SELECT...) expression in a WHERE clause to the equivalent IN(...) expression in situations where this is possible and advantageous. 
FossilOrigin-Name: 9f90a88221d0694951c353e58efce342eb0b868b8ca6a4469c8205e5c7855b24
 2021-01-14 20:50:40 +00:00
drh
5870dc80f9 The early-out of the inner loop on the min/max optimization was overly 
aggressive for the cases where there is a join and outer loops contain
IN operators.  Fix this.  Test case in TH3.

FossilOrigin-Name: ccd3bae14b6b47bb0f9622700c04db989f76ce65e10e0709964cfd0675eca762
 2021-01-14 00:53:14 +00:00
drh
5e5683ae46 Fix a harmless compiler warning. 
FossilOrigin-Name: 83ec01e38cbd22147ba544e15eae32c72e0523a55b54851e483dc2effc64f206
 2021-01-13 21:05:07 +00:00
drh
af7b76534b Expand the number of optimization-disable bits from 16 to 32. Use one of 
the new bits to disable the min/max optimization, so that we can more easily
verify that we get the same answer both with and within that optimization.

FossilOrigin-Name: fd0c9a123b58b7b134ed67f26dbb4196b61e56227f078422cc7e9a3497054c2d
 2021-01-13 19:28:17 +00:00
drh
d193057ad1 Further enhancements to the min/max optimization of 
[/info/b8ba2f17f938c035|check-in b8ba2f17f938c035] to fix the performance
regression identified by
[forum:/forumpost/623f571482|forum post 623f571482].

FossilOrigin-Name: 188772a1dbaf066fbddd39c718fdd87478b19a920622f4640bcb79d4ef065331
 2021-01-13 15:23:17 +00:00
drh
aa556b0fa7 cli: Omit surplus whitespace at the end of lines in .explain output. 
FossilOrigin-Name: 11e4eb095746602961a178044809a68a77ba7b367596997bef726e54062423d9
 2021-01-13 12:59:20 +00:00
drh
b9366f8e32 In the .selecttrace output, show the ORDER BY clause added by the Min/Max 
optimization.

FossilOrigin-Name: db0ecfe66433f8915b6eb16d3735a4a0d0f8e0bbc395bc9c1364387506fc4657
 2021-01-13 11:44:51 +00:00
drh
2053f313bf Lexer and grammar rules for a RETURNING clause on DELETE/INSERT/UPDATE. 
Actually making this work, though, will involve a lot more code which will
likely slow down processing for the common case where there is no
RETURNING clause.  Furthermore, RETURNING seems to be of limited usefulness
and it is not standard SQL.  So we abandon it here.  These experimental
changes are parked in a branch as an historical reference.  If circumstances
changes, we might take up the cause again some day.

FossilOrigin-Name: abf8da815646055df5b871d54b99994c1470182dee7952fc5fd627e4379406cb
 2021-01-12 20:16:31 +00:00
drh
b782e05c64 Merge the ParseCleanup enhancement to trunk. 
FossilOrigin-Name: 35824c1bcbd89ae4a94acfbe511bfbd888c418b981819e72bc9a991fc82d136c
 2021-01-12 16:26:36 +00:00
drh
21d4f5b53a Fix a potential use-after-free following an OOM in sqlite3ParserAddCleanup() 
and add a mechanism to detect situations where this might occur in the
future.

FossilOrigin-Name: 38ef8ab9830e12acd2c710e113939b1f8dced02612c6933c37a3c948a4030d0a
 2021-01-12 15:30:01 +00:00
drh
d9cc532a1e Rerun autoconf. 
FossilOrigin-Name: 8f3ab5da4c8906b63e2c1a0021a3ba4f60e7199e8640518060f998876a002663
 2021-01-12 14:23:03 +00:00
dan
ef36ccd1a4 Fix for the top-level configure script so that it works with tcl 8.7. 
FossilOrigin-Name: 4810f814ff13db31b95b471d53e9654ecde286c23d10984e3cc8788d79ee79ee
 2021-01-12 14:19:12 +00:00
drh
cf3c078f93 Add a linked list of ParseCleanup objects to the end of a Parse object and 
use that list as a place to put other sub-objects that need to be deallocated.
Have a single such list for infrequently used sub-objects is more efficient
than doing an a separate check for each kind of sub-object.

FossilOrigin-Name: affa2b7b316941b8a6c4d0d1ff212c81a593faf1d05d129e14d2b70d73a25c59
 2021-01-11 20:37:02 +00:00
drh
a6e6cf2c8f New CLI command: ".stats vmstep" enables the display of the virtual-machine 
step count only, after each command.  Useful for optimization problems.

FossilOrigin-Name: 49dfce469e6a17111b349e53578479daf783064200bf0eec5bf8a91d3553b19f
 2021-01-09 19:10:04 +00:00
drh
4ee492f176 More detailed compile-time testing before attempting to use atomic load 
intrinsics.  See
[forum:/forumpost/fc0237a39b30ac0a|forum post fc0237a39b30ac0a].

FossilOrigin-Name: 5204c2c4a7b73a64764b0d2d1d7c53709bb64e0d2685a829c7bf31af13bab5e7
 2021-01-09 18:24:33 +00:00
drh
1242c0ccf4 Fix an issue with sha3_query() when the first argument contains blank 
SQL statements.

FossilOrigin-Name: 24baab9a9faab50c26d7167821031cd66aaf784baefbc0f92354ae54ac43a714
 2021-01-08 19:53:18 +00:00
dan
3a5e975947 Update cksumvfs to check that the xCurrentTimeGetInt64 method of the underlying VFS is not NULL before invoking it. 
FossilOrigin-Name: c71f6cadcc8c2172ad4113bbe4026aac4ebb8a91485454e8a14de32d197a93aa
 2021-01-07 16:59:35 +00:00
dan
5cb960b7af Fix problems with some "crashsql" tests. 
FossilOrigin-Name: 0c8e2ede5c325aa7fef8e8587057ec8c865fc7cf3e974a2733066fbac640b983
 2021-01-07 16:29:34 +00:00
drh
c2dbf35f49 Fix harmless typos in comments per 
[forum:/forumpost/7849e58dd5|forum post 7849e58dd5]

FossilOrigin-Name: d1e22e2f76cce7eb9f9029646176daef2d9e41c7bb1d3e1da182fbdd0096605c
 2021-01-07 16:10:14 +00:00
dan
31afee9372 Add extra test for handling of embedded nul characters in the fts4 unicode61 tokenizer. 
FossilOrigin-Name: c2c2c7e945f5d5700d91b8e779117e70e388ffc613912a434885ae27f5fe4e22
 2021-01-04 18:28:29 +00:00
drh
e81f879f51 In Lemon, factor the parser stack overflow detection logic out of the 
yy_reduce() subroutine and into the main parser routine, so that when overflow
is detected, it can exit immediately.  This saves a single conditional in
the main loop of the parser.

FossilOrigin-Name: 203c049c662380411522d0c7c493201331bbb2792a7c5b12684f04f532a0695d
 2021-01-02 23:56:37 +00:00
drh
c8af879e5f Avoid allocating space to hold the prepared statements for CREATE statements 
when parsing the schema of an existing database, since those prepared
statements are never used..  This helps to make startup faster,

FossilOrigin-Name: d01e9f2d00dc439c529cd8885a219fcddbaad73b9f471b020e2a0c18e2add69b
 2021-01-01 22:06:17 +00:00
drh
630fc34c1a Faster and smaller test to ensure that the sqlite_schema.sql field is always 
a CREATE statement of some kind.

FossilOrigin-Name: 76de2bb04b1c02a6c0300cd61d9b3d2477d845aa0d1cdb9dbe4f354b9fedd923
 2021-01-01 21:02:37 +00:00
drh
37114fbfcc Change the unions of the Table.addColOffset field from characters to bytes. 
This makes the query that implements ALTER TABLE ADD COLUMN more complex and
slightly slower, but also makes CREATE TABLE statement parsing faster by
avoiding a call to sqlite3UtfCharLen().  Since, CREATE TABLE parsing is far
more common than ALTER TABLE, this is a net win for performance.

FossilOrigin-Name: 6f25f2529f1495a26129d7d407979906e4962b2de351f901d41cb037d05ba780
 2021-01-01 20:04:34 +00:00
drh
3e992d1ab7 Use the column name hash to improve performance of column name collision 
detection while parsing CREATE TABLE statements.

FossilOrigin-Name: d02820f03575e4633a7917427f11c19f99bd7b92f37d0ffe6fdc2418ad729813
 2021-01-01 19:17:01 +00:00
drh
266f0f4585 Modify the makefile rule for "startup" so that it always builds with 
-Os and -DSQLITE_THREADSAFE=0 and no other options, for consistency of
performance.

FossilOrigin-Name: 5ac939e0adc923378173297e934c3664254a4fefbcddcc842bf4cc42dbaacf4f
 2021-01-01 18:32:15 +00:00
drh
88efc796c2 Size reduction and performance increase in sqlite3Prepare(). 
FossilOrigin-Name: 41f45c8e894f48049325ccfef12cec0887b636bfad5d531a47628eb9e8612924
 2021-01-01 18:23:56 +00:00
drh
e2b0a12d58 Small size reduction and performance improvement in sqlite3VdbeMakeReady() 
by linking the new prepared statement into the prepared statement list sooner
rather than later.

FossilOrigin-Name: 2996e800a02967f9d0e27c816cf0b7b581a25634f94abcf167f27b019e1515e5
 2021-01-01 17:01:33 +00:00
drh
69e856ae66 Streamline processing of the authenticator callback for the common case 
when there is no callback.

FossilOrigin-Name: d3196685d958bf22b5c362e96bbf8e1df58cc09cc3abc4bfa94bb33bc28c61aa
 2021-01-01 16:43:26 +00:00
drh
33e1ec224e Add the "startup" test program designed to measure startup performance, 
and in particular schema parsing time.

FossilOrigin-Name: 7b3b31efb0047c5a461f487905cffba2b0ddb1518a6e757ca092eb40e1e2cd49
 2021-01-01 15:13:17 +00:00
drh
4fd4a7a1e9 Do not attempt to take a pointer to the ceil() and floor() functions as 
those routines are intrinsics on some versions of MSVC.

FossilOrigin-Name: e5d7209e118a84537a85c0c9cd2b7ca4cd6ccf04181dc840b19339b4c93840cd
 2021-01-01 01:44:06 +00:00
drh
85d31b9f37 New test case for the HAVING fix of check-in [f62f983b56623f0e]. 
FossilOrigin-Name: 45f46317ab8bd92dcd346bf00ba3a33b0cfd030b790c04e19ef33cff124d8d7f
 2020-12-30 13:20:27 +00:00
drh
c4403ca61a New test cases for cursor renumbering in the UNION ALL query flattener. 
FossilOrigin-Name: 270babf259750f3d6c490a08df608a101b24b3c06b9e8a938a0e09a854af6a20
 2020-12-30 13:10:57 +00:00
drh
a06eafc8fc Do not set the P3 parameter on OP_RowCell when copying an index btree, as 
P3 is not used in that case.

FossilOrigin-Name: eef070a4aadf02a845d0ed00767be049d3b76e811e24797a116776fa836d1b03
 2020-12-29 15:06:26 +00:00
drh
277a30d9ce Fix missing comma in ctime.c that would cause the ENABLE_MATH_FUNCTIONS 
output rw to merge with whatever row followed.  Problem reported in
[forum:/forumpost/aacac97680|forum post aacac97680].

FossilOrigin-Name: 328bc4a01dd67096be49c8b5a656109ad2839a7959d1b00c02a96bfbcb44ec18
 2020-12-28 21:42:38 +00:00
dan
0cb735b9fb Add the sqlite3session_memory_used() API to the sessions module. For querying the amount of heap memory currently being used by a session object. 
FossilOrigin-Name: 823f75c2e448b649cbe9e174be21524ae3f580beedced65701ad49a2dcc5ee19
 2020-12-23 16:46:39 +00:00
dan
7225bfef16 Fix SQLITE_OMIT_WINDOWFUNC builds by moving declaration of sqlite3ExpandSubquery out of "ifndef SQLITE_OMIT_WINDOWFUNC" block. 
FossilOrigin-Name: 9587fa8b29fc2f91d751a71b909f574014656f24d276b4974f47fcc18dbadcb8
 2020-12-22 20:35:22 +00:00
mistachkin
9a60e716f7 Fix a couple spelling typos in comments. 
FossilOrigin-Name: 907ddf86766ebdbe39bdc89543c1a7bbd65c710c9f3a3a4d796845b2c02b711b
 2020-12-22 19:57:53 +00:00
dan
f39168e468 Fix a problem handling sub-queries with both a correlated WHERE clause and a "HAVING 0" clause where the parent query is itself an aggregate. 
FossilOrigin-Name: f62f983b56623f0ec34f9a54ce1c21b013a20399162f5ee6ee43b23f10c2ecd5
 2020-12-22 16:23:29 +00:00
drh
06ddb08f3f Simplification to the aggregate-function analysis error detection logic at 
the end of sqlite3Select().

FossilOrigin-Name: 82884438e30ad8241f8249927fe92e0856d78b64d7ade38f3d5bb1c931d958d0
 2020-12-22 14:54:20 +00:00
dan
961a72601b Fix problems with joining UNION ALL sub-queries against other sub-queries that contain LEFT JOIN. 
FossilOrigin-Name: d554f710a5abbe64022f47a14ef67227c861a8f0991d85d240434e9a709cf8b8
 2020-12-21 19:50:10 +00:00
dan
a3d33ebe4a Fix a problem when flattening joins between a UNION ALL sub-query and another sub-query that uses more than one window function. 
FossilOrigin-Name: ef9733fe1c6b31849a5da1037d21915f82e0e4ab42d1a23ead8a121012f1bace
 2020-12-21 18:39:58 +00:00
drh
6d5f928d22 Enhance documentation to show that "ro" is the correct way to say "readonly" 
in the mode= query parameter.

FossilOrigin-Name: 788b96851d9ced84757c48dc3e0414cab27ee7e50e9730dab30b2e42a7762397
 2020-12-21 14:51:33 +00:00
drh
237f41ab8d Add the --timer option to fuzzcheck. Get the --timeout option working in 
fuzzcheck when running dbsql tests.

FossilOrigin-Name: 3b0c9b41a877c7344ef3b7c5b6981436005716e25b41b1a1ffc145520243abd3
 2020-12-21 12:14:59 +00:00
drh
8e2b9c2a89 Always declare the sqlite3WhereTrace variable, even for non-debug builds. 
FossilOrigin-Name: 88d93ee380b6fd87474545f20ade874ba05c784c787ce9c45ebfcffed3795308
 2020-12-20 14:51:17 +00:00
dan
5763f3d582 Fix a broken assert() in fts5 that could be triggered by corrupt database records. 
FossilOrigin-Name: b79f59f9ad897d5bd4b9d17e6219bc765b02450bfe14dc020485f221ba6b02cb
 2020-12-19 15:39:10 +00:00
drh
e69ba68363 Allow UNION ALL sub-queriesto be flattened even if the parent query is a join. 
FossilOrigin-Name: df1d6482f9e92dafdca1948e96eef52d8646eef9c356394afabe431d6357dd34
 2020-12-19 13:58:06 +00:00
dan
d131b51cbd Fix for the previous fix in the case where a UNION ALL sub-query is joined against some other compound query. 
FossilOrigin-Name: 63c5cfb9ae8f4598a523bed2a60c0e69172179952961a573113fcf756c06551d
 2020-12-18 18:04:44 +00:00
dan
964fa26e0c When flattening UNION ALL subqueries into a join query, ensure that separate cursor numbers are used for each segment of the newly flattened query. 
FossilOrigin-Name: c510377b0b052e400f2ee4f20220b61cdf74ee44b9bb9e6490787c88dd4c55aa
 2020-12-18 16:13:39 +00:00
dan
9353beaff1 Fix a part of the header comment for flattenSubquery(). 
FossilOrigin-Name: dc0937ce9d5569e3409b2b036a9f15b896125f4eb2eec30e3f0bbe4a92bcd0ad
 2020-12-17 17:17:12 +00:00
dan
8daf5ae2ed Add test cases and minor fixes to this branch. 
FossilOrigin-Name: 5d6dc29d5f81738b07e4fee652fb2343fc409c2545f2f4667e8ee82d1a75f721
 2020-12-17 16:48:04 +00:00
drh
18a4bbdf63 In the CLI, add the ".filectrl data_version" command. And put the various 
".filectrl" subcommands in alphabetical order.

FossilOrigin-Name: 3434452148eef39ba3ba2f40a6fedb6ec4f5157cbc2763b3ec90ec7f2b126382
 2020-12-17 15:17:42 +00:00
dan
13dd0228d3 Fix a problem with sqlite3_expanded_sql() that could occur with statements that use both numbered (e.g. "?1") and unnumbered (i.e. "?") parameters. 
FossilOrigin-Name: 2a6cd6833e44dd6a2ac388815f43be6508f6fa6db5e451e964276a6c87e6c5ae
 2020-12-17 11:24:26 +00:00
drh
0a8b6a9f8f Enhance the sqlite3BtreeTransferRow() routine so that it does more careful 
checks for corrupt database pages.

FossilOrigin-Name: 85952e71175dae73c4e587a3b80783825d91fe8567a819e072da651c1ff4131b
 2020-12-16 21:09:45 +00:00
dan
de9ed6293d Allow sub-queries that use UNION ALL to be flattened, even if the parent query is a join. Still some problems on this branch. 
FossilOrigin-Name: 00e4bf74d3dfb87666a2266905f7d1a2afc6eb088d22cfd4f38f048733d6b936
 2020-12-16 20:00:46 +00:00
drh
e5baf5c283 Remove an unnecessary and incorrect #ifdef. Fix harmless compiler warnings. 
FossilOrigin-Name: 31cd1bbfa5b06723288d99d1cb423f88353bdef770b82e9103f71a796d66f660
 2020-12-16 14:20:45 +00:00
drh
9463d79353 Fix a typo in the sqlite3_free_filename() documentation. 
FossilOrigin-Name: 48301edc90fe5811df0394b106edce7726d0ea86ac562c9f4db511b812a76433
 2020-12-16 13:17:32 +00:00
dan
7f60706691 Fix another integer overflow triggered by a corrupt database in recently modified vacuum code. 
FossilOrigin-Name: 4e2dd2a53364f1fed48b995fd5d2642472585f6da5e4735e9da193ba7ff45514
 2020-12-15 19:27:20 +00:00
dan
0bf333467c When the -statstep option is passed to the "rbu" executable, print out memory stats right before exiting, as well as every -statstep steps. 
FossilOrigin-Name: 94f81b51176566409b7d16b30d861f48ad15bb43a145df6e02e0880f7c348109
 2020-12-15 16:28:07 +00:00
dan
84b168ffa7 Change an fts5 assert() that can be triggered by a corrupt database to an if() condition. 
FossilOrigin-Name: ea0a7f103a6f6a9e57d7377140ff9f372bf2b156f86f148291fb05a7030f2b36
 2020-12-15 13:55:38 +00:00
drh
9f023ce539 Enhance UPSERT so that it allows multiple ON CONFLICT clauses and does 
not require a conflict target for DO UPDATE.

FossilOrigin-Name: 6b01a24daab1e5bcb0768ebf994368d941b1dfc217bf6b661211d900331e68cf
 2020-12-14 15:39:12 +00:00
dan
59964b4010 Fix an integer overflow problem in new VACUUM code. 
FossilOrigin-Name: 59b4367fd852ba1bfefdff99a27b11657495a3f114ed6f85fdcf6c532f4a19fa
 2020-12-14 15:25:14 +00:00
drh
1c19848386 Minor changes for test coverage. 
FossilOrigin-Name: e5a8fa50f4e5e5c24664452eda4af80904f75e5123b8f84353347dbd505d416d
 2020-12-14 13:52:03 +00:00
drh
250af6e0fb More test cases. No new problems discovered. 
FossilOrigin-Name: f34dd67e2d0dfc9e3b5d49148fb0162853119c097cbc3fe961878875ba98d8e3
 2020-12-12 00:43:52 +00:00
drh
255c1c159b New test cases with corresponding bug fixes. 
FossilOrigin-Name: f22c21a94ca4cad0217f91c1a5a275bc348cb6ba0f3a54c927533bc8d8c96a90
 2020-12-12 00:28:15 +00:00
drh
58b18a47df Begin adding test cases. Fix one bug found so far. More are pending. 
FossilOrigin-Name: aadd67ddf2a191629b5356395f75e4556aac904a6e2f6b83742fa4f26e4253a4
 2020-12-11 19:36:19 +00:00
dan
855aed19e2 Fix an assert() broken by recent changes to vacuum. 
FossilOrigin-Name: dd058da85ca54ae70e26cb0bdc75ff42998d4a8b29a5e2dcac44ee0e45776a85
 2020-12-11 19:01:24 +00:00
drh
d3e21a1098 Small performance tweaks. 
FossilOrigin-Name: 5321d60c575ef8f888d1b315df02cf9ed96a3ffc61babbc1429aa73b2a61a190
 2020-12-11 17:11:56 +00:00
drh
ed4c54699d Bug fixes so that legacy tests pass. New tests for new functionality have 
not yet been added.

FossilOrigin-Name: aa76790e58cea9a2b707f5912fd66c76545e7417442553fc13c87f773a2fe1dd
 2020-12-11 16:49:51 +00:00
dan
7710878333 Add an "#ifndef SQLITE_AMALGAMATION" block around the typedef for u64 in shathree.c. 
FossilOrigin-Name: b411f29e1a6415f4a241777c45591b8389e746cd8b40d9b225e073bcb0a3bdbf
 2020-12-11 16:03:19 +00:00
drh
d0a0538229 Fix the configure script on the autoconf distribution so that the 
--disable-threadsafe option works.  See
[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244459|FreeBSD bug 244459].

FossilOrigin-Name: e64ff2cce3c03ba27c3bf410948ece1424113e727870015eb3806b75d0d21f94
 2020-12-11 14:34:58 +00:00
dan
69871baa15 Fix the expert extension so that it handles generated columns correctly. 
FossilOrigin-Name: c2ae7ba6f8f4b10bd734051a0cfa8ed9675bd58c82ede4e9eadfd7cbcc03b82d
 2020-12-11 14:22:44 +00:00
drh
61e280ad8a Logic is in place to handle multiple ON CONFLICT clauses, but it does not work. 
Any use of ON CONFLICT will likely lead to memory faults.  This is an
incremental check-in to save my place.

FossilOrigin-Name: 155142314feb007d526f8f67723636fd50dc52d1cd4d3a67dd93b105c9d5c2be
 2020-12-11 01:17:06 +00:00
drh
daf2761c62 Use an iterator for the index loop in sqlite3GenerateConstraintChecks(). 
The idea is that this iterator can be enhanced to traverse the indexes in
any order, as required by multi-index UPSERT.

FossilOrigin-Name: 64a4a91ecc5dcde3fa07d3cf038c74b9ede63d36628ecfb35203a9dfbbfe113c
 2020-12-10 20:31:25 +00:00
dan
9257ddbf87 Remove a redundant branch added by [56a54258560]. 
FossilOrigin-Name: b4d6f6d728738710249ad74236c31a1872fdff7dadabd4c4a67d05826eb5df9e
 2020-12-10 19:54:13 +00:00
dan
a64804b5e1 Changes to avoid loading large records into memory within VACUUM. 
FossilOrigin-Name: 56a54258560fab715b83967634b2bd4c04be43cded112b46e85da9f99ee02f7c
 2020-12-10 19:51:39 +00:00
dan
d2ffc9721e Fix minor issues with new code on this branch. 
FossilOrigin-Name: f7fa76d0963e7b34026dc20c920bfbf7961033fe2b99503f6857157595f86823
 2020-12-10 19:20:15 +00:00
dan
46a6b1a1be Merge trunk changes into this branch. 
FossilOrigin-Name: 7337eed629b4537b8fc2dc87c3c71d0a664128a91fd00f3c5f18843505beee90
 2020-12-10 18:07:01 +00:00
dan
7aae73588a Better integrate the changes on this branch with OP_Insert and OP_IdxInsert. 
FossilOrigin-Name: 101cef14910d6e865a94bc870aed599321b893188062a9a61d70a9434992cf23
 2020-12-10 18:06:24 +00:00
drh
70f3eda5be Add an optional function to the chsumvfs extension. When activated by 
the SQLITE_CKSUMVFS_INIT_FUNCNAME macro, this function will invoke the
file-control that sets the number of reserved bytes to 8.  This can be
used to initialize a cksumvfs database file by programming languages
that do not have access to the sqlite3_file_control() interface.

FossilOrigin-Name: 01841fb4bf3d6c5fd5bcbc7d1338998c50f69f84ca475fba7cf764d636714678
 2020-12-10 13:49:00 +00:00
drh
91f2717f22 The DO UPDATE code generator searches for the correct ON CONFLICT clause to 
use.

FossilOrigin-Name: a47e35ee2d901baaa37e7229d190f934e1b0bd3510147cd4a2a49c4a1411416a
 2020-12-10 12:49:26 +00:00
mistachkin
d97a4c008d Fix compilation issues with MSVC related to C99. 
FossilOrigin-Name: c0de6c1fb2c486be1da01e5e4ca8c5634ba37822e418d57f272e018c3e3fc0a2
 2020-12-09 23:35:51 +00:00
dan
cd1b2d0b54 Transfer large index or WITHOUT ROWID records between b-trees when vacuuming without loading them into memory. 
FossilOrigin-Name: dfd4ca6891a893d0e9551689954d3e79114d5565f8a5264f96ad1d64fe1d6280
 2020-12-09 20:33:51 +00:00
drh
e84ad92f17 For upsert, the constraint check code generator uses a copy of the index list 
for the target table, which can potentially be reordered.

FossilOrigin-Name: 3194c00c2c6a32bdfd5acc9fda5b38ae131d20cd3b7aea8512a41b2e76808f6a
 2020-12-09 20:30:47 +00:00
dan
1418b9daf6 Add tests for a 'delete' command on a contentless table where values that weren't actually inserted are NULL. 
FossilOrigin-Name: 818c647cec7063b33b6c5de3e23599a1d61439fa6e9bf6c974b2522a5a9e1b44
 2020-12-09 16:49:28 +00:00
dan
ebbf36878c Avoid loading large intkey rows when VACUUMing, even if the page-size is changing. 
FossilOrigin-Name: 0d2c3776065dc94119899ae4164995193b82fca7ac31868f3141b729d0b65ab9
 2020-12-09 16:32:11 +00:00
drh
5602777e8f Improved comments in sqliteInt.h. No changes to code. 
FossilOrigin-Name: 8ccb8d1d55fa5aaf625c30f0e7c10aa403d79b5574dbdfa3fd0271a4e546f7e3
 2020-12-09 13:11:02 +00:00
drh
20b86324a1 Initialize all terms in the ON CONFLICT clause stack. 
FossilOrigin-Name: 5e683fd1cbde53f37cf8a2b1e981191e2b29e3376db554691767f33c37c7547e
 2020-12-09 01:34:48 +00:00
dan
036e0675e6 Experimental changes to vacuum to avoid loading large records entirely into memory. Currently only works in limited cases only - for rowid tables when the page-size does not change. 
FossilOrigin-Name: c90e063ca9ddcdd1e9f1a2e25a3f7d6e7ee798373ad8acf65b90536b0a124c0d
 2020-12-08 20:19:07 +00:00
drh
2549e4cc2f Enhance UPSERT parsing to allow multiple ON CONFLICT clauses. Only the 
very last clause may omit the conflict target, but the conflict target may
now be omitted for the DO UPDATE resolution.

FossilOrigin-Name: 2ca62f4c71df6544cb8039bdc80e3701d09697c38800534371f6d44532fcffae
 2020-12-08 14:29:03 +00:00
drh
0dffe465f7 Fix a bad assert() in math1Func(). 
FossilOrigin-Name: 4b286129138d44e6f8e9b3450289941e01d20fdfb9d0b5d846031425e8ca6b49
 2020-12-07 23:14:25 +00:00
drh
e2ce8c446f Fix to the --disable-math option to ./configure. 
FossilOrigin-Name: 99ff6418492adcbaf2be728737735afa1c2997de5868395e69c53d08fc14491f
 2020-12-07 21:19:17 +00:00
drh
63f8f98a63 Many more math functions. Semantics follows PG wherever possible. 
FossilOrigin-Name: 6b93627b5d9819abf179a3e4a82e7afe17cbcafdabbd5f058de9ed114c9d477f
 2020-12-07 21:13:06 +00:00
drh
f6e904bd92 Begin adding new SQL functions that depend on -lm: ceil(), ceiling(), 
floor(), ln(), log(), and log10() so far.  More to follow.

FossilOrigin-Name: 4db5f2f7875f6df78630a7816fc018141a6eee2e295b44fc7627eb66d07881ea
 2020-12-07 17:15:32 +00:00
drh
aeb6bc5628 Fix harmless compiler warnings associated with the recent FTS5 enhancements. 
FossilOrigin-Name: 1db7c751912beb57a697ac8e85b9c29e30da7b6c89207e9828bf08e56c58242f
 2020-12-04 17:05:16 +00:00
drh
0a2fb7960c Fix a bug in the ".eqp" command of the shell that was introduced by the 
recent sqlite3SelectTrace/SQLITE_TESTCTRL_TRACEFLAGS changes.

FossilOrigin-Name: fd02dffceb0e21cd85c99d5481ab8567110d01c30ea701178547f32299944302
 2020-12-04 16:58:20 +00:00
dan
b9ceb833f7 Ensure that fts5 function matchinfo() is registered before running tests that use it in fts5corrupt3.test. 
FossilOrigin-Name: 932e05e093192991589e70c2cbcc8a57fb3dcc6df1c2673962bfd06ba5cfdd97
 2020-12-04 16:49:25 +00:00
dan
ee8221859b Fix a test script problem in walvfs.test. 
FossilOrigin-Name: 4c5076fbe42cc6447c47bfc202501f945f78bd716cbe8e33599c67b7d0956611
 2020-12-04 16:26:25 +00:00
drh
7b0ab21016 Fix an incorrect datatype no the sqlite3WhereTrace variable in test1.c. 
FossilOrigin-Name: 4e6dab30f6d6795ecec9d8c4489fa4d210a3002715ad89812d65a1a846c164b9
 2020-12-04 16:25:59 +00:00
drh
0a3e80b051 Eliminate the sqlite3_unsupported_selecttrace global variable by creating 
a new test-control to control SELECT tracing.  Note that SELECT tracing is
only available on debug builds.

FossilOrigin-Name: fb07c4e3c7ad3493c274cbfcf0dffdedcca18c0d90de04459134511d4e2a5277
 2020-12-04 16:09:27 +00:00
drh
fda8e49207 Further changes to the trace variables to try to eliminate (harmless) compiler 
warnings in all configurations.

FossilOrigin-Name: 3a4c98b989964e3e366fe9519e9b5ed935e893d5b69d92bc0388a14c7e7938e6
 2020-12-04 16:04:45 +00:00
drh
c0622a4d03 Alternative implementation of ".selecttrace" and ".wheretrace" that uses 
a test-control rather than global variables.

FossilOrigin-Name: d36d6f2923a2393c751c0ac7634433453be20df7567fd914e57cbb1ae15f68b2
 2020-12-04 01:17:57 +00:00
dan
3190b88e75 When merging prefix lists in fts5, use 16-way merges instead of 2-way merges. This faster. 
FossilOrigin-Name: 026a93508ec392ca5cd2578ae9eab64974f58beccda088e10d4cc951f237632f
 2020-12-03 21:22:37 +00:00
drh
1de03abb03 Do not simulate OOM faults on the SQLITE_FCNTL_CKPT_START and 
SQLITE_FCNTL_CKPT_DONE file-controls, as those are write-only and
the return value is always ignored.

FossilOrigin-Name: 62a2d394835276fabc0f1df2302605a700b2244775bf2e35e86529df8e40a0da
 2020-12-03 19:25:06 +00:00
drh
0b1e70c4ce Enhance the generate_series() table-valued function to support negative 
step values.

FossilOrigin-Name: 9b60fc48706bb77b2d4fe27a7b5834a6dc229b4051a9285032da578e4f2849e6
 2020-12-03 14:21:26 +00:00
mistachkin
4338000d47 Prevent potential segfault in the sqlite-expert idxPopulateStat1 context cleanup code. 
FossilOrigin-Name: c24f13448b5a55f45b4d4786a878fa73fe3395b5724f3bc2eea22e5e2b074353
 2020-12-02 20:07:49 +00:00
dan
64f1ef6abd Allow a search for an N character prefix in fts5 to use a prefix index of size N+1, if no prefix index of size N exists. 
FossilOrigin-Name: 78a7801d8fc9e58a62e5168e35b52b7440340549123fc6a537e2abd571f6fe7b
 2020-12-02 19:08:15 +00:00
drh
f30bbcec90 Fix the ".open" command in the CLI so that it accepts command-line options 
both before and after the filename.

FossilOrigin-Name: d330bf0c02e67f70f49496e4b1e484bb4e876622becc6a062b2aefbd585d0117
 2020-12-02 18:27:48 +00:00
dan
0fa433b40c Improve performance for fts5 column filters that filter for more than one column. e.g. "{col1 col2 col3}:phrase". 
FossilOrigin-Name: d8de2f236d43a88fac7550a0451951dd5a945eb304e32f82e662479cea7c2684
 2020-12-02 16:23:05 +00:00
drh
bb497fe36d Parameterize the hash function in mkkeywordhash.c. This was an attempt to 
find a better hash function, which turned out to not be successful.

FossilOrigin-Name: 2195d731f51a18f917c4299d8f4c7ee7c139c2527f62869d6da171a6d1d89ea6
 2020-12-02 02:58:05 +00:00
drh
636f505864 Increase the version number to 3.35.0 to begin the next development cycle. 
FossilOrigin-Name: edbabaa30823db7c7d169cb93722b5f74bc711359984fb7e139ca9d10fe7dae4
 2020-12-02 00:22:09 +00:00
drh
c52a1e9f35 Slightly faster tokenization of non-keyword identifiers. 
FossilOrigin-Name: 55fa22bd403cc8f0973efea898a7cfa3a32b57c7e2a7a4c30c3f2c72d5396f07
 2020-12-02 00:20:00 +00:00
drh
f461bab265 Add the --lookaside SIZE COUNT command-line option to the dbfuzz2 testing tool. 
FossilOrigin-Name: 2466960c0ba02ef9c325e9a5f8603db518e7529547f614c225fef430421e1643
 2020-12-01 23:18:13 +00:00
drh
384f5c26f4 Version 3.34.0 
FossilOrigin-Name: a26b6597e3ae272231b96f9982c3bcc17ddec2f2b6eb4df06a224b91089fed5b
 2020-12-01 16:14:00 +00:00
dan
9f4fb42730 Update the tea/win/makefile.vc file that ships as part of the autoconf package to use "sqlite3" instead of "tclsqlite3" for the installed dll filename. 
FossilOrigin-Name: 23212b1a054f05773a9f69f9802035eea6a9d759a2a09e22f46d1046c058b417
 2020-11-30 18:52:08 +00:00
dan
aeb4e6eebd Update the tea/win/makefile.vc file that ships as part of the autoconf package to use "sqlite3" instead of "tclsqlite3" for the installed dll filename. 
FossilOrigin-Name: 93d4d9dc05bb86c08a12d56b3ce68ec39b69e57951a936fb3b326812c051c3b4
 2020-11-30 18:43:40 +00:00
drh
56a5747e63 Do not reuse the obsolete SQLITE_TESTCTRL_PRNG_RESET value for 
SQLITE_TESTCTRL_SEEK_COUNT.  Give SEEK_COUNT its own unique value.
This avoids incompatibility with legacy test code.

FossilOrigin-Name: fdba0b129091d607dc0c1aa52f8631a208dbff22476a298bd5428e672593ed18
 2020-11-30 14:20:17 +00:00
drh
d1032f952c Improve the speed of the tokenizer by recognizing that tokens starting 
with letters "_", "Y", or "Z" can never be SQL keywords and must be ordinary
identifiers.

FossilOrigin-Name: 16e281ed6219cc229dec7e3f1b40da2304dc270a74fd6ef78d04a088e30e7026
 2020-11-27 20:56:16 +00:00
dan
cad760d16e Fix a compiler warning in fts5_aux.c. 
FossilOrigin-Name: 8edb983bc87898eff2cd2e7e672a32a47c71b2be9d818513d339e95560d45b2b
 2020-11-27 19:40:13 +00:00
dan
6d19bf9460 Add missing cast to fts5 bm25() code. 
FossilOrigin-Name: 6ff9673847c0b4174d9435e93d19af0ee7406b1a12edeb6edec98697e1646824
 2020-11-27 16:15:55 +00:00
dan
3181706895 Remove a redundant "if( rc==SQLITE_OK )" from the fts5 bm25() code. 
FossilOrigin-Name: d85f4f27f58adcc75fc7d59e63af95b2a338052d8748a11f22ec1e48d1aff4cc
 2020-11-27 16:08:15 +00:00
dan
66efc393c5 Move an "if( rc==SQLITE_OK )" to outside a loop body in the fts5 bm25() code. 
FossilOrigin-Name: 14a4dcf3474566d072007a37d214c892397c21dd3b7f8b55ad0e5edfb7130dd6
 2020-11-27 16:05:31 +00:00
dan
1c5b23f170 Fix a case in the FTS5 integrity check where a corrupt database could cause a buffer overread. 
FossilOrigin-Name: a32b4f650d2d543bd2773cbc8655c1679a20b35ac9ec4d08c7754ddf6d972acb
 2020-11-27 15:28:26 +00:00
dan
ec8962869a Update mkunicode.tcl to match the change erroneously made to machine generated file fts5_unicode2.c in [b7b7bde9]. 
FossilOrigin-Name: 326d579d777fdede6bc64f9525248767f4730de4e50260b0387e614a9d006416
 2020-11-26 20:13:54 +00:00
drh
68b4034450 Update a requirement mark in the e_expr.test script. 
FossilOrigin-Name: bb174a074b5833181900d396edda955254ea1768750a0ab3b6d714530b1fe13f
 2020-11-25 18:44:20 +00:00
drh
d36f588f31 Fix harmless compiler warnings about unused function parameters. 
FossilOrigin-Name: 25d067c270966d9506db8bedf280883e32b69050b14bdbbeda4bb2d9a362619c
 2020-11-25 16:28:04 +00:00
drh
3ef2cb5991 Fix a potential NULL pointer dereference in the geopoly_overlap() routine 
of the GeoPoly extension.

FossilOrigin-Name: b5665712e667a20d42a2e892d9d540f4273609eabd56f8178e1d5664280821f3
 2020-11-25 15:29:08 +00:00
drh
f82d78e9c2 Fix the shell1.test test script so that it works on windows. 
FossilOrigin-Name: 9bd15b07e58b1811c2a368ec76059ac683a2c35b163ef4bba01ccb8b7ca7288d
 2020-11-25 14:50:42 +00:00
drh
b7c46aa8c9 Change the -init option to the command-line shell to honor the -bail option. 
Also change it to report an error if the filename mentioned cannot be
opened.

FossilOrigin-Name: a29f54bd2c032374d7235bb1f9d4c04c094611bbc7d274b7b92722b5b802050c
 2020-11-25 13:59:47 +00:00
drh
f862b55a56 Fix a typo in the sqlite3_txn_state() documentation. 
FossilOrigin-Name: 5b4325295b2f17b7a4eaa2d3a30d06a24801992b3aa17c7d57e015f9f395fb95
 2020-11-24 23:40:48 +00:00
drh
4989a530a1 Add the new sqlite3_txn_state() interface to the set of routines accessible 
by run-time loadables extensions.

FossilOrigin-Name: db25f1dc8eb8b8bd45912e9b457d4cc32687bc4f709ce1878e9b4ccedbb18af9
 2020-11-24 21:19:23 +00:00
drh
a7fc1686e4 Fix a harmless typo in a comment. 
FossilOrigin-Name: b2a201f1b5dc2fc94b360df4807c108fac47db2399edd8763efbdd66b71ffe5f
 2020-11-24 19:55:49 +00:00
dan
f5c3a75b63 Fix a bug in OOM handling code introduced by [6a28713d]. 
FossilOrigin-Name: 8a786ce99491401dd7660e54f1a1ba3b2300cecbe180b1a31e549ff5f5b77bdc
 2020-11-24 17:55:34 +00:00
dan
2e3cb1382f Ensure that super-journal and other journal filenames passed by SQLite to an sqlite3_vfs.xOpen() implementation may be safely passed to sqlite3_uri_parameter() and similar functions. 
FossilOrigin-Name: 6a28713d59cde0882c3508160347c2ea18c7c4e9bfd1b053103af2d5e12a144c
 2020-11-24 16:44:09 +00:00
drh
ef5b2d27b7 Remove the VERSION_NUMBER macro from configure.ac as it has been unused 
since 2009 check-in [7f4810747b086498].  See also
[forum:/forumpost/bb2c634fcd|forum post bb2c634fcd].

FossilOrigin-Name: 5466dd55d4aa15fd96f00b6e205dfb868879357a476df7ffd29b97bb570629a5
 2020-11-24 13:14:15 +00:00
drh
de9873bb0a Syntactic changes to work around a bug in gcov 9.3.0. No changes to the 
generated code for release builds.

FossilOrigin-Name: 4f1573b146193e5d552981a9d1d11e50da4da4a843f790e4af1cf0cc19a0b020
 2020-11-23 21:05:29 +00:00
drh
d46beb06aa In os_unix.c, put ALWAYS() on unreachable branches associated with pathname 
normalization.

FossilOrigin-Name: b45a08e3c7edfa76b699d3e29f28daa5bd08039668ec57121e4e85edf36150f1
 2020-11-23 17:36:06 +00:00
dan
39acaec16c Fix a test script problem causing crash8.test to fail when run with leak-sanitizer. 
FossilOrigin-Name: 2c437f7a2c87129d00c71fa569315b68e0ba9514041d93503350c9ae9f080f17
 2020-11-23 15:30:16 +00:00
drh
1335ec7df7 Allow "substring()" as an alias for "substr()" for compatibility with other 
SQL engines.

FossilOrigin-Name: aa2ee5754c9f8378c4d490ca756a6415042904477727f0d86e9c0190b5e8b275
 2020-11-23 14:50:43 +00:00
dan
6a5e21149b Add file doc/vdbesort-memory.md, containing notes on the way vdbesort.c uses heap memory. 
FossilOrigin-Name: 07f53899a929cce93f17c0332819610c9517c7e54e00092af20efd746cf84438
 2020-11-20 14:16:41 +00:00
drh
6fc74a4454 The xFullPathname method of the unix VFS now normalizes the filenames by 
omitting surplus "/", "/./" and "/../" strings.

FossilOrigin-Name: c38dec6f52c01614c1bee8356daf0fcd9f708d029116e9bff51e06719a730dde
 2020-11-19 21:12:08 +00:00
drh
e5dc4a2097 More test case changes so that shared-cache mode tests all work 
with normalized database names.

FossilOrigin-Name: 6f0d5f0949130a4688319adf05d37c5ccd683ca9ad2dacb7ce433a5fe18ac3c3
 2020-11-19 21:01:11 +00:00
drh
f4097026ef Fix the tkt3793 test case so that work even when filenames are normalized. 
FossilOrigin-Name: e85d32ac6c82d39f5dc9b28f881d5d72f5e5a7e16df12c19315bfa8edea1b0b4
 2020-11-19 20:07:24 +00:00
drh
5dc18e33ae Use an ephemeral table rather than a RowSet to remember rowids in the 
two-pass UPDATE algorithm, as this uses much less memory for large UPDATEs.

FossilOrigin-Name: 842c432772e6cd8464cdb7bfdb38789adeea9aa9e0486d4034cc9841f085f517
 2020-11-19 19:43:46 +00:00
drh
02e4b7d7df If a read() or pread() indicates that the database file is unreadable due to 
filesystem damage, then it returns SQLITE_IOERR_CORRUPTFS which is then
converted into SQLITE_CORRUPT before being returned to the application.

FossilOrigin-Name: 849e4e14fd06eda512381f5f8aa65f75ad0a955e835da7c63526a53cf5e8f4dc
 2020-11-18 23:44:41 +00:00
drh
f56a4bfcd1 Improvements to the mechanism that attempts to report SQLITE_CORRUPT if 
pread() says that the underlying filesystem is corrupt.

FossilOrigin-Name: b887c7504e7edeba758f3c1203c6cc56eef499fe05e7e6c6d82939bf7d78c57f
 2020-11-18 21:50:05 +00:00
dan
8ea11095c9 Update cksumvfs.c so that if SQLITE_AMALGAMATION is defined, SQLITE_CKSUMVFS_STATIC is implied. 
FossilOrigin-Name: 184e9d782dfbad8011b5b0043b3fd8e5a369ed7076e37e14b301483ce5ffe5db
 2020-11-18 20:55:01 +00:00
dan
c30b78f6f3 Add test infrastructure for cksumvfs. And update cksumvfs so that it works in concert with version 2 VFSs. No changes to core SQLite. 
FossilOrigin-Name: 43d4801df5dc4625f6829ed8246758493842b2416ba609ee0423ef63155cece2
 2020-11-18 18:36:43 +00:00
dan
8bb3961d40 Fix a problem causing sqlite3_carray_bind() to return an undefined value. 
FossilOrigin-Name: 083203a549d3cf26991d8626b308ff1e9e44be6abb72ab3d38e5fd53c99aed7f
 2020-11-18 14:30:53 +00:00
dan
5011bb8dd2 Update test code to fix a problem with SQLITE_OMIT_VIRTUAL_TABLE builds. 
FossilOrigin-Name: 29c779a07bf6ede1ec2cdb4695d801a5c113ab4b12d6cd22bcee8d2adb06891e
 2020-11-18 14:12:20 +00:00
drh
5a07d10fd1 On unix, for certain error codes of read()/pread() return 
SQLITE_IOERR_CORRUPTFS instead of SQLITE_IOERR_READ.  And then convert this
error into SQLITE_CORRUPT prior to returning back to the application.

FossilOrigin-Name: 9538ea8447e7b07c05197d6ff2208d3e97b45798736c85b63e8f0c7a3a98c1f3
 2020-11-18 12:48:48 +00:00
drh
32881bebbe Claw back most of the performance lost in the previous commit. 
FossilOrigin-Name: df8ce2675b070fcdc338918e7652a26ffc90439fe399ceac206fadf8a93a681f
 2020-11-17 21:26:13 +00:00
dan
aff1a57f4d Fix trivial memory leaks in the shell and sqldiff programs. 
FossilOrigin-Name: 272793e5edc47e431be77d589718a001f2696869e3e15f1371a1890645a995a7
 2020-11-17 21:09:56 +00:00
dan
12c9994659 Fix test file busy2.test so that it works with the "inmemory_journal" permutation. 
FossilOrigin-Name: b192fdddb63ac56fd6725032af110a069baac52347c0012c130bf34f3cbe69e4
 2020-11-17 18:25:48 +00:00
drh
ea847f1b94 Add a single-argument form to the CARRAY table-valued function, with 
content bound using the sqlite3_carray_bind() interface that is included
with the extension.

FossilOrigin-Name: 7b229cb1202be203a87b8f47d284313f357deb1e6dfeb94bba7b46744c33512e
 2020-11-17 14:41:37 +00:00
drh
7f42dcd901 Enhance the unix VFS so that it removes extra "/", "/./" and "/../" from 
the database filename.

FossilOrigin-Name: 7ba89d3e5c68d970ed26c2ec6e6e34bae535c2cc0b22a022d20ac9ff4527b8ab
 2020-11-16 18:45:21 +00:00
drh
ea2487200f Modify UPDATE so that two-pass updates on a rowid table use an ephemeral 
table to store rowids rather than a RowSet.  This uses less memory, though
it is slower.

FossilOrigin-Name: 4673096dd8c5ed7aed098ff518a6d01d35c40fad991b89fddd91c19a727a4308
 2020-11-14 20:03:34 +00:00
drh
b035b87ef8 Improved diagnostics output with ".wheretrace 0x800". No changes to 
non-debug builds.

FossilOrigin-Name: 772ae83c61c87a9004a614d8ec120ba843286bff1edbd20b987fd592ced84d79
 2020-11-12 18:16:01 +00:00
drh
75e6bbbeca Fix a typo in a comment. No changes to code. 
FossilOrigin-Name: 572f1ed59d29e74f810c74ef9e72ebc94c2d3e04befc03a1f88034f04a9c60a8
 2020-11-11 19:11:44 +00:00
drh
235667a858 Use NEVER and ALWAYS macros to confirm that the return value from 
sqlite3ExprSkipCollateAndLikely() is never NULL in some of its use cases.

FossilOrigin-Name: 76d2eb86e109fc3cbdba2e8175c22ed7660b59bb9315f6c55c565587f33ad43b
 2020-11-08 20:44:30 +00:00
drh
78043e891a Add ALWAYS() to conditionals associated with SHM locking that are always true. 
FossilOrigin-Name: b599e89076d60afede7d2b3503b9338ca863d0c2d25799afe4080a6186386ea9
 2020-11-06 16:48:55 +00:00
drh
4e451aad54 Suppress errors associated with TEMP triggers that reference objects in 
non-TEMP databases.  This is a continuation of the fix for ticket #3810
shown in check-in [ba1afc040171810d]
from [/timeline?c=trunk:200908061743|2009-08-06], based on a bug report in
[forum:/forumpost/157dc791df|forum post 157dc791df]

FossilOrigin-Name: 991ca9b26bacd8f6b64498057fe28f2068466a220f372fd365b6685f583f0e92
 2020-11-05 19:13:44 +00:00
drh
114cb01796 Remove unused variable from speedtest1.c 
FossilOrigin-Name: c0a18565e614021b74646de7efd11d3d46894ef9132fb26787ab0269dc6a647c
 2020-11-05 14:50:21 +00:00
drh
6d5ab2a1d6 Fix an another OSS-Fuzz discovered assertion fault due to ALTER TABLE and 
strange triggers.

FossilOrigin-Name: 6646d7898ca1d2f71ec906d9613fbfc5c59c6cf05f053529e6e32ab826d1cb78
 2020-11-02 00:40:05 +00:00
drh
2fa7818571 Add the -tabs command-line option to the CLI. 
FossilOrigin-Name: 7d01e84dc49074e6364267eea9fd20d46a457d2498121a0f218fbf482692392d
 2020-10-31 18:58:37 +00:00
dan
7a39faecc2 Update the ALTER TABLE command to correctly handle UPDATE ... FROM statements within trigger programs. 
FossilOrigin-Name: 3e6af890406b58da1c4aebec4d483be7ab0fdb589ef7a4c4e987d6bde18d6b97
 2020-10-31 16:33:01 +00:00
drh
ed7974dee5 Always create a statement journal when using the OP_ParseSchema opcode, 
as you never know when it might fail.  See the discussion on
[forum:/forumpost/daa2c728cc|forum post daa2c728cc].

FossilOrigin-Name: aa512f72cf5adfece6299db17bd122aeff0cdee2a25f83f60e2ebb05e99c9591
 2020-10-26 18:14:12 +00:00
dan
19f7bd3b07 Ensure that the table argument passed to Tcl_GetIndexFromObjStruct() in the sessions module test code is declared "static". 
FossilOrigin-Name: 80eba105d6d1b49ba8ca2ad4e14ddec2de0bdc2f6686c2f8a1c1d24fc1fe846f
 2020-10-26 16:22:31 +00:00
dan
d1d43efa4f Prevent fts5 tokenizer unicode61 from considering '\0' to be a token characters, even if other characters of class "Cc" are. 
FossilOrigin-Name: b7b7bde9b7a03665e3691c6d51118965f216d2dfb1617f138b9f9e60e418ed2f
 2020-10-26 13:24:36 +00:00
drh
beb22d086b Minor tweaks to query planning weights so that when STAT4 is enabled 
and functioning, a full table scan is more likely to be selected if
that seems like the fastest solution.  Only do this when STAT4 info
is available because an error has a large potential downside.

FossilOrigin-Name: 0e7e113d9f2c929c1f8a85e2cfad8e2e60f0e8770212b5e5320fb2a2c42911f8
 2020-10-22 18:50:30 +00:00
drh
461ff3594b Test case updates. 
FossilOrigin-Name: 27c681c9c6672ad7098d8ff2c41e76d3e9e55866b6327ed85e73f63bd623ceed
 2020-10-22 18:16:17 +00:00