mirrors/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
22,856 Commits 1,487 Branches 166 Tags 416 MiB
23634898c5
Commit Graph

22856 Commits

Author SHA1 Message Date
drh
49e6e5a04f In the wholenumber virtual table, increase the cost penalty for running 
open-loop.  This appears to fix the problem reported by
[https://sqlite.org/forum/forumpost/b52a020ce4|forum post b52a020ce4].

FossilOrigin-Name: f12b54042e27b2fe99f23f97c103ee4371f8d4df3b049d9bb5d64891db56eee5
 2021-03-19 17:54:43 +00:00
drh
340fd0bc23 Dbsqlfuzz found a new way to make that branch in codeVectorCompare 
reachable.

FossilOrigin-Name: 959272c27555e39f180d46257afe45d41da1f5df38ea269196c06741ff6a278e
 2021-03-19 16:29:40 +00:00
larrybr
4cf34a5e73 Fix tokenizer's classification of EBCDIC newline. 
FossilOrigin-Name: 8680f6a8fb34b9c0ea9b4286888b4df5df427d2df10c782d198bc3f2fdcd0704
 2021-03-19 15:02:59 +00:00
drh
66f9655599 Restore the NEVER() that was taken out by [f481636f1a0333c6] because that 
case is no longer reachable after the previous check-in.

FossilOrigin-Name: e3a78b2a237a2e101faf01dde913f63641da8854720a9daa4b45a9c5dfe30b1b
 2021-03-19 14:51:15 +00:00
dan
93eb906488 Fix a crash that could occur when an INSERT has more than one ON CONFLICT clause, at least one of which contains an unresolvable symbol. 
FossilOrigin-Name: 74208386508012326a0e88ec5b4a995d1b99607720bb05785a01c2d89ea03543
 2021-03-19 14:26:24 +00:00
drh
d685dd6be6 Correlated CTEs should not generate a materialization subroutine. If they 
need to be materialized, each use case must be materialized separately.
dbsqlfuzz 01b8355086998f0a452cb31208e80b9d29ca739a.

FossilOrigin-Name: d72d865d3e8503a545603038eb26044bee42e4e8725522be678059ce6517fc8d
 2021-03-19 13:53:34 +00:00
drh
a979993b25 Improved labeling of EXPLAIN QUERY PLAN output. Many test failures due to 
the different output format.

FossilOrigin-Name: 6f8faec0222a7ca07cc1a5ed16cc08d92c6e20bbcb34851b4eff9e624de53601
 2021-03-19 13:00:28 +00:00
drh
080fe6dec9 Add a NEVER() on a branch that was made unreachable by the 
"circular reference" fix.

FossilOrigin-Name: 114d9780aecdd9f03f235fc1f2ab81ef89cb00b3bafa61cff612e939595ff5f0
 2021-03-18 20:04:46 +00:00
drh
f09a1794d8 Disable a test case requiring generate_series when virtual tables are not 
available.

FossilOrigin-Name: ee86e2f4c5999a090a5d2fe8251107cf55e621a6b988f315eb82f462cc1e377d
 2021-03-18 18:27:37 +00:00
dan
ca237a8b7b Fix a problem causing spurious "<cte>: circular reference" errors to be reported when there is actually a different error in the SQL statement. 
FossilOrigin-Name: 9981223618782bf867dfc8988d0c634a42f569228880c5c5e00aa4ae762cfff2
 2021-03-18 18:25:43 +00:00
drh
42d2aec1e9 Increase the patch level to 3.35.3. 
FossilOrigin-Name: 259b7c3e219873f3f679b00d3a89ecdac8a02c3472176d3a260f399e1faf3611
 2021-03-18 16:52:06 +00:00
drh
8d81aac13f Fix the OP_OpenDup opcode so that it is able to duplicate a cursor that 
was itself opened by OP_OpenDup.  Add additional verification of
ephemeral tables.  Fix for ticket [bb8a9fd4a9b7fce5].

FossilOrigin-Name: bcbe5308f3a3b94f965b0f5627cb29cce2e09343b86d757e2de889f7773576e7
 2021-03-18 16:47:24 +00:00
drh
76f7b16f1e Remove unnecessary code from sqlite3BtreeClose() and add test cases. 
FossilOrigin-Name: edbfdcaefae1e9a42c046c058341bf5b0f533c0b0cbd39543fcaa2a83d67561d
 2021-03-18 16:36:31 +00:00
drh
5a4a15fd2e Further sanity checking of the OpenDup cursors. 
FossilOrigin-Name: 0ec71cf16983697f68ab8d921d80a5f39611e4cb5e6e19cbc4a9ad6d49bfc835
 2021-03-18 15:42:59 +00:00
drh
8df014979e Fix the dbsqlfuzz-derived authorizer in fuzzcheck to avoid creating junk 
files when running rogue tests.

FossilOrigin-Name: eca21a620630b0c8d21a91ad6a8760a6c87270ab2a45cafa18bd31b305c53dba
 2021-03-18 14:36:19 +00:00
dan
eeee8a5f01 Automatically close ephemeral b-trees when their last cursor is closed. 
FossilOrigin-Name: 39b5af18c0580c8e92516d410f8c465bfec31b2d0be9df1cfd6a1d1a19b4fc14
 2021-03-18 14:31:37 +00:00
drh
8e7c82ca3f Fix a problem with the filename normalizer in unix, discovered by dbsqlfuzz. 
FossilOrigin-Name: ff1eca7fcdcbc550a5f23db9d85281e5373500912699a7c7ae54bc0df0547e26
 2021-03-18 13:55:25 +00:00
dan
918232aadb Allow instruction OP_OpenDup to duplicate cursors created by OP_OpenDup, as well as by OP_OpenEphemeral. 
FossilOrigin-Name: b8de980b2fb78088ef74e053cb987bb84319d13dc96ce1e89baaaa3fe8cf1efc
 2021-03-18 13:42:53 +00:00
drh
e44ac3858c New assert statements associated with Ephemeral cursors in the bytecode engine. 
FossilOrigin-Name: a8ce73e2573b271d5d45838802ed1905ce5e18d5fafe0078700e79fab85457e2
 2021-03-18 13:19:41 +00:00
drh
2b994ce5d3 Change the name of the iDataVersion field of Btree to iBDataVersion to make 
it distinct from Pager.iDataVersion.

FossilOrigin-Name: e4c44c0bca317c03f8e6d3aa7cc88e5f96159a3d91c07257d408f7db028fd151
 2021-03-18 12:36:09 +00:00
drh
176b04c476 Version 3.35.2 
FossilOrigin-Name: ea80f3002f4120f5dcee76e8779dfdc88e1e096c5cdd06904c20fd26d50c3827
 2021-03-17 19:07:21 +00:00
drh
8b04094c4f Fix a harmless compiler warning in the appendvfs.c extension. 
FossilOrigin-Name: 0ed7eb9115510511f13dca715bb2b178580648517d8d30436a992d70a2e85ac1
 2021-03-17 19:05:59 +00:00
dan
51ddfef74d If there are already 500 or more simple SELECTs in a query, do not add more by flattening UNION ALL sub-queries into parent join queries. 
FossilOrigin-Name: 9520bed2bd87dc56543ee58123323d293e960ecd84707b77f15f41669a2c9c3d
 2021-03-17 14:29:37 +00:00
dan
42470513b7 Fix a problem in sqldiff virtual table hanlding to do with tab and other non-space whitespace characters in the CREATE VIRTUAL TABLE statement. 
FossilOrigin-Name: 1737e4fdfc9a3628415b234338a68a64cbbaadb23598517761e571ab7ed7ad14
 2021-03-17 11:25:42 +00:00
drh
a7d8d4a07a Date/time functions with no arguments (ex: date() or time()) should be 
non-deterministic.  Fix for ticket [2c6c8689fb5f3d2f].

FossilOrigin-Name: 1734c332e7f609769fc30f82cf7af097c2964e08900ee3e297f6a25e6df60555
 2021-03-16 18:41:20 +00:00
dan
1fffa73ea2 Add tests for sqlite_rename_quotefix(). Fix a memory leak in the same. 
FossilOrigin-Name: 531550056c38589c99c9a97b6afdbf8f34ff8d2131d74e9d42af3506e8045064
 2021-03-16 18:24:49 +00:00
dan
2ad080aa82 Have ALTER TABLE RENAME COLUMN and DROP COLUMN use sqlite_rename_quotefix() to convert any double-quoted strings in the database schema to their single-quoted equivalents. 
FossilOrigin-Name: 6446c0961077396086251670102ea7bf17d54a6b0f0ca56c6af89028a1ff9039
 2021-03-16 16:14:48 +00:00
drh
0d3485f019 Increase the version number to 3.35.2. 
FossilOrigin-Name: 7a211b3f09b17b758ac43c3ed14e3f90c55459077412a57baca0f7cadff47fbf
 2021-03-16 14:43:26 +00:00
drh
0f503f6696 Fix recent breakage of the appendvfs extension. 
FossilOrigin-Name: 7dbbe5b34eea31ea54a5804035d4d0dfeb09c42cd9ab337e1e64c1296decbef3
 2021-03-16 14:26:56 +00:00
drh
3fee67533e Comment and stylistic changes to the appendvfs.c implementation. 
FossilOrigin-Name: 25c3186aa143328157fb506a29802e87099cd14be4fa218230484a3212f20621
 2021-03-16 14:12:26 +00:00
dan
00bc66f2cc Merge trunk changes into this branch. 
FossilOrigin-Name: f15d51054afb1e3fec87938f2b04a5a0d0611b08248367850450de7c4166e3d1
 2021-03-16 11:21:36 +00:00
dan
776a578c21 Fix a problem with ALTER TABLE RENAME COLUMN when used on a schema that features generated columns. 
FossilOrigin-Name: 0e255b26872b50581d470952dd98e21dd82d081885006f58d49daa4b4576b35d
 2021-03-16 11:11:07 +00:00
larrybr
67d4bbf6c1 Fix assert typo. 
FossilOrigin-Name: 3aedf818c1cfc88ee1103abd8b20e787f6be1bcc4c9350963f0cd52f5ac04154
 2021-03-16 07:06:29 +00:00
larrybr
b0f23784f6 Merge from trunk. 
FossilOrigin-Name: eae8236f3b9bc326648d1c8fca61cb3c38f821d06fe915fd0978cffeb1f6152b
 2021-03-16 06:50:39 +00:00
larrybr
5cad178b86 Fix appendvfs bug exposed with bigger files, and add tests for such conditions. 
FossilOrigin-Name: 19b1f53a1c0a14440ae8ac71660a2595d37a4a5b201055c19366c7dca75d6660
 2021-03-16 06:41:51 +00:00
larrybr
21f0f694ff Create new branch named "appendvfs_fix" 
FossilOrigin-Name: 026edd601444d86858a503ffc3be17667a62a29f09c001009d9a678400b3b0a1
 2021-03-16 04:03:59 +00:00
dan
1e24072d05 Add internal SQL function sqlite_rename_quotefix(). For converting double-quoted strings to their single-quoted counterparts in DDL statements. 
FossilOrigin-Name: d874b300463ce0bbb53b7e2f88c6a12893e4fd751fcc7f810077ba108f4061ef
 2021-03-15 20:22:34 +00:00
drh
a7eaa518f8 Version 3.35.1 
FossilOrigin-Name: aea12399bf1fdc76af43499d4624c3afa17c3e6c2459b71c195804bb98def66a
 2021-03-15 16:53:57 +00:00
drh
67c4ce131b Improvements to the built-in ".dump" documentation in the CLI. 
FossilOrigin-Name: 0915f969f429a8d0b594e937e0128d5476774d9bbe4a24081dbc60273cb5bb9a
 2021-03-15 15:12:10 +00:00
drh
c9f1a7d1df Bump the version number to 3.35.1. 
FossilOrigin-Name: 184d5a352f098459cfb0cc029713d5d43fefc83f6cc95ce5666bd07591aaac2f
 2021-03-15 15:02:38 +00:00
drh
6127d73abc Improved detection of conflicting indexes when doing DROP COLUMN on a column 
whose name is quoted in the index definition.
Fix for ticket [1c24a659e6d7f3a1].

FossilOrigin-Name: c450d0ad6b39db4bf93015d629e25f7af0d7a9779f7a987e2fc38a5ef064a182
 2021-03-15 14:58:12 +00:00
larrybr
7bdbe59829 Make shell's .help output for .dump more accurate as to what can be dumped. 
FossilOrigin-Name: f91d8c09a02f7a7ab354c49cd193d422074daa5eb908f17d1907a8c2b38f96a5
 2021-03-15 12:56:00 +00:00
larrybr
d8b4befdef Create new branch named "cli-tweaks" 
FossilOrigin-Name: 4cf056a571cae6fded8136bc12f3a2787da37c6b52383cbf7b918827654ba4e7
 2021-03-15 12:32:35 +00:00
drh
0e8075ab78 An additional test case 
FossilOrigin-Name: 7e2d7ca15a84e5bd9f2b1360232607d15c2dbcc9d30b0f1a7cdbf2865e6b1af5
 2021-03-14 20:17:06 +00:00
drh
44d441313a An alternative approach for fixing ticket [1c24a659e6d7f3a1]. 
FossilOrigin-Name: a2adae907a28e169e64cfe69d97d7b68cb94e6ba07d2dfa995e3fbc6672fafdd
 2021-03-14 19:55:40 +00:00
dan
b19a581241 Fix a memory leak in the new code on this branch. 
FossilOrigin-Name: 0817cf2ec08fdefd3c1d41790df7b5d6d490767757b44bb0229694023c8e40fc
 2021-03-13 18:23:30 +00:00
dan
9bfafa8917 Fix typos in comments and add test cases. 
FossilOrigin-Name: 01312a3dbd92823af535dc618c68d95a2aa1cbee2501b0a9826eae3f09bec760
 2021-03-13 17:21:24 +00:00
larrybr
9c0fee296a Update generated autoconf/Makefile.msc to reflect its source. 
FossilOrigin-Name: d9f8f488ff9d47fe7bb8838e683bae4fea038f7278ef885ecf292143a0dd88ed
 2021-03-12 23:15:08 +00:00
dan
7607580791 Fix a crash in new code on this branch. 
FossilOrigin-Name: c05ed2a8a9c4975c69bdfa733598ed90c1509d52b3c39dedbd829ab148777e1d
 2021-03-12 21:09:20 +00:00
dan
051170c453 Merge latest trunk changes into this branch. 
FossilOrigin-Name: 198bc510d64b5794559584ad5c9de41dc966dce4eb78be15b12adba43dfcb639
 2021-03-12 18:33:55 +00:00
dan
5383db714e Attempt to use an index for DISTINCT aggregate queries that have GROUP BY clauses. 
FossilOrigin-Name: 3bca003cd2b2cb38d4a4e2e5f673ee0ac05bfe31247ec09e7bd379b77a31b44c
 2021-03-12 18:24:31 +00:00
drh
f1c43ea647 Version 3.35.0 
FossilOrigin-Name: acd63062eb06748bfe9e4886639e4f2b54ea6a496a83f10716abbaba4115500b
 2021-03-12 15:10:09 +00:00
drh
0ca23aa437 Fix broken requirement marks. 
FossilOrigin-Name: 98d67152849e062c6de45b0e526daffc3d6cb29d563d40664a8d7140119a30b2
 2021-03-12 13:49:09 +00:00
drh
9d59e3b1bf Fix the ".read" command in the CLI so that SQLITE_OMIT_POPEN disables 
reading from a pipeline.

FossilOrigin-Name: cea34f3cc35ad6dc67691799a219a30739f2296945d624d232bf76150c598ec0
 2021-03-12 01:49:08 +00:00
larrybr
ab6098cfa6 Conform description of sqlite3changeset_op() arguments to implemented behavior, some reformatting. 
This is a comment-only change; no code is affected.

FossilOrigin-Name: 9d6e544c47b9a5d97bd02a658db5cd202bd1952f8ba3bc50e8cf47d7206041c0
 2021-03-12 00:44:10 +00:00
dan
3ddc3809bf Fix a Tcl object leak in test_session.c. 
FossilOrigin-Name: 07150cf15ad36c7fc681a911f66db23d610ddf110a7be7f1fcefbd8750cd135a
 2021-03-11 15:57:25 +00:00
drh
407cfe994d Bug fix in appendvfs.c: Adjust the size parameter for 
SQLITE_FCNTL_SIZE_HINT to account for the prefix.

FossilOrigin-Name: 41df3bbefd63151f2ddb920066777eab8e07ecfc0edb0f71f9493debe0a4a2c4
 2021-03-11 13:43:29 +00:00
dan
632f0ed265 Have the Tcl tests support environment variable SQLITE_TEST_PATTERN_LIST, so that if it is set it is interpreted as a list of patterns that are matched against tests file names. Only test files that match at least one pattern are run. 
FossilOrigin-Name: b7c92e1d08f213865f026d8dbdc4e805fb5c119b7f206506ed06e83a878de657
 2021-03-11 08:49:52 +00:00
dan
3fb7bd5ee0 Fix sanitizer complaint in fts3 code. 
FossilOrigin-Name: 424b39eaeb578f85e58214af4b467e6e363431308ab7a327774e62fa70d3c2db
 2021-03-10 20:04:21 +00:00
dan
55b2e8b062 Fix further sanitizer complaints in the fts5 code. 
FossilOrigin-Name: 4cb00b9d4020a51f690720c6f51009c5be8c22ef8c70807ead1d953d19784f26
 2021-03-10 19:32:47 +00:00
drh
662a1426cb Improved testcase() related the SQLITE_MAX_ATTACHED vs. SQLITE_MAX_DB problem. 
FossilOrigin-Name: 27d3c00efef66ad48ed94228474dbea3ad81ea5c19425028c42cf4220920a645
 2021-03-10 18:21:18 +00:00
drh
4d17e30624 Improvement to the ATTACH-abuse authorizer logic in fuzzcheck. 
FossilOrigin-Name: 88132f698a7a9b7d41dd1dd393592cbda130d2bf1a9fd18c509503e1891b9655
 2021-03-10 17:52:59 +00:00
dan
ba34b79f15 Do not run avfs.test when testing SQLITE_OMIT_VIRTUALTABLE builds. 
FossilOrigin-Name: 2ab6957a2238a2ab713a50d21dbd9921c944e8141197275bbfe7dae303fee7d0
 2021-03-10 17:43:18 +00:00
drh
099b385d17 Do not confuse the constant SQLITE_MAX_ATTACHED with the maximum number of 
schemas.  Add the new SQLITE_MAX_DB constant for the maximum number of
schemas.  [forum:/forumpost/a006d86f72|Forum post a006d86f72].

FossilOrigin-Name: 7b65fb9f7bd616f834633afd64b3448bf9ca2b6e4cc6d6c01e75d1d877c88a79
 2021-03-10 16:35:37 +00:00
dan
bc3c4e0830 Fix test file avfs.test so that it works with SQLITE_DEFAULT_AUTOVACUUM builds. Do not run avfs.test under test permutation "journaltest". 
FossilOrigin-Name: 2c6078ebe797dd2cb6045b5f13e6d92a6b49393ecf96f9fd7222412f5a3eefd5
 2021-03-10 15:10:20 +00:00
dan
3be2b860d0 Fix a few sanitizer complaints in fts5. 
FossilOrigin-Name: 4fe4fee00e9294fa384bd073ed8e9a2a4ad10dcf653b6ad4851e44a64443ede9
 2021-03-10 14:57:10 +00:00
dan
a1c467f51f Fix a problem preventing wapptest from setting SQLITE_ENABLE_LOCKING_STYLE for OSX tests. Also modify the "Sanitize" configuration in releasetest_data.tcl to subsume test item 6g. 
FossilOrigin-Name: f762d7df2a41a88560a4251d744e0887f42812f8160af4f0129d22a71c0fa48b
 2021-03-10 10:43:17 +00:00
larrybr
c5edbd1cf6 When shell has no .ar, fake its effect w.r.t. page_size and table creation/filling. 
FossilOrigin-Name: 959f5c65ea14f4716df61e250e9d5a0d69d602a2a973ad22a364e640162c2983
 2021-03-10 06:06:16 +00:00
drh
a94c484584 Add appendvfs.c to the MSVC makefile. 
FossilOrigin-Name: a6681fbb2e0c8d5a7c968f6fd458f61658fad6ac4c7eb8663762b6ac386cdae5
 2021-03-09 23:38:27 +00:00
dan
4049ede97d Update a comment in btree.h. 
FossilOrigin-Name: 9645fe1a050e8b61aea1fba2f142819c387ecb043741392c5719bf7ad303bf8b
 2021-03-09 21:20:12 +00:00
drh
0db20c490a Fix a bad comment (copy-paste error) in the byte code engine. No code changes. 
FossilOrigin-Name: 1c01745734c7b62a8c792f743aae08dfbb9e047dc92fef8da067fec152b20fd5
 2021-03-09 20:58:21 +00:00
drh
45e4cb8e77 Improved comments on the NOT NULL strength reduction optimization. 
FossilOrigin-Name: a85d72293914b48edbb39171fd591d37ffb09570d8103140a052203ec71d49ee
 2021-03-09 19:52:15 +00:00
drh
6d0053cfa7 Extra comments and testcase() macros associated with the new 
sqlite3ParserAddCleanup() mechanism.  No changes to release builds.

FossilOrigin-Name: c3c8691121e6cb7bfc326212cc81a7472c0e6f22e655ab024bd4bd885e1cd878
 2021-03-09 19:32:37 +00:00
drh
e7a377046d Add --enable-math to the amalgamation autoconf. On be default. Improved 
logging of the amalgamation autoconf.

FossilOrigin-Name: 85d28b52250e1817b722dc10da3b7b73abf7539cbe7aa913b5960ae4da40d5f8
 2021-03-09 17:09:00 +00:00
dan
96ecb7b004 Add missing comment to new routine in select.c. 
FossilOrigin-Name: ef2f0cf21ba61bdd29e09cf41b012a2d757683f524a252f0af7dfee7df1a1a0f
 2021-03-09 16:47:33 +00:00
drh
42c93b5e9f Math functions are enabled by default in the main configure script. 
FossilOrigin-Name: b7456e0715c63308b7b3acf49eb66ecd947481400d4688ae459e2e1499447bcd
 2021-03-09 16:35:14 +00:00
dan
4fcb30b7d7 Experimental optimization for distinct aggregates (e.g. "SELECT count(DISTINCT <expr) FROM ..."). 
FossilOrigin-Name: eb919611fd2f255e4ad1fe7db633363793169f6cf99c650eaefa48c022eb5d22
 2021-03-09 16:06:25 +00:00
drh
24ec37c3b3 Improvements to the configure script. Math functions are enabled 
by --enable-all.

FossilOrigin-Name: c79c6d18dee608e54ae31388b240cc521218309094502d8815111bb4ddf7d9ef
 2021-03-09 13:53:39 +00:00
drh
657a7a66c3 Update the authorizer in fuzzcheck to align with dbsqlfuzz. 
FossilOrigin-Name: f86d8fae3b29de014d8bfcae38a15bdb15ddceabfcfff7829f3145cfd69dff2a
 2021-03-09 13:12:58 +00:00
larrybr
ddf4972063 Add tests for too-tiny appended DBs, clarify align macro. 
FossilOrigin-Name: eb40a8dea6afe6890ddda989de83f3d4ae03b112bf78bfc818dfbd57cc5b5b2a
 2021-03-08 20:13:43 +00:00
dan
52a0753152 Add test cases for ALTER TABLE. 
FossilOrigin-Name: 9c9ba36e859e330c50ed40ede4b93eeb0a5c3337240465d953a7be9115a81390
 2021-03-08 17:22:01 +00:00
drh
e58b2b4a80 Fix a bad assert in RENAME COLUMN. 
dbsqlfuzz 3f0a7245b69cd08617d7d7781ebaedb0fe765a93.

FossilOrigin-Name: f13e0d12f137cd6b4e83e92bd36652431d8416e6eed4797313e061f2e390d39b
 2021-03-08 17:17:38 +00:00
drh
baca9807f9 Fix a harmless compiler warning in appendvfs.c 
FossilOrigin-Name: f538961a8058cc327d64c8ec317f1b4f8bbb604f90261160c6c27f26f4800682
 2021-03-08 16:29:06 +00:00
drh
7ae0549961 Enable internal functions for fuzzcheck. 
FossilOrigin-Name: 79281603b951b438303130820deb6b05baeca366c2cd93be7d8909d3232bcc96
 2021-03-08 16:13:52 +00:00
larrybr
b47e4c2819 Added test/avfs.test (missing from branch merge for some reason.) 
FossilOrigin-Name: 08fa67053c20d223c9b5334fe2e85adc95588b91046c100d7fe8e8e2535e485f
 2021-03-08 14:32:26 +00:00
larrybr
fb645d20bc Merge appendvfs updates and testing. 
FossilOrigin-Name: 63fcf301fedf1f3708e2226ed499a53b3e9c1d2cc2b17d4b0b736e36aff0ae74
 2021-03-08 14:26:22 +00:00
drh
e021890954 Require that the appendvfs suffix mark indicate that the appended database 
begins at an offset that is a muliple of 512 and that the appended database
contains at least 512 bytes.

FossilOrigin-Name: aeb87cc70495dd172e170eff31fd754331d4b979c0b649ab239f8c5c0c76e695
 2021-03-08 13:45:08 +00:00
drh
1e6f334645 Correct the precendence order for rules that determine how a database is 
opened by appendvfs when a database is appended to another database.

FossilOrigin-Name: 92989fc56f2e81ac13f8106ec83c930f43d10715269b988ee47c9bfa53621995
 2021-03-08 13:30:29 +00:00
drh
40942f22f1 Minor comment and formatting changes. 
FossilOrigin-Name: cf2add064f70c477fee1473c3196b72deb41222eb0cdbbdbdcf4a79995184e2b
 2021-03-08 12:59:16 +00:00
larrybr
5777380d19 Add tests for sqlite3 shell with -append flag. 
FossilOrigin-Name: d1790288729441d53603709df02aa5fb5f04714e2da86ce128ca81840b0b545f
 2021-03-08 01:31:53 +00:00
larrybr
7e398c04fe Add grow/shrink tests. Fix truncate bug. Make appendvfs.c easier to inspect. 
FossilOrigin-Name: c9521fa55620d0cb3cec20db7b42bc5f18876b42dca07811d1cd0f4b2907eab2
 2021-03-07 18:55:25 +00:00
larrybr
b2e9640155 Merge from trunk. 
FossilOrigin-Name: 729117cdfa2d6ff24b66656e9ccc380199606b830fc338286e4dd10e8e787597
 2021-03-06 23:49:18 +00:00
larrybr
1b22ad8ae6 Create initial tests for appendvfs, and make it available as a statically loaded extension. 
FossilOrigin-Name: 9f33d45179f5985bd4c4f7582e94f5833a63f853c8cdc19f39cf7e3ee70177d0
 2021-03-06 23:36:47 +00:00
drh
4bb4293b2a Limit parenthesis nesting depth in FTS3 expressions to 
SQLITE_MAX_EXPR_DEPTH.

FossilOrigin-Name: 5ddd8032ef9ecd5b53909d304c8f1375a72f270fd7810964cb4e385e25bedd4f
 2021-03-06 15:13:26 +00:00
dan
7f8653a257 Ensure the correct collation sequence is used for comparisons when delimiting a RANGE window. 
FossilOrigin-Name: 01eae68e85b31b7a9f08733459765bbd9bf9dad592bf64f10fc2fa32e02a89c2
 2021-03-06 14:46:24 +00:00
dan
fa9011ec70 Fix a crash in fts3 that could occur when running a NEAR query on a corrupt database. 
FossilOrigin-Name: 609d94996324f3d3c12bb8cc04a2527d1d86c35cdb2267b5b34053c961158986
 2021-03-06 13:28:07 +00:00
drh
747cc9425d Fix a possible NULL pointer dereference when applying a DROP COLUMN to a 
corrupt database schema.  dbsqlfuzz 419aa525df93db6e463772c686ac6da27b46da9e

FossilOrigin-Name: 349ccf58ae4bb770805066102fc8e9e478d4da1f7a6a728223bd74eabf7b7843
 2021-03-06 13:02:12 +00:00
larrybr
1f8f131a8b Merge last day of trunk changes, reverify build. 
FossilOrigin-Name: 1d67ed1c98a6bc49cce6bdc156bd6f22b3f37d33226bd62430a43aa5318f5781
 2021-03-05 20:52:19 +00:00
larrybr
feecc9f547 Fix appendvfs bug exposed by docsapp build (in docsrc), and tighten/revise published behavior. 
FossilOrigin-Name: 7f0f2eacdb496f7f36865ba62164a48edb324a3c6baede736b4e7edf5e8b0fdb
 2021-03-05 20:46:53 +00:00
drh
70149ba47e Modify the SQLITE_DBCONFIG_ENABLE_VIEW option so that it always permits 
TEMP views, just as SQLITE_DBCONFIG_ENABLE_TRIGGER always permits TEMP
triggers.

FossilOrigin-Name: 83dab8b358b6832a221a58e74dd5e99b9cdea4eee65124bb6799881e867d989c
 2021-03-05 18:33:01 +00:00
dan
68d4f07577 Fix problems with RETURNING clauses attached to UPDATEs on tables with virtual columns. 
FossilOrigin-Name: 6b41b136fbfc0b56a6948f2306b69fb1d69306adb86674a15a87fe3b52062512
 2021-03-05 15:42:15 +00:00
dan
0d08072b68 Fix another problem with RETURNING clauses in UPDATEs against tables with virtual columns. 
FossilOrigin-Name: f0ef5c76ab1a6568b9148b928277bf589d4cb7033c0acf3e6323879b656d8bd1
 2021-03-05 15:29:22 +00:00
dan
a7e16a2f05 Fix an assert() failure that could be triggered by a correlated sub-query in a RETURNING clause. 
FossilOrigin-Name: 551260c8625828262809b1ef7acf5343a3527b7e167ca0cfd13b81e5ece0e66c
 2021-03-05 15:10:33 +00:00
drh
bc7819d176 Fix the processing of implied LIMIT clauses when flattening a compound 
query.

FossilOrigin-Name: 90c6b9fcb0e15e2552fe5be53f8201f145bb535cc37b603d488eadf33438412b
 2021-03-05 14:08:45 +00:00
larrybr
b14d14696b Create new branch named "appendvfs_tighten" 
FossilOrigin-Name: 48c968bf4c8e1517864bec68d3072441994ea511a9cb446d2fdf031d5f43b077
 2021-03-05 09:42:58 +00:00
drh
05edf729f7 Mark the NotUsed parameter to the dropColumnFunc() function as unused, 
to avoid a harmless compiler warning.

FossilOrigin-Name: 23459071091248e94202e609bb8031c3e34722b8ae8ff5a66851dcc528a2d2c2
 2021-03-04 19:44:01 +00:00
drh
91be05a910 Put ALWAYS() on a branch that is now always true because of changes 
in OOM behavior due to check-in [9adf6e2469d18bc3].

FossilOrigin-Name: 8a1bb9c3e92085fb71d75eb36f64eb85053a4730fd314acd401e7ad32c274748
 2021-03-04 18:34:54 +00:00
dan
39b6bd5e17 Update shell.c.in so that SQLITE_SHELL_IS_UTF8 is set to 0 if the -municode option is passed to gcc on windows. 
FossilOrigin-Name: 99e6a0f020fadda4011e4ca370d2421dbf2f97f6fb004fcbba9bd6c76faf7a73
 2021-03-04 18:31:07 +00:00
drh
5f0922b96c Remove a branch made unreachable by check-in [e893f88750ea64d4]. 
FossilOrigin-Name: 20d7dc120dc964a0236da719e4de22bff5110b95da396e2ac6790e9f6b667899
 2021-03-04 16:32:28 +00:00
dan
e8dd6a4e77 Fix a segfault that could occur following an OOM condition. 
FossilOrigin-Name: 9adf6e2469d18bc3bfc0c804cfcaa692e23ab6b3e13465dcfc51c4b111b05cb4
 2021-03-04 16:10:23 +00:00
drh
aae0f74e64 Earlier detection of a misplaced ORDER BY or LIMIT clause in a compound 
SELECT.  This prevents problems in recursive CTEs with multiple recursive
terms in which there is an ORDER BY or LIMIT clause on the last non-recursive
term.

FossilOrigin-Name: e893f88750ea64d45922429e022c585748974016404f2a2b7952f5a227865246
 2021-03-04 16:03:32 +00:00
dan
50f9f6c649 Fix a crash that could occur if a sub-select inside an EXISTS expression features an ORDER BY clause containing one or more window functions. 
FossilOrigin-Name: 9768e7db624fbfe688d61ac06bffca14a169d439d8f65f5a14529af5660d3d2e
 2021-03-04 14:18:22 +00:00
dan
8718f0b613 Fix a buffer overrun that could occur in fts5 when running a prefix query against a corrupt db. 
FossilOrigin-Name: 4da40620ac8557aba6e1e06e720418b55e9950f406288b03749ef1b117041cd9
 2021-03-03 19:36:40 +00:00
dan
0bff34aea3 Remove the --timeout option from the valgrindfuzz Makefile target. 
FossilOrigin-Name: 3f520b8bdef7dcdad30e052ed8a07b0493bff4497603521e701fab7324df2995
 2021-03-03 16:46:03 +00:00
dan
c6920cdb0c Fix a case where fts3 was erroneously reporting corruption. 
FossilOrigin-Name: e6c7683c7503ac743d1d476c60c31f887b7ad829e26e812c25acdd4366044db8
 2021-03-03 16:00:26 +00:00
drh
fad1ad0526 Fix a harmless assertion fault resulting from [6e6b3729e0549de0] that was 
discovered by dbsqlfuzz.  Enhance .selecttrace output to show omitted
ORDER BY clauses.  New dbsqlfuzz test cases added.

FossilOrigin-Name: 27a0388ad616f80e8dcc986c247a5c23a8565dae9081b04ff85bac0d357e531b
 2021-03-03 14:07:52 +00:00
dan
3083d5f5ea Fix a problem with using ALTER TABLE commands on database schemas that contain expressions of the form "<expr> NOT NULL" or "<expr> IS NULL" that can be evaluated at prepare time. 
FossilOrigin-Name: d2630ffafa077b8cfd75110b6b73da30f780edc920d2788769a4dc747f09d3f6
 2021-03-03 11:00:31 +00:00
drh
bb05976dac Cast a string size variable to 64-bit to avoid any possibility of 
integer overflow.

FossilOrigin-Name: a5940294b2ac8d157d7fa72f65ee70b713f7feb8a0a98d7f47e71acd1b6942b1
 2021-03-02 21:07:41 +00:00
drh
898ec7927a Limit the size of the exponent input in the second argument to the 
ieee754() SQL function, to avoid integer overflow.
Ticket [22dea1cfdb9151e4].

FossilOrigin-Name: 99aab32da14cc76beb5c1823a70bdeab144459398d61c42a858be4d6868d361e
 2021-03-02 16:27:04 +00:00
dan
730629680a Change the timeout for test case "valgrindfuzz" from 600 seconds to 1200. 
FossilOrigin-Name: 7c6aa6f38403931df7940c7acfeba4e2f8099a419222fcab2a3c959ccae90e40
 2021-03-02 13:50:56 +00:00
dan
eefef9ae80 Do not run test file windowpushd.test as part of the "no_optimization" permutation. 
FossilOrigin-Name: 275a75aa82bf5d2366fd4020066d7b9fbb93a955ac9ec15dc7d5b8bfa29074e4
 2021-03-02 13:36:37 +00:00
drh
1b1a1dda9e Add ALWAYS() to an always-true conditional. 
FossilOrigin-Name: fa3506db2051ceade8aa535d92c0900b3cfdd8850c6d00adedeb1ebfaf6f885f
 2021-03-02 00:42:46 +00:00
drh
2d7a691fba Add #ifndef macros so that the build works again with 
-DSQLITE_OMIT_AUTHORIZATION and -DSQLITE_OMIT_WINDOWFUNC.

FossilOrigin-Name: 9400bdc60294be6a938025d481e50aad9af246e64f38fafecc6ca4f24112a98c
 2021-03-01 21:43:25 +00:00
dan
531d01cae0 Fix a couple of memory-sanitizer complaints that could be triggered by a corrupt database. 
FossilOrigin-Name: 39c8686cabe6c437ba4860aade49a701c4f5772b97d9fbe6cb9a394e85b9c092
 2021-03-01 16:16:59 +00:00
dan
1f9f576695 Fix another msan complain triggered by a corrupt database. 
FossilOrigin-Name: d235d406283191fc7b9e1299be602f1e8be6f36cee8b183cf85c8660519a1c3b
 2021-03-01 16:15:41 +00:00
dan
1e06c70eb0 Initialize extra field in PgHdr1 to fix an msan complaint. 
FossilOrigin-Name: 4cb2ea5795b0c0678665fd89bd560209beaab8a756fe00335dbfd07493b0542d
 2021-02-28 08:24:56 +00:00
dan
a3944bc4fe Add OOM test case associated with the fix in the previous commit. 
FossilOrigin-Name: a631c38d22bc00d38b0f112a623fb24c0e03a962f661ffe0931dad32fd31ba31
 2021-02-27 15:32:02 +00:00
drh
676c869d52 Remove a NEVER() that might sometimes be tree following an OOM. 
FossilOrigin-Name: ccb8cf5256d01b3ff13e75e1471b1afb0055ec2c344ba886f98b83d47eba00f8
 2021-02-27 15:12:24 +00:00
dan
15de3ce9ab Fix a segfault that could occur when optimizing a NOT NULL constraint against an IPK column of a sub-query. 
FossilOrigin-Name: e4d1970ef17b2330f78c750d71d625c2997f79ed1445d0351ec32b482485a954
 2021-02-26 21:39:34 +00:00
dan
eca6d60bfa Attempt to optimize "x IS NULL" and "x IS NOT NULL" expressions when x is a column with a NOT NULL constraint. 
FossilOrigin-Name: de9c86c9e4cdb34f4b7d65f160d1e589fb969bbf64c66d2b24c502d1ee424dbb
 2021-02-26 20:39:08 +00:00
dan
8ddf686267 Attempt to optimize "x IS NULL" and "x IS NOT NULL" expressions when x is a column with a NOT NULL constraint. 
FossilOrigin-Name: 5ecd842555009ce27ee6390325ac5c2504143474b12b730933f0833b3dad788a
 2021-02-26 20:14:32 +00:00
dan
4b17455ab2 Minor simplification in resolve.c. 
FossilOrigin-Name: 310dac342e7b1f9b5a5df6a9d598e85d5fef59bba9307d9230baf77c8f2351a2
 2021-02-26 15:20:17 +00:00
dan
b3617e9d2d Fix test case in altercorrupt.test so that it works with SQLITE_ENABLE_OVERSIZE_CELL_CHECK builds. 
FossilOrigin-Name: 062b338ff2ea71633b4fb3c75c6a47b5fc4fe9c2a72daacd987d1eca0bda5217
 2021-02-25 18:28:11 +00:00
dan
a4656e390a Fix a problem with UPDATE and DELETE statements that use both INDEXED BY and LIMIT clauses in SQLITE_ENABLE_UPDATE_DELETE_LIMIT builds. 
FossilOrigin-Name: cc2b4b38668bd32ebd8cf2e0d244eef2a6c7e0a1ee0a34c9c43eaf25c9cc09ae
 2021-02-25 18:23:39 +00:00
dan
3dc864b575 Fix handling of INSERT on views with implicitly named hidden columns in SQLITE_ENABLE_HIDDEN_COLUMNS builds. 
FossilOrigin-Name: 15795a96a8b3f4ea368b3eb29a4ff8d1b4b33ebb2bff2a5ccb045b8f01f9f99b
 2021-02-25 16:55:47 +00:00
dan
ce5de60ff9 Ensure that tests like "rbu.test" and "notify2.test" that are only run by specific configurations during release testing are run for both release and debug versions of the tests. 
FossilOrigin-Name: 911df43f98297bf645688dc51e988106a0297cb60bb97dde699c2848404fcf72
 2021-02-25 15:50:19 +00:00
dan
e9cfe87843 When a sub-transaction is released, if no pages required by containing sub-transactions were journaled, truncate the statement journal. This prevents out of control statement journal growth in some cases. 
FossilOrigin-Name: 23ca23894af352ea351c9efcdd7d86b82455f4c81b6001052a6d13aa2d705e84
 2021-02-23 16:40:47 +00:00
dan
601ec240a9 Allow WHERE terms to be pushed down into sub-queries that contain window functions, provided that the WHERE term is made up of entirely of constants and copies of expressions found in the PARTITION BY clauses of all window functions in the sub-query. 
FossilOrigin-Name: 20689468100aed264877111367b42837ca19e63e717fed2ebd4b20b908f13178
 2021-02-23 15:53:22 +00:00
dan
34a224a13b Further tests for the push-down optimization with window functions. 
FossilOrigin-Name: 4b089f70117bfb440eaefd830c05576be0cc624d9d6018c869270dc68e44513e
 2021-02-23 15:36:06 +00:00
dan
903fdd4834 Allow WHERE terms to be pushed down into sub-queries that contain window functions, provided that the WHERE term is made up of entirely of constants and copies of expressions found in the PARTITION BY clauses of all window functions in the sub-query. 
FossilOrigin-Name: dac51f303bba1a0aac7768c688b0c134deb7641062cce2071d546f2d8f241dec
 2021-02-22 20:56:13 +00:00
drh
dee1cb3006 Add a few simple test cases for MATERIALIZED and NOT MATERIALIZED. 
FossilOrigin-Name: 64878124c160f790bc5861fd799ada03bd7db0c4426b8abc3b7ad1f7aa181168
 2021-02-22 19:57:58 +00:00
drh
c3b93d9e59 Implement the MATERIALIZED and NOT MATERIALIZED hints on common 
table expressions.

FossilOrigin-Name: b5a0778cc5a98a864bea72670f83262da940aceb91fa4cdf46ec097337a38a95
 2021-02-22 16:42:09 +00:00
dan
f43fef29bb When a sub-transaction is released, if no pages required by containing sub-transactions were journaled, truncate the statement journal. This might prevent out-of-control statement journal growth in some cases. 
FossilOrigin-Name: e36327fb22db08763a82fb517407ff5ab0dbc053953098033e7e50796a777810
 2021-02-22 15:44:45 +00:00
drh
606411bf91 Add an ALWAYS() on a branch that is now unreachable. 
FossilOrigin-Name: ace54c5bd50176db7c60b7e3cf9293a86d9ecf2fea897467044020b9684c0af3
 2021-02-22 14:25:40 +00:00
drh
17267fe393 Fix inverted logic regarding the materialization hint on the push-down 
optimization.

FossilOrigin-Name: b66a49570852cf118a372a6ac44be3070cf9b4254696f16315b7c79a614e6c35
 2021-02-22 11:07:25 +00:00
drh
745912efac Add the AS MATERIALIZED and AS NOT MATERIALIZED syntax that works like it 
does in PostgreSQL.

FossilOrigin-Name: a6bb272ec0c758ab069bfc07443624e0ea7910b1f23224ee078d050fa3ccf068
 2021-02-22 03:04:25 +00:00
drh
a79e2a2d28 Materialize any CTE that is used more than once. 
FossilOrigin-Name: ba59159fbe6b83fb6d79fbfee22d983768b0ebbaac7e99d2ac66c810e5e04100
 2021-02-21 23:44:14 +00:00
drh
7601294ad3 Rename the "struct SrcList_item" object to the more succinct "SrcItem". 
This is a symbolic change only.  The logic is unmodified.

FossilOrigin-Name: bfd5bf2c73110fcb36db9ba2a949ff516131fbd3e89325f88fe9f5c2b4ed87b2
 2021-02-21 21:04:54 +00:00
drh
5abe1d3d53 Simplified resolution of CTE names. Slightly faster and about 100 bytes 
of code smaller.

FossilOrigin-Name: 0d2c992f3622a6272ca4a3caff6b21f619fe976b8df8b34eff066086f8df2202
 2021-02-21 01:19:42 +00:00
drh
1862271f7c Performance improvement in resolving the INDEXED BY index name for the common 
case where there is no INDEXED BY clause.

FossilOrigin-Name: 554b286ac208168bde91c6c6034cc7087410def76fce650b519661b2ee2c61b7
 2021-02-20 21:20:54 +00:00
dan
1e0cfd7184 Fix a case where FTS3/4 could pass a NULL pointer to memcpy() when handling a corrupt db. 
FossilOrigin-Name: 68bb541a39833d7d4bf41aa91cb6cd9c98757d1fc8236299d09db7e9b14d8ec9
 2021-02-20 19:22:32 +00:00
dan
1e25d20cca Update sqlite3changeset_apply_v2() so that it handles no-op UPDATE changes (UPDATE changes that modify no columns). This fixes a regression introduced by [e4ccfac09b]. Also modify sqlite3rebaser_rebase() so that it does not output changesets containing such UPDATEs. 
FossilOrigin-Name: 0288a8013e00594e716a5fb0d9f684dcfeb03e877650630e2736565fa6261290
 2021-02-20 18:02:37 +00:00
drh
f824b41e64 Break out the Cte object from the With object. This will make it simpler 
to add new kinds of Cte objects (ex: DML statements) and/or MATERIALIZED
keywords in the future.  It brings trunk into closer alignment with the
experimental as-materialize branch.

FossilOrigin-Name: f03efe905d7b40fb25f9f78b874bb56c6d6ccacb60f86b3b199d430d5eade8d2
 2021-02-20 14:57:16 +00:00
drh
271d7c2677 Simplification to where.c manually cherrypicked from the as-materialize 
branch.

FossilOrigin-Name: 03805a6117c813a33f9bca68bf4d9912997d6abd88ac9b3cb844c5d93ec68049
 2021-02-20 13:36:14 +00:00
dan
578277c257 Fix another problem handling corrupt database files in the ALTER TABLE DROP COLUMN code. 
FossilOrigin-Name: 9edf2ddc4799c8830c4b7b91d7aacee50029a4b9db329fd4c5674fbedea33034
 2021-02-19 18:39:32 +00:00
dan
d97471e1ad Add tests for ALTER TABLE DROP COLUMN commands. 
FossilOrigin-Name: 05dbea9b26bdcb096194dc531816333f3784eca50b133fe3efede6ab0d233472
 2021-02-19 15:34:16 +00:00
dan
be2ee38283 Add support for "ALTER TABLE ... DROP COLUMN ..." commands. 
FossilOrigin-Name: c844a331e78949850fde8ed95058cb34f863566944bc9e92e3ae042768f130e1
 2021-02-19 14:32:58 +00:00
dan
f4a72788a4 Fix a crash that could occur in ALTER TABLE DROP COLUMN if the sqlite_schema table was corrupt. 
FossilOrigin-Name: 126ee1ec4f3565c0cccca98885fa3665a641ea3df251511de16eed2a1c396124
 2021-02-19 14:13:40 +00:00
drh
60fe2352f5 Omit an branch made unreachable by the improved error message from dropping 
the last column of a table.

FossilOrigin-Name: c5719fc5aa04c50bb01533f1cedb73dc80c4bf5315ff6a7206c8a10504afca8b
 2021-02-19 09:46:52 +00:00
drh
329cb9eb88 The COLUMN keyword in ALTER TABLE DROP COLUMN is optional. 
FossilOrigin-Name: a22f87fb6c43dd6217691c8dd1cdcd7880068024fb779ca8a5def068d72c3e6b
 2021-02-19 09:36:50 +00:00
drh
239c84fc62 Give a better error message on DROP COLUMN when attempting to drop 
the last column of a table.

FossilOrigin-Name: 5e1f362bc3e53c60f9e6f771346d10c6e6a6cb3ff1eec5608101f9c5d6d2a5a4
 2021-02-19 09:09:07 +00:00
drh
c90fa01dbf Add a NEVER() to an unreachable branch in the DROP COLUMN logic. 
FossilOrigin-Name: 963f498ae64cf7530fb7a405fa476c411ad66523f62f5eefa5a16596cd19a481
 2021-02-19 02:30:02 +00:00
drh
0336140cd9 Add missing VdbeCoverage() macros. 
FossilOrigin-Name: 9bb720e6590482bc9c2fbb273738808209e9651710dbee7572b0348cadf87e68
 2021-02-18 23:53:47 +00:00
drh
dcc29e0d1d Enhance renameParseSql() to better handle OOMs. 
FossilOrigin-Name: 68bcde7ab57b2d4bdcfb2f6c7134a0b01a504b2e7cdf6ee5bf0df70fb4a517b0
 2021-02-18 23:03:50 +00:00
drh
a7da40f377 Merge changes from trunk into the alter-table-drop-column branch. 
FossilOrigin-Name: 9ea640073f8809dfe2612ae1ea384a938b433f884c54d9e5aa3712de79397ac1
 2021-02-18 22:47:34 +00:00
dan
678f3b33cc Fix DROP COLUMN so that it works even if the user has registered an authorizer callback. 
FossilOrigin-Name: e5f144182bbb3ba10c77151cf63c8bddf86374049fb6866387f85e335df298cb
 2021-02-18 20:27:46 +00:00
dan
16953469a6 Fix a problem with schema error detection when processing ALTER TABLE DROP COLUMN commands. 
FossilOrigin-Name: 565a6fd0c95b438fea7bf84913b38de1718117e16e0d685534a8650e1dc8421b
 2021-02-18 19:25:44 +00:00
dan
30cdb992dd Add test cases for ALTER TABLE DROP COLUMN. 
FossilOrigin-Name: 204ee5e28210738fb624a9cf85dc6f9b59de0d7eb4fddd46c8babe9beddd4944
 2021-02-18 17:48:36 +00:00
dan
a55a839ab3 Avoid invoking the update or pre-update hooks during VACUUM operations. 
FossilOrigin-Name: 3c25cb4ab8885a50e2a485fe76f5ffd5dd8ebe1306aca8c0989e0b7fd7dd18d2
 2021-02-18 15:59:37 +00:00
drh
6f6e60ddb1 Improvement to the INSERT optimization of check-in [16ac213c57196361] so 
that it works with SQLITE_ENABLE_HIDDEN_COLUMN but is also easier to maintain
and a little faster as well.

FossilOrigin-Name: f985a78ecc0c6d9ff671c730a109d97dc781b06e47a0ab03f441cea5d021a4c3
 2021-02-18 15:45:34 +00:00
drh
39065807dd Disable the optimization of [16ac213c57196361] when the 
SQLITE_ENABLE_HIDDEN_COLUMN compile-time option is used, as the optimization
does not work in that case.

FossilOrigin-Name: 5168b06bcf283ef64cb9fd76330a743baf8bb0cd747c14eae23e607e0491cbce
 2021-02-18 14:27:43 +00:00
dan
fadc0e34be Ensure that the pre-update hook is invoked for INSERT operations on WITHOUT ROWID tables that use the xfer optimization. 
FossilOrigin-Name: 66bbad239b4527ac8ae8b487a0c71d88b1861a8dfe1edc25109600dc447c60c4
 2021-02-18 12:18:10 +00:00
drh
6859d3245a Add missing VdbeCoverage() macros to some of the new RETURNING code. 
FossilOrigin-Name: 53a5390909822b3aef8c5f522144bc2e86cc31318b2d3e310a064ae7202b4a15
 2021-02-18 01:02:03 +00:00
drh
7b7a9cf263 Performance optimization in the resolver. 
FossilOrigin-Name: 1aafb94d4e3f28a8322e5e43be737d84b1a09f0063408f4a466a6071fa95b39b
 2021-02-18 00:59:16 +00:00
drh
c7e93f58d5 Performance optimization in the code generator for INSERT for the common 
case where the target table has neither generated nor hidden columns.
Also fix a redundant (and thus unreachable) branch in the resolver.

FossilOrigin-Name: 16ac213c57196361a9d14df4c0d1ccc6f67ac522365b345ea364d1aec61fa3f2
 2021-02-18 00:26:11 +00:00
drh
c54246ffdf Use the sqlite3ParserAddCleanup() mechanism to ensure that the AggInfo 
structure associated with an aggregate query is deallocated, for a performance
increase and size reduction.

FossilOrigin-Name: 7a1399671fa10c64d5358cc4d364d24c643fe9dd8da923356462267ee7962f61
 2021-02-17 21:13:14 +00:00
dan
c2a878ed0a Fix a problem with OOM error handling in the new code on this branch. 
FossilOrigin-Name: ea999c9db59e4193b306a2e1b15fc94f8f04cb05e852bb0d068b7d5243a0849b
 2021-02-17 20:46:44 +00:00
dan
c16592cd1b Merge trunk changes into this branch. 
FossilOrigin-Name: 0cd5e2f9ce181f2c940ffca6fe69fda84f452613e66463d0d7c7413fc11b9772
 2021-02-17 20:19:13 +00:00
dan
6a5a13df97 Fix various issues with the changes on this branch. Add test cases for the same. 
FossilOrigin-Name: 10538ec6fc1642dfc2ca6cef06ce6cb9e124847b421ccf01f5842064fad379ab
 2021-02-17 20:08:22 +00:00
drh
4b0229ae1f Enhance the ".once" and ".output" commands in the CLI so that if the 
filename argument begins with "|" the name becomes the concatenation
of all subsequent arguments.  Hence, commands like ".once | open -f" become
possible without the need for quotes.

FossilOrigin-Name: c46a94a624c2cc6c49ac916a206a913081e1628c24805987cabc75c9057ea36b
 2021-02-17 13:19:22 +00:00
dan
6e6d9833cc Add experimental implementation of ALTER TABLE DROP COLUMN. Only some cases work so far. 
FossilOrigin-Name: f0217937d7306fb595727e61e871e8b03d8c881d339a0865bfd0117d90d42e4e
 2021-02-16 20:43:36 +00:00
drh
6b37b762ed Simplification to the resolveAlias() routine. 
FossilOrigin-Name: 00bead3931135af80475c22f08cbb26c914518e8f2c7e73c2b8be1cee4ac4d5e
 2021-02-16 20:32:17 +00:00
drh
13162ef975 New SELECTTRACE macros more clearly deliniate when the query planner is 
invoked in the middle of PRAGMA vdbe_addoptrace output.

FossilOrigin-Name: 7c03ce49b74f72b63dd75c3a02625e671bfd771f71b24e808994322b00d97677
 2021-02-16 20:01:08 +00:00
drh
33941691a5 Fix an issue with the LIKE operator when it includes the "ESCAPE '_'" clause. 
Ticket [c0aeea67d58ae0fd].

FossilOrigin-Name: 27d4117980d125975b5e70eeea58a6ab07bcf066e71b5fcb81b822e05afdbab0
 2021-02-15 17:02:01 +00:00
dan
f2b32e8915 Add tests for sqlite3_column_count(). 
FossilOrigin-Name: 7cc65ae57183b3c16f1102fca5603a36acda432e5d45e22a2996e5ebe069fc6a
 2021-02-15 14:32:05 +00:00
drh
351ae772a3 Ensure that the ALTER TABLE statements return 0 for 
sqlite3_column_count().

FossilOrigin-Name: 29c1932a47cd46c2585ebbf937c03544a8a355014776129662789e15db9ed4de
 2021-02-15 13:17:19 +00:00
dan
863fd4905c Fix an error in the test case fix in [ecd71203]. 
FossilOrigin-Name: 5411bfa41ea9a492ca1f567327d8e0a1b3db047292fec1753bfef8a157cf8c1d
 2021-02-15 11:14:53 +00:00
drh
329eaaf0b3 Fix incorrect test name labels in the select1.test script. 
FossilOrigin-Name: 179c79ea0deb0f5adaa8d369cfcad06d959a9cc18a8a41e01ef013b2d90acd61
 2021-02-13 18:14:15 +00:00
drh
8794c68a35 Avoid manifesting a CTE (or other view) multiple times when it is possible to 
reuse the first manifestation.

FossilOrigin-Name: 9692f510803c9b9725abb687d7c10fbc0d5ed784479ec6f3fcc55925a87fe16d
 2021-02-13 16:39:24 +00:00
dan
e8f1490f55 Fix a problem in the unreleased union-all flattening code. 
FossilOrigin-Name: e4f8a79fd8b3be9bf8add5f5e1c66bc2fe78da4e50ea500ab0b8370d30e31ba5
 2021-02-13 14:26:25 +00:00
dan
8b7e93adbc Fix a test case to account for the fact that different versions of OpenBSD behave differently when a program tries to read() from a file-descriptor open on a directory. 
FossilOrigin-Name: ecd712032f56a20d7df2bcf89b0d3b8d91dc72c552e27f0a4b23980bd49747b0
 2021-02-12 21:22:01 +00:00
dan
23ed8109b6 Ensure RBU tests are run as part of release testing. 
FossilOrigin-Name: a18dc08bafefd849e640086b18c41e06361d2e09d7dd2e9af4a394dc543e598b
 2021-02-12 11:37:13 +00:00
dan
40803caa1d Fix a longstanding problem causing an RBU vacuum to omit releasing some locks before finishing. 
FossilOrigin-Name: 66c07a07b21e46529780eec3c82a84c494d586f8b7ed80b78d358e23b80458c7
 2021-02-10 20:00:40 +00:00
dan
b9edded0fd Remove an assert() added by the previous commit that is sometimes false. 
FossilOrigin-Name: fb36ac4dc60ccc6c5fba3f23e13fcab985f27ebef0527c929806cda5f9d3660c
 2021-02-10 19:49:35 +00:00
dan
513c9a1ff3 Fix a longstanding problem causing an RBU vacuum to omit releasing some locks before finishing. 
FossilOrigin-Name: cb5bdf82fe0f90922dc34202be9d0aa34d899afff4200456623765da2877ca41
 2021-02-10 19:40:47 +00:00
dan
8737d46ea1 In RBU, avoid passing VFS xShmLock calls through to the underlying VFS in cases where xShmMap calls may not be. This fixes a bad interaction with ZipVFS. 
FossilOrigin-Name: bd1e9e0a4c0e07901ef59fe3b7e6f7b9cc66ccfcd5192f576e1620820891de99
 2021-02-10 17:31:50 +00:00
drh
82ab4f6b1a Correctly detect correlated subqueries when resolving names in RETURNING 
clauses.

FossilOrigin-Name: b43cfa04922a401442b9d1708e3e4a88d3cfa2c591f9a6b253d99ba83f4b280a
 2021-02-08 15:56:01 +00:00
drh
d510197276 Improved name resolution for references to a table begin modified from 
within a subquery in the RETURNING clause.

FossilOrigin-Name: 799d205bfa7945ee4a92dfec5fbf90a00b9a535e3171aab2ec46404f7efb0f78
 2021-02-08 13:41:17 +00:00
drh
e1c9a4ebf9 Do not allow RETURNING in the DML statements of a trigger. 
FossilOrigin-Name: 7a8fe6463a9728bc4e34465688a059afb74f3c373cde8fdf570d5d148fdde04d
 2021-02-07 23:28:20 +00:00
drh
8729642112 Fix harmless compiler warnings. 
FossilOrigin-Name: 5f8bf99579e6663fc701cdc94f685584a86398c4687e25e7e241de755398f17d
 2021-02-07 12:59:43 +00:00
drh
5f323787bd Remove an ALWAYS() and NEVER() in the authorizer that become reachable 
as of [078dbff04a95a001].  Test case for coverage in TH3.

FossilOrigin-Name: b469327e2949352325d3db815bd4782f9734239c378f08afd2f00ffa54bef924
 2021-02-06 14:56:30 +00:00
drh
8873aea390 Fix the OSSFuzz-discovered shift problem from two days ago. This patch was 
omitted from [078dbff04a95a001] apparently because I made the edit to
"sqlite3.c" rather than "resolve.c" where it belongs.

FossilOrigin-Name: 864772ffec4e91d8d73f9b97e6e1d7bd4e0537de19d11d30aed7eedd5b7d394a
 2021-02-06 14:37:36 +00:00
drh
29f6a365cc Remove unreachable code. Fix a shift UB problem introduced yesterday 
and discovered by OSSFuzz.

FossilOrigin-Name: 078dbff04a95a001bbd8690ab08038fbb5506899df8290991b53fd1122a4c30c
 2021-02-05 17:34:47 +00:00
drh
70bd2124ed Change the RETURNING algorithm so that outputs accumulate in an ephemeral 
table until all modifications have been completed, and only then do results
start being returned.  This should help prevent problems with interleaved
sqlite3_step() calls on two separate DML statements.  It also seems to be
closer to how PostgreSQL works, which might prevent compatibility problems.

FossilOrigin-Name: c4615eb28c3dd2d473daf104f32e60d02799f3158d9d275a899c39129cc71401
 2021-02-04 23:20:13 +00:00
drh
7dec804d42 Remove dead code. Fix RETURNING for INSERT into a virtual table. 
FossilOrigin-Name: dbfa38699c87ab4bf390666e411dda8d375c7b53b9b4fb131adacbf575867a72
 2021-02-04 22:59:19 +00:00
drh
e1db9343d5 Fix an issue with RETURNING from UPSERT. 
FossilOrigin-Name: 757b74ba0fd64634a365bd73955181191767ad8816a33a362e32ece250299a51
 2021-02-04 21:17:12 +00:00
drh
552562c48f Snapshot. New design appears to work on a simple test case. 
FossilOrigin-Name: 8a65fbeecf3597e30853c5f0ccd9b8b46c508854fa521e58e0db279deebca7d4
 2021-02-04 20:52:20 +00:00
drh
381bdacc8f Preliminary changes for a new implementation of RETURNING that captures all 
results in a buffer and plays them all back after the DML statement
completes.  This avoids problems with interleaved DML statements.
This particular check-in is a non-functional work in progress.

FossilOrigin-Name: 04b77d63216ce11b4e797946953bcde504fc005807c7a5ac757fbf47d78698dc
 2021-02-04 17:29:04 +00:00
drh
8ab79d6135 Add NEVER() to a branch that check-in [5d54d9fd40638138] apparently made 
unreachable.

FossilOrigin-Name: 5c8e6296aa9f69a092364524b716ba894f113f7f1e6024b9a2eaa01c239e65c1
 2021-02-04 13:52:34 +00:00
drh
02c4aa39e7 Performance optimization in sqlite3FinishCoding(). 
FossilOrigin-Name: 0f34f241d37cc4f31dc657a6fc33815fa5e24298487121cb27c29118524b8ee7
 2021-02-04 13:44:42 +00:00
mistachkin
8c333cfc0d Corrections to the 'filepath_normalize' test suite helper procedure. 
FossilOrigin-Name: 32f4d04470bf953b08eea285543f16e03de13d5448c1ebccbba1578ca3b5363e
 2021-02-03 19:38:40 +00:00
drh
17b74817c0 Change the name of Vdbe.magic to Vdbe.iVdbeMagic to disambiguate with 
sqlite3.magic.

FossilOrigin-Name: 6b29e549bb34933bfd0758e31085e65dcc0f75446c478fc775d96cf01c22cf43
 2021-02-03 18:32:25 +00:00
dan
7937f63220 Avoid doing any foreign-key constraint related processing for an UPDATE statement that does not modify any columns that are part of FK constraints, even if the table has a self-referencing FK. 
FossilOrigin-Name: 7f3b036e730153ac22933b03a52d4ec3978c9ecab1399d8cc79fe533893321e3
 2021-02-03 14:20:56 +00:00
drh
c5eb176a09 Fix a harmless compiler warning. 
FossilOrigin-Name: 1eb69c64ed4a11601698000573c507684bc4b0366336ba0748ebd661644d0902
 2021-02-03 13:20:12 +00:00
drh
cd39cda00c Add support for the RETURNING clause following PostgreSQL syntax. 
FossilOrigin-Name: 416c898bfb8ff9639ffbaefcfb47fce3782763af1fc67969fa91c5f01a336676
 2021-02-03 13:08:09 +00:00
drh
78197e0f8b Fix an assert() that might be off-by-one in the case of a prior 
errors in the parse.

FossilOrigin-Name: 06b15b17be38c804dd2641d8616a2a7bd396d2eb9901a0fbf94edd8bd508cf9c
 2021-02-03 12:35:51 +00:00
drh
2aa41c82da Modify the SQLITE_DBCONFIG_ENABLE_TRIGGER setting so that it only disables 
main-schema triggers and allows TEMP trigger to continue operating.  This is
safe, since only the application (not an attacker) can add TEMP triggers.
It will also all us to disengage SQLITE_DBCONFIG_ENABLE_TRIGGER on Fossil
databases since Fossil has no main-schema triggers but does use TEMP triggers.

FossilOrigin-Name: a10c5a2503ff2998f6ee40f721aab8c9579052e535dc141bd57d10551eaea387
 2021-02-03 00:55:34 +00:00
drh
47600083f1 Load enhancements from trunk into the returning branch. 
FossilOrigin-Name: b84c7f60c2e1e7debf9f50622087f87d60c6870061d61e14e59cc1ba0775ee92
 2021-02-03 00:05:57 +00:00
drh
cb83dc9e95 Do not allow aggregates in a RETURNING clause. Fix a memory leak that 
occurs when window functions are used in a RETURNING clause.

FossilOrigin-Name: 2e9bd94b9ad37c7e4123b7324f2fe42d3609a65af449eb8a0064057647709a73
 2021-02-02 20:46:11 +00:00
dan
e0d2096afa Modify the sessions extension to use more efficient SQL when applying a changeset or patchset. 
FossilOrigin-Name: e4ccfac09b6fe8cc3aec29d10f4e4c83097964f29882343db52ed91f6f0dde1c
 2021-02-02 20:41:13 +00:00
drh
709dd13927 Report an error if RETURNING is used for DELETE or UPDATE of a virtual table. 
FossilOrigin-Name: bd5dee8425327fde0429043ce325b910f1b7951988d9a448a8eeeb713a46bc81
 2021-02-02 12:01:22 +00:00
drh
c9be863098 Allow the RETURNING trigger to exist for virtual tables. 
FossilOrigin-Name: 2f244ab4a2ba2bdb608cf44ef02e00738ad58c10a76d9e4222dc843a17103d92
 2021-02-02 00:16:15 +00:00
drh
d33d3a2ba7 Add a few test cases for RETURNING together with UPDATE/DELETE LIMIT. 
FossilOrigin-Name: 7611c77d6baa84086ff18cbd045127fd682c6d5c434af5404e34fbe631fedfe1
 2021-02-01 21:26:09 +00:00
drh
9e673ace5b Improved corrupt database detection in balance_nonroot(). 
FossilOrigin-Name: 5d54d9fd406381383afdf10612bfd590afc4142215d9bca09e227e3aa5baa102
 2021-02-01 12:39:50 +00:00
drh
7baf3d411b Modify RETURNING so that it does not return changes implemented by 
cascading foreign keys or by triggers.

FossilOrigin-Name: 6e62470a737cbde7f3fdcd027b98eb0b3dd11d063c63501d3c18448e93f5959f
 2021-02-01 01:57:55 +00:00
drh
9407b6ef29 Mark an unreachable branch as ALWAYS(). 
FossilOrigin-Name: cb8b797a64f65fca01c5faaeb30cbe4a53b56b81e696d1b62a90362d7ef8f924
 2021-01-31 16:45:10 +00:00
drh
18e5607211 New opcode OP_ChngCntRow used to output the result of PRAGMA change_count. 
Only this new opcode, and not OP_ResultRow, checks for foreign key errors.
Faster performance, and now also works with RETURNING.

FossilOrigin-Name: 154fc2b15465c7c92a1af0a93851421aec42a81bab54840a9701f2c78068e14e
 2021-01-31 15:50:36 +00:00
drh
662fe79647 When setting the number of result columns in a RETURNING trigger, be sure 
to set that value in the top-level bytecode program, not in the immediate
caller of the trigger.

FossilOrigin-Name: 1f1ce7ceb9807d22efea496f33908040ee196a31cd192f27ec0fb3e23afb729c
 2021-01-31 12:41:20 +00:00
drh
28828c550f Improved comments on the new code. 
FossilOrigin-Name: a38f0c1d7c1d7635732ac370d8fbc7e6a2005378e4621da7bc4f51a2f99912d1
 2021-01-30 21:55:38 +00:00
drh
1832f2921d Add an ALWAYS() to an unreachable branch. 
FossilOrigin-Name: 6bb6de42b62acd35ade6c95a11bb4c9b35e7e9a24620731ae36364c4d5c3bc31
 2021-01-30 16:16:42 +00:00
drh
a8a64a078f Chagne the OP_ResultRow opcode so that it does not cancel 
pending statement transactions.

FossilOrigin-Name: fea91e3a511b14dafcc4da92c59188f927ec60ed91441335183da6b4e7866c1b
 2021-01-30 14:17:18 +00:00
drh
0166df0bda Fix a obsolete assert() in the bytecode engine. Improved OOM detection 
in sqlite3AddReturning().

FossilOrigin-Name: 138b10d54a83e1e7d5b3cdbe593a5073b05e632d1823e1b74d85835435b9ee3d
 2021-01-30 12:07:32 +00:00
drh
cf4108bbc6 Fix handling of an OOM condition in sqlite3AddReturning(). 
FossilOrigin-Name: 52204cd768f115d13249ff0e3a252b716620f7ad16a6962e1192a09137a78596
 2021-01-30 03:06:19 +00:00
drh
658f0a3679 Fix a memory deallocation problem that comes up when doing a RETURNING query 
on a corrupt database.  I think I fixed this before, but it got unfixed with
stale editor content.

FossilOrigin-Name: 02b1415efb7d9849499afe4e9dbf7e470484bf144d6ca3d28fdc38fc0ac10afa
 2021-01-30 02:43:26 +00:00
drh
343256b9b0 Another attempt to get trigger selection correct for RETURNING triggers. 
FossilOrigin-Name: 1b8ed52275a54800df90682d694b482f55f26c6c4a420659f9a3b7bfc61e8abe
 2021-01-30 02:34:47 +00:00
drh
16d861ffc2 When running the RETURNING trigger, if it is tagged as a DELETE trigger, 
do not use it as INSERT or UPDATE.

FossilOrigin-Name: 3c7a6e04ddde34961d8e9d0443913e572a80853cf14a8263cec19523c39ca744
 2021-01-30 02:22:38 +00:00
drh
ba71a8a01b Test cases added. RETURNING works with UPSERT as does PG. 
FossilOrigin-Name: f5698f96e27c9b8669ec6016bb9920ef7580c4146eb61d628a0f62be5135ce94
 2021-01-30 01:30:26 +00:00
drh
8f4e2e25c4 Better handling of errors in RETURNING due to corrupt database files. 
FossilOrigin-Name: 6aa2a058d136d0b24d94c5cbe1ce447eb435c1a1c7cdce5e435f1548bb3f05e7
 2021-01-29 22:33:05 +00:00
drh
d086aa0a48 RETURNING works even if "PRAGMA count_changes=ON" is set. 
FossilOrigin-Name: a9122d97577b239704cdee1a90a3b0dbff8bdf9dea2324d7315bd47238dcc8eb
 2021-01-29 21:31:59 +00:00
drh
dac9a5f7df Allow "*" wildcards in the RETURNING clause. 
FossilOrigin-Name: b0e3ae303db2a035583a05848ab7977e612d7e40c77e31ea9e0166de443c901f
 2021-01-29 21:18:46 +00:00
drh
b835247954 Working prototype. 
FossilOrigin-Name: b7ef4dc21f187ff4ff679e823782535188c3814aa6ce720b3a01c6d3ba4ef9f5
 2021-01-29 19:32:17 +00:00
drh
02d6f9b295 Fix possible division-by-zero in the new log() SQL functions. 
Problemm discovered by OSSFuzz.

FossilOrigin-Name: 1ffd321a33b778e87614a26a91a8407ec7b9dec4f0f847b16b1dac4f3b910604
 2021-01-29 16:20:16 +00:00
drh
2c99b84c95 Incorporate the sqlite3TriggerList() optimization from trunk. And move 
the pReturning field to the uninitialized area in the Parse object, to
save memset() time.

FossilOrigin-Name: 29fbaf0e3eabda08500f350bc32e9f339e5732a65bfa62822eefb692a2ff0243
 2021-01-29 14:22:56 +00:00
drh
f54a80fe5c Performance optimization (and size reduction) in sqlite3TriggerList() for the 
common case where there are no TEMP triggers.

FossilOrigin-Name: 0defaf730bdc82212a5d3feeb2e16f16423b1691b0aaa7da1787eb82ea39ae9e
 2021-01-29 13:47:36 +00:00
drh
55d4c84b61 Merge recent enhancements from trunk. 
FossilOrigin-Name: 5fbcb208d24d45169fc53ad8738dd3545d9bbd26b7434e31afc7f6419cd4e958
 2021-01-27 20:35:22 +00:00
drh
16cd8b96d3 Fix an issue with IN operator optimization introduced by 
check-in [4a43430fd23f8835] and described by ticket [ee51301f316c09e9].

FossilOrigin-Name: 9dc7fc9f04d5c14fc436e5ff5b4c06c1969ddde5857ebeb5dccd59b7c748c339
 2021-01-27 19:15:06 +00:00
dan
df1b52e727 Ensure a cursor used by the SeekScan operator does not point to a valid row on the first iteration of the loop. Possible fix for [2d6e8400]. 
FossilOrigin-Name: 390cf60a286b13f454429f4652a133f95a7891a75c1ec6d16cd39990590fd3fb
 2021-01-27 17:15:06 +00:00
drh
e5ceaac446 Add an extra log message in the case of an SQLITE_CORRUPT_INDEX error. 
FossilOrigin-Name: 0571c24177d77ac966bcf42cb8ab00fdf541ce84af1468c8ef0b60c48c45a22f
 2021-01-25 21:24:14 +00:00
drh
8ac090f51d Enhance the query planner to enable it to use an index for IS NOT NULL 
constraints, even if STAT4 is not enabled.

FossilOrigin-Name: 7b2a7c7314d2239992dc1d707280f3b75ba75bb074ba1e77b55cad01ca7fd51b
 2021-01-22 21:23:12 +00:00
drh
17988aae5b Merge fixes from trunk. Omit a conditional in 
sqlite3IsLikeFunction() that was made unreachable by this enhancement.

FossilOrigin-Name: 0b42f9eb5dd710991af3cf4b16464b22db9539361d618e50eaa4d43c811577b4
 2021-01-22 20:28:30 +00:00