From d5bdd5effbb60debf62172a3a8b3025b2034e098 Mon Sep 17 00:00:00 2001 From: drh Date: Wed, 31 May 2017 13:27:15 +0000 Subject: [PATCH] Remove a completely unnecessary memset() from the INSERT code generator. FossilOrigin-Name: 7d58836b9db1293a3a6581af4358b7c91a588efd5c9b2df384803f3855ff87a8 --- manifest | 12 ++++++------ manifest.uuid | 2 +- src/insert.c | 1 - 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/manifest b/manifest index 54173749fd..b07ac856e5 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Very\ssmall\sperformance\sincrease\sin\ssqlite3VdbeSetNumCols(). -D 2017-05-31T11:24:13.659 +C Remove\sa\scompletely\sunnecessary\smemset()\sfrom\sthe\sINSERT\scode\sgenerator. +D 2017-05-31T13:27:15.732 F Makefile.in 1cc758ce3374a32425e4d130c2fe7b026b20de5b8843243de75f087c0a2661fb F Makefile.linux-gcc 7bc79876b875010e8c8f9502eb935ca92aa3c434 F Makefile.msc 8eeb80162074004e906b53d7340a12a14c471a83743aab975947e95ce061efcc @@ -366,7 +366,7 @@ F src/hash.c 63d0ee752a3b92d4695b2b1f5259c4621b2cfebd F src/hash.h ab34c5c54a9e9de2e790b24349ba5aab3dbb4fd4 F src/hwtime.h 747c1bbe9df21a92e9c50f3bbec1de841dc5e5da F src/in-operator.md 10cd8f4bcd225a32518407c2fb2484089112fd71 -F src/insert.c d4bb3a135948553d18cf992f76f7ed7b18aa0327f250607b5a6671e55d9947d5 +F src/insert.c ea52232babcee65f1f9833d0fefc3b598662a004c19a178ef4fc0981e2f02a58 F src/legacy.c e88ed13c2d531decde75d42c2e35623fb9ce3cb0 F src/loadext.c a72909474dadce771d3669bf84bf689424f6f87d471fee898589c3ef9b2acfd9 F src/main.c 1054e4dbb4fcca84246ed48b35164a996f5a52daa56c275157a5d583c0e2cd00 @@ -1581,7 +1581,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0 -P 326e63d71e0e164c5bcd1f74772cb4071b82daf6f04a5d440b985bace5a4c941 -R 7046283035661560edab9492c510bae7 +P 8885b4461044ae8ecdfe1b9aa47f4aad65efabc98e3fcd9e307a06504fab34c6 +R cc1154430da7b77ebab75d70354618af U drh -Z a2792650408b6d55b08b5a41a2e34334 +Z 89e693181079061c65ab41950ea33320 diff --git a/manifest.uuid b/manifest.uuid index bea727b9b8..89f0aba28c 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -8885b4461044ae8ecdfe1b9aa47f4aad65efabc98e3fcd9e307a06504fab34c6 \ No newline at end of file +7d58836b9db1293a3a6581af4358b7c91a588efd5c9b2df384803f3855ff87a8 \ No newline at end of file diff --git a/src/insert.c b/src/insert.c index a1f5442515..48502b7e07 100644 --- a/src/insert.c +++ b/src/insert.c @@ -521,7 +521,6 @@ void sqlite3Insert( #endif db = pParse->db; - memset(&dest, 0, sizeof(dest)); if( pParse->nErr || db->mallocFailed ){ goto insert_cleanup; }