From 6557a07ca8a7b8aad6ebf0c5c6102a5f86c1ba82 Mon Sep 17 00:00:00 2001 From: drh Date: Sun, 16 Sep 2018 16:34:31 +0000 Subject: [PATCH] Fix a memory leak in the explain extension. FossilOrigin-Name: d0c92b047a5355726aea87f38038e5bda3adf6137492919be94bd29bb847eddb --- ext/misc/explain.c | 1 + manifest | 12 ++++++------ manifest.uuid | 2 +- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/ext/misc/explain.c b/ext/misc/explain.c index c2c8c07a5c..b228440f58 100644 --- a/ext/misc/explain.c +++ b/ext/misc/explain.c @@ -208,6 +208,7 @@ static int explainFilter( rc = SQLITE_NOMEM; }else{ rc = sqlite3_prepare_v2(pCur->db, zSql, -1, &pCur->pExplain, 0); + sqlite3_free(zSql); } if( rc ){ sqlite3_finalize(pCur->pExplain); diff --git a/manifest b/manifest index 015c3618f7..49d43aeba6 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Add\sthe\snew\s"explain"\svirtual\stable\sin\sext/misc.\s\sUse\sthis\svirtual\stable\nfor\sadditional\stest\scases\sfor\sthe\soptimization\sthat\savoids\supdating\sindexes\non\sexpressions\swhen\snone\sof\sthe\scolumns\schanged\sby\sthe\sUPDATE\sare\sin\sthe\nexpression. -D 2018-09-16T16:18:01.470 +C Fix\sa\smemory\sleak\sin\sthe\sexplain\sextension. +D 2018-09-16T16:34:31.947 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea F Makefile.in 01e95208a78b57d056131382c493c963518f36da4c42b12a97eb324401b3a334 @@ -281,7 +281,7 @@ F ext/misc/compress.c dd4f8a6d0baccff3c694757db5b430f3bbd821d8686d1fc24df55cf9f0 F ext/misc/csv.c 65297bcce8d5acd5aadef42acbe739aef5a2ef5e74c7b73361ca19f3e21de657 F ext/misc/dbdump.c 12389a10c410fadf1e68eeb382def92d5a7fa9ce7cce4fb86a736fa2bac1000a F ext/misc/eval.c 6ea9b22a5fa0dd973b67ca4e53555be177bc0b7b263aadf1024429457c82c0e3 -F ext/misc/explain.c 657b95855157379b406af602ed0e1cf5d136c0947cdd207fa5470797c8a1ce18 +F ext/misc/explain.c 5851a1a4a1bba6e078da4103fcafc84aa54adfd8edbba419f5cf1eba9f000d50 F ext/misc/fileio.c 7317d825fab6a3c48f6e3822a00a6a22e08e55af31700ac96f16a523f83069fd F ext/misc/fuzzer.c 7c64b8197bb77b7d64eff7cac7848870235d4c25 F ext/misc/ieee754.c f190d0cc5182529acb15babd177781be1ac1718c @@ -1766,7 +1766,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0 -P c9f045295c4577752b0847ff2027b44661e6cb15bb08b942ccb3a0ef396f3dec -R 58a4dfba8e02bbbb06c952d22469b1fa +P 2404304cc15eaeee2744cf3c8f9cac0a544631c4f1060c5a17a78b43ca86edf0 +R adb45010554cac59e3a349d9c44c8ea1 U drh -Z ae02262bf6d409f9ac69a0871114af64 +Z d3428e60bf87865d7969feaa7735e32f diff --git a/manifest.uuid b/manifest.uuid index 1c4ba86291..5c03e13318 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -2404304cc15eaeee2744cf3c8f9cac0a544631c4f1060c5a17a78b43ca86edf0 \ No newline at end of file +d0c92b047a5355726aea87f38038e5bda3adf6137492919be94bd29bb847eddb \ No newline at end of file