From 4b31bda2c5e446e6876c7e7e34c03aa676a0b7a3 Mon Sep 17 00:00:00 2001 From: drh Date: Wed, 20 Jan 2016 02:01:02 +0000 Subject: [PATCH] Remove an unnecessary memset() for a small size reduction and speed improvement. FossilOrigin-Name: 730d7efb6fef54ed7c1f4ae27e3b55778ea6ff01 --- manifest | 12 ++++++------ manifest.uuid | 2 +- src/vdbeaux.c | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/manifest b/manifest index 2bdfa7fcdd..712e32918e 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C During\scompilation,\stransfer\sthe\sazVar[0..nzVar-1]\sarray\sfrom\sParse\sto\sVdbe\nrather\sthan\scopying\sit.\s\sSmaller\sand\sfaster\scode. -D 2016-01-20T01:48:25.150 +C Remove\san\sunnecessary\smemset()\sfor\sa\ssmall\ssize\sreduction\sand\sspeed\simprovement. +D 2016-01-20T02:01:02.932 F Makefile.in a476545d0c8626224d0bacac85c6e2967474af81 F Makefile.linux-gcc 7bc79876b875010e8c8f9502eb935ca92aa3c434 F Makefile.msc 01e855f958932d0d3ed62ec675fc63e2cef61fcb @@ -414,7 +414,7 @@ F src/vdbe.c b90d9d38e5e0260c2eafa3cb4c2274d8ea94da27 F src/vdbe.h 7a733ea8aac1b77305a67698e784fa3484ee3337 F src/vdbeInt.h 42eefa4f9e7432b9968d321b44e48821ec13b189 F src/vdbeapi.c ffae8f5af4570fbd548504e815e9fb7227f0822e -F src/vdbeaux.c f53b709c4c0d8f80e51dbf343292564e8628e217 +F src/vdbeaux.c d34740a472662f9555c0cbb46bbfe323014ba0e5 F src/vdbeblob.c 37c3d11a753e403698c69e17383d282e1ae73e75 F src/vdbemem.c b9181e77eca2a095929d46250daf85c8d2621fc0 F src/vdbesort.c 0971557e5d3c289e46f56a52aed2197c13251de7 @@ -1419,7 +1419,7 @@ F tool/vdbe_profile.tcl 246d0da094856d72d2c12efec03250d71639d19f F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4 F tool/warnings.sh 48bd54594752d5be3337f12c72f28d2080cb630b F tool/win/sqlite.vsix deb315d026cc8400325c5863eef847784a219a2f -P f421adf54c9db91ba6ca64a8ba3751680e47924a -R 0c5d0312a4aace8397299f6692596f42 +P 80dd495f378614e4eca72e71e43061b1b94ee450 +R a035637148b8d47d70dffd1e7fd4febf U drh -Z ec44132b48754f37e54bd488e98f7a49 +Z c01377a6a12f63d2df1dc07be9d35345 diff --git a/manifest.uuid b/manifest.uuid index 1408be74b1..4ea4de6797 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -80dd495f378614e4eca72e71e43061b1b94ee450 \ No newline at end of file +730d7efb6fef54ed7c1f4ae27e3b55778ea6ff01 \ No newline at end of file diff --git a/src/vdbeaux.c b/src/vdbeaux.c index cbb707d25a..47ac9dd9f5 100644 --- a/src/vdbeaux.c +++ b/src/vdbeaux.c @@ -849,7 +849,7 @@ int sqlite3VdbeChangeToNoop(Vdbe *p, int addr){ assert( addr>=0 && addrnOp ); pOp = &p->aOp[addr]; freeP4(p->db, pOp->p4type, pOp->p4.p); - memset(pOp, 0, sizeof(pOp[0])); + pOp->p4type = P4_NOTUSED; pOp->opcode = OP_Noop; return 1; }