From 80dbe636cd647c48b36db8df70708b4bc5ca1d6f Mon Sep 17 00:00:00 2001 From: Michael Vetter Date: Sat, 10 Nov 2018 08:36:15 +0100 Subject: [PATCH] core: OpenURL() fix xdg-open call Calling just `xdg-open` is not right. One needs to pack the URL in `'`. If we don't do this then some special characters (like ampersand) will be executed. Maybe this is true for Windows and Apple case too, but I don't own any such system. So please merge this, and if it's true for more cases let's use `sprintf()` in the other cases too. --- src/core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core.c b/src/core.c index 380137b7..d6c5f243 100644 --- a/src/core.c +++ b/src/core.c @@ -1823,14 +1823,17 @@ int StorageLoadValue(int position) void OpenURL(const char *url) { char *cmd = calloc(10 + strlen(url), sizeof(char)); + #if defined(_WIN32) strcpy(cmd, "explorer "); + strcat(cmd, url); #elif defined(__linux__) - strcpy(cmd, "xdg-open "); // Alternatives: firefox, x-www-browser + sprintf(cmd, "xdg-open '%s'", url); // Alternatives: firefox, x-www-browser #elif defined(__APPLE__) strcpy(cmd, "open "); -#endif strcat(cmd, url); +#endif + system(cmd); free(cmd); }