From 07f971622836c09bd797961bf3efb3137776b717 Mon Sep 17 00:00:00 2001 From: Ned Williamson Date: Sun, 18 Jan 2015 17:37:54 -0500 Subject: [PATCH] nicer error handling in static tester --- static2/testing.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/static2/testing.py b/static2/testing.py index e1e72bb8..c03570c7 100755 --- a/static2/testing.py +++ b/static2/testing.py @@ -42,16 +42,20 @@ def get_functions(dwarfinfo): def test_files(fns,quiet=False,profile=False): for fn in fns: + if os.path.isdir(fn): + if not quiet: + print "{} Skipping directory `{}'".format(warn, fn) + continue try: elf = ELFFile(open(fn)) except ELFError: if not quiet: - print "Skipping non-ELF file:",fn + print "{} Skipping non-ELF file `{}'".format(warn, fn) continue if not elf.has_dwarf_info(): if not quiet: - print "No dwarf info for {}.".format(fn) + print "{} No dwarf info for `{}'".format(warn, fn) continue dwarfinfo = elf.get_dwarf_info() @@ -97,7 +101,7 @@ if __name__ == "__main__": parser.add_argument("files", metavar="file", nargs="*", help="use user-specified binaries") parser.add_argument("--quiet",dest="quiet",action="store_true", - help="don't warn about missing dwarf information") + help="don't warn about skipped cases") parser.add_argument('--profile',dest="profile",action='store_true', help='use internal profiling, output to prof.png') parser.add_argument('--verbose',dest="verbose",action="store_true",