68406d1085
This test is hanging under heavy load when the two socats race while trying to create the socket. I've tried various approaches to avoid the race but it seems "creat=0" won't stop socat trying to create a pipe if it executes first. In the end I just use a small sleep which seems to be reliable enough on the load situations I've tried. While I was there I also properly created a tmpdir for the socket to live in which is cleaned up at the end of the test. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Cc: Thomas Huth <thuth@redhat.com> Cc: Marc-André Lureau <marcandre.lureau@redhat.com> Cc: Juan Quintela <quintela@redhat.com> Message-Id: <20221027183637.2772968-30-alex.bennee@linaro.org>
144 lines
4.1 KiB
C
144 lines
4.1 KiB
C
/*
|
|
* QEMU I/O channel command test
|
|
*
|
|
* Copyright (c) 2015 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include <glib/gstdio.h>
|
|
#include "io/channel-command.h"
|
|
#include "io-channel-helpers.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/module.h"
|
|
|
|
#define TEST_FIFO "test-io-channel-command.fifo"
|
|
|
|
static char *socat = NULL;
|
|
|
|
static void test_io_channel_command_fifo(bool async)
|
|
{
|
|
g_autofree gchar *tmpdir = g_dir_make_tmp("qemu-test-io-channel.XXXXXX", NULL);
|
|
g_autofree gchar *fifo = g_strdup_printf("%s/%s", tmpdir, TEST_FIFO);
|
|
g_autoptr(GString) srcargs = g_string_new(socat);
|
|
g_autoptr(GString) dstargs = g_string_new(socat);
|
|
g_auto(GStrv) srcargv;
|
|
g_auto(GStrv) dstargv;
|
|
QIOChannel *src, *dst;
|
|
QIOChannelTest *test;
|
|
|
|
g_string_append_printf(srcargs, " - PIPE:%s,wronly", fifo);
|
|
g_string_append_printf(dstargs, " PIPE:%s,rdonly -", fifo);
|
|
|
|
srcargv = g_strsplit(srcargs->str, " ", -1);
|
|
dstargv = g_strsplit(dstargs->str, " ", -1);
|
|
|
|
src = QIO_CHANNEL(qio_channel_command_new_spawn((const char **) srcargv,
|
|
O_WRONLY,
|
|
&error_abort));
|
|
/* try to avoid a race to create the socket */
|
|
g_usleep(1000);
|
|
|
|
dst = QIO_CHANNEL(qio_channel_command_new_spawn((const char **) dstargv,
|
|
O_RDONLY,
|
|
&error_abort));
|
|
|
|
test = qio_channel_test_new();
|
|
qio_channel_test_run_threads(test, async, src, dst);
|
|
qio_channel_test_validate(test);
|
|
|
|
object_unref(OBJECT(src));
|
|
object_unref(OBJECT(dst));
|
|
|
|
g_rmdir(tmpdir);
|
|
}
|
|
|
|
|
|
static void test_io_channel_command_fifo_async(void)
|
|
{
|
|
if (!socat) {
|
|
g_test_skip("socat is not found in PATH");
|
|
return;
|
|
}
|
|
|
|
test_io_channel_command_fifo(true);
|
|
}
|
|
|
|
static void test_io_channel_command_fifo_sync(void)
|
|
{
|
|
if (!socat) {
|
|
g_test_skip("socat is not found in PATH");
|
|
return;
|
|
}
|
|
|
|
test_io_channel_command_fifo(false);
|
|
}
|
|
|
|
|
|
static void test_io_channel_command_echo(bool async)
|
|
{
|
|
QIOChannel *ioc;
|
|
QIOChannelTest *test;
|
|
const char *socatargv[] = {
|
|
socat, "-", "-", NULL,
|
|
};
|
|
|
|
if (!socat) {
|
|
g_test_skip("socat is not found in PATH");
|
|
return;
|
|
}
|
|
|
|
ioc = QIO_CHANNEL(qio_channel_command_new_spawn(socatargv,
|
|
O_RDWR,
|
|
&error_abort));
|
|
test = qio_channel_test_new();
|
|
qio_channel_test_run_threads(test, async, ioc, ioc);
|
|
qio_channel_test_validate(test);
|
|
|
|
object_unref(OBJECT(ioc));
|
|
}
|
|
|
|
|
|
static void test_io_channel_command_echo_async(void)
|
|
{
|
|
test_io_channel_command_echo(true);
|
|
}
|
|
|
|
static void test_io_channel_command_echo_sync(void)
|
|
{
|
|
test_io_channel_command_echo(false);
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
module_call_init(MODULE_INIT_QOM);
|
|
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
socat = g_find_program_in_path("socat");
|
|
|
|
g_test_add_func("/io/channel/command/fifo/sync",
|
|
test_io_channel_command_fifo_sync);
|
|
g_test_add_func("/io/channel/command/fifo/async",
|
|
test_io_channel_command_fifo_async);
|
|
g_test_add_func("/io/channel/command/echo/sync",
|
|
test_io_channel_command_echo_sync);
|
|
g_test_add_func("/io/channel/command/echo/async",
|
|
test_io_channel_command_echo_async);
|
|
|
|
return g_test_run();
|
|
}
|