fea374e7c8
We have this issue reported when using libvirt to hotplug CPUs:
https://bugzilla.redhat.com/show_bug.cgi?id=1741451
Basically, libvirt is not copying die-id from
query-hotpluggable-cpus, but die-id is now mandatory.
We could blame libvirt and say it is not following the documented
interface, because we have this buried in the QAPI schema
documentation:
> Note: currently there are 5 properties that could be present
> but management should be prepared to pass through other
> properties with device_add command to allow for future
> interface extension. This also requires the filed names to be kept in
> sync with the properties passed to -device/device_add.
But I don't think this would be reasonable from us. We can just
make QEMU more flexible and let die-id to be omitted when there's
no ambiguity. This will allow us to keep compatibility with
existing libvirt versions.
Test case included to ensure we don't break this again.
Fixes: commit
|
||
|---|---|---|
| .. | ||
| avocado_qemu | ||
| boot_linux_console.py | ||
| cpu_queries.py | ||
| empty_cpu_model.py | ||
| linux_initrd.py | ||
| linux_ssh_mips_malta.py | ||
| migration.py | ||
| pc_cpu_hotplug_props.py | ||
| README.rst | ||
| version.py | ||
| virtio_version.py | ||
| vnc.py | ||
| x86_cpu_model_versions.py | ||
============================================ Acceptance tests using the Avocado Framework ============================================ This directory contains functional tests, also known as acceptance level tests. They're usually higher level, and may interact with external resources and with various guest operating systems. For more information, please refer to ``docs/devel/testing.rst``, section "Acceptance tests using the Avocado Framework".