qemu/hw/usb
Gerd Hoffmann f419a626c7 usb/uhci: move pid check
commit "5f77e06 usb: add pid check at the first of uhci_handle_td()"
moved the pid verification to the start of the uhci_handle_td function,
to simplify the error handling (we don't have to free stuff which we
didn't allocate in the first place ...).

Problem is now the check fires too often, it raises error IRQs even for
TDs which we are not going to process because they are not set active.

So, lets move down the check a bit, so it is done only for active TDs,
but still before we are going to allocate stuff to process the requested
transfer.

Reported-by: Joe Clifford <joe@thunderbug.co.uk>
Tested-by: Joe Clifford <joe@thunderbug.co.uk>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 1461321893-15811-1-git-send-email-kraxel@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
2016-04-25 12:05:05 +01:00
..
bus.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
ccid-card-emulated.c event-notifier: Add "is_external" parameter 2016-04-22 16:43:56 +02:00
ccid-card-passthru.c Passthru CCID card: QOMify 2016-02-11 15:15:47 +03:00
ccid.h
combined-packet.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
core.c usb: check RNDIS message length 2016-02-23 10:38:00 +01:00
desc-msos.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
desc.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
desc.h all: Clean up includes 2016-02-23 12:43:05 +00:00
dev-audio.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
dev-bluetooth.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
dev-hid.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
dev-hub.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
dev-mtp.c * Log filtering from Alex and Peter 2016-03-24 21:42:40 +00:00
dev-network.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
dev-serial.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
dev-smartcard-reader.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
dev-storage.c util: move declarations out of qemu-common.h 2016-03-22 22:20:17 +01:00
dev-uas.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
dev-wacom.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
hcd-ehci-pci.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
hcd-ehci-sysbus.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
hcd-ehci.c Revert "ehci: make idt processing more robust" 2016-04-19 08:20:56 +02:00
hcd-ehci.h Include monitor/monitor.h exactly where needed 2015-06-22 18:20:41 +02:00
hcd-musb.c Replaced get_tick_per_sec() by NANOSECONDS_PER_SECOND 2016-03-22 22:20:17 +01:00
hcd-ohci.c Replaced get_tick_per_sec() by NANOSECONDS_PER_SECOND 2016-03-22 22:20:17 +01:00
hcd-uhci.c usb/uhci: move pid check 2016-04-25 12:05:05 +01:00
hcd-xhci.c usb: fix unbounded stack warning for xhci_dma_write_u32s 2016-03-18 13:42:14 +01:00
host-legacy.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
host-libusb.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
host-stub.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
host.h
libhw.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
Makefile.objs tusb6010: move from hw/timer to hw/usb 2016-02-23 10:38:00 +01:00
quirks-ftdi-ids.h
quirks-pl2303-ids.h
quirks.c usb: Clean up includes 2016-01-29 15:07:23 +00:00
quirks.h
redirect.c * Log filtering from Alex and Peter 2016-03-24 21:42:40 +00:00
tusb6010.c Replaced get_tick_per_sec() by NANOSECONDS_PER_SECOND 2016-03-22 22:20:17 +01:00