Markus Armbruster
eddf817bd8
qapi: Simplify error reporting for array types
...
check_type() first checks and peels off the array type, then checks
the element type. For two out of four error messages, it takes pains
to report errors for "array of T" instead of just T. Odd. Let's
examine the errors.
* Unknown element type, e.g.
tests/qapi-schema/args-array-unknown.json:
Member 'array' of 'data' for command 'oops' uses unknown type
'array of NoSuchType'
To make sense of this, you need to know that 'array of NoSuchType'
refers to '[NoSuchType]'. Easy enough. However, simply reporting
Member 'array' of 'data' for command 'oops' uses unknown type
'NoSuchType'
is at least as easy to understand.
* Element type's meta-type is inadmissible, e.g.
tests/qapi-schema/returns-whitelist.json:
'returns' for command 'no-way-this-will-get-whitelisted' cannot
use built-in type 'array of int'
'array of int' is technically not a built-in type, but that's
pedantry. However, simply reporting
'returns' for command 'no-way-this-will-get-whitelisted' cannot
use built-in type 'int'
avoids the issue, and is at least as easy to understand.
* The remaining two errors are unreachable, because the array checking
ensures that value is a string.
Thus, reporting some errors for "array of T" instead of just T works,
but doesn't really improve things. Drop it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
2015-09-04 15:47:16 +02:00
..
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-09-04 15:47:15 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:02 +02:00
2014-06-23 11:01:25 -04:00
2014-06-23 11:01:25 -04:00
2014-06-23 11:01:25 -04:00
2015-06-18 14:19:47 +02:00
2015-06-18 14:19:47 +02:00
2015-06-18 14:19:47 +02:00
2015-06-18 14:19:47 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2015-06-18 14:12:34 +02:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2015-06-18 14:12:34 +02:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-16 10:35:59 -04:00
2014-05-16 10:35:59 -04:00
2014-05-16 10:35:59 -04:00
2014-05-16 10:35:59 -04:00
2014-05-16 10:35:59 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-09-04 15:47:15 +02:00
2015-05-05 18:39:02 +02:00
2014-05-08 14:19:58 -04:00
2015-09-04 15:47:14 +02:00
2015-09-04 15:47:14 +02:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-09-04 15:47:15 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-09-04 15:47:16 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2015-09-04 15:47:16 +02:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2014-05-08 14:19:58 -04:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-09-04 15:47:16 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:00 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:02 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00
2015-05-05 18:39:01 +02:00