ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
38 lines
866 B
C
38 lines
866 B
C
#ifndef HW_ETRAXFS_DMA_H
|
|
#define HW_ETRAXFS_DMA_H
|
|
|
|
#include "exec/hwaddr.h"
|
|
#include "hw/irq.h"
|
|
|
|
struct dma_context_metadata {
|
|
/* data descriptor md */
|
|
uint16_t metadata;
|
|
};
|
|
|
|
struct etraxfs_dma_client
|
|
{
|
|
/* DMA controller. */
|
|
int channel;
|
|
void *ctrl;
|
|
|
|
/* client. */
|
|
struct {
|
|
int (*push)(void *opaque, unsigned char *buf,
|
|
int len, bool eop);
|
|
void (*pull)(void *opaque);
|
|
void (*metadata_push)(void *opaque,
|
|
const struct dma_context_metadata *md);
|
|
void *opaque;
|
|
} client;
|
|
};
|
|
|
|
void *etraxfs_dmac_init(hwaddr base, int nr_channels);
|
|
void etraxfs_dmac_connect(void *opaque, int channel, qemu_irq *line,
|
|
int input);
|
|
void etraxfs_dmac_connect_client(void *opaque, int c,
|
|
struct etraxfs_dma_client *cl);
|
|
int etraxfs_dmac_input(struct etraxfs_dma_client *client,
|
|
void *buf, int len, int eop);
|
|
|
|
#endif
|