ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
60 lines
1.3 KiB
C
60 lines
1.3 KiB
C
#ifndef HW_ESCC_H
|
|
#define HW_ESCC_H
|
|
|
|
#include "chardev/char-fe.h"
|
|
#include "chardev/char-serial.h"
|
|
#include "hw/sysbus.h"
|
|
#include "ui/input.h"
|
|
|
|
/* escc.c */
|
|
#define TYPE_ESCC "escc"
|
|
#define ESCC_SIZE 4
|
|
|
|
#define ESCC(obj) OBJECT_CHECK(ESCCState, (obj), TYPE_ESCC)
|
|
|
|
typedef enum {
|
|
escc_chn_a, escc_chn_b,
|
|
} ESCCChnID;
|
|
|
|
typedef enum {
|
|
escc_serial, escc_kbd, escc_mouse,
|
|
} ESCCChnType;
|
|
|
|
#define ESCC_SERIO_QUEUE_SIZE 256
|
|
|
|
typedef struct {
|
|
uint8_t data[ESCC_SERIO_QUEUE_SIZE];
|
|
int rptr, wptr, count;
|
|
} ESCCSERIOQueue;
|
|
|
|
#define ESCC_SERIAL_REGS 16
|
|
typedef struct ESCCChannelState {
|
|
qemu_irq irq;
|
|
uint32_t rxint, txint, rxint_under_svc, txint_under_svc;
|
|
struct ESCCChannelState *otherchn;
|
|
uint32_t reg;
|
|
uint8_t wregs[ESCC_SERIAL_REGS], rregs[ESCC_SERIAL_REGS];
|
|
ESCCSERIOQueue queue;
|
|
CharBackend chr;
|
|
int e0_mode, led_mode, caps_lock_mode, num_lock_mode;
|
|
int disabled;
|
|
int clock;
|
|
uint32_t vmstate_dummy;
|
|
ESCCChnID chn; /* this channel, A (base+4) or B (base+0) */
|
|
ESCCChnType type;
|
|
uint8_t rx, tx;
|
|
QemuInputHandlerState *hs;
|
|
} ESCCChannelState;
|
|
|
|
typedef struct ESCCState {
|
|
SysBusDevice parent_obj;
|
|
|
|
struct ESCCChannelState chn[2];
|
|
uint32_t it_shift;
|
|
MemoryRegion mmio;
|
|
uint32_t disabled;
|
|
uint32_t frequency;
|
|
} ESCCState;
|
|
|
|
#endif
|