Bin Meng e9d28020d2 hw/sd: sd: Drop sd_crc16() ... commit f6fb1f9b31 ("sdcard: Correct CRC16 offset in sd_function_switch()") changed the 16-bit CRC to be stored at offset 64. In fact, this CRC calculation is completely wrong. From the original codes, it wants to calculate the CRC16 of the first 64 bytes of sd->data[], however passing 64 as the `width` to sd_crc16() actually counts 256 bytes starting from the `message` for the CRC16 calculation, which is not what we want. Besides that, it seems existing sd_crc16() algorithm does not match the SD spec, which says CRC16 is the CCITT one but the calculation does not produce expected result. It turns out the CRC16 was never transferred outside the sd core, as in sd_read_byte() we see: if (sd->data_offset >= 64) sd->state = sd_transfer_state; Given above reasons, let's drop it. Signed-off-by: Bin Meng <bin.meng@windriver.com> Tested-by: Pragnesh Patel <pragnesh.patel@sifive.com> Reviewed-by: Pragnesh Patel <pragnesh.patel@sifive.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <20210123104016.17485-6-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>		2021-01-24 19:14:15 +01:00
..
allwinner-sdhost.c
aspeed_sdhci.c
bcm2835_sdhost.c
cadence_sdhci.c
core.c
Kconfig
meson.build
milkymist-memcard.c
omap_mmc.c
pl181.c
pxa2xx_mmci.c
sd.c	hw/sd: sd: Drop sd_crc16()	2021-01-24 19:14:15 +01:00
sdhci-internal.h
sdhci-pci.c
sdhci.c
sdmmc-internal.c
sdmmc-internal.h
ssi-sd.c
trace-events
trace.h