Eduardo Habkost e90f2a8c3e qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable ... cannot_instantiate_with_device_add_yet was introduced by commit efec3dd631 to replace no_user. It was supposed to be a temporary measure. When it was introduced, we had 54 cannot_instantiate_with_device_add_yet=true lines in the code. Today (3 years later) this number has not shrunk: we now have 57 cannot_instantiate_with_device_add_yet=true lines. I think it is safe to say it is not a temporary measure, and we won't see the flag go away soon. Instead of a long field name that misleads people to believe it is temporary, replace it a shorter and less misleading field: user_creatable. Except for code comments, changes were generated using the following Coccinelle patch: @@ expression DC; @@ ( -DC->cannot_instantiate_with_device_add_yet = false; +DC->user_creatable = true; | -DC->cannot_instantiate_with_device_add_yet = true; +DC->user_creatable = false; ) @@ typedef ObjectClass; expression dc; identifier class, data; @@ static void device_class_init(ObjectClass *class, void *data) { ... dc->hotpluggable = true; +dc->user_creatable = true; ... } @@ @@ struct DeviceClass { ... -bool cannot_instantiate_with_device_add_yet; +bool user_creatable; ... } @@ expression DC; @@ ( -!DC->cannot_instantiate_with_device_add_yet +DC->user_creatable | -DC->cannot_instantiate_with_device_add_yet +!DC->user_creatable ) Cc: Alistair Francis <alistair.francis@xilinx.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Marcel Apfelbaum <marcel@redhat.com> Cc: Markus Armbruster <armbru@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Thomas Huth <thuth@redhat.com> Acked-by: Alistair Francis <alistair.francis@xilinx.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Acked-by: Marcel Apfelbaum <marcel@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20170503203604.31462-2-ehabkost@redhat.com> [ehabkost: kept "TODO remove once we're there" comment] Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>		2017-05-17 10:37:00 -03:00
..
dec.c	qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable	2017-05-17 10:37:00 -03:00
dec.h	Clean up header guards that don't match their file name	2016-07-12 16:19:16 +02:00
gen_pcie_root_port.c	pci: Convert msix_init() to Error and fix callers	2017-02-01 03:37:18 +02:00
i82801b11.c	Migration: Add i82801b11 migration data	2016-04-07 19:57:33 +03:00
ioh3420.c	hw/ioh3420: derive from PCI Express Root Port base class	2017-02-01 03:37:17 +02:00
ioh3420.h	ioh3420: remove unused ioh3420_init() declaration	2014-09-02 17:28:26 +03:00
Makefile.objs	ppc patch queue 2017-02-02	2017-02-02 18:48:06 +00:00
pci_bridge_dev.c	hw/pci: disable pci-bridge's shpc by default	2017-02-01 03:37:18 +02:00
pci_expander_bridge.c	qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable	2017-05-17 10:37:00 -03:00
pcie_root_port.c	hw/pcie: Introduce a base class for PCI Express Root Ports	2017-02-01 03:37:17 +02:00
xio3130_downstream.c	PCI/migration merge vmstate_pci_device and vmstate_pcie_device	2017-01-24 18:00:31 +00:00
xio3130_downstream.h	hw: move private headers to hw/ subdirectories.	2013-04-08 18:13:16 +02:00
xio3130_upstream.c	PCI/migration merge vmstate_pci_device and vmstate_pcie_device	2017-01-24 18:00:31 +00:00
xio3130_upstream.h	Clean up decorations and whitespace around header guards	2016-07-12 16:20:46 +02:00