4c315c2766
Several devices don't survive object_unref(object_new(T)): they crash or hang during cleanup, or they leave dangling pointers behind. This breaks at least device-list-properties, because qmp_device_list_properties() needs to create a device to find its properties. Broken in commitf4eb32b
"qmp: show QOM properties in device-list-properties", v2.1. Example reproducer: $ qemu-system-aarch64 -nodefaults -display none -machine none -S -qmp stdio {"QMP": {"version": {"qemu": {"micro": 50, "minor": 4, "major": 2}, "package": ""}, "capabilities": []}} { "execute": "qmp_capabilities" } {"return": {}} { "execute": "device-list-properties", "arguments": { "typename": "pxa2xx-pcmcia" } } qemu-system-aarch64: /home/armbru/work/qemu/memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed. Aborted (core dumped) [Exit 134 (SIGABRT)] Unfortunately, I can't fix the problems in these devices right now. Instead, add DeviceClass member cannot_destroy_with_object_finalize_yet to mark them: * Hang during cleanup (didn't debug, so I can't say why): "realview_pci", "versatile_pci". * Dangling pointer in cpus: most CPUs, plus "allwinner-a10", "digic", "fsl,imx25", "fsl,imx31", "xlnx,zynqmp", because they create such CPUs * Assert kvm_enabled(): "host-x86_64-cpu", host-i386-cpu", "host-powerpc64-cpu", "host-embedded-powerpc-cpu", "host-powerpc-cpu" (the powerpc ones can't currently reach the assertion, because the CPUs are only registered when KVM is enabled, but the assertion is arguably in the wrong place all the same) Make qmp_device_list_properties() fail cleanly when the device is so marked. This improves device-list-properties from "crashes, hangs or leaves dangling pointers behind" to "fails". Not a complete fix, just a better-than-nothing work-around. In the above reproducer, device-list-properties now fails with "Can't list properties of device 'pxa2xx-pcmcia'". This also protects -device FOO,help, which uses the same machinery since commitef52358
"qdev-monitor: include QOM properties in -device FOO, help output", v2.2. Example reproducer: $ qemu-system-aarch64 -machine none -device pxa2xx-pcmcia,help Before: qemu-system-aarch64: .../memory.c:1307: memory_region_finalize: Assertion `((&mr->subregions)->tqh_first == ((void *)0))' failed. After: Can't list properties of device 'pxa2xx-pcmcia' Cc: "Andreas Färber" <afaerber@suse.de> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com> Cc: Alexander Graf <agraf@suse.de> Cc: Anthony Green <green@moxielogic.com> Cc: Aurelien Jarno <aurelien@aurel32.net> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Cc: Blue Swirl <blauwirbel@gmail.com> Cc: Eduardo Habkost <ehabkost@redhat.com> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn> Cc: Jia Liu <proljc@gmail.com> Cc: Leon Alrae <leon.alrae@imgtec.com> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Cc: Max Filippov <jcmvbkbc@gmail.com> Cc: Michael Walle <michael@walle.cc> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Richard Henderson <rth@twiddle.net> Cc: qemu-ppc@nongnu.org Cc: qemu-stable@nongnu.org Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <1443689999-12182-10-git-send-email-armbru@redhat.com>
181 lines
4.8 KiB
C
181 lines
4.8 KiB
C
/*
|
|
* QEMU MIPS CPU
|
|
*
|
|
* Copyright (c) 2012 SUSE LINUX Products GmbH
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see
|
|
* <http://www.gnu.org/licenses/lgpl-2.1.html>
|
|
*/
|
|
|
|
#include "cpu.h"
|
|
#include "kvm_mips.h"
|
|
#include "qemu-common.h"
|
|
#include "sysemu/kvm.h"
|
|
|
|
|
|
static void mips_cpu_set_pc(CPUState *cs, vaddr value)
|
|
{
|
|
MIPSCPU *cpu = MIPS_CPU(cs);
|
|
CPUMIPSState *env = &cpu->env;
|
|
|
|
env->active_tc.PC = value & ~(target_ulong)1;
|
|
if (value & 1) {
|
|
env->hflags |= MIPS_HFLAG_M16;
|
|
} else {
|
|
env->hflags &= ~(MIPS_HFLAG_M16);
|
|
}
|
|
}
|
|
|
|
static void mips_cpu_synchronize_from_tb(CPUState *cs, TranslationBlock *tb)
|
|
{
|
|
MIPSCPU *cpu = MIPS_CPU(cs);
|
|
CPUMIPSState *env = &cpu->env;
|
|
|
|
env->active_tc.PC = tb->pc;
|
|
env->hflags &= ~MIPS_HFLAG_BMASK;
|
|
env->hflags |= tb->flags & MIPS_HFLAG_BMASK;
|
|
}
|
|
|
|
static bool mips_cpu_has_work(CPUState *cs)
|
|
{
|
|
MIPSCPU *cpu = MIPS_CPU(cs);
|
|
CPUMIPSState *env = &cpu->env;
|
|
bool has_work = false;
|
|
|
|
/* It is implementation dependent if non-enabled interrupts
|
|
wake-up the CPU, however most of the implementations only
|
|
check for interrupts that can be taken. */
|
|
if ((cs->interrupt_request & CPU_INTERRUPT_HARD) &&
|
|
cpu_mips_hw_interrupts_pending(env)) {
|
|
has_work = true;
|
|
}
|
|
|
|
/* MIPS-MT has the ability to halt the CPU. */
|
|
if (env->CP0_Config3 & (1 << CP0C3_MT)) {
|
|
/* The QEMU model will issue an _WAKE request whenever the CPUs
|
|
should be woken up. */
|
|
if (cs->interrupt_request & CPU_INTERRUPT_WAKE) {
|
|
has_work = true;
|
|
}
|
|
|
|
if (!mips_vpe_active(env)) {
|
|
has_work = false;
|
|
}
|
|
}
|
|
return has_work;
|
|
}
|
|
|
|
/* CPUClass::reset() */
|
|
static void mips_cpu_reset(CPUState *s)
|
|
{
|
|
MIPSCPU *cpu = MIPS_CPU(s);
|
|
MIPSCPUClass *mcc = MIPS_CPU_GET_CLASS(cpu);
|
|
CPUMIPSState *env = &cpu->env;
|
|
|
|
mcc->parent_reset(s);
|
|
|
|
memset(env, 0, offsetof(CPUMIPSState, mvp));
|
|
tlb_flush(s, 1);
|
|
|
|
cpu_state_reset(env);
|
|
|
|
#ifndef CONFIG_USER_ONLY
|
|
if (kvm_enabled()) {
|
|
kvm_mips_reset_vcpu(cpu);
|
|
}
|
|
#endif
|
|
}
|
|
|
|
static void mips_cpu_realizefn(DeviceState *dev, Error **errp)
|
|
{
|
|
CPUState *cs = CPU(dev);
|
|
MIPSCPUClass *mcc = MIPS_CPU_GET_CLASS(dev);
|
|
|
|
cpu_reset(cs);
|
|
qemu_init_vcpu(cs);
|
|
|
|
mcc->parent_realize(dev, errp);
|
|
}
|
|
|
|
static void mips_cpu_initfn(Object *obj)
|
|
{
|
|
CPUState *cs = CPU(obj);
|
|
MIPSCPU *cpu = MIPS_CPU(obj);
|
|
CPUMIPSState *env = &cpu->env;
|
|
|
|
cs->env_ptr = env;
|
|
cpu_exec_init(cs, &error_abort);
|
|
|
|
if (tcg_enabled()) {
|
|
mips_tcg_init();
|
|
}
|
|
}
|
|
|
|
static void mips_cpu_class_init(ObjectClass *c, void *data)
|
|
{
|
|
MIPSCPUClass *mcc = MIPS_CPU_CLASS(c);
|
|
CPUClass *cc = CPU_CLASS(c);
|
|
DeviceClass *dc = DEVICE_CLASS(c);
|
|
|
|
mcc->parent_realize = dc->realize;
|
|
dc->realize = mips_cpu_realizefn;
|
|
|
|
mcc->parent_reset = cc->reset;
|
|
cc->reset = mips_cpu_reset;
|
|
|
|
cc->has_work = mips_cpu_has_work;
|
|
cc->do_interrupt = mips_cpu_do_interrupt;
|
|
cc->cpu_exec_interrupt = mips_cpu_exec_interrupt;
|
|
cc->dump_state = mips_cpu_dump_state;
|
|
cc->set_pc = mips_cpu_set_pc;
|
|
cc->synchronize_from_tb = mips_cpu_synchronize_from_tb;
|
|
cc->gdb_read_register = mips_cpu_gdb_read_register;
|
|
cc->gdb_write_register = mips_cpu_gdb_write_register;
|
|
#ifdef CONFIG_USER_ONLY
|
|
cc->handle_mmu_fault = mips_cpu_handle_mmu_fault;
|
|
#else
|
|
cc->do_unassigned_access = mips_cpu_unassigned_access;
|
|
cc->do_unaligned_access = mips_cpu_do_unaligned_access;
|
|
cc->get_phys_page_debug = mips_cpu_get_phys_page_debug;
|
|
cc->vmsd = &vmstate_mips_cpu;
|
|
#endif
|
|
|
|
cc->gdb_num_core_regs = 73;
|
|
cc->gdb_stop_before_watchpoint = true;
|
|
|
|
/*
|
|
* Reason: mips_cpu_initfn() calls cpu_exec_init(), which saves
|
|
* the object in cpus -> dangling pointer after final
|
|
* object_unref().
|
|
*/
|
|
dc->cannot_destroy_with_object_finalize_yet = true;
|
|
}
|
|
|
|
static const TypeInfo mips_cpu_type_info = {
|
|
.name = TYPE_MIPS_CPU,
|
|
.parent = TYPE_CPU,
|
|
.instance_size = sizeof(MIPSCPU),
|
|
.instance_init = mips_cpu_initfn,
|
|
.abstract = false,
|
|
.class_size = sizeof(MIPSCPUClass),
|
|
.class_init = mips_cpu_class_init,
|
|
};
|
|
|
|
static void mips_cpu_register_types(void)
|
|
{
|
|
type_register_static(&mips_cpu_type_info);
|
|
}
|
|
|
|
type_init(mips_cpu_register_types)
|