mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
e2c0c4eef5
qemu/hw/i386
History
Markus Armbruster d319e05d6f pc: Fix machine property nvdimm-persistence error handling 
Calling error_report() in a function that takes an Error ** argument
is suspicious.  pc.c's pc_machine_set_nvdimm_persistence() does that,
and then exit()s.  Wrong.  Attempting to set machine property
nvdimm-persistence to a bad value instantly kills the VM:

    $ qemu-system-x86_64 -nodefaults -S -display none -qmp stdio
    {"QMP": {"version": {"qemu": {"micro": 50, "minor": 0, "major": 3}, "package": "v3.0.0-837-gc5e4e49258"}, "capabilities": []}}
    {"execute": "qmp_capabilities"}
    {"return": {}}
    {"execute": "qom-set", "arguments": {"path": "/machine", "property": "nvdimm-persistence", "value": "instadeath"}}
    -machine nvdimm-persistence=instadeath: unsupported option
    $ echo $?
    1

Broken when commit 11c39b5cd9 (v3.0.0) replaced error_propagate();
return by error_report(); exit() instead of error_setg(); return.  Fix
that.

Fixes: 11c39b5cd9
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181017082702.5581-10-armbru@redhat.com>
2018-10-19 14:51:34 +02:00
..
kvm kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread 2018-10-02 19:09:13 +02:00
xen hw/xen: Use the IEC binary prefix definitions 2018-07-02 15:41:13 +02:00
acpi-build.c pc: acpi: revert back to 1 SRAT entry for hotpluggable area 2018-09-07 17:05:18 -04:00
acpi-build.h
amd_iommu.c iommu: Add IOMMU index argument to translate method 2018-06-15 15:23:34 +01:00
amd_iommu.h hw/i386: Fix AMDVI GATS and HATS encodings 2018-06-26 21:58:03 +03:00
intel_iommu_internal.h intel-iommu: Extend address width to 48 bits 2018-01-18 21:52:38 +02:00
intel_iommu.c intel-iommu: replace more vtd_err_* traces 2018-08-27 15:09:20 +02:00
kvmvapic.c target: Do not include "exec/exec-all.h" if it is not necessary 2018-06-01 14:15:10 +02:00
Makefile.objs hw/i386: make IOMMUs configurable via default-configs/ 2018-03-12 16:12:46 +01:00
multiboot.c Drop "qemu:" prefix from error_report() arguments 2018-09-24 17:13:07 +02:00
multiboot.h
pc_piix.c hw/i386: Use the IEC binary prefix definitions 2018-07-02 15:41:16 +02:00
pc_q35.c hw/i386: Use the IEC binary prefix definitions 2018-07-02 15:41:16 +02:00
pc_sysfw.c hw/i386: Use the IEC binary prefix definitions 2018-07-02 15:41:16 +02:00
pc.c pc: Fix machine property nvdimm-persistence error handling 2018-10-19 14:51:34 +02:00
trace-events intel-iommu: replace more vtd_err_* traces 2018-08-27 15:09:20 +02:00
vmmouse.c hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h 2018-03-12 16:12:48 +01:00
vmport.c hw/input/i8042: Extract declarations from i386/pc.h into input/i8042.h 2018-03-12 16:12:48 +01:00
x86-iommu.c x86_iommu: check if machine has PCI bus 2018-01-18 21:52:38 +02:00