dae66a3f66
In the previous commit, we modified gdbstub.c to only send stop-reply packets as a response to GDB commands that accept it. Now, let's add a test for this intended behavior. Running this test before the fix from the previous commit fails as QEMU sends a stop-reply packet asynchronously, when GDB was in fact waiting an ACK. Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com> Acked-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com> Message-Id: <a30d93b9a8d66e9d9294354cfa2fc3af35f00202.1683214375.git.quic_mathbern@quicinc.com>
118 lines
3.6 KiB
Python
Executable File
118 lines
3.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# Run a gdbstub test case
|
|
#
|
|
# Copyright (c) 2019 Linaro
|
|
#
|
|
# Author: Alex Bennée <alex.bennee@linaro.org>
|
|
#
|
|
# This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
# See the COPYING file in the top-level directory.
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
import argparse
|
|
import subprocess
|
|
import shutil
|
|
import shlex
|
|
import os
|
|
from time import sleep
|
|
from tempfile import TemporaryDirectory
|
|
|
|
def get_args():
|
|
parser = argparse.ArgumentParser(description="A gdbstub test runner")
|
|
parser.add_argument("--qemu", help="Qemu binary for test",
|
|
required=True)
|
|
parser.add_argument("--qargs", help="Qemu arguments for test")
|
|
parser.add_argument("--binary", help="Binary to debug",
|
|
required=True)
|
|
parser.add_argument("--test", help="GDB test script")
|
|
parser.add_argument("--gdb", help="The gdb binary to use",
|
|
default=None)
|
|
parser.add_argument("--gdb-args", help="Additional gdb arguments")
|
|
parser.add_argument("--output", help="A file to redirect output to")
|
|
parser.add_argument("--stderr", help="A file to redirect stderr to")
|
|
|
|
return parser.parse_args()
|
|
|
|
|
|
def log(output, msg):
|
|
if output:
|
|
output.write(msg + "\n")
|
|
output.flush()
|
|
else:
|
|
print(msg)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
args = get_args()
|
|
|
|
# Search for a gdb we can use
|
|
if not args.gdb:
|
|
args.gdb = shutil.which("gdb-multiarch")
|
|
if not args.gdb:
|
|
args.gdb = shutil.which("gdb")
|
|
if not args.gdb:
|
|
print("We need gdb to run the test")
|
|
exit(-1)
|
|
if args.output:
|
|
output = open(args.output, "w")
|
|
else:
|
|
output = None
|
|
if args.stderr:
|
|
stderr = open(args.stderr, "w")
|
|
else:
|
|
stderr = None
|
|
|
|
socket_dir = TemporaryDirectory("qemu-gdbstub")
|
|
socket_name = os.path.join(socket_dir.name, "gdbstub.socket")
|
|
|
|
# Launch QEMU with binary
|
|
if "system" in args.qemu:
|
|
cmd = "%s %s %s -gdb unix:path=%s,server=on" % (args.qemu,
|
|
args.qargs,
|
|
args.binary,
|
|
socket_name)
|
|
else:
|
|
cmd = "%s %s -g %s %s" % (args.qemu, args.qargs, socket_name,
|
|
args.binary)
|
|
|
|
log(output, "QEMU CMD: %s" % (cmd))
|
|
inferior = subprocess.Popen(shlex.split(cmd))
|
|
|
|
# Now launch gdb with our test and collect the result
|
|
gdb_cmd = "%s %s" % (args.gdb, args.binary)
|
|
if args.gdb_args:
|
|
gdb_cmd += " %s" % (args.gdb_args)
|
|
# run quietly and ignore .gdbinit
|
|
gdb_cmd += " -q -n -batch"
|
|
# disable prompts in case of crash
|
|
gdb_cmd += " -ex 'set confirm off'"
|
|
# connect to remote
|
|
gdb_cmd += " -ex 'target remote %s'" % (socket_name)
|
|
# finally the test script itself
|
|
if args.test:
|
|
gdb_cmd += " -x %s" % (args.test)
|
|
|
|
|
|
sleep(1)
|
|
log(output, "GDB CMD: %s" % (gdb_cmd))
|
|
|
|
result = subprocess.call(gdb_cmd, shell=True, stdout=output, stderr=stderr)
|
|
|
|
# A result of greater than 128 indicates a fatal signal (likely a
|
|
# crash due to gdb internal failure). That's a problem for GDB and
|
|
# not the test so we force a return of 0 so we don't fail the test on
|
|
# account of broken external tools.
|
|
if result > 128:
|
|
log(output, "GDB crashed? (%d, %d) SKIPPING" % (result, result - 128))
|
|
exit(0)
|
|
|
|
try:
|
|
inferior.wait(2)
|
|
except subprocess.TimeoutExpired:
|
|
log(output, "GDB never connected? Killed guest")
|
|
inferior.kill()
|
|
|
|
exit(result)
|