Peter Maydell e0784d8375 hw/net/can/ctucan: Avoid unused value in ctucan_send_ready_buffers() ... Coverity points out that in ctucan_send_ready_buffers() we set buff_st_mask = 0xf << (i * 4) inside the loop, but then we never use it before overwriting it later. The only thing we use the mask for is as part of the code that is inserting the new buff_st field into tx_status. That is more comprehensibly written using deposit32(), so do that and drop the mask variable entirely. We also update the buff_st local variable at multiple points during this function, but nothing can ever see these intermediate values, so just drop those, write the final TXT_TOK as a fixed constant value, and collapse the only remaining set/use of buff_st down into an extract32(). Fixes: Coverity CID 1432869 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz> Tested-by: Pavel Pisa <pisa@cmp.felk.cvut.cz> Signed-off-by: Jason Wang <jasowang@redhat.com>		2020-11-11 20:34:36 +08:00
..
can	hw/net/can/ctucan: Avoid unused value in ctucan_send_ready_buffers()	2020-11-11 20:34:36 +08:00
fsl_etsec	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
rocker	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
allwinner_emac.c	hw/net: Make NetCanReceive() return a boolean	2020-03-31 21:14:35 +08:00
allwinner-sun8i-emac.c	hw/net/allwinner-sun8i-emac: Use AddressSpace for DMA transfers	2020-08-28 10:02:45 +01:00
cadence_gem.c	hw/arm: xlnx: Set all boards' GEM 'phy-addr' property value to 23	2020-09-09 15:54:18 -07:00
dp8393x.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
e1000_regs.h	e1000: Rename the SEC symbol to SEQEC	2017-09-08 08:17:37 +08:00
e1000.c	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
e1000e_core.c	hw/net/e1000e: Remove duplicated write handler for FLSWDATA register	2020-09-10 16:20:49 +02:00
e1000e_core.h	hw/net/e1000e_core: Let e1000e_can_receive() return a boolean	2020-03-31 21:14:35 +08:00
e1000e.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
e1000x_common.c	Include hw/hw.h exactly where needed	2019-08-16 13:31:52 +02:00
e1000x_common.h	Supply missing header guards	2019-06-12 13:20:21 +02:00
eepro100.c	Drop more @errp parameters after previous commit	2020-05-15 07:08:14 +02:00
etraxfs_eth.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
ftgmac100.c	ftgmac100: Improve software reset	2020-09-01 14:21:50 +02:00
i82596.c	hw/net: Make NetCanReceive() return a boolean	2020-03-31 21:14:35 +08:00
i82596.h	hw/net: Make NetCanReceive() return a boolean	2020-03-31 21:14:35 +08:00
imx_fec.c	Add a phy-num property to the i.MX FEC emulator	2020-07-03 16:59:41 +01:00
Kconfig	hw/net/can: Correct Kconfig dependencies	2020-09-30 19:11:37 +02:00
lan9118.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
lance.c	Drop more @errp parameters after previous commit	2020-05-15 07:08:14 +02:00
lasi_i82596.c	sysbus: Convert to sysbus_realize() etc. with Coccinelle	2020-06-15 22:05:28 +02:00
mcf_fec.c	mcf_fec: Move mcf_fec_state typedef to header	2020-08-27 14:04:54 -04:00
meson.build	meson: convert hw/net	2020-08-21 06:30:29 -04:00
milkymist-minimac2.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
mipsnet.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
msf2-emac.c	hw/net: Add Smartfusion2 emac block	2020-04-30 11:52:28 +01:00
ne2000-isa.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
ne2000-pci.c	Drop more @errp parameters after previous commit	2020-05-15 07:08:14 +02:00
ne2000.c	Clean up inclusion of sysemu/sysemu.h	2019-08-16 13:31:53 +02:00
ne2000.h	Include hw/hw.h exactly where needed	2019-08-16 13:31:52 +02:00
net_rx_pkt.c	NetRxPkt: fix hash calculation of IPV6 TCP	2020-03-03 18:04:47 +08:00
net_rx_pkt.h	NetRxPkt: Introduce support for additional hash types	2020-03-03 18:04:47 +08:00
net_tx_pkt.c	hw/net/net_tx_pkt: fix assertion failure in net_tx_pkt_add_raw_fragment()	2020-08-04 14:14:48 +08:00
net_tx_pkt.h	hw/net: Added plen fix for IPv6	2020-07-21 21:30:39 +08:00
opencores_eth.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
pcnet-pci.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
pcnet.c	Clean up inclusion of sysemu/sysemu.h	2019-08-16 13:31:53 +02:00
pcnet.h	lance: replace PROP_PTR with PROP_LINK	2020-01-07 17:24:29 +04:00
rtl8139.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
smc91c111.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
spapr_llan.c	hw/net: move allocation to the heap due to very large stack frame	2020-10-28 01:08:53 +11:00
stellaris_enet.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
sungem.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
sunhme.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
trace-events	Add a phy-num property to the i.MX FEC emulator	2020-07-03 16:59:41 +01:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00
tulip.c	tulip: Move TulipState typedef to header	2020-08-27 14:04:54 -04:00
tulip.h	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
vhost_net-stub.c	vhost_net: introduce set_config & get_config	2020-07-03 07:57:04 -04:00
vhost_net.c	vhost-vdpa: introduce vhost-vdpa backend	2020-07-07 07:59:51 -04:00
virtio-net.c	virtio-net: Set mac address to hardware if the peer is vdpa	2020-11-11 16:52:23 +08:00
vmware_utils.h	hw/net/vmxnet3: Fix code to work on big endian hosts, too	2017-11-20 11:08:00 +08:00
vmxnet3_defs.h	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
vmxnet3.c	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
vmxnet3.h	hw/net/vmxnet3: Fix code to work on big endian hosts, too	2017-11-20 11:08:00 +08:00
vmxnet_debug.h	Clean up ill-advised or unusual header guards	2016-07-12 16:20:46 +02:00
xen_nic.c	Include hw/hw.h exactly where needed	2019-08-16 13:31:52 +02:00
xgmac.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
xilinx_axienet.c	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
xilinx_ethlite.c	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00