Daniel P. Berrangé b4682a63f8 filemon: fix watch IDs to avoid potential wraparound issues ... Watch IDs are allocated from incrementing a int counter against the QFileMonitor object. In very long life QEMU processes with a huge amount of USB MTP activity creating & deleting directories it is just about conceivable that the int counter can wrap around. This would result in incorrect behaviour of the file monitor watch APIs due to clashing watch IDs. Instead of trying to detect this situation, this patch changes the way watch IDs are allocated. It is turned into an int64_t variable where the high 32 bits are set from the underlying inotify "int" ID. This gives an ID that is guaranteed unique for the directory as a whole, and we can rely on the kernel to enforce this. QFileMonitor then sets the low 32 bits from a per-directory counter. The USB MTP device only sets watches on the directory as a whole, not files within, so there is no risk of guest triggered wrap around on the low 32 bits. Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>		2019-04-02 13:52:02 +01:00
..
aio-posix.c	aio-posix: Assert that aio_poll() is always called in home thread	2019-02-25 15:03:19 +01:00
aio-wait.c	block: Use a single global AioWait	2018-09-25 15:50:15 +02:00
aio-win32.c	aio-posix: Fix concurrent aio_poll/set_fd_handler.	2019-01-14 14:09:41 +00:00
aiocb.c	block: move AioContext, QEMUTimer, main-loop to libqemuutil	2017-02-21 11:14:07 +00:00
async.c	util/async: use qemu_aio_coroutine_enter in co_schedule_bh_cb	2018-09-25 15:50:15 +02:00
atomic64.c	util: add atomic64	2018-10-02 18:47:55 +02:00
base64.c	include/qemu/osdep.h: Don't include qapi/error.h	2016-03-22 22:20:15 +01:00
bitmap.c	bitmap: provide to_le/from_le helpers	2017-09-22 14:11:25 +02:00
bitops.c	avoid TABs in files that only contain a few	2019-01-11 15:46:56 +01:00
buffer.c	qemu-common: stop including qemu/host-utils.h from qemu-common.h	2016-05-19 16:42:28 +02:00
bufferiszero.c	util: Introduce include/qemu/cpuid.h	2017-07-24 12:42:55 +01:00
cacheinfo.c	util: add atomic64	2018-10-02 18:47:55 +02:00
compatfd.c	cpus: remove ugly cast on sigbus_handler	2017-03-03 16:40:02 +01:00
coroutine-sigaltstack.c	coroutine-sigaltstack: use helper for allocating stack memory	2016-09-29 14:13:39 +02:00
coroutine-ucontext.c	build: try improve handling of clang warnings	2018-03-12 08:59:03 +01:00
coroutine-win32.c	coroutine: add a macro for the coroutine stack size	2016-09-29 14:13:39 +02:00
crc32c.c	util: Clean up includes	2016-02-04 17:01:04 +00:00
cutils.c	cutils: Fix qemu_strtosz() & friends to reject non-finite sizes	2018-12-13 19:10:06 +01:00
drm.c	util: promote qemu_egl_rendernode_open() to libqemuutil	2018-08-27 10:51:44 +02:00
envlist.c	util: Use g_malloc/g_free in envlist.c	2017-05-07 09:57:51 +03:00
error.c	util/error: Remove an unnecessary NULL check	2019-03-26 08:10:11 +01:00
event_notifier-posix.c	Revert "qemu: add a cleanup callback function to EventNotifier"	2018-01-24 19:20:19 +02:00
event_notifier-win32.c	Revert "qemu: add a cleanup callback function to EventNotifier"	2018-01-24 19:20:19 +02:00
fifo8.c	migration: consolidate VMStateField.start	2017-02-13 17:27:13 +00:00
filemonitor-inotify.c	filemon: fix watch IDs to avoid potential wraparound issues	2019-04-02 13:52:02 +01:00
filemonitor-stub.c	filemon: fix watch IDs to avoid potential wraparound issues	2019-04-02 13:52:02 +01:00
getauxval.c	util: Clean up includes	2016-02-04 17:01:04 +00:00
hbitmap.c	Revert "hbitmap: Add @advance param to hbitmap_iter_next()"	2019-01-15 18:26:50 -05:00
hexdump.c	util: Improved qemu_hexmap() to include an ascii dump of the buffer	2016-04-06 09:52:07 +08:00
host-utils.c	host-utils: Implement unsigned quadword left/right shift and unit tests	2017-01-31 10:10:14 +11:00
id.c	util: move declarations out of qemu-common.h	2016-03-22 22:20:17 +01:00
iohandler.c	block: move AioContext, QEMUTimer, main-loop to libqemuutil	2017-02-21 11:14:07 +00:00
iov.c	util: Fix assertion in iov_copy() upon zero 'bytes' and non-zero 'offset'	2016-08-03 18:44:57 +02:00
iova-tree.c	util: remove redundant include of glib.h and add osdep.h	2018-06-29 12:22:28 +01:00
keyval.c	qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF	2018-05-04 08:27:53 +02:00
lockcnt.c	qemu-thread: optimize QemuLockCnt with futexes on Linux	2017-01-16 13:25:18 +00:00
log.c	tcg: Optionally log FPU state in TCG -d cpu logging	2018-05-15 14:58:44 +01:00
main-loop.c	slirp: move sources to src/ subdirectory	2019-03-07 12:46:31 +01:00
Makefile.objs	build-sys: link with slirp as an external project	2019-03-07 12:46:31 +01:00
memfd.c	memfd: improve error messages	2019-03-11 17:17:01 -03:00
mmap-alloc.c	mmap-alloc: fix hugetlbfs misaligned length in ppc64	2019-02-04 18:44:20 +11:00
module.c	module: Use QEMU_MODULE_DIR as a search path	2018-08-23 18:46:25 +02:00
notify.c	util: Clean up includes	2016-02-04 17:01:04 +00:00
osdep.c	slirp: prefer c99 types over BSD kind	2019-02-07 15:49:08 +02:00
oslib-posix.c	Machine queue, 2019-03-11	2019-03-12 15:25:46 +00:00
oslib-win32.c	hostmem-file: reject invalid pmem file sizes	2019-03-11 10:44:19 -03:00
pagesize.c	util: move qemu_real_host_page_size/mask to osdep.h	2017-10-10 09:45:00 -07:00
path.c	util: Removed unneeded header from path.c	2017-03-14 13:26:37 +01:00
qdist.c	qdist: return "(empty)" instead of NULL when printing an empty dist	2016-08-03 18:44:56 +02:00
qemu-config.c	block: Add block-specific QDict header	2018-06-15 14:49:44 +02:00
qemu-coroutine-io.c	coroutine: move entry argument to qemu_coroutine_create	2016-07-13 13:26:02 +02:00
qemu-coroutine-lock.c	coroutine: avoid co_queue_wakeup recursion	2018-03-27 13:05:28 +01:00
qemu-coroutine-sleep.c	qemu-coroutine-sleep: drop CoSleepCB	2019-01-24 10:05:16 +00:00
qemu-coroutine.c	block: Add missing locking in bdrv_co_drain_bh_cb()	2018-09-25 15:50:15 +02:00
qemu-error.c	error: Drop bogus "use error_setg() instead" admonitions	2018-10-19 15:47:09 +02:00
qemu-openpty.c	util: Clean up includes	2016-02-04 17:01:04 +00:00
qemu-option.c	qemu/queue.h: simplify reverse access to QTAILQ	2019-01-11 15:46:55 +01:00
qemu-progress.c	progress: Show current progress on SIGINFO	2017-04-28 18:48:11 +02:00
qemu-sockets.c	avoid TABs in files that only contain a few	2019-01-11 15:46:56 +01:00
qemu-thread-common.h	Clean up includes	2018-12-20 10:29:08 +01:00
qemu-thread-posix.c	qemu-thread: Don't block SEGV, ILL and FPE	2019-01-08 12:34:46 +00:00
qemu-thread-win32.c	build-sys: build with Vista API by default	2019-01-11 13:57:25 +01:00
qemu-timer-common.c	util: Clean up includes	2016-02-04 17:01:04 +00:00
qemu-timer.c	qemu-timer: avoid checkpoints for virtual clock timers in external subsystems	2018-10-19 13:44:03 +02:00
qht.c	qht: constify arguments to some internal functions	2018-09-26 08:55:54 -07:00
qsp.c	include: move exec/tb-hash-xx.h to qemu/xxhash.h	2018-12-17 06:04:44 +03:00
range.c	Don't talk about the LGPL if the file is licensed under the GPL	2019-01-30 10:51:20 +01:00
rcu.c	membarrier: introduce qemu/sys_membarrier.h	2018-03-12 16:12:47 +01:00
readline.c	readline: don't free completions in readline_free()	2018-02-05 13:54:39 +01:00
stats64.c	util/stats64: Fix min/max comparisons	2017-11-15 09:34:51 +01:00
sys_membarrier.c	sys_membarrier: fix up include directives	2018-04-05 14:37:38 +02:00
systemd.c	qemu-ga: obey LISTEN_PID when using systemd socket activation	2017-03-19 11:12:12 +01:00
thread-pool.c	thread-pool: add missing qemu_bh_cancel in completion function	2017-03-17 12:54:21 +01:00
throttle.c	throttle: Assert that bkt->max is valid in throttle_compute_wait()	2017-09-26 14:46:23 +02:00
timed-average.c	Fix some typos found by codespell	2016-05-18 15:04:27 +03:00
trace-events	filemon: fix watch IDs to avoid potential wraparound issues	2019-04-02 13:52:02 +01:00
unicode.c	json: Reject invalid UTF-8 sequences	2018-08-24 20:26:37 +02:00
uri.c	cutils: Provide strchrnul	2018-06-29 12:32:10 +02:00
uuid.c	uuid: Make qemu_uuid_bswap() take and return a QemuUUID	2019-02-01 13:46:45 +01:00
vfio-helpers.c	exec: Change RAMBlockIterFunc definition	2019-03-06 10:49:17 +00:00