mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
d8e44802f8
qemu/util
History
Markus Armbruster 8277d2aa58 error: New error_prepend(), error_reportf_err() 
Instead of simply propagating an error verbatim, we sometimes want to
add to its message, like this:

    frobnicate(arg, &err);
    error_setg(errp, "Can't frobnicate %s: %s",
                     arg, error_get_pretty(err));
    error_free(err);

This is suboptimal, because it loses err's hint (if any).  Moreover,
when errp is &error_abort or is subsequently propagated to
&error_abort, the abort message points to the place where we last
added to the error, not to the place where it originated.

To avoid these issues, provide means to add to an error's message in
place:

    frobnicate(arg, errp);
    error_prepend(errp, "Can't frobnicate %s: ", arg);

Likewise, reporting an error like

    frobnicate(arg, &err);
    error_report("Can't frobnicate %s: %s", arg, error_get_pretty(err));

can lose err's hint.  To avoid:

    error_reportf_err(err, "Can't frobnicate %s: ", arg);

The next commits will put these functions to use.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1450452927-8346-10-git-send-email-armbru@redhat.com>
2016-01-13 15:16:17 +01:00
..
acl.c acl: fix memory leak 2014-11-17 11:48:56 +01:00
base64.c util: add base64 decoding function 2015-12-18 16:25:08 +00:00
bitmap.c maint: remove / fix many doubled words 2015-09-11 10:21:38 +03:00
bitops.c
buffer.c buffer: allow a buffer to shrink gracefully 2015-11-05 09:09:58 +01:00
compatfd.c util: Remove unused functions 2015-04-30 16:05:48 +03:00
coroutine-gthread.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
coroutine-sigaltstack.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
coroutine-ucontext.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
coroutine-win32.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
crc32c.c qemu: add castagnoli crc32c checksum algorithm 2013-05-03 10:31:58 +02:00
cutils.c utils: rename strtosz to use qemu prefix 2015-09-25 12:04:41 +02:00
envlist.c utils: drop strtok_r from envlist_parse 2015-02-16 16:20:02 -06:00
error.c error: New error_prepend(), error_reportf_err() 2016-01-13 15:16:17 +01:00
event_notifier-posix.c util: const event_notifier_get_fd() argument 2015-10-24 18:02:49 +02:00
event_notifier-win32.c
fifo8.c savevm: Remove all the unneeded version_minimum_id_old (arm) 2014-05-13 16:09:35 +01:00
getauxval.c util: Move general qemu_getauxval to util/getauxval.c 2014-09-09 13:13:05 +02:00
hbitmap.c util/hbitmap: Add an API to reset all set bits in hbitmap 2015-06-23 15:06:16 +01:00
hexdump.c Rename hexdump to avoid FreeBSD libutil conflict 2013-05-20 08:20:08 -05:00
host-utils.c util: Don't link host-utils.o if it's empty 2014-09-09 13:13:05 +02:00
id.c util/id: fully allocate names table 2015-12-04 09:39:55 +03:00
iov.c iov: don't touch iov in iov_send_recv() 2015-06-23 16:05:34 +01:00
Makefile.objs util: add base64 decoding function 2015-12-18 16:25:08 +00:00
memfd.c vhost: add migration block if memfd failed 2015-10-22 14:34:49 +03:00
mmap-alloc.c mmap-alloc: tweak a comment on ppc64 2015-12-22 17:45:12 +02:00
module.c module: Don't complain when a module is absent 2014-07-18 14:57:35 +02:00
notify.c notify: add NotiferWithReturn so notifier list can abort 2013-06-28 09:20:26 +02:00
osdep.c osdep: Change default value of qemu_hw_version() to "2.5+" 2015-11-25 13:42:37 +02:00
oslib-posix.c util/mmap-alloc: fix hugetlb support on ppc64 2015-12-02 22:38:23 +02:00
oslib-win32.c oslib-win32: Change return type of function getpagesize 2015-11-30 06:47:02 +01:00
path.c util/path: Use the GLib memory allocation routines 2014-08-24 13:16:32 +04:00
qemu-config.c util/qemu-config: fix missing machine command line options 2015-10-20 16:21:00 +02:00
qemu-coroutine-io.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-coroutine-lock.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-coroutine-sleep.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-coroutine.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-error.c error: Improve documentation 2016-01-13 15:16:16 +01:00
qemu-openpty.c util/qemu-openpty: fix build with musl libc by include termios.h as fallback 2014-06-11 00:25:06 +01:00
qemu-option.c error: Don't append a newline when printing the error hint 2016-01-13 11:58:58 +01:00
qemu-progress.c progress: Allow regressing progress 2015-12-18 14:34:43 +01:00
qemu-sockets.c io: add QIOChannelSocket class 2015-12-18 12:18:31 +00:00
qemu-thread-posix.c * Support for jemalloc 2015-09-14 16:13:16 +01:00
qemu-thread-win32.c qemu-thread: add a fast path to the Win32 QemuEvent 2015-09-24 20:52:28 +02:00
qemu-timer-common.c Allow clock_gettime() monotonic clock to be utilized on more OS's 2013-04-04 20:22:45 -05:00
rcu.c Revert "rcu: init rcu_registry_lock after fork" 2015-09-16 17:33:32 +02:00
readline.c readline: Clear screen on form feed. 2014-06-11 10:10:29 -04:00
rfifolock.c rfifolock: add recursive FIFO lock 2014-03-13 14:42:21 +01:00
throttle.c throttle: refuse bps_max/iops_max without bps/iops 2015-08-05 12:53:48 +01:00
timed-average.c block: Add average I/O queue depth to BlockDeviceTimedStats 2015-11-12 16:22:46 +01:00
unicode.c unicode: New mod_utf8_codepoint() 2013-04-13 19:39:59 +00:00
uri.c util/uri: Add overflow check to rfc3986_parse_port 2015-03-18 12:05:31 +01:00