9405d87be2
QEMU currently crashes when the user tries to do something like: qemu-system-x86_64 -M x-remote -device piix3-ide This happens because the "isabus" variable is not initialized with the x-remote machine yet. Add a proper check for this condition and propagate the error to the caller, so we can fail there gracefully. Message-Id: <20210416125256.2039734-1-thuth@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
69 lines
2.5 KiB
C
69 lines
2.5 KiB
C
/*
|
|
* QEMU IDE disk and CD/DVD-ROM Emulator
|
|
*
|
|
* Copyright (c) 2003 Fabrice Bellard
|
|
* Copyright (c) 2006 Openedhand Ltd.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/isa/isa.h"
|
|
#include "qemu/error-report.h"
|
|
#include "qemu/timer.h"
|
|
#include "sysemu/blockdev.h"
|
|
#include "sysemu/dma.h"
|
|
#include "hw/block/block.h"
|
|
#include "sysemu/block-backend.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/cutils.h"
|
|
#include "sysemu/replay.h"
|
|
|
|
#include "hw/ide/internal.h"
|
|
#include "trace.h"
|
|
|
|
static const MemoryRegionPortio ide_portio_list[] = {
|
|
{ 0, 8, 1, .read = ide_ioport_read, .write = ide_ioport_write },
|
|
{ 0, 1, 2, .read = ide_data_readw, .write = ide_data_writew },
|
|
{ 0, 1, 4, .read = ide_data_readl, .write = ide_data_writel },
|
|
PORTIO_END_OF_LIST(),
|
|
};
|
|
|
|
static const MemoryRegionPortio ide_portio2_list[] = {
|
|
{ 0, 1, 1, .read = ide_status_read, .write = ide_ctrl_write },
|
|
PORTIO_END_OF_LIST(),
|
|
};
|
|
|
|
int ide_init_ioport(IDEBus *bus, ISADevice *dev, int iobase, int iobase2)
|
|
{
|
|
int ret;
|
|
|
|
/* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
|
|
bridge has been setup properly to always register with ISA. */
|
|
ret = isa_register_portio_list(dev, &bus->portio_list,
|
|
iobase, ide_portio_list, bus, "ide");
|
|
|
|
if (ret == 0 && iobase2) {
|
|
ret = isa_register_portio_list(dev, &bus->portio2_list,
|
|
iobase2, ide_portio2_list, bus, "ide");
|
|
}
|
|
|
|
return ret;
|
|
}
|