qemu/hw/m68k
Thomas Huth cd4fc14207 hw/m68k/next-cube: Avoid static RTC variables and introduce control register
Coverity currently complains that the "if (0x00 & (0x80 >> (phase - 8))"
in next-cube.c can never be true. Right it is. The "0x00" is meant as value
of the control register of the RTC, which is currently not implemented yet.
Thus, let's add a register variable for this now. However, the RTC
registers are currently defined as static variables in nextscr2_write(),
which is quite ugly. Thus let's also move the RTC variables to the main
machine state instead. In the long run, we should likely even refactor
the whole RTC code into a separate device in a separate file, but that's
something for calm winter nights later... as a first step, cleaning up
the static variables and shutting up the warning from Coverity should
be sufficient.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20190921091738.26953-1-huth@tuxfamily.org>
Signed-off-by: Thomas Huth <huth@tuxfamily.org>
2019-10-01 11:42:27 +02:00
..
an5206.c Include hw/hw.h exactly where needed 2019-08-16 13:31:52 +02:00
Kconfig m68k: Add serial controller to the NeXTcube machine 2019-09-07 08:32:34 +02:00
Makefile.objs m68k: Add NeXTcube machine 2019-09-07 08:31:51 +02:00
mcf5206.c Include qemu/main-loop.h less 2019-08-16 13:31:52 +02:00
mcf5208.c Include qemu/main-loop.h less 2019-08-16 13:31:52 +02:00
mcf_intc.c Include hw/irq.h a lot less 2019-08-16 13:31:52 +02:00
next-cube.c hw/m68k/next-cube: Avoid static RTC variables and introduce control register 2019-10-01 11:42:27 +02:00
next-kbd.c m68k: Add NeXTcube keyboard device 2019-09-07 08:31:33 +02:00