c8389550de
This compat property sole function is to prevent the device from being instantiated. Instead of requiring an extra compat property, check if fw_cfg has DMA enabled. fw_cfg is a built-in device that is initialized very early by the machine init code. We have at least one other device that also assumes fw_cfg_find() can be safely used on realize: pvpanic. This has the additional benefit of handling other cases properly, like: $ qemu-system-x86_64 -device vmgenid -machine none qemu-system-x86_64: -device vmgenid: vmgenid requires DMA write support in fw_cfg, which this machine type does not provide $ qemu-system-x86_64 -device vmgenid -machine pc-i440fx-2.9 -global fw_cfg.dma_enabled=off qemu-system-x86_64: -device vmgenid: vmgenid requires DMA write support in fw_cfg, which this machine type does not provide $ qemu-system-x86_64 -device vmgenid -machine pc-i440fx-2.6 -global fw_cfg.dma_enabled=on [boots normally] Suggested-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Ben Warren <ben@skyportsystems.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
37 lines
1.2 KiB
C
37 lines
1.2 KiB
C
#ifndef ACPI_VMGENID_H
|
|
#define ACPI_VMGENID_H
|
|
|
|
#include "hw/acpi/bios-linker-loader.h"
|
|
#include "hw/qdev.h"
|
|
#include "qemu/uuid.h"
|
|
|
|
#define VMGENID_DEVICE "vmgenid"
|
|
#define VMGENID_GUID "guid"
|
|
#define VMGENID_GUID_FW_CFG_FILE "etc/vmgenid_guid"
|
|
#define VMGENID_ADDR_FW_CFG_FILE "etc/vmgenid_addr"
|
|
|
|
#define VMGENID_FW_CFG_SIZE 4096 /* Occupy a page of memory */
|
|
#define VMGENID_GUID_OFFSET 40 /* allow space for
|
|
* OVMF SDT Header Probe Supressor
|
|
*/
|
|
|
|
#define VMGENID(obj) OBJECT_CHECK(VmGenIdState, (obj), VMGENID_DEVICE)
|
|
|
|
typedef struct VmGenIdState {
|
|
DeviceClass parent_obj;
|
|
QemuUUID guid; /* The 128-bit GUID seen by the guest */
|
|
uint8_t vmgenid_addr_le[8]; /* Address of the GUID (little-endian) */
|
|
} VmGenIdState;
|
|
|
|
/* returns NULL unless there is exactly one device */
|
|
static inline Object *find_vmgenid_dev(void)
|
|
{
|
|
return object_resolve_path_type("", VMGENID_DEVICE, NULL);
|
|
}
|
|
|
|
void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *guid,
|
|
BIOSLinker *linker);
|
|
void vmgenid_add_fw_cfg(VmGenIdState *vms, FWCfgState *s, GArray *guid);
|
|
|
|
#endif
|