Kevin Wolf c81219a7dd monitor: Fix assertion failure on shutdown ... Commit 357bda95 already tried to fix the order in monitor_cleanup() by moving shutdown of the dispatcher coroutine further to the start. However, it didn't go far enough: iothread_stop() makes sure that all pending work (bottom halves) in the AioContext of the monitor iothread is completed. iothread_destroy() depends on this and fails an assertion if there is still a pending BH. While the dispatcher coroutine is running, it will try to resume the monitor after taking a request out of the queue, which involves a BH. The dispatcher is run until it terminates in the AIO_WAIT_WHILE() loop. However, adding new BHs between iothread_stop() and iothread_destroy() is forbidden. Fix this by stopping the dispatcher first before shutting down the other parts of the monitor. This means we can now receive requests that aren't handled any more when QEMU is shutting down, but this is unlikely to be a problem for QMP clients. Fixes: 357bda9590 Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-Id: <20210212172028.288825-2-kwolf@redhat.com> Tested-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2021-02-15 15:10:14 +01:00
..
hmp-cmds.c	migration: introduce a delete_snapshot wrapper	2021-02-08 11:19:51 +00:00
hmp.c	machine: introduce MachineInitPhase	2020-12-15 12:51:52 -05:00
meson.build	meson: add spice_headers dependency.	2020-10-15 11:14:40 +02:00
misc.c	remove TCG includes from common code	2021-01-02 21:03:36 +01:00
monitor-internal.h	monitor: Use GString instead of QString for output buffer	2020-12-19 10:38:35 +01:00
monitor.c	monitor: Fix assertion failure on shutdown	2021-02-15 15:10:14 +01:00
qmp-cmds-control.c	qapi: A couple more QAPI_LIST_PREPEND() stragglers	2021-01-28 08:08:45 +01:00
qmp-cmds.c	monitor/qmp-cmds.c: Don't include ui/vnc.h	2021-02-04 13:20:28 +01:00
qmp.c	qmp: Resume OOB-enabled monitor before processing the request	2021-02-04 13:20:29 +01:00
trace-events	qmp: Add more tracepoints	2021-02-04 13:20:29 +01:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00