e88a856efd
The documentation says:
SUBV Rm, Rn Rn - Rm -> Rn, underflow -> T
The overflow / underflow can be calculated as:
T = ((Rn ^ Rm) & (Result ^ Rn)) >> 31
However we were using the incorrect:
T = ((Rn ^ Rm) & (Result ^ Rm)) >> 31
Fix by using the Rn register instead of Rm.
Add tests provided by Paul Cercueil.
Cc: qemu-stable@nongnu.org
Fixes: ad8d25a11f ("target-sh4: implement addv and subv using TCG")
Reported-by: Paul Cercueil <paul@crapouillou.net>
Suggested-by: Paul Cercueil <paul@crapouillou.net>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2318
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20240430163125.77430-3-philmd@linaro.org>
26 lines
519 B
Makefile
26 lines
519 B
Makefile
# -*- Mode: makefile -*-
|
|
#
|
|
# SuperH specific tweaks
|
|
#
|
|
|
|
# This triggers failures for sh4-linux about 10% of the time.
|
|
# Random SIGSEGV at unpredictable guest address, cause unknown.
|
|
run-signals: signals
|
|
$(call skip-test, $<, "BROKEN")
|
|
run-plugin-signals-with-%:
|
|
$(call skip-test, $<, "BROKEN")
|
|
|
|
VPATH += $(SRC_PATH)/tests/tcg/sh4
|
|
|
|
test-macl: CFLAGS += -O -g
|
|
TESTS += test-macl
|
|
|
|
test-macw: CFLAGS += -O -g
|
|
TESTS += test-macw
|
|
|
|
test-addv: CFLAGS += -O -g
|
|
TESTS += test-addv
|
|
|
|
test-subv: CFLAGS += -O -g
|
|
TESTS += test-subv
|