qemu/net
Eric Blake 7fb1cf1606 qapi: Don't let implicit enum MAX member collide
Now that we guarantee the user doesn't have any enum values
beginning with a single underscore, we can use that for our
own purposes.  Renaming ENUM_MAX to ENUM__MAX makes it obvious
that the sentinel is generated.

This patch was mostly generated by applying a temporary patch:

|diff --git a/scripts/qapi.py b/scripts/qapi.py
|index e6d014b..b862ec9 100644
|--- a/scripts/qapi.py
|+++ b/scripts/qapi.py
|@@ -1570,6 +1570,7 @@ const char *const %(c_name)s_lookup[] = {
|     max_index = c_enum_const(name, 'MAX', prefix)
|     ret += mcgen('''
|     [%(max_index)s] = NULL,
|+// %(max_index)s
| };
| ''',
|                max_index=max_index)

then running:

$ cat qapi-{types,event}.c tests/test-qapi-types.c |
    sed -n 's,^// \(.*\)MAX,s|\1MAX|\1_MAX|g,p' > list
$ git grep -l _MAX | xargs sed -i -f list

The only things not generated are the changes in scripts/qapi.py.

Rejecting enum members named 'MAX' is now useless, and will be dropped
in the next patch.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1447836791-369-23-git-send-email-eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
[Rebased to current master, commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2015-12-17 08:21:28 +01:00
..
checksum.c net: iovec checksum calculator 2013-03-25 11:13:10 +01:00
clients.h net: Permit incremental conversion of init functions to Error 2015-05-27 09:51:04 +01:00
dump.c net: Convert to new qapi union layout 2015-11-02 08:30:27 +01:00
eth.c misc: Use g_assert_not_reached for code which is expected to be unreachable 2013-07-27 11:22:54 +04:00
filter-buffer.c netfilter: add a netbuffer filter 2015-10-12 13:31:28 +08:00
filter.c net: Convert net filter code to use object property iterators 2015-11-18 21:13:49 +01:00
hub.c net: Convert to new qapi union layout 2015-11-02 08:30:27 +01:00
hub.h net: fix qemu_flush_queued_packets() in presence of a hub 2013-02-27 16:10:23 +01:00
l2tpv3.c net: Convert to new qapi union layout 2015-11-02 08:30:27 +01:00
Makefile.objs netfilter: add a netbuffer filter 2015-10-12 13:31:28 +08:00
net.c qapi: Don't let implicit enum MAX member collide 2015-12-17 08:21:28 +01:00
netmap.c net: netmap: use error_setg() helpers in place of error_report() 2015-11-12 15:31:52 +08:00
queue.c net/queue: export qemu_net_queue_append_iov 2015-10-12 13:31:18 +08:00
slirp.c net: Convert to new qapi union layout 2015-11-02 08:30:27 +01:00
socket.c net: Convert to new qapi union layout 2015-11-02 08:30:27 +01:00
tap_int.h tap: add VNET_LE/VNET_BE operations 2015-06-17 17:12:54 +02:00
tap-aix.c tap: fix non-linux build 2015-06-19 12:17:25 +02:00
tap-bsd.c tap-bsd: use user-specified tap device if it already exists 2015-11-06 15:42:38 +03:00
tap-haiku.c tap: fix non-linux build 2015-06-19 12:17:25 +02:00
tap-linux.c trivial: remove trailing newline from error_report 2015-09-11 10:21:38 +03:00
tap-linux.h tap: add VNET_LE/VNET_BE operations 2015-06-17 17:12:54 +02:00
tap-solaris.c tap: fix non-linux build 2015-06-19 12:17:25 +02:00
tap-win32.c tap-win32: disable broken async write path 2015-11-27 10:39:55 +08:00
tap.c net: Convert to new qapi union layout 2015-11-02 08:30:27 +01:00
util.c net: reorganize headers 2012-12-19 08:31:29 +01:00
util.h
vde.c net: Convert to new qapi union layout 2015-11-02 08:30:27 +01:00
vhost-user.c vhost-user: verify that number of queues is non-zero 2015-12-02 16:42:27 +02:00