a3fc839635
platform-bus were using machine_done notifier to get and map (assign irq/mmio resources) dynamically added sysbus devices after all '-device' options had been processed. That however creates non obvious dependencies on ordering of machine_done notifiers and requires carefull line juggling to keep it working. For example see comment above create_platform_bus() and 'straitforward' arm_load_kernel() had to converted to machine_done notifier and that lead to yet another machine_done notifier to keep it working arm_register_platform_bus_fdt_creator(). Instead of hiding resource assignment in platform-bus-device to magically initialize sysbus devices, use device plug callback and assign resources explicitly at board level at the moment each -device option is being processed. That adds a bunch of machine declaration boiler plate to e500plat board, similar to ARM/x86 but gets rid of hidden machine_done notifier and would allow to remove the dependent notifiers in ARM code simplifying it and making code flow easier to follow. Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Acked-by: David Gibson <david@gibson.dropbear.id.au> Message-id: 1525691524-32265-3-git-send-email-imammedo@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
58 lines
1.9 KiB
C
58 lines
1.9 KiB
C
#ifndef HW_PLATFORM_BUS_H
|
|
#define HW_PLATFORM_BUS_H
|
|
|
|
/*
|
|
* Platform Bus device to support dynamic Sysbus devices
|
|
*
|
|
* Copyright (C) 2014 Freescale Semiconductor, Inc. All rights reserved.
|
|
*
|
|
* Author: Alexander Graf, <agraf@suse.de>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "hw/sysbus.h"
|
|
|
|
typedef struct PlatformBusDevice PlatformBusDevice;
|
|
|
|
#define TYPE_PLATFORM_BUS_DEVICE "platform-bus-device"
|
|
#define PLATFORM_BUS_DEVICE(obj) \
|
|
OBJECT_CHECK(PlatformBusDevice, (obj), TYPE_PLATFORM_BUS_DEVICE)
|
|
#define PLATFORM_BUS_DEVICE_CLASS(klass) \
|
|
OBJECT_CLASS_CHECK(PlatformBusDeviceClass, (klass), TYPE_PLATFORM_BUS_DEVICE)
|
|
#define PLATFORM_BUS_DEVICE_GET_CLASS(obj) \
|
|
OBJECT_GET_CLASS(PlatformBusDeviceClass, (obj), TYPE_PLATFORM_BUS_DEVICE)
|
|
|
|
struct PlatformBusDevice {
|
|
/*< private >*/
|
|
SysBusDevice parent_obj;
|
|
|
|
/*< public >*/
|
|
uint32_t mmio_size;
|
|
MemoryRegion mmio;
|
|
|
|
uint32_t num_irqs;
|
|
qemu_irq *irqs;
|
|
unsigned long *used_irqs;
|
|
};
|
|
|
|
int platform_bus_get_irqn(PlatformBusDevice *platform_bus, SysBusDevice *sbdev,
|
|
int n);
|
|
hwaddr platform_bus_get_mmio_addr(PlatformBusDevice *pbus, SysBusDevice *sbdev,
|
|
int n);
|
|
|
|
void platform_bus_link_device(PlatformBusDevice *pbus, SysBusDevice *sbdev);
|
|
|
|
#endif /* HW_PLATFORM_BUS_H */
|